On Sat, Nov 2, 2024 at 1:56 PM William Hooper wrote:
> At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the
> host's ARP replies, to the minimum size (60 bytes before the frame check
> sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device
On Sat, Nov 2, 2024 at 1:56 PM William Hooper wrote:
> At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the
> host's ARP replies, to the minimum size (60 bytes before the frame check
> sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device
errors.
This patch calls eth_pad_short_frame() to add padding, as in net/tap.c
and net/slirp.c. Thanks to Bin Meng, Philippe Mathieu-Daudé, and Phil
Dennis-Jordan for reviewing earlier versions.
Signed-off-by: William Hooper
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2058
Reviewed-by: Phil Denn
On Sat, Aug 17, 2024 at 11:33 PM William Hooper wrote:
> At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the
> host's ARP replies, to the minimum size (60 bytes before the frame check
> sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet d
errors.
This patch calls eth_pad_short_frame() to add padding, as in net/tap.c
and net/slirp.c. Thanks to Bin Meng and Philippe Mathieu-Daudé for
reviewing an earlier version.
Signed-off-by: William Hooper
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2058
---
net/vmnet-common.m | 22 +
On Mon, Jan 8, 2024 at 7:36 AM Philippe Mathieu-Daudé wrote:
> Don't we want to initialize min_pktsz here ...
>
>min_pktsz = sizeof(min_pkt);
>
> > +if (eth_pad_short_frame(min_pkt, &min_pktsz, pkt, pktsz)) {
>
> ... because eth_pad_short_frame() update it?
Thanks for
errors.
This patch calls eth_pad_short_frame() to add padding, as in net/tap.c
and net/slirp.c.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2058
Signed-off-by: William Hooper
---
net/vmnet-common.m | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/net/v
