+0000, Wei, Jiangang wrote:
> Ping again ...
> May I ask for some attention for these two patches？
>
> Thanks
> wei
> On Thu, 2016-06-30 at 03:36 +, Wei, Jiangang wrote:
> > Ping
> > These two patches seem to be forgotten ...
> >
> > On Tue, 2016-05-1
Ping again ...
May I ask for some attention for these two patches？
Thanks
wei
On Thu, 2016-06-30 at 03:36 +, Wei, Jiangang wrote:
> Ping
> These two patches seem to be forgotten ...
>
> On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote:
> > The first had been reviewed.
Ping
These two patches seem to be forgotten ...
On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote:
> The first had been reviewed.
> The second had been posted last month, but no feedback.
> They're similar, so resend them together.
>
> Wei Jiangang (2):
> hw/
On Fri, 2016-06-03 at 17:00 +0800, Fam Zheng wrote:
> On Thu, 06/02 10:46, Wei, Jiangang wrote:
> > My intention is only to avoid the output of multiple location
> > information.
>
> Then I think this should have gone into the commit message.
OK, I'll make more de
On Thu, 2016-06-02 at 09:57 +0200, Markus Armbruster wrote:
> Wei Jiangang writes:
>
> > Use a single error_printf to replace triple error_report.
> >
> > Signed-off-by: Wei Jiangang
> > ---
> > block/raw-posix.c | 10 +-
> > 1 file changed, 5
On Wed, 2016-06-01 at 15:23 +0800, Fam Zheng wrote:
> On Wed, 06/01 15:08, Wei Jiangang wrote:
> > Use a single error_printf to replace triple error_report.
> >
> > Signed-off-by: Wei Jiangang
> > ---
> > block/raw-posix.c | 10 +-
> > 1 fil
Use a single error_printf to replace triple error_report.
Signed-off-by: Wei Jiangang
---
block/raw-posix.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index a4f5a1b..141b01a 100644
--- a/block/raw-posix.c
+++ b/block/raw
Ping
Any comments?
Thanks in advance.
On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote:
> The first had been reviewed.
> The second had been posted last month, but no feedback.
> They're similar, so resend them together.
>
> Wei Jiangang (2):
> hw/
Add qemu-trivial
Reviewed-by: Eric Blake
Reviewed-by: Liang Li
Thanks,
wei
On Mon, 2016-05-23 at 17:43 +0800, Wei Jiangang wrote:
> s/info_migrate_capabilities/info migrate_capabilities
>
> Signed-off-by: Wei Jiangang
> ---
> docs/multi-thread-compression.txt | 2 +-
>
Hi all,
I found a problem about the output of 'query-version'
As the qmp-command.hx said, it shoud be
-> { "execute": "query-version" }
<- {
"return":{
"qemu":{
"major":0,
"minor":11,
"micro":5
},
"package":""
}
}
Act
s/info_migrate_capabilities/info migrate_capabilities
Signed-off-by: Wei Jiangang
---
docs/multi-thread-compression.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/multi-thread-compression.txt
b/docs/multi-thread-compression.txt
index 3d477c3..d0caaf7 100644
--- a
received hint that Message to <*@redhat.com> was undeliverable.
ping to confirm my message had been sent successfully.
On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote:
> The first had been reviewed.
> The second had been posted last month, but no feedback.
> They're sim
The first had been reviewed.
The second had been posted last month, but no feedback.
They're similar, so resend them together.
Wei Jiangang (2):
hw/pci-bridge: Convert pxb initialization functions to Error
apb: convert init to realize
hw/pci-bridge/pci_expander_bridge.c
-off-by: Wei Jiangang
Signed-off-by: Cao jin
Reviewed-by: Marcel Apfelbaum
Reviewed-by: Markus Armbruster
Reviewed-by: Michael S. Tsirkin
---
hw/pci-bridge/pci_expander_bridge.c | 52 ++---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/hw/pci
ping ...
Any comments?
On Tue, 2016-05-10 at 18:13 +0800, Wei Jiangang wrote:
> spice-server-devel is required, not spice-protocol-devel.
> "spice-protocol(>=0.12.3) devel" maybe mislead user.
>
> when configure isn't able to find the required usb-redir,
> It'
Convert a device model where initialization obviously can't fail,
make it implement realize() rather than init().
Signed-off-by: Wei Jiangang
---
hw/pci-host/apb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
index aa
spice-server-devel is required, not spice-protocol-devel.
"spice-protocol(>=0.12.3) devel" maybe mislead user.
when configure isn't able to find the required usb-redir,
It's better to explicitly output version requirement.
Signed-off-by: Wei Jiangang
---
configure | 4
On Wed, 2016-04-27 at 06:44 +0300, Max Filippov wrote:
> Hi Wei,
>
> On Wed, Apr 27, 2016 at 03:27:47AM +0000, Wei, Jiangang wrote:
> > On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote:
> > > static void open_eth_start_xmit(OpenEthState *s, desc *tx)
> > >
On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote:
> open_eth_start_xmit has a huge stack usage of 65536 bytes approx.
> Moving large arrays to heap to reduce stack usage.
>
> Signed-off-by: Zhou Jie
> ---
> hw/net/opencores_eth.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(
It should redirect stdout to /dev/null first,
then redirect stderr to whatever stdout currently points at.
Signed-off-by: Wei Jiangang
---
tests/qemu-iotests/083 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/083 b/tests/qemu-iotests/083
index aa99278
Convert a device model where initialization obviously can't fail,
make it implement realize() rather than init().
Signed-off-by: Wei Jiangang
---
hw/pci-host/apb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
index aa
s/imlement/implement/
Signed-off-by: Wei Jiangang
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index f1f520a..f74eb43 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -73,7 +73,7 @@ static int if_max_devs[IF_COUNT] = {
* Do not
I'm not sure...
Any comments and suggestions are welcome.
Thanks in advance.
On Fri, 2016-04-15 at 09:36 +0800, Wei Jiangang wrote:
> Usually, Random Number Generator is abbreviated to RNG/rng.
> so replacing RndRandom with RngRandom seems more reasonable
> and keep consistent w
Usually, Random Number Generator is abbreviated to RNG/rng.
so replacing RndRandom with RngRandom seems more reasonable
and keep consistent with RngBackend.
Signed-off-by: Wei Jiangang
---
backends/rng-random.c | 18 +-
include/hw/virtio/virtio-rng.h | 2 +-
include
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang
---
accel.c| 4 +---
include/sysemu/accel.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/accel.c b/accel.c
index 05
On Thu, 2016-04-14 at 11:34 +0800, Changlong Xie wrote:
> On 04/14/2016 11:19 AM, Wei, Jiangang wrote:
> > ping...
> > Any comments?
> > On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> >> Return the negated value of accel_initialised is meaningless,
> >
ping...
Any comments?
On Tue, 2016-03-15 at 18:07 +0800, Wei Jiangang wrote:
> Return the negated value of accel_initialised is meaningless,
> and the caller vl doesn't check it.
>
> Signed-off-by: Wei Jiangang
> ---
> accel.c | 4 +---
> 1 file changed, 1 insertion(+)
ping...
Any comments? Thanks in advance.
On Thu, 2016-04-07 at 10:46 +0800, Wei Jiangang wrote:
> The series used to change basename and dirname to
> g_path_get_basename() and g_path_get_dirname() respectively.
>
> Refer to http://wiki.qemu.org/BiteSizedTasks#API_conversion
>
&
/2016 01:56 PM, Markus Armbruster wrote:
> > > >> Wei Jiangang writes:
> > > >>
> > > >>> v1 -> v2:
> > > >>>
> > > >>> - Extract a separate bugfix patch
> > > >>> - Squash v1 patches 1-3 together
-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 52 ++---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/hw/pci-bridge/pci_expander_bridge.c
b/hw/pci-bridge/pci_expander_bridge.c
index ba320bd..cbea9c1 100644
Using g_strdup and g_basename to get the last component
of filename is not the best solution,
Only g_path_get_basename can achive the purpose we want.
Signed-off-by: Wei Jiangang
---
fsdev/virtfs-proxy-helper.c | 6 +-
hw/9pfs/9p-local.c | 6 +++---
hw/vfio/pci.c
The series used to change basename and dirname to
g_path_get_basename() and g_path_get_dirname() respectively.
Refer to http://wiki.qemu.org/BiteSizedTasks#API_conversion
*** BLURB HERE ***
Wei Jiangang (3):
linux-user: complete omission of removing uses of strdup
use g_path_get_dirname
Use g_path_get_basename to get the directory components of
a file name, and free its return when no longer needed.
Signed-off-by: Wei Jiangang
---
os-posix.c | 3 ++-
util/oslib-posix.c | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/os-posix.c b/os-posix.c
The 900cfbc just removed two unchecked uses of strdup
in fill_psinfo and missed the rest in core_dump_filename.
This patch fixes it.
Signed-off-by: Wei Jiangang
---
linux-user/elfload.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user
On Wed, 2016-04-06 at 01:02 +0200, Paolo Bonzini wrote:
>
> On 22/03/2016 10:45, Wei Jiangang wrote:
> > The scale line should align with A line's end,
>
> No, A ends at 0x7fff so the line should end just before. See what
> happens for B/C/D/E.
Yes, you'
ping...
Any feedback？
On Tue, 2016-03-22 at 17:45 +0800, Wei Jiangang wrote:
> The scale line should align with A line's end,
> and correct the range of vga-window example 0xa-0xb.
>
> Signed-off-by: Wei Jiangang
> ---
> docs/memory.txt | 6 +++---
> 1 file c
On Wed, 2016-03-23 at 13:05 +0100, Markus Armbruster wrote:
> Wei Jiangang writes:
>
> > Firstly, convert pxb_dev_init_common() to Error and rename
> > it to pxb_dev_realize_common().
> > Actually, pxb_register_bus() is converted as well.
> >
> > And th
Firstly, convert pxb_dev_init_common() to Error and rename
it to pxb_dev_realize_common().
Actually, pxb_register_bus() is converted as well.
And then,
convert pxb_dev_initfn() and pxb_pcie_dev_initfn() to Error,
rename them to pxb_dev_realize() and pxb_pcie_dev_realize()
respectively.
---
hw/pci
to realize()'
was raised by Cao jin ,
and reviewed by Marcel Apfelbaum .
It conflicts with 02b0743 that had been merged,
so resend a newer version, including the following,
hw/pci-bridge: modify pxb_dev_init_common
pxb: convert to realize()
pxb-pcie: convert to realize()
Wei Jiangang (2):
hw
The error paths after a successful qdev_create/pci_bus_new
should contain a object_unref/object_unparent.
pxb_dev_init_common() did not yet, so add it.
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 8 +++-
1 file changed, 7 insertions(+), 1
It conflicts with 02b0743 that had been merged,
so resend a newer version, including the following,
hw/pci-bridge: modify pxb_dev_init_common
pxb: convert to realize()
pxb-pcie: convert to realize()
Wei Jiangang (2):
hw/pci-bridge: Add missing unref in case register-bus fails
hw/pci-bridge
-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 51 +
1 file changed, 24 insertions(+), 27 deletions(-)
diff --git a/hw/pci-bridge/pci_expander_bridge.c
b/hw/pci-bridge/pci_expander_bridge.c
index ba320bd..efb8863 100644
The error paths after a successful qdev_create/pci_bus_new
should contain a object_unref/object_unparent.
pxb_dev_init_common() did not yet, so add it.
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 8 +++-
1 file changed, 7 insertions(+), 1
The scale line should align with A line's end,
and correct the range of vga-window example 0xa-0xb.
Signed-off-by: Wei Jiangang
---
docs/memory.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/memory.txt b/docs/memory.txt
index 97134e1..5a7163c 1
machine->init() was replaced with machine_class->init().
Signed-off-by: Wei Jiangang
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 7a28982..3c403d1 100644
--- a/vl.c
+++ b/vl.c
@@ -4079,7 +4079,7 @@ int main(int argc, char **argv, char
Return the negated value of accel_initialised is meaningless,
and the caller vl doesn't check it.
Signed-off-by: Wei Jiangang
---
accel.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/accel.c b/accel.c
index 0510b90..403eb5e 100644
--- a/accel.c
+++ b/accel.c
@@
1) add Error **errp parameter for it,
2) rename pxb_dev_init_common to pxb_dev_realize_common,
and prepare for pxb/pxb-pcie convert to realize.
3) modify the callers,
including pxb_dev_initfn and pxb_pcie_dev_initfn.
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/hw/pci-bridge/pci_expander_bridge.c
b/hw/pci-bridge/pci_expander_bridge.c
index cc5074d..64267d8 100644
--- a/hw
The previous patch named '[PATCH v3] PXB: convert to realize()'
was raised by Cao jin ,
and reviewed by Marcel Apfelbaum .
It conflicts with 02b0743 that had been merged,
so resend a newer version.
Wei Jiangang (3):
hw/pci-bridge: modify pxb_dev_init_common
pxb: convert to reali
Signed-off-by: Wei Jiangang
Signed-off-by: Cao jin
---
hw/pci-bridge/pci_expander_bridge.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/hw/pci-bridge/pci_expander_bridge.c
b/hw/pci-bridge/pci_expander_bridge.c
index ce5baf8..cc5074d 100644
--- a/hw
Signed-off-by: Wei Jiangang
---
util/buffer.c | 4 ++--
util/qemu-sockets.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/util/buffer.c b/util/buffer.c
index a6118bf..33e94d1 100644
--- a/util/buffer.c
+++ b/util/buffer.c
@@ -25,7 +25,7 @@
#define
51 matches
Mail list logo
