Re: [PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-22 Thread Vladimir Sementsov-Ogievskiy
-rwxr-xr-x. 1 berrange berrange 85M Jul 21 19:41 qemu-system-x86_64 $ strip qemu-system-x86_64 $ ls -alh qemu-system-x86_64 -rwxr-xr-x. 1 berrange berrange 29M Jul 21 19:41 qemu-system-x86_64 Signed-off-by: Daniel P. Berrangé Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-22 Thread Vladimir Sementsov-Ogievskiy
On 21.07.25 23:22, Stefan Hajnoczi wrote: On Mon, Jul 21, 2025 at 2:58 PM Daniel P. Berrangé wrote: Currently the tracing 'log' back emits special code to add timestamps to trace points sent via qemu_log(). This current impl is a bad design for a number of reasons. * It changes the QEMU hea

Re: [PATCH 0/4] vhost: drop backend_features

2025-07-16 Thread Vladimir Sementsov-Ogievskiy
On 14.07.25 22:23, Vladimir Sementsov-Ogievskiy wrote: On 14.07.25 13:41, Michael S. Tsirkin wrote: On Thu, Jul 03, 2025 at 03:47:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: This field is mostly unused and sometimes confusing (we even have a TODO-like comment to drop it). Let's final

[PATCH v2] net/tap: drop too small packets

2025-07-16 Thread Vladimir Sementsov-Ogievskiy
x27;t make sense. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: change "<" -> "<=" net/tap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/tap.c b/net/tap.c index 23536c09b46..2a859360193 100644 --- a/net/tap.c +++ b/net/tap.c @@ -190,6 +19

Re: [PATCH] net/tap: drop too small packets

2025-07-15 Thread Vladimir Sementsov-Ogievskiy
On 14.07.25 05:12, Jason Wang wrote: On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy wrote: On 07.07.25 06:49, Jason Wang wrote: On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: Theoretically tap_read_packet() may

Re: [PATCH 0/4] vhost: drop backend_features

2025-07-14 Thread Vladimir Sementsov-Ogievskiy
On 14.07.25 13:41, Michael S. Tsirkin wrote: On Thu, Jul 03, 2025 at 03:47:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: This field is mostly unused and sometimes confusing (we even have a TODO-like comment to drop it). Let's finally do. Breaks make check with UBSAN enabled: 32/109

Re: [PATCH] net/tap: drop too small packets

2025-07-09 Thread Vladimir Sementsov-Ogievskiy
On 07.07.25 06:49, Jason Wang wrote: On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin wrote: On 7/3/25 1:55 PM, Vladimir Sementsov-Ogievskiy wrote: Theoretically tap_read_packet() may return size less than s->host_vnet_hdr_len, and next, we'll work with negative size (in ca

Re: [PATCH 0/4] vhost: drop backend_features

2025-07-09 Thread Vladimir Sementsov-Ogievskiy
ping:) On 03.07.25 15:47, Vladimir Sementsov-Ogievskiy wrote: This field is mostly unused and sometimes confusing (we even have a TODO-like comment to drop it). Let's finally do. Vladimir Sementsov-Ogievskiy (4): vhost: introduce vhost_ops->vhost_set_vring_enable_supported method

[PATCH 2/4] vhost-user: stop use backend_features

2025-07-03 Thread Vladimir Sementsov-Ogievskiy
Simply use features instead, we have same flag here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost-user.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 1b2879a90cc..cf6f53801db

[PATCH 3/4] vhost_net: stop use backend_features

2025-07-03 Thread Vladimir Sementsov-Ogievskiy
We are going to drop backend_features variable as an extra one. Call to qemu_has_vnet_hdr() is cheap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/net/vhost_net.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c

[PATCH 1/4] vhost: introduce vhost_ops->vhost_set_vring_enable_supported method

2025-07-03 Thread Vladimir Sementsov-Ogievskiy
Remove vhost-user specific hack from generic code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost-user.c| 8 hw/virtio/vhost.c | 15 ++- include/hw/virtio/vhost-backend.h | 2 ++ 3 files changed, 16 insertions(+), 9 deletions

[PATCH 0/4] vhost: drop backend_features

2025-07-03 Thread Vladimir Sementsov-Ogievskiy
This field is mostly unused and sometimes confusing (we even have a TODO-like comment to drop it). Let's finally do. Vladimir Sementsov-Ogievskiy (4): vhost: introduce vhost_ops->vhost_set_vring_enable_supported method vhost-user: stop use backend_features vhost_net:

[PATCH 4/4] hw/vhost: finally drop vhost_dev.backend_features field

2025-07-03 Thread Vladimir Sementsov-Ogievskiy
It's unused now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/block/vhost-user-blk.c | 1 - hw/scsi/vhost-scsi.c | 1 - hw/scsi/vhost-user-scsi.c | 1 - hw/virtio/vdpa-dev.c | 1 - hw/virtio/virtio-qmp.c| 2 -- include/hw/virtio/vhost.h | 7 --- 6 files change

[PATCH] net/tap: drop too small packets

2025-07-03 Thread Vladimir Sementsov-Ogievskiy
Theoretically tap_read_packet() may return size less than s->host_vnet_hdr_len, and next, we'll work with negative size (in case of !s->using_vnet_hdr). Let's avoid it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 5 + 1 file changed, 5 insertions(+) diff --g

[PATCH] trace: log.py: human-readable timestamp

2025-06-26 Thread Vladimir Sementsov-Ogievskiy
So tired to parse all these timestamps, when need to compare them with other logs. Use iso8601 format as in warn_report() (info_report(), error_report()) already used. Also, start line with date, to be similar with warn_report() as well. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts

Re: [PATCH 0/3] vhost-user-blk: add an option to skip GET_VRING_BASE for force shutdown

2025-06-11 Thread Vladimir Sementsov-Ogievskiy
stem/runstate.h | 1 + system/runstate.c | 10 ++ 6 files changed, 75 insertions(+), 14 deletions(-) all patches: Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 2/4] hbitmap: introduce hbitmap_inverse()

2025-06-09 Thread Vladimir Sementsov-Ogievskiy
On 28.05.25 15:07, Andrey Zhadchenko wrote: and bdrv_dirty_bitmap_inverse() helper Signed-off-by: Andrey Zhadchenko Please, also add a test into tests/unit/test-hbitmap.c for a new function. -- Best regards, Vladimir

Re: [PATCH v2 4/4] block/copy-before-write: report partial block status to snapshot

2025-06-09 Thread Vladimir Sementsov-Ogievskiy
On 28.05.25 15:07, Andrey Zhadchenko wrote: until the non-accessible area Please write a bit more: what, why and how. What is the scenario when this change helps? I think the client of snapshot-access, should not try to read/get-block-status from "denied" areas? Also, it's a lot more comfort

Re: [PATCH v2 3/4] block/copy-before-write: inverse access bitmap

2025-06-09 Thread Vladimir Sementsov-Ogievskiy
64 Signed-off-by: Andrey Zhadchenko Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 2/4] hbitmap: introduce hbitmap_inverse()

2025-06-09 Thread Vladimir Sementsov-Ogievskiy
On 28.05.25 15:07, Andrey Zhadchenko wrote: and bdrv_dirty_bitmap_inverse() helper Signed-off-by: Andrey Zhadchenko Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 1/4] hbitmap: drop meta bitmap leftovers

2025-06-09 Thread Vladimir Sementsov-Ogievskiy
On 28.05.25 15:07, Andrey Zhadchenko wrote: API to manipulate meta bitmap was removed with commit 0c88f1970c76 Signed-off-by: Andrey Zhadchenko Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PULL v3 8/8] blockdev-backup: Add error handling option for copy-before-write jobs

2025-05-12 Thread Vladimir Sementsov-Ogievskiy
remains unchanged to maintain backward compatibility. Signed-off-by: Raman Dzehtsiar Message-ID: <20250414090025.828660-1-raman.dzehts...@gmail.com> Acked-by: Markus Armbruster [vsementsov: fix long lines] Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievski

[PULL v3 0/8] block-job patches 2025-04-29

2025-05-12 Thread Vladimir Sementsov-Ogievskiy
t to unmap zero blocks block: add test non-active commit with zeroed data Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and block-jobs documentation qapi/block-core: deprecate some block-job- APIs block/backup.c | 3 +- bloc

[PULL v2 3/8] block: refactor error handling of commit_iteration

2025-05-01 Thread Vladimir Sementsov-Ogievskiy
From: Vincent Vanlaer Signed-off-by: Vincent Vanlaer Message-Id: <20241026163010.2865002-4-libvirt-e6954...@volkihar.be> [vsementsov]: move action declaration to the top of the function Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.

[PULL v2 0/8] block-job patches 2025-04-29

2025-05-01 Thread Vladimir Sementsov-Ogievskiy
block: add test non-active commit with zeroed data Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and block-jobs documentation qapi/block-core: deprecate some block-job- APIs block/backup.c | 3 +- bloc

Re: [PULL 0/8] block-job patches 2025-04-29

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
Oops, accidentally extra old patches were sent, sorry for the noice. Please ignore patches */5, they are already in master. The cover-letter message and the tag pull-block-jobs-2025-04-29 are correct. On 29.04.25 14:33, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit

[PULL 1/8] block: get type of block allocation in commit_run

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
From: Vincent Vanlaer bdrv_co_common_block_status_above not only returns whether the block is allocated, but also if it contains zeroes. Signed-off-by: Vincent Vanlaer Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20241026163010.2865002-2-libvirt-e6954...@volkihar.be> Signed-

[PULL 5/5] util/co-shared-resource: Remove unused co_try_get_from_shres

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
220.27871-1-d...@treblig.org> Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/co-shared-resource.h | 7 --- util/qemu-co-shared-resource.c| 6 -- 2 files changed, 13 deletions(-) diff --git a/include/qemu/co-shared-resource.h b/include/qemu/co-shared-resource.h index 78ca

[PULL 5/8] block: add test non-active commit with zeroed data

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
From: Vincent Vanlaer Signed-off-by: Vincent Vanlaer Tested-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20241026163010.2865002-6-libvirt-e6954...@volkihar.be> Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/commi

[PULL 4/8] block: allow commit to unmap zero blocks

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
: Vincent Vanlaer Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20241026163010.2865002-5-libvirt-e6954...@volkihar.be> Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff -

[PULL 3/5] block/reqlist: allow adding overlapping requests

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
...) at ../block/io.c:2474 > #12 0x6152853f2016 in bdrv_co_common_block_status_above (...) at > ../block/io.c:2652 > #13 0x6152853f22cf in bdrv_co_block_status_above (...) at > ../block/io.c:2732 > #14 0x00006152853d9a86 in blk_co_block_status_above (...) at > ../block/bloc

[PULL 0/8] block-job patches 2025-04-29

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
e of block allocation in commit_run block: move commit_run loop to separate function block: refactor error handling of commit_iteration block: allow commit to unmap zero blocks block: add test non-active commit with zeroed data Vladimir Sementsov-Ogievskiy (2): qapi: synchroniz

[PULL 2/5] backup: add minimum cluster size to performance options

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
discard requests and thus effectively ignore then. To make @discard-source work in such a scenario, allow specifying the minimum cluster size used for block-copy operations and thus in particular also the granularity for discard requests to the source. Suggested-by: Vladimir Sementsov-Ogievskiy

[PULL 6/8] qapi: synchronize jobs and block-jobs documentation

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
Actualize documentation and synchronize it for commands which actually call the same functions internally. Reviewed-by: Markus Armbruster Signed-off-by: Vladimir Sementsov-Ogievskiy Message-ID: <20250409084232.28201-2-vsement...@yandex-team.ru> --- qapi/block-core.jso

[PULL 1/5] copy-before-write: allow specifying minimum cluster size

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
ulation in block_copy_calculate_cluster_size() is done in the target int64_t type. Suggested-by: Vladimir Sementsov-Ogievskiy Acked-by: Markus Armbruster (QAPI schema) Signed-off-by: Fiona Ebner Message-Id: <20240711120915.310243-2-f.eb...@proxmox.com> [vsementsov: switch version to

[PULL 7/8] qapi/block-core: deprecate some block-job- APIs

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
are not documented at all, so be silent in deprecated.txt as well. ACKed-by: Peter Krempa Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Vladimir Sementsov-Ogievskiy Message-ID: <20250409084232.28201-3-vsement...@yandex-team.ru> --- docs/about/dep

[PULL 4/5] block: Remove unused aio_task_pool_empty

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
From: "Dr. David Alan Gilbert" aio_task_pool_empty has been unused since it was added in 6e9b225f73 ("block: introduce aio task pool") Remove it. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20240917002007.330689-1-d...@treblig.org> Signed-off-by: Vl

[PULL 8/8] blockdev-backup: Add error handling option for copy-before-write jobs

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
remains unchanged to maintain backward compatibility. Signed-off-by: Raman Dzehtsiar Message-ID: <20250414090025.828660-1-raman.dzehts...@gmail.com> Acked-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Seme

[PULL 2/8] block: move commit_run loop to separate function

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
From: Vincent Vanlaer Signed-off-by: Vincent Vanlaer Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20241026163010.2865002-3-libvirt-e6954...@volkihar.be> Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.c | 89 +-

[PULL 3/8] block: refactor error handling of commit_iteration

2025-04-29 Thread Vladimir Sementsov-Ogievskiy
From: Vincent Vanlaer Signed-off-by: Vincent Vanlaer Message-Id: <20241026163010.2865002-4-libvirt-e6954...@volkihar.be> Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.c | 62 -- 1 file changed, 35 insertions(+), 27 del

Re: [PATCH 3/6] mirror: Skip writing zeroes when target is already zero

2025-04-22 Thread Vladimir Sementsov-Ogievskiy
On 21.04.25 17:41, Eric Blake wrote: On Mon, Apr 21, 2025 at 09:15:33AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 17.04.25 00:51, Eric Blake wrote: (a write zeroes that fails AND causes the disk to no longer read as zero should not happen) I don't know, is there such a contract?

Re: [PATCH 3/6] mirror: Skip writing zeroes when target is already zero

2025-04-20 Thread Vladimir Sementsov-Ogievskiy
On 17.04.25 00:51, Eric Blake wrote: (a write zeroes that fails AND causes the disk to no longer read as zero should not happen) I don't know, is there such a contract? write-zeroes may fallback to write(), which only state that: An error return value while performing write() using dir

Re: [PATCH v4] blockdev-backup: Add error handling option for copy-before-write jobs

2025-04-16 Thread Vladimir Sementsov-Ogievskiy
The default behavior remains unchanged to maintain backward compatibility. Signed-off-by: Raman Dzehtsiar Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy Thanks, applied to my block branch. Note for the future: better, add test in a separate commit, no re

Re: [PATCH 2/6] file-posix: Allow lseek at offset 0 when !want_zero

2025-04-15 Thread Vladimir Sementsov-Ogievskiy
On 15.04.25 18:22, Eric Blake wrote: On Tue, Apr 15, 2025 at 03:37:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 14.04.25 21:12, Eric Blake wrote: On Mon, Apr 14, 2025 at 08:05:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 11.04.25 04:04, Eric Blake wrote: The 'want_zero'

Re: [PATCH 3/6] mirror: Skip writing zeroes when target is already zero

2025-04-15 Thread Vladimir Sementsov-Ogievskiy
On 11.04.25 04:04, Eric Blake wrote: When mirroring, the goal is to ensure that the destination reads the same as the source; this goal is met whether the destination is sparse or fully-allocated. However, if the destination cannot efficiently write zeroes, then any time the mirror operation wan

Re: [PATCH 2/6] file-posix: Allow lseek at offset 0 when !want_zero

2025-04-15 Thread Vladimir Sementsov-Ogievskiy
On 14.04.25 21:12, Eric Blake wrote: On Mon, Apr 14, 2025 at 08:05:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 11.04.25 04:04, Eric Blake wrote: The 'want_zero' parameter to raw_co_block_status() was added so that we can avoid potentially time-consuming lseek(SEEK_DATA) calls

Re: [PATCH 2/6] file-posix: Allow lseek at offset 0 when !want_zero

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
On 11.04.25 04:04, Eric Blake wrote: The 'want_zero' parameter to raw_co_block_status() was added so that we can avoid potentially time-consuming lseek(SEEK_DATA) calls throughout the file (working around poor filesystems that have O(n) rather than O(1) extent probing). But when it comes to lear

Re: [PATCH 1/6] mirror: Skip pre-zeroing destination if it is already zero

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
quot;, "timestamp": {"microseconds": "USECS", "seconds": "SECS"}} Starting migration... {"return": {}} {"execute": "migrate-start-postcopy", "arguments": {}} @@ -18,7 +18,7 @@ Starting migration... {"data": {"status": "completed"}, "event": "MIGRATION", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}} Gracefully ending the `drive-mirror` job on source... {"return": {}} -{"data": {"device": "mirror-job0", "len": 1073741824, "offset": 1073741824, "speed": 0, "type": "mirror"}, "event": "BLOCK_JOB_COMPLETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}} +{"data": {"device": "mirror-job0", "len": "LEN", "offset": "LEN", "speed": 0, "type": "mirror"}, "event": "BLOCK_JOB_COMPLETED", "timestamp": {"microseconds": "USECS", "seconds": "SECS"}} Stopping the NBD server on destination... {"return": {}} Wait for migration completion on target... With "int ret = -1;" kept as is: Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v3 0/2] deprecate some block-job- APIs

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 11:42, Vladimir Sementsov-Ogievskiy wrote: This is for 10.1, of course. v3: fix wording, typos v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru> Vl

Re: [PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
On 14.04.25 04:30, Raman Dzehtsiar wrote: Hi Vladimir, Thank you for your review. The patch looks good to me. Still, could you also provide a test for a new option? Probably the simplest would be add a test-case to `tests/qemu-iotests/tests/copy-before-write`, where existing on-cbw-error opt

Re: [PATCH 1/6] mirror: Skip pre-zeroing destination if it is already zero

2025-04-11 Thread Vladimir Sementsov-Ogievskiy
On 11.04.25 04:04, Eric Blake wrote: When doing a sync=full mirroring, QMP drive-mirror requests full zeroing if it did not just create the destination, and blockdev-mirror requests full zeroing unconditionally. This is because during a full sync, we must ensure that the portions of the disk tha

Re: [PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-10 Thread Vladimir Sementsov-Ogievskiy
On 07.04.25 18:28, Eric Blake wrote: On Fri, Apr 04, 2025 at 10:31:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: Actualize documentation and synchronize it for commands which actually call the same functions internally. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json

Re: [PATCH] [for-10.1] qtest: introduce qtest_init_ext

2025-04-10 Thread Vladimir Sementsov-Ogievskiy
On 10.04.25 19:22, Vladimir Sementsov-Ogievskiy wrote: Merge qtest_init_with_env_and_capabilities() and qtest_init_with_env() into one qtest_init_ext(). CC Steve -- Best regards, Vladimir

[PATCH] [for-10.1] qtest: introduce qtest_init_ext

2025-04-10 Thread Vladimir Sementsov-Ogievskiy
true as well. 2. qtest_init_with_env() is not used outside of libqtest.c, so no reason to keep it as public function 3. and in libqtest.c it's used not often, so no problem to use more generic function instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qtest/libqt

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 20:48, Steven Sistare wrote: On 4/9/2025 12:22 PM, Vladimir Sementsov-Ogievskiy wrote: On 15.01.25 22:00, Steve Sistare wrote: This patch series implements a minimal version of cpr-transfer.  Additional series are ready to be posted to deliver the complete vision described above

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 19:22, Vladimir Sementsov-Ogievskiy wrote: [offlist] Hah, decided to send offlist, but forget to clear CC. Sorry. However, nothing secret here. Moreover, interesting, what do all think about a cpr-exec variant with loading QEMU as library instead of doing exec. On 15.01.25 22

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
[offlist] On 15.01.25 22:00, Steve Sistare wrote: This patch series implements a minimal version of cpr-transfer. Additional series are ready to be posted to deliver the complete vision described above, including * vfio * chardev * vhost and tap * blockers * cpr-exec mode Hi St

[PATCH v3 2/2] qapi/block-core: deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
are not documented at all, so be silent in deprecated.txt as well. ACKed-by: Peter Krempa Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/about/deprecated.rst | 31 +++ qapi/block-core.json

Re: [PATCH v6] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 13:48, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dum

[PATCH v6] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
ginal VHOST_OPS_DEBUG(), to keep original debug output as is here, it's not the only call to VHOST_OPS_DEBUG in the file. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v6: rename path to qom-path, and improve throttling of the event improve wording hw/virtio/vhost.c | 12 +--- monitor

[PATCH v3 0/2] deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
This is for 10.1, of course. v3: fix wording, typos v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jo

[PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
Actualize documentation and synchronize it for commands which actually call the same functions internally. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 61 ++-- qapi/job.json| 30 -- 2 files changed

[PATCH v5] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-05 Thread Vladimir Sementsov-Ogievskiy
ginal VHOST_OPS_DEBUG(), to keep original debug output as is here, it's not the only call to VHOST_OPS_DEBUG in the file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Denis Plotnikov --- v5: resend, update version in QAPI to 10.1 drop a-b by Markus (too much time passed, the con

[PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
t all, so be silent in deprecated.txt as well. ACKed-by: Peter Krempa Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/about/deprecated.rst | 31 +++ qapi/block-core.json | 30 ++ 2 files changed, 61 insertions(+) diff --git a

[PATCH v2 0/2] derpecate some block-job- APIs

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and block-jobs documentation qapi/block-core: der

[PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
Actualize documentation and synchronize it for commands which actually call the same functions internally. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 59 +--- qapi/job.json| 29 -- 2 files changed

[PATCH v3] [for-10.1] block-jobs: add final flush

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
am, commit and backup jobs too. Note that jobs behave a bit different around IGNORE action: backup and commit just retry the operation, when stream skip failed operation and store the error to report later. Keep these different behaviors for final flush too. Signed-off-by: Vladimir Sementsov

Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
On 04.04.25 17:13, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 04.04.25 09:20, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] + +``block-job-finalize`` (since 10.1) +'''''''''''''

Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
On 04.04.25 09:20, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What&#

Re: [PATCH v5] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
On 04.04.25 09:46, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dum

Re: [PATCH v5] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-03 Thread Vladimir Sementsov-Ogievskiy
On 02.04.25 15:32, Vladimir Sementsov-Ogievskiy wrote: On 01.04.25 20:07, Vladimir Sementsov-Ogievskiy wrote: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible:   - collect statistics of such errors   - make imme

Re: [PATCH v9 4/7] qapi: add blockdev-replace command

2025-04-02 Thread Vladimir Sementsov-Ogievskiy
On 18.10.24 16:59, Kevin Wolf wrote: If we want to get rid of the union, I think the best course of action would unifying the namespaces (so that nodes, exports and devices can't share the same ID) and then we could just accept a universal 'id' along with 'child'. Maybe we can go this way even

Re: [PATCH v5] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-02 Thread Vladimir Sementsov-Ogievskiy
On 01.04.25 20:07, Vladimir Sementsov-Ogievskiy wrote: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dumps or do some other debu

[PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-01 Thread Vladimir Sementsov-Ogievskiy
t all, so be silent in deprecated.txt as well. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! That's a continuation of my "[RFC 00/15] block job API"[1], exactly, the simplest part of it - deprecating block-job-* commands which simply duplicate job-* ones. Note tha

Re: [PATCH v2 2/2] utils/qemu-sockets: Introduce keep-alive-idle-period inet socket option

2025-03-20 Thread Vladimir Sementsov-Ogievskiy
ion when a client-side or server-side socket is created. The default value is 0, which means system configuration is used, and no custom value is set. Signed-off-by: Juraj Marcin Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v2 1/2] util/qemu-sockets: Add support for keep-alive flag to passive sockets

2025-03-20 Thread Vladimir Sementsov-Ogievskiy
clients. This patch also fixes an issue in 'qio_dns_resolver_lookup_sync_inet()' where the keep-alive flag is not copied together with other attributes. Signed-off-by: Juraj Marcin Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 1/2] util/qemu-sockets: Add support for keep-alive flag to passive sockets

2025-03-15 Thread Vladimir Sementsov-Ogievskiy
On 03.03.25 17:33, Juraj Marcin wrote: Commit aec21d3175 (qapi: Add InetSocketAddress member keep-alive) introduces the keep-alive flag, which enables the SO_KEEPALIVE socket option, but only on client-side sockets. However, this option is also useful for server-side sockets, so they can check if

Re: [PATCH 2/2] utils/qemu-sockets: Introduce keep-alive-idle-period inet socket option

2025-03-14 Thread Vladimir Sementsov-Ogievskiy
On 03.03.25 17:33, Juraj Marcin wrote: The default idle period for TCP connection could be even 2 hours. However, in some cases, the application needs to be aware of a connection issue much sooner. This is the case, for example, for postcopy live migration. If there is no traffic from the migrat

Re: [PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-03-14 Thread Vladimir Sementsov-Ogievskiy
On 04.03.25 12:17, Raman Dzehtsiar wrote: This patch extends the blockdev-backup QMP command to allow users to specify how to behave when IO errors occur during copy-before-write operations. Previously, the behavior was fixed and could not be controlled by the user. The new 'on-cbw-error' option

[PATCH v2] qapi: merge common parts of NbdServerOptions and nbd-server-start data

2025-02-19 Thread Vladimir Sementsov-Ogievskiy
Instead of comment "Keep this type consistent with the nbd-server-start arguments", we can simply merge these things. Note that each field of new base already has "since" tag, equal in both original copies. So "since" information is saved. Signed-off-by: Vladimi

Re: [PATCH] qapi: merge common parts of NbdServerOptions and nbd-server-start data

2025-02-13 Thread Vladimir Sementsov-Ogievskiy
On 13.02.25 11:26, Markus Armbruster wrote: Eric Blake writes: On Wed, Feb 12, 2025 at 05:33:51PM +0300, Vladimir Sementsov-Ogievskiy wrote: Instead of comment "Keep this type consistent with the nbd-server-start arguments", we can simply merge these things. Signed-off-by

Re: [PATCH v5 1/4] os: add an ability to lock memory on_fault

2025-02-12 Thread Vladimir Sementsov-Ogievskiy
On 12.02.25 17:39, Daniil Tatianin wrote: This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH] qapi: merge common parts of NbdServerOptions and nbd-server-start data

2025-02-12 Thread Vladimir Sementsov-Ogievskiy
Instead of comment "Keep this type consistent with the nbd-server-start arguments", we can simply merge these things. Signed-off-by: Vladimir Sementsov-Ogievskiy --- No problem for me to rebase on top of [PATCH 0/2] nbd: Allow debugging tuning of handshake limit if it goes earlier.

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.25 00:46, Eric Blake wrote: On Thu, Feb 06, 2025 at 10:20:09AM +0300, Vladimir Sementsov-Ogievskiy wrote: --- qapi/block-export.json | 10 ++ include/block/nbd.h| 6 +++--- [..] @@ -52,6 +57,10 @@ # # @addr: Address on which to listen

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-05 Thread Vladimir Sementsov-Ogievskiy
names serve as good self-documentation, and unlike the command line, machines don't have problems generating longer spellings. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy (renaming to -seconds is, of course, OK) --- qapi/block-export.json | 10 ++

Re: [PATCH 1/2] qemu-nbd: Allow users to adjust handshake limit

2025-02-05 Thread Vladimir Sementsov-Ogievskiy
name to be added in the next commit; this is because typing a longer command-line name is undesirable and there is sufficient --help text to document the units. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v3 4/4] overcommit: introduce mem-lock=on-fault

2024-12-12 Thread Vladimir Sementsov-Ogievskiy
QEMU pages. Add an option to only lock pages lazily as they're faulted by the process by using MCL_ONFAULT if asked. Signed-off-by: Daniil Tatianin Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v3 3/4] sysemu: introduce a new MlockState enum

2024-12-12 Thread Vladimir Sementsov-Ogievskiy
: Daniil Tatianin Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v3 2/4] system/vl: extract overcommit option parsing into a helper

2024-12-12 Thread Vladimir Sementsov-Ogievskiy
On 12.12.24 02:04, Daniil Tatianin wrote: This will be extended in the future commits, let's move it out of line right away so that it's easier to read. Signed-off-by: Daniil Tatianin Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-10 Thread Vladimir Sementsov-Ogievskiy
Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[BUG] qemu crashes on assertion in cpu_asidx_from_attrs when cpu is in smm mode

2024-11-29 Thread Vladimir Sementsov-Ogievskiy
Hi all! First, I see this issue: https://gitlab.com/qemu-project/qemu/-/issues/1198. where some kvm/hardware failure leads to guest crash, and finally to this assertion: cpu_asidx_from_attrs: Assertion `ret < cpu->num_ases && ret >= 0' failed. But in the ticket the talk is about the guest

Re: [PATCH v4 3/5] block: refactor error handling of commit_iteration

2024-11-18 Thread Vladimir Sementsov-Ogievskiy
On 18.11.24 10:37, Vladimir Sementsov-Ogievskiy wrote: On 26.10.24 19:30, Vincent Vanlaer wrote: Signed-off-by: Vincent Vanlaer ---   block/commit.c | 61 --   1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/block/commit.c b/block

Re: [PATCH v4 0/5] block: allow commit to unmap zero blocks

2024-11-18 Thread Vladimir Sementsov-Ogievskiy
On 26.10.24 19:30, Vincent Vanlaer wrote: This patch series adds support for zero blocks in non-active commits. The first three patches in the series refactor the relevant code, patch four makes the actual changes, and the last patch adds a test for the new functionality. --- Changes since v3:

Re: [PATCH v4 3/5] block: refactor error handling of commit_iteration

2024-11-17 Thread Vladimir Sementsov-Ogievskiy
_processed_bytes(&s->common, bytes); } + /* Publish progress */ -job_progress_update(&s->common.job, *n); -if (copy) { -block_job_ratelimit_processed_bytes(&s->common, *n); +job_progress_update(&s->common.job, bytes); + +*requested_b

Re: [PATCH] nbd-server: Silence server warnings on port probes

2024-11-17 Thread Vladimir Sementsov-Ogievskiy
ost 10809 Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH] qapi: fix device-sync-config since-version

2024-11-07 Thread Vladimir Sementsov-Ogievskiy
Actually it comes in 9.2, not 9.1. Fixes: 3f98408e2e ("qapi: introduce device-sync-config") Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/qdev.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qdev.json b/qapi/qdev.json index 2a581129c9..25cbcf9

Re: [PATCH v7 0/3] vhost-user-blk: live resize additional APIs

2024-11-07 Thread Vladimir Sementsov-Ogievskiy
On 06.11.24 21:17, Michael S. Tsirkin wrote: On Wed, Nov 06, 2024 at 02:18:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: v7: update QAPI version 9.1 -> 9.2 Not like this. ypur patches are merged, pls post a fix patch on top. Thanks! Ah, missed this. Ok. Vladimir Sementsov-Ogievs

[PATCH v7 0/3] vhost-user-blk: live resize additional APIs

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
v7: update QAPI version 9.1 -> 9.2 Vladimir Sementsov-Ogievskiy (3): qdev-monitor: add option to report GenericError from find_device_state vhost-user-blk: split vhost_user_blk_sync_config() qapi: introduce device-sync-config hw/block/vhost-user-blk.c | 27 ++-- hw/vir

[PATCH v7 1/3] qdev-monitor: add option to report GenericError from find_device_state

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
pread of DeviceNotFound anyway - also, nothing prevent simply copy-pasting find_device_state() calls with false argument Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster Acked-by: Raphael Norwitz --- system/qdev-monitor.c | 15 +++ 1 file change

[PATCH v7 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
Split vhost_user_blk_sync_config() out from vhost_user_blk_handle_config_change(), to be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Raphael Norwitz Reviewed-by: Stefano Garzarella --- hw/block/vhost-user-blk.c | 26 +++--- 1 file

  1   2   3   4   5   6   7   8   9   10   >