Resubmitted with errors fixed.
Regards,
Vlad
On 12/21/2016 01:01 AM, no-re...@patchew.org wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim,
> unescape module
get_opt_value() truncates the value at the first comma
Use memcpy() instead
Unescape the module filename and parameters with get_opt_value()
before calling mb_add_cmdline()
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 21 +++--
1 file changed, 11 insertions(+), 10
get_opt_value() truncates the value at the first comma
Use memcpy() instead
Unescape the module filename and parameters with get_opt_value()
before calling mb_add_cmdline()
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions
On 12/18/2016 10:25 PM, Eduardo Habkost wrote:
> On Thu, Dec 15, 2016 at 02:32:04PM +0200, Vlad Lungu wrote:
>> get_opt_value() truncates the value at the first comma
>> Use memcpy() instead
>> Unescape the module filename and parameters with get_opt_value()
>> be
get_opt_value() truncates the value at the first comma
Use memcpy() instead
Unescape the module filename and parameters with get_opt_value()
before calling mb_add_cmdline()
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions
On 12/15/2016 02:29 PM, Paolo Bonzini wrote:
>
> On 15/12/2016 12:34, Vlad Lungu wrote:
>>
>> On 12/15/2016 12:56 PM, Paolo Bonzini wrote:
>>> On 15/12/2016 11:03, Vlad Lungu wrote:
>>>>
>>>> if (initrd_filename) {
>>>> -
On 12/15/2016 12:56 PM, Paolo Bonzini wrote:
>
> On 15/12/2016 11:03, Vlad Lungu wrote:
>>
>> if (initrd_filename) {
>> -char *next_initrd, not_last;
>> +char *next_initrd, not_last, tmpbuf[strlen(initrd_filename) + 1];
>>
>>
get_opt_value() truncates the value at the first comma
Use memcpy() instead
Unescape the module filename and parameters with get_opt_value()
before calling mb_add_cmdline()
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions
Sorry about replying to myself, I only had one coffee today.
There is no need for mb_add_modstring(), we can simply do
get_opt_value(tmpbuf,..) then mb_add_cmdline(&mbs, tmpbuf)
Regards,
Vlad
On 12/15/2016 11:45 AM, Vlad Lungu wrote:
> get_opt_value() truncates the value at the firs
get_opt_value() truncates the value at the first comma
Rename mb_add_cmdline() to mb_add_modstring()
Unescape filename too
Add new mb_add_cmdline() using memcpy()
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions
On 12/15/2016 12:32 AM, Paolo Bonzini wrote:
In other words: this fixes the mb_add_cmdline(kcmdline) case, and
doesn't break comma escaping on the initrd case (because it was
already broken). I don't see a problem with this patch.
>>> ... there is one case of comma escaping that wa
get_opt_value() truncates the value at the first comma
Use memcpy() instead
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 387caa6..b4495ad 100644
--- a/hw/i386/multiboot.c
get_opt_value() truncates the value at the first comma.
Use memcpy() instead.
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 387caa6..b4495ad 100644
--- a/hw/i386/multiboot.c
Wolfgang Denk wrote:
In message <[EMAIL PROTECTED]> you wrote:
Now with board config file included, so it can be built :-)
Thiemo, I'll think about the memory size issue and get back to you on that.
How about a git repo for U-Boot, if this thing takes off?
We actually have already a
644
index 000..39570b1
--- /dev/null
+++ b/board/qemu-mips/README
@@ -0,0 +1,11 @@
+By Vlad Lungu [EMAIL PROTECTED] 2007-Oct-01
+
+Qemu is a full system emulator. See
+
+http://fabrice.bellard.free.fr/qemu
+
+Limitations & comments
+---
Thiemo Seufer wrote:
Vlad Lungu wrote:
Thiemo Seufer wrote:
Vlad Lungu wrote:
[snip]
+long int initdram(int board_type)
+{
+ /* Sdram is setup by assembler code */
+ /* If memory could be changed, we should return the true value
here */
+ return
Thiemo Seufer wrote:
Vlad Lungu wrote:
[snip]
+long int initdram(int board_type)
+{
+ /* Sdram is setup by assembler code */
+ /* If memory could be changed, we should return the true value
here */
+ return MEM_SIZE*1024*1024;
Qemu gets the amount of
Thiemo Seufer wrote:
Vlad Lungu wrote:
Fix for mips GOT relocation bug, NE2000 bugs, add support for qemu -M mips
target.
[snip]
diff --git a/board/qemu-mips/config.mk b/board/qemu-mips/config.mk
[snip]
+#
+# AMD development board AMD Alchemy DbAu1x00, MIPS32 core
Fix for mips GOT relocation bug, NE2000 bugs, add support for qemu -M mips target.
Patch is against U-Boot master branch.
--
diff --git a/Makefile b/Makefile
index 85885b1..8f650d2 100644
--- a/Makefile
+++ b/Makef
Vlad Lungu wrote:
lol, replying to myself
Blue Swirl wrote:
Someone could port OpenBIOS or LinuxBIOS to MIPS.
Well, just FYI:
I sort-of-ported U-Boot to Qemu (-M mips). Network performance sucks for
some reason (hard enough that tftp-booting a kernel is impossible) and I
didn't
Ralf Baechle wrote:
Both CONFIG_PCI_NEW and PCI_AUTO were amazingly broken in both concept
and implementation. It is possible to get them to work well for particular
configurations but for the general case nothing else nothing but rewrite
can rescue things.
Hi Ralf,
I found this the hard wa
Blue Swirl wrote:
Someone could port OpenBIOS or LinuxBIOS to MIPS.
Well, just FYI:
I sort-of-ported U-Boot to Qemu (-M mips). Network performance sucks for
some reason (hard enough that tftp-booting a kernel is impossible) and I
didn't have time to investigate this yet. But I guess that p
Alexander Voropay wrote:
<[EMAIL PROTECTED]> wrote:
- QEMU malta emulation is not really complete, to put it mildly
Out of curiosity, what parts did you miss?
Like, for example, the PCI stuff. So I can use the network card.
PCI stuff in the QEMU/Malta works fine, but pseudo-bootrom
does not
Thiemo Seufer wrote:
Vlad Lungu wrote:
I know some of you will laugh, but:
- QEMU malta emulation is not really complete, to put it mildly
Out of curiosity, what parts did you miss?
Like, for example, the PCI stuff. So I can use the network card.
And yes, I am aware of YAMON.
- the QEMU
I know some of you will laugh, but:
- QEMU malta emulation is not really complete, to put it mildly
- the QEMU target is available only for Linux 2.6
- despite popular opinion, 2.4 ain't dead yet, at least in the embedded
market
I have a port of the QEMU target for Linux 2.4.34.4 (latest 2.4
25 matches
Mail list logo
