> From: "Michael S. Tsirkin"
> To: "Victor Kaplansky"
> Cc: qemu-devel@nongnu.org, "Maxime Coquelin" ,
> "Jason Wang"
> Sent: Tuesday, November 28, 2017 8:45:43 PM
> Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_
> From: "Michael S. Tsirkin"
> To: "Victor Kaplansky"
> Cc: qemu-devel@nongnu.org, "Maxime Coquelin" ,
> "Jason Wang"
> Sent: Tuesday, November 28, 2017 8:06:52 PM
> Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_
> > +Note that master is not expected to issue more than one
> > VHOST_USER_SET_LOG_BASE
> > +request before the rings are fully stopped by the master. Thus no
> > modifications
> > +to log_base address are allowed before the rings are restated and the
> > client
> > +can ignore all subsequent VHOS
> From: "Michael S. Tsirkin"
> To: "Dr. David Alan Gilbert"
> Cc: "Victor Kaplansky" , qemu-devel@nongnu.org, "Maxime
> Coquelin"
> Sent: Tuesday, November 28, 2017 6:12:44 PM
> Subject: Re: [Qemu-devel] [PATCH] vhost-user spec: Clari
> From: "Michael S. Tsirkin"
> To: "Victor Kaplansky"
> Cc: qemu-devel@nongnu.org, "Maxime Coquelin"
> Sent: Tuesday, November 28, 2017 6:16:32 PM
> Subject: Re: [PATCH] vhost-user spec: Clarify policy on setting log_base
>
> On Tue, Nov 2
From: Victor Kaplansky
If we allow qemu to change logging area after it was already established,
it may require from the backend to acquire a lock on each access to
the log_base, which has a potential quite a big performance hit.
Thus we would like to clarify in the spec, that qemu is not
Hi MST, I've reviewed the patches and they are fine.
>From my perspective we can pull them into upstream.
On Mon, Jun 06, 2016 at 06:44:58PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Hi,
>
> In a previous series "RFCv2: vhost-user: shutdown and reconnection", I
>
On Mon, Jun 06, 2016 at 06:45:01PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This patch is a similar solution to what Yuanhan Liu/Huawei Xie have
> suggested for DPDK. When vubr quits (killed or crashed), a restart of
> vubr would get stale vring base from QEMU. That
On Mon, Jun 06, 2016 at 06:45:00PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> If -c is specified, vubr will try to connect to the socket instead of
> listening for connections.
>
> Signed-off-by: Marc-André Lureau
> Tested-by: Yuanhan Liu
> Reviewed-by: Yuanhan Liu
Thanks!
--
Victor
- Original Message -
> From: "Marc-André Lureau"
> To: "Markus Armbruster"
> Cc: "marcandre lureau" , qemu-devel@nongnu.org,
> vict...@redhat.com, m...@redhat.com
> Sent: Monday, June 6, 2016 1:16:50 PM
> Subject: Re: [Qemu-devel] [PATCH 1/6] vubr: remove false commen
Add one more testcase to pxe-test for checking vhost-user
interface. The test is based on spawning vhost-user-bridge
process in addition to qemu under test.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Victor Kaplansky
---
The patch is a quick and dirty, but working implementation of
This patch adds to the vubr test the scattering of incoming
packets to the chain of RX buffer. Also, this patch corrects the
size of the header preceding the packet in RX buffers.
Note that this patch doesn't add the support for mergeable
buffers.
Signed-off-by: Victor Kaplansky
---
v2 ch
by: Didier Pallard
Signed-off-by: Victor Kaplansky
---
v5 changes:
- rebased to mst tree.
- removed a traling space.
v4 changes:
In respond to Michael S. Tsirkin comments:
- changed the name of new field to use_guest_notifier_mask
- clarified comments
- vhost_virtqueue_mask()
by: Didier Pallard
Signed-off-by: Victor Kaplansky
---
v4 changes:
In respond to Michael S. Tsirkin comments:
- changed the name of new field to use_guest_notifier_mask
- clarified comments
- vhost_virtqueue_mask() called for unmask
- cosmetic changes
- moved the initialization
This patch adds to the vubr test the scattering of incoming
packets to the chain of RX buffer. Also, this patch corrects the
size of the header preceding the packet in RX buffers.
Note that this patch doesn't add the support for mergeable
buffers.
Signed-off-by: Victor Kaplansky
---
unmasked state;
- cosmetic fixes.
v2 changes:
- a new boolean field is added to all virtio devices instead
of defining a property in some virtio-pci devices.
Signed-off-by: Victor Kaplansky
---
include/hw/virtio/virtio.h | 1 +
hw/net/vhost_net.c | 16 ++--
hw/virt
Hi, this patch is a cosmetic rework of two patches originally sent
by Didier Pallard "[PATCH 2/3] virtio-pci: add an option to
bypass guest_notifier_mask" and "[PATCH 3/3] vhost-net: force
guest_notifier_mask bypass in vhost-user case".
The problem the patch solves is described in original posting
virtio pci.
Signed-off-by: Victor Kaplansky
---
include/hw/virtio/virtio.h | 1 +
hw/net/vhost_net.c | 24 ++--
hw/virtio/vhost.c | 13 +
hw/virtio/virtio-pci.c | 15 +--
hw/virtio/virtio.c | 1 +
5 files changed, 46 insert
On Thu, Dec 03, 2015 at 10:53:18AM +0100, Didier Pallard wrote:
> Using guest_notifier_mask function in vhost-user case may
> break interrupt mask paradigm, because mask/unmask is not
> really done when returning from guest_notifier_mask call, instead
> message is posted in a unix socket, and proce
The test is based on bios-tables-test.c. It creates a file with
the boot sector image and loads it into a guest using PXE and TFTP
functionality.
Cc: Jason Wang
Signed-off-by: Victor Kaplansky
Suggested-by: Michael S. Tsirkin
---
v2:
- added a one more test for virtio-pci device, so the
The test is based on bios-tables-test.c. It creates a file with
a boot sector image and loads it into a guest using PXE and TFTP
functionality.
Cc: Jason Wang
Signed-off-by: Victor Kaplansky
Suggested-by: Michael S. Tsirkin
---
tests/pxe-test.c | 141
by taking/giving vring_call fd from/to kernel kvm module).
> Patches 2 and 3 of the serie propose an implementation of this second option.
>
> Didier
>
Tested-by: Victor Kaplansky
> Didier Pallard (3):
> char: fix vhost-user socket full
> virtio-pci:
On Tue, Jan 12, 2016 at 01:05:52PM +0100, Didier Pallard wrote:
> On 01/12/2016 09:26 AM, Victor Kaplansky wrote:
> >This RFC PATCH tries to solve the problem of lost interrupts
> >from a slow back-end. Didier could you test it?
> >
> >Thanks, Victor
> >
> >
masked_notifier, and some
interrupts could be lost.
This patch tries to handle the above situation by testing and
cleaning both masked_notifier and guest_notifier in
guest_notifier read handler.
Signed-off-by: Victor Kaplansky
---
include/hw/virtio/virtio.h | 1 +
hw/virtio/vhost.c | 3
On Thu, Dec 10, 2015 at 04:09:23PM +0100, Didier Pallard wrote:
> On 12/10/2015 01:56 PM, Victor Kaplansky wrote:
> >On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote:
> >>On 12/09/2015 04:59 PM, Victor Kaplansky wrote:
> >>>On Mon, Dec 07, 2015 at 02:31
On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote:
> On 12/09/2015 04:59 PM, Victor Kaplansky wrote:
> >On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote:
> >>Hi
> >>
> >>On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard
> >>
On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard
> wrote:
> > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all
> > is used to send a message and retries as long as EAGAIN errno is set,
> > but w
On Thu, Dec 03, 2015 at 03:11:57PM +0530, Naredula Janardhana Reddy wrote:
> Hi
> I am using the latest qemu-2.5.0-rc2 with vhost-user(with multi-queue,
> with 3 queues) to test multi-queue feature with vhost-user. In the guest
> vm, multi-queue feature flag is not getting enabled .
>
> On the
On Thu, Dec 03, 2015 at 03:11:57PM +0530, Naredula Janardhana Reddy wrote:
> Hi
> I am using the latest qemu-2.5.0-rc2 with vhost-user(with multi-queue,
> with 3 queues) to test multi-queue feature with vhost-user. In the guest
> vm, multi-queue feature flag is not getting enabled .
>
> On the
This fixes file descriptor leakage in vhost-user-bridge
application. Whenever a new callfd or kickfd is set, the previous
one should be explicitly closed. File descriptors used to map
guest's memory are closed immediately after mmap call.
Signed-off-by: Victor Kaplansky
---
tests/vhost
Fix QEMU crash when -netdev type=vhost-user,queues=n is passed
with zero number of queues.
Signed-off-by: Victor Kaplansky
---
net/vhost-user.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 5071602..b368a90 100644
--- a/net/vhost-user.c
+++ b
. default: 127.0.0.1:
Signed-off-by: Victor Kaplansky
---
tests/vhost-user-bridge.c | 129 +++---
1 file changed, 111 insertions(+), 18 deletions(-)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 784f15f..85c4c8a 100644
--- a/tests
The backend has to know whether VIRTIO_NET_F_GUEST_ANNOUNCE was
negotiated, so, as a hack we propose the feature by
vhost-user-bridge during the feature negotiation.
Signed-off-by: Victor Kaplansky
---
tests/vhost-user-bridge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vhost
This series of patches enhances vhost-user command line interface
to enable using it for on-line migration testing.
Signed-off-by: Victor Kaplansky
Victor Kaplansky (2):
tests/vhost-user-bridge: propose GUEST_ANNOUNCE feature
tests/vhost-user-bridge: read command line arguments
tests
On Mon, Nov 16, 2015 at 06:47:03PM +0200, Michael S. Tsirkin wrote:
> We are currently only sending VRING_ENABLE message for the first ring,
> that's wrong: we must start/stop them all.
>
> Reported-by: Victor Kaplansky
> Signed-off-by: Michael S. Tsirkin
> ---
>
>
During migration devices continue writing to the guest's memory.
The writes has to be reported to QEMU. This change implements
minimal support in vhost-user-bridge required for successful
migration of a guest with virtio-net device.
Signed-off-by: Victor Kaplansky
---
v5:
- The backen
On Tue, Nov 17, 2015 at 01:04:33PM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 17, 2015 at 12:04:06PM +0200, Victor Kaplansky wrote:
> > During migration devices continue writing to the guest's memory.
> > The writes has to be reported to QEMU. This change implements
&g
During migration devices continue writing to the guest's memory.
The writes has to be reported to QEMU. This change implements
minimal support in vhost-user-bridge required for successful
migration of a guest with virtio-net device.
Signed-off-by: Victor Kaplansky
---
v4:
- impl
Thanks for the clarification.
Reviewed-by: Victor Kaplansky
On Mon, Nov 16, 2015 at 12:01:44PM +0200, Michael S. Tsirkin wrote:
> Clarify logging setup to make sure all clients comply in a way that is
> future-proof. Document how rings are started/stopped.
>
> Signed-off-b
On Sun, Nov 15, 2015 at 09:29:59PM +0200, Michael S. Tsirkin wrote:
> Clarify logging setup to make sure all clients comply in a way that is
> future-proof. Document how rings are started/stopped.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> docs/specs/vhost-user.txt | 62
> ++
During migration devices continue writing to the guest's memory.
The writes has to be reported to QEMU. This change implements
minimal support in vhost-user-bridge required for successful
migration of a guest with virtio-net device.
Signed-off-by: Victor Kaplansky
---
v3:
- Get r
On Thu, Nov 12, 2015 at 04:38:51PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 12, 2015 at 02:34:56PM +0200, Victor Kaplansky wrote:
> > /* Based on qemu/hw/virtio/vhost-user.c */
> > @@ -173,6 +180,9 @@ typedef struct VubrVirtq {
> > #define VHOST_MEMORY_MAX_NREGI
During migration devices continue writing to the guest's memory.
The writes has to be reported to QEMU. This change implements
minimal support in vhost-user-bridge required for successful
migration of a guest with virtio-net device.
Signed-off-by: Victor Kaplansky
---
v2:
- use log_guest
Unlike the kernel, vhost-user application accesses log table by
mmaping it to its user space. This change adds two new fields to
VhostUserMsg payload: mmap_size, and mmap_offset and make QEMU to
pass the to vhost-user application in VHOST_USER_SET_LOG_BASE
request.
Signed-off-by: Victor Kaplansky
During migration devices continue writing to the guest's memory.
These writes have to be reported to QEMU. The change implements
minimal support in vhost-user-bridge required for successful
migration of a guest with virtio-net device.
Signed-off-by: Victor Kaplansky
---
tests/vhost
After looking into linux driver code at hw/virtio/vhost.c,
I see that the driver does what spec says. Thus spec the should
remain as is, and QEMU need to be fixed on big-endian machines by
changing the code in hw/virtio/vhost.c
--Victor
- Original Message -
From: "Victor Kaplansky
: Victor Kaplansky
---
docs/specs/vhost-user.txt | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
index e0d71e2..3d18771 100644
--- a/docs/specs/vhost-user.txt
+++ b/docs/specs/vhost-user.txt
@@ -177,9 +177,11 @@ addresses
xecute transmits
and receives to the internet. I tested with "wget redhat.com",
"dig redhat.com".
PS. I've consulted DPDK's code for vhost-user during Vhost-User
Bridge implementation.
Signed-off-by: Victor Kaplansky
---
v3:
- Change debug printings to use condition
On Tue, Oct 27, 2015 at 01:40:03PM +0200, Michael S. Tsirkin wrote:
> On Mon, Oct 26, 2015 at 07:19:23PM +0200, Victor Kaplansky wrote:
> > +
> > +#define VHOST_USER_PROTOCOL_FEATURE_MASK ((1 << VHOST_USER_PROTOCOL_F_MAX)
> > - 1)
> > +
&
xecute transmits
and receives to the internet. I tested with "wget redhat.com",
"dig redhat.com".
PS. I've consulted DPDK's code for vhost-user during Vhost-User
Bridge implementation.
Signed-off-by: Victor Kaplansky
---
v2:
Cosmetic changes:
- Tabs expan
ceives to the
internet. I tested with "wget redhat.com", "dig redhat.com".
PS. I've consulted DPDK's code for vhost-user during Vubr
implementation.
Signed-off-by: Victor Kaplansky
---
tests/vubr/dispatcher.h | 26 ++
tests/vubr/vhost.h | 77 +
tests/vubr/vh
instances after the example.
- English and others cleanups.
Signed-off-by: Victor Kaplansky
---
qemu-options.hx | 22 ++
1 file changed, 22 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 2485b94..6bdb884 100644
--- a/qemu-options.hx
+++ b/qemu
For a long time QEMU has had support for UDP unicast network
backend, but manual was missing description and usage examples.
This patch adds some more documentation and an example.
Signed-off-by: Victor Kaplansky
---
qemu-options.hx | 23 +++
1 file changed, 23 insertions
On Sun, Aug 09, 2015 at 12:54:37PM +0100, Peter Maydell wrote:
> On 9 August 2015 at 12:39, Michael S. Tsirkin wrote:
> > On Sun, Aug 09, 2015 at 12:39:59PM +0300, Victor Kaplansky wrote:
> >> -$(eval -include $(addsuffix *.d, $(sort $(dir $($v)
> >&g
".
I've tested the fix by validating that lists included by previous "*.d"
approach and new "patsubst" approach are identical.
Victor Kaplansky (2):
make: fix where dependency *.d are stored.
make: load only required dependency files.
hw/i386/Makefile.objs
.d files.
As a hack, we also touch two sources for generated *.hex files. Without
this hack, anyone doing "git pull; make" will not get *.hex rebuilt
correctly since the dependency file would be missing.
Signed-off-by: Victor Kaplansky
---
hw/i386/acpi-dsdt.dsl | 1 -
hw
it list of required dependency info files for
*.hex autogenerated sources.
Note that Makefile still includes some .d in rood directory by including
"*.d".
Signed-off-by: Victor Kaplansky
---
hw/i386/Makefile.objs | 8 +++-
rules.mak | 2 +-
2 files changed, 8 insert
> - Original Message -
> From: "Michael S. Tsirkin"
> To: "Paolo Bonzini"
> Cc: "Victor Kaplansky" , qemu-devel@nongnu.org, "Richard
> Henderson" , "Eduardo Habkost"
> Sent: Wednesday, August 5, 2015 4:59:56 PM
>
On Wed, Aug 05, 2015 at 07:40:00PM +0200, Paolo Bonzini wrote:
>
>
> On 05/08/2015 19:29, Victor Kaplansky wrote:
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index bd4f147..311d364 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386
it list of required dependency info files for
*.hex autogenerated sources.
Note that Makefile still includes some .d in rood directory by including
"*.d".
Signed-off-by: Victor Kaplansky
---
hw/i386/Makefile.objs | 2 ++
rules.mak | 2 +-
2 files changed, 3 inser
ex rebuild, when old revision is switched to the new one.
Signed-off-by: Victor Kaplansky
---
hw/i386/acpi-dsdt.dsl | 1 -
hw/i386/q35-acpi-dsdt.dsl | 1 +
rules.mak | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i386/acpi-dsdt
.d"
approach and new "patsubst" approach are identical.
Victor Kaplansky (2):
make: fix where dependency *.d are stored.
make: load only required dependency files.
hw/i386/Makefile.objs | 2 ++
hw/i386/acpi-dsdt.dsl | 1 -
hw/i386/q35-acpi-dsdt.dsl | 1 +
rules.mak
explicitly.
This will allow us not to break future builds when one of such generated
sources is removed - by removing explicit include of removed dependency.
By itself this doesn't fix broken builds from the past and this will be
done by the following patch.
Signed-off-by: Victor Kaplansky
---
hw
63 matches
Mail list logo
