Re: [PATCH v3 6/7] docs: gpio: Add GPIO Aggregator/Repeater documentation

2019-11-27 Thread Ulrich Hecht
<&gpio2 20 GPIO_ACTIVE_LOW>; > +}; > + > +it can be bound to the GPIO Aggregator by either: > + > +1. Adding its compatible value to ``gpio_aggregator_dt_ids[]``, > +2. Binding manually using "driver_override": > + > +.. code-block:: bash >

Re: [PATCH v3 3/7] gpiolib: Add support for GPIO line table lookup

2019-11-27 Thread Ulrich Hecht
gt; --- a/include/linux/gpio/machine.h > +++ b/include/linux/gpio/machine.h > @@ -31,7 +31,7 @@ enum gpio_lookup_flags { > */ > struct gpiod_lookup { > const char *chip_label; > - u16 chip_hwnum; > + u16 chip_hwnum; /* if -1, chip_label is named line */

Re: [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver

2019-11-27 Thread Ulrich Hecht
Thank you for this series! > On November 27, 2019 at 9:42 AM Geert Uytterhoeven > wrote: > > > GPIO controllers are exported to userspace using /dev/gpiochip* > character devices. Access control to these devices is provided by > standard UNIX file system permissions, on an all-or-nothing basi

Re: [PATCH v3 4/7] dt-bindings: gpio: Add gpio-repeater bindings

2019-11-27 Thread Ulrich Hecht
gt; +description: > + Strings defining the names of the GPIO lines going out of the GPIO > + controller. > + > +required: > + - compatible > + - "#gpio-cells" > + - gpio-controller > + - gpios > + > +additionalProperties: false > + > +examples: > + # Device node describing a polarity inverter for a single GPIO > + - | > +#include > + > +inverter: gpio-repeater { > +compatible = "gpio-repeater"; > +#gpio-cells = <2>; > +gpio-controller; > +gpios = <&gpio 95 GPIO_ACTIVE_LOW>; > +}; > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v3 1/7] gpiolib: Add GPIOCHIP_NAME definition

2019-11-27 Thread Ulrich Hecht
bus_unregister(&gpio_bus_type); > diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h > index ca9bc1e4803c2979..a4a759920faa48ab 100644 > --- a/drivers/gpio/gpiolib.h > +++ b/drivers/gpio/gpiolib.h > @@ -16,6 +16,8 @@ > #include > #include > > +#define GPIOCHIP_NAME"gpiochip" > + > /** > * struct gpio_device - internal state container for GPIO devices > * @id: numerical ID number for the GPIO chip > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v3 2/7] gpiolib: Add support for gpiochipN-based table lookup

2019-11-27 Thread Ulrich Hecht
eturn NULL; > + > + if (kstrtoint(name + strlen(GPIOCHIP_NAME), 10, &id)) > + return NULL; > + > + return gpiochip_find((void *)(uintptr_t)id, gpiochip_match_id); > } > > #ifdef CONFIG_GPIOLIB_IRQCHIP > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [Qemu-devel] [PATCH QEMU] hw/char/sh_serial: Add timeout handling to unbreak serial input

2018-07-30 Thread Ulrich Hecht
> Signed-off-by: Geert Uytterhoeven Works for me, kernel 4.18-rc7 for rts7751r2dplus. Tested-by: Ulrich Hecht CU Uli

[Qemu-devel] [PATCH] linux-user: fail execve() if env/args too big

2012-01-31 Thread Ulrich Hecht
rget process an environment that is too big for it to handle, at which point QEMU barfs and exits, confusing procmail's autoconf script and causing the build to fail. This patch makes sure that execve() will return E2BIG if the environment is too large for the target. Signed-off-by: Ulrich Hecht ---

Re: [Qemu-devel] [PATCH 2/9] S/390 CPU emulation

2009-11-11 Thread Ulrich Hecht
On Tuesday 10 November 2009, Aurelien Jarno wrote: > I have tested it by removing all the block around tb_add_jump in > cpu_exec.c. I have a speed loss of about 2.5x in the boot time of an > x86_64 image. I just tried it with qemu-system-x86_64, and with that I can observe a noticable performance

Re: [Qemu-devel] [PATCH 2/9] S/390 CPU emulation

2009-11-09 Thread Ulrich Hecht
On Monday 02 November 2009, Laurent Desnogues wrote: > That indeed looks strange: fixing the TB chaining on ARM > made nbench i386 three times faster. Note the gain was > less for FP parts of the benchmark due to the use of > helpers. > > out of curiosity could you post your tb_set_jmp_target1 >

Re: [Qemu-devel] [PATCH 3/4] S/390 host support for TCG

2009-11-09 Thread Ulrich Hecht
On Monday 02 November 2009, Aurelien Jarno wrote: > First of all I have a question about s390/s390x. It seems that you > plan to support both s390 and s390x in the same file. Is that correct? Actually, I didn't think about supporting s390 hosts at all, but it should be possible. > Do you know ho

Re: [Qemu-devel] [PATCH 2/9] S/390 CPU emulation

2009-11-02 Thread Ulrich Hecht
On Thursday 22 October 2009, Aurelien Jarno wrote: > Probably the second. Changing the instruction pointer in the helper > instead of using the proper goto_tb TCG op prevents TB chaining, and > therefore as a huge impact on performance. > > It's something not difficult to implement, and that I woul

[Qemu-devel] [PATCH 10/12] linux-user: define a couple of syscalls for non-uid16 targets

2009-10-21 Thread Ulrich Hecht
Quite a number of syscalls are only defined on systems with USE_UID16 defined; this patch defines them on other systems as well. Fixes a large number of uid/gid-related testcases on the s390x target (and most likely on other targets as well) Signed-off-by: Ulrich Hecht --- linux-user/syscall.c

[Qemu-devel] [PATCH 07/12] linux-user: S/390 64-bit (s390x) support

2009-10-21 Thread Ulrich Hecht
code for running 64-bit S/390 Linux binaries use CPU_DoubleU for FP regs proper specification exception (SIGILL) handling Signed-off-by: Ulrich Hecht --- linux-user/elfload.c | 18 ++ linux-user/main.c| 89 ++ linux-user/s390x/syscall.h | 25

[Qemu-devel] [PATCH 08/12] linux-user: don't do locking in single-threaded processes

2009-10-21 Thread Ulrich Hecht
Skips setting the tb_lock if a process doesn't have more than one thread, which is usually the case. Results in about 20% performance gain (measured with the s390x target, but the effect should be similar with other targets). Signed-off-by: Ulrich Hecht --- cpu-defs.h |

[Qemu-devel] [PATCH 09/12] linux-user: dup3, fallocate syscalls

2009-10-21 Thread Ulrich Hecht
implementations of dup3 and fallocate that are good enough to fool LTP dup3 check, fallocate check fixed use compile_prog Signed-off-by: Ulrich Hecht --- configure| 36 linux-user/syscall.c | 10 ++ 2 files changed, 46 insertions

[Qemu-devel] [PATCH 12/12] enable CPU_QuadU for s390x

2009-10-21 Thread Ulrich Hecht
Signed-off-by: Ulrich Hecht --- cpu-all.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index ebe8bfb..d245dd2 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -138,7 +138,7 @@ typedef union { uint64_t ll; } CPU_DoubleU; -#ifdef TARGET_SPARC

[Qemu-devel] [PATCH 04/12] S/390 host build system support

2009-10-21 Thread Ulrich Hecht
changes to configure and makefiles for S/390 host support --- configure | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 350c742..df984a3 100755 --- a/configure +++ b/configure @@ -157,9 +157,12 @@ case "$cpu" in parisc|parisc64)

[Qemu-devel] [PATCH 11/12] linux-user: getpriority errno fix

2009-10-21 Thread Ulrich Hecht
getpriority returned wrong errno; fixes LTP test getpriority02. Signed-off-by: Ulrich Hecht --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index da6f2e1..455c3fd 100644 --- a/linux-user/syscall.c

[Qemu-devel] [PATCH 01/12] TCG "sync" op

2009-10-21 Thread Ulrich Hecht
ilure on 32-bit targets. Signed-off-by: Ulrich Hecht --- tcg/tcg-op.h | 12 tcg/tcg-opc.h |2 ++ tcg/tcg.c |6 ++ 3 files changed, 20 insertions(+), 0 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index faf2e8b..c1b4710 100644 --- a/tcg/tcg-op.h +++ b/tc

[Qemu-devel] [PATCH 02/12] S/390 disassembler fixes

2009-10-21 Thread Ulrich Hecht
enable zArch (64-bit) instructions enable disassembler for both s390 and s390x Signed-off-by: Ulrich Hecht --- configure |2 +- disas.c|3 +++ s390-dis.c |4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configure b/configure index ca6d45c..350c742 100755

[Qemu-devel] [PATCH 05/12] S/390 target build system support

2009-10-21 Thread Ulrich Hecht
changes to configure and makefiles for S/390 target support --- configure |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configure b/configure index df984a3..64be51f 100755 --- a/configure +++ b/configure @@ -793,6 +793,7 @@ sh4eb-linux-user \ sparc-linux-user \

[Qemu-devel] [PATCH 06/12] S/390 host support for TCG

2009-10-21 Thread Ulrich Hecht
S/390 TCG code generator as posted before improvements since last time: - don't use R0 (often means "zero", not "register zero") - optimized add_i32 immediate - formatted for better compliance with the QEMU coding style Signed-off-by: Ulrich Hecht --- dyngen-exec.h

[Qemu-devel] [PATCH 00/12] S/390 support

2009-10-21 Thread Ulrich Hecht
Here's the patches again, split and fixed as suggested by Aurelien. It should now be possible to apply host and target support separately. See the individual patches for details on what has changed. CU Uli Ulrich Hecht (12): TCG "sync" op S/390 disassembler fixes S/390 CP

Re: [Qemu-devel] [PATCH 1/9] TCG "sync" op

2009-10-19 Thread Ulrich Hecht
On Saturday 17 October 2009, Edgar E. Iglesias wrote: > I looked at the s390 patches and was also unsure about this sync op. > I'm not convinced it's bad but my first feeling was as Aurelien points > out that the translator shoud take care of it. Indeed. I would have expected it to, in fact. But i

Re: [Qemu-devel] [PATCH 1/9] TCG "sync" op

2009-10-19 Thread Ulrich Hecht
On Friday 16 October 2009, Aurelien Jarno wrote: > This example is a bit biased, as registers are only saved, and never > reused. Let's comment on it though. Yeah, well, I searched from the top for the first case where it makes a difference. If it's of any help, I can upload a complete dump of bo

Re: [Qemu-devel] [PATCH 2/9] S/390 CPU emulation

2009-10-19 Thread Ulrich Hecht
On Saturday 17 October 2009, Aurelien Jarno wrote: > On Fri, Oct 16, 2009 at 02:38:48PM +0200, Ulrich Hecht wrote: > First of all a few general comments. Note that I know very few things > about S390/S390X, so I may have dumb comments/questions. Also as the > patch is very long, I p

[Qemu-devel] [patch] s390-dis.c license

2008-01-17 Thread Ulrich Hecht
Hi! Our Teenage Mutant Legal Turtles have discovered that s390-dis.c contains GPLv3 code. Fortunately, the actual code has not changed since the last GPLv2 binutils release, save for the license headers, so it suffices to change those back to fix the problem. CU Uli -- SUSE LINUX Products Gm

Re: [Qemu-devel] Help needed! dyngen: Unsupported ELF class

2007-11-15 Thread Ulrich Hecht
On Thursday 15 November 2007, test test wrote: > -- >-- dyngen: Unsupported ELF class > make[1]: *** [op.h] Error 1 > -- >-- > > What's the problem

Re: [Qemu-devel] s390 host support

2007-11-13 Thread Ulrich Hecht
On Tuesday 13 November 2007, Bastian Blank wrote: > Please describe the environment you work in, including compiler > versions and patchsets. gcc 3.3 (Hammer branch, really vintage stuff) with recent (2.18.50) binutils. We already use gcc 4 for targets where the old one won't work (ia64 and ppc6

Re: [Qemu-devel] s390 host support

2007-11-12 Thread Ulrich Hecht
On Saturday 10 November 2007, Bastian Blank wrote: > Thimo Seufer asked me to check if the s390 host supports works at all. > It did not even build, dyngen failed. A 31-bit build of the CVS code works fine for me. (At least if I add the br %rANY fix that is also in your patch and the jcc patch th

Re: [Qemu-devel] Porting QEMU to Minix - op_goto_tb1 segfaults because tb_next[1] is NULL

2007-08-23 Thread Ulrich Hecht
On Wednesday 22 August 2007, Erik van der Kouwe wrote: > My problem is the following: quickly after starting I get a > segmentation fault while the generated code is running. > > This happens in the code generated from op_goto_tb1 and is caused by > jumping to a NULL pointer. This NULL pointer orig

Re: [Qemu-devel] [PATCH] S/390 host fixed

2007-08-01 Thread Ulrich Hecht
On Wednesday 01 August 2007 01:59, Thiemo Seufer wrote: > > -AIOLIBS="-lrt" > > +AIOLIBS="-lrt -lpthread" > > Why is this needed? Linux toolchains should add -lpthread implicitly. Our SLES9 toolchain seems not to. It's a near-cosmetic change. > > +#ifdef __s390__ > > +retaddr = (void*

[Qemu-devel] [PATCH] Z80 emulation updated

2007-07-06 Thread Ulrich Hecht
Hi! Here's an update to Stuart Brady's ZX Spectrum system emulator, fixed to work with the code in CVS, with some dead code removed, implementing HALT (and a hack that makes the Spectrum ROM use it in the input loop), and with support for loading snapshots ("-kernel commando.z80" :) using libs

Re: [Qemu-devel] [PATCH] ARM7TDMI emulation

2007-07-03 Thread Ulrich Hecht
On Monday 02 July 2007 18:14, Ulrich Hecht wrote: > Anyway, here's the 920T version. The magic numbers may or may not be > correct. And here's an even better version that implements both 920T and 7TDMI (with base-updated aborts). CU Uli -- SUSE LINUX Products GmbH, GF: Marku

Re: [Qemu-devel] [PATCH] ARM7TDMI emulation

2007-07-02 Thread Ulrich Hecht
On Monday 02 July 2007 15:40, Paul Brook wrote: > You should add/use ARM_FEATURE_V5/ARCH(5) instead. Alright. > The ARM7TDMI implements the base updated abort model. Er, yes, but there is no MMU that could actually cause an abort, right? Anyway, here's the 920T version. The magic numbers may or

[Qemu-devel] [PATCH] ARM7TDMI emulation

2007-07-02 Thread Ulrich Hecht
Hi! This patch adds ARM7TDMI emulation with Thumb v1 (no BLX, no BKPT, ignore bit 0 on POP PC) and without CP15. CU Uli -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Index: cpu.h === RCS file: /sources/qemu/

Re: [Qemu-devel] [PATCH] ARM (Thumb) read from R15

2007-07-02 Thread Ulrich Hecht
On Saturday 30 June 2007 04:19, Paul Brook wrote: > > QEMU does not set the Thumb bit when reading from R15 in Thumb mode. > > Neither does real hardware. You are, unsurprisingly, right. The problem seems to be a different one. Quoting the ARM on "pop pc": "In ARM architecture 5 and above, bit[0

Re: [Qemu-devel] [PATCH] ARM (Thumb) read from R15

2007-06-28 Thread Ulrich Hecht
On Thursday 28 June 2007 17:30, Ulrich Hecht wrote: > On Thursday 28 June 2007 16:31, Ulrich Hecht wrote: > > QEMU does not set the Thumb bit when reading from R15 in Thumb mode. > > Here's the fix: > > Maybe not; this seems to break some cases ... :( This works in all m

Re: [Qemu-devel] [PATCH] ARM (Thumb) read from R15

2007-06-28 Thread Ulrich Hecht
On Thursday 28 June 2007 16:31, Ulrich Hecht wrote: > QEMU does not set the Thumb bit when reading from R15 in Thumb mode. > Here's the fix: Maybe not; this seems to break some cases ... :( CU Uli -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)

[Qemu-devel] [PATCH] ARM (Thumb) read from R15

2007-06-28 Thread Ulrich Hecht
Hi! QEMU does not set the Thumb bit when reading from R15 in Thumb mode. Here's the fix: Index: target-arm/translate.c === RCS file: /sources/qemu/qemu/target-arm/translate.c,v retrieving revision 1.53 diff -u -r1.53 translate.c ---

[Qemu-devel] Patch day

2006-03-08 Thread Ulrich Hecht
Hi! Here's the current lot of patches from the SuSE QEMU package. As we have now arrived at the point where patches start to conflict with each other, I would be very grateful if at least some of these went into the next release. qemu-0.7.0-binfmt.patch: some enhancements to the qemu-binfmt-co

Re: [Qemu-devel] qemu regression 0.7.2 -> 0.8.0 (ARM user emulation)

2006-03-07 Thread Ulrich Hecht
Hi! On Wednesday 01 March 2006 23:18, Anderson Lizardo wrote: > I was having some issues with the latest qemu (ARM user emulation), > which I tracked down to the following reduced test case: > > #include > int main(void) > { > float a, b; > a = 0.1f; > b = 0.8f; >