[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-01-27 Thread Tony Breeds
** Changed in: nova Milestone: None => kilo-2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status in Cinder: Triaged St

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-01-26 Thread Tony Breeds
** Changed in: cinder Assignee: (unassigned) => Tony Breeds (o-tony) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output ima

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-16 Thread Tony Breeds
Patchg 0500-block-raw-posix-Try-both-FIEMAP-and-SEEK_HOLE.patch appears to be part of a bigger re-write of the related code. and is ON TOP of the patches already applied in this bug. No doubt the rewirtten code is "better" but backporting it contains more risk than the 2 simple fixes I already

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-11 Thread Tony Breeds
I'm happy to tackle to also fix cinder with a version of the nova fix (for consistency). I propose waiting until the nova fix lands ** Changed in: cinder Assignee: (unassigned) => Tony Breeds (o-tony) -- You received this bug notification because you are a member of qemu- devel-m

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-11 Thread Tony Breeds
I'd elevate this to high so it matches nova and ubuntu but I don't have permissions to do so. ** Changed in: cinder Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/136

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-10 Thread Tony Breeds
Chris, I've read through 1292234 and I'll have a play with your reproducer locally and see if I can gain any insight. I'm sorry my fix didn't help 1292234, but glad you can't hit 1368815 with upstream, I was kinda having kittens here ;P -- You received this bug notification because you are a me

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-12-10 Thread Tony Breeds
Hi Chris, Markus' rework will not reintroduce this bug as it completely removes all fiemap code. bug 129224 is a different issue, I'll comment on that bug. You say: you encounter issues with upstream with ^extent and ext3 filesystems. Just to be clear: Are you saying that *this* bug is still a

Re: [Qemu-devel] Providing a mechanism to reopen() file based chardevs

2014-12-08 Thread Tony Breeds
On Mon, Dec 08, 2014 at 09:48:12AM +, Daniel P. Berrange wrote: > My long term desired approach to deal with this problem in OpenStack (and > other libvirt based mgmt apps) is to have a separate log daemon in libvirt > eg a virtlogd daemon. Take QEMU out of the business of writing to files >

Re: [Qemu-devel] Providing a mechanism to reopen() file based chardevs

2014-12-05 Thread Tony Breeds
On Fri, Dec 05, 2014 at 11:09:02PM +0100, Paolo Bonzini wrote: > I think so. Should it reopen stdout/stderr too? Thanks for the feedback I'm gald it's something that isn't a clearly terrible idea. I don't think that's required for my use case, but it's not all about me. If that's something pe

[Qemu-devel] Providing a mechanism to reopen() file based chardevs

2014-12-05 Thread Tony Breeds
Hi All, Openstcak (Nova) has had an issue for a longish time where a running instance (qemu via libvirt) which has a file based console can fill the disk of the hypervisor causing all guests to stall. I'm looking at ways to fix this. Clearly it can be done in openstack wothout changing qemu b

Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()

2014-12-04 Thread Tony Breeds
On Thu, Nov 27, 2014 at 06:00:38PM +0100, Paolo Bonzini wrote: > You're right. It's just that the API should be private to > qemu-timer.c, it is not meant for external usage---and it is messy > because get_clock_realtime() is for QEMU_CLOCK_HOST. Somehow this got horrendously lost. > In addition

Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()

2014-11-26 Thread Tony Breeds
On Wed, Nov 26, 2014 at 03:01:01PM +0100, Paolo Bonzini wrote: > Use the external qemu-timer API instead. Perhaps it's obvious but is it reasonable to expand on why you're doign this in the commit message? Yours Tony. pgpbbAXtQoPFT.pgp Description: PGP signature

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-11-20 Thread Tony Breeds
Awesome. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status in OpenStack Compute (Nova): In Progress Status in QE

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-11-20 Thread Tony Breeds
Hi Serge, Is there any chance these fixes will go into trusty? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status in OpenS

Re: [Qemu-devel] mute button not work

2014-11-18 Thread Tony Breeds
On Tue, Nov 18, 2014 at 03:55:07PM +0800, li wrote: > Hi all, > > i use qemu-system-x86_64 to run windows 7, and fund that "mute/unmute" button > in the right bottom of guest desktop not work. > > related info is as below: > > $qemu-system-x86_64 --version > QEMU emulator version 1.4.0, Copy

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-10-22 Thread Tony Breeds
FWIW the following 2 commits in qemu master resolve the issue for qemu- img. http://git.qemu.org/?p=qemu.git;a=commit;h=38c4d0aea3e1264c86e282d99560330adf2b6e25 http://git.qemu.org/?p=qemu.git;a=commit;h=7c15903789953ead14a417882657d52dc0c19a24 If possible they should be back ported to trus

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-29 Thread Tony Breeds
openstack review at: https://review.openstack.org/#/c/123957/ Qemu patches at: http://patchwork.ozlabs.org/patch/393494/ ; and http://patchwork.ozlabs.org/patch/393495/ ** Changed in: nova Assignee: (unassigned) => Tony Breeds (o-tony) ** Changed in: qemu Status: New =&

Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap

2014-09-26 Thread Tony Breeds
On Fri, Sep 26, 2014 at 11:09:30AM -0600, Eric Blake wrote: > [you buried your patches in deep reply to a longer thread, making them > harder to find; in the future, you can just send a v2 as a new top-level > thread] Thanks. I'll remember that next time. Tony. pgpqvgudi2tHf.pgp Description:

[Qemu-devel] [PATCH v2 2/2] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Tony Breeds
try_fiemap() uses FIEMAP_FLAG_SYNC which has a significant performance impact. Prefer seek_hole() over fiemap() to avoid this impact where possible. seek_hole is more widely used and, arguably, has potential to be optimised in the kernel. Reported-By: Michael Steffens Signed-off-by: Tony Breeds

[Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk corruption in try_fiemap

2014-09-25 Thread Tony Breeds
Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter. Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl. This has the downside of significantly reducing performance. Reported-By: Michael Steffens Signed-off-by: Tony Breeds Cc: Kevin Wolf Cc: Markus Armbruster Cc: Stefan

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Tony Breeds
On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > Does this fix the problem or does it just make it less likely that it > becomes apparent? Sorry for not making this clearer in my commit message. I haven't been able to reproduce the corruption with the fiemap flag change. > If ther

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Tony Breeds
On Thu, Sep 25, 2014 at 08:42:25AM +0200, Greg Kurz wrote: > Same path : ./scripts/get_maintainer.pl Thanks Greg. Now I know :) Tony. pgp2j8su8SSSV.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Tony Breeds
On Thu, Sep 25, 2014 at 08:21:27AM +0200, Markus Armbruster wrote: > Please copy Kevin & Stefan for block patches. Doing that for you. I > also copy Max, who left his fingerprints on commit 4f11aa8. Sorry. Is there a qemu version of get_maintainers.pl? Tony. pgpYwsSX2dsBU.pgp Description: PG

[Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Tony Breeds
we're there modify try_fiemap() to set FIEMAP_FLAG_SYNC. Reported-By: Michael Steffens CC: Pádraig Brady Signed-off-by: Tony Breeds --- block/raw-posix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index a253697..b438c54 1