Re: [Qemu-devel] [virtio-dev] [PATCH V2 1/1] virtio-balloon: fix internal stat name array to match Linux kernel

2018-05-10 Thread Thomas Tai
On 2018-05-10 04:18 AM, Stefan Hajnoczi wrote: On Wed, May 09, 2018 at 03:53:05PM -0400, Thomas Tai wrote: The Linux kernel commit b4325044 ("virtio_balloon: add array of stat names") defines an array of stat name strings for consumers of the virtio interface to u

[Qemu-devel] [PATCH V2 1/1] virtio-balloon: fix internal stat name array to match Linux kernel

2018-05-09 Thread Thomas Tai
defined in this array by the Linux kernel do not match up with those defined internally by QEMU. This patch fixes this inconsistency by importing the header file from linux and use the new macro to construct the balloon_stat_names array. Signed-off-by: Jonathan Helman Signed-off-by: Thomas Ta

[Qemu-devel] [PATCH V2 0/1] virtio-balloon: fix internal stat name array to match Linux kernel

2018-05-09 Thread Thomas Tai
Hi Michael, As you have suggested I have imported the kernel header file and use the new macro to create the string array. Would you kindly review the patch for me? Please feel free to comment. Thank you, Thomas

Re: [Qemu-devel] [PATCH] virtio-balloon: fix internal stat name array to match Linux kernel

2018-05-07 Thread Thomas Tai
defined by the Linux kernel. Signed-off-by: Jonathan Helman Cc: Rob Gardner Cc: Thomas Tai So pls import the header from Linux so we can stop maintaining it in QEMU. Hi Michael, Thank you for your comment. Because Jonathan left the company last week, I hope to pick up what he left over. As

[Qemu-devel] [PATCH] e1000e : fix PCIe AER error injection

2018-02-23 Thread Thomas Tai
. Followed pci-bridge/xio3130_downstream.c to use pcie_cap_deverr_init() to initialize the mask. Signed-off-by: Thomas Tai --- hw/net/e1000e.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c index 191398a3d5..1ebcaa2d19 100644 --- a/hw/net/e1000e.c +++ b/hw/net