Re: [Qemu-devel] [PATCH] hw/arm: Qomify pxa2xx.c

On 15-Apr-2017 11:34 PM, "Suramya Shah" wrote: > Signed-off-by: Suramya Shah > --- > hw/arm/pxa2xx.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c > index cfee392..eea551d 100644 > --

[Qemu-devel] [PATCH] hw/arm: Qomify pxa2xx.c

Signed-off-by: Suramya Shah --- hw/arm/pxa2xx.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index cfee392..eea551d 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -755,19 +755,18 @@ static void pxa2xx_ssp_reset

[Qemu-devel] [PATCH] hw/core: fix segmentation fault

Signed-off-by: Suramya Shah --- hw/core/qdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 1e7fb33..07a211b 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -84,7 +84,11 @@ static void bus_add_child(BusState *bus, DeviceState *child

[Qemu-devel] [PATCH v2] hw/net: convert "dma" property type from ptr to link

The lance device needs pointer to ISA DMA device to operate. But according to qdev-properties.h, properties of pointer type should be avoided. A link type property is a good substitution. Changes since v1 -changed the code in hw/sparc/sun4m.c which uses the device. Signed-off-by: Suramya Shah

Re: [Qemu-devel] [PATCH] hw/net: convert "dma" property type from ptr to link

On 03-Apr-2017 1:06 PM, "Suramya Shah" wrote: > The lance device needs pointer to ISA DMA device to operate. But according > to > qdev-properties.h, properties of pointer type should be avoided. > A link type property is a good substitution. > > Signed-off-by: S

[Qemu-devel] [PATCH] hw/net: convert "dma" property type from ptr to link

The lance device needs pointer to ISA DMA device to operate. But according to qdev-properties.h, properties of pointer type should be avoided. A link type property is a good substitution. Signed-off-by: Suramya Shah --- hw/net/lance.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead Signed-off-by: Suramya Shah --- hw/unicore32/puv3.c | 7 +-- 1 file changed, 5 insertions(+), 2

[Qemu-devel] [PATCH v4] hw/unicore32: remove wrong assertion in puv machine init

Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error.Assert should not be used to check user provided parameters. Report an error and exit instead Signed-off-by: Suramya Shah --- hw/unicore32/puv3.c | 7 +-- 1 file changed, 5 insertions(+), 2

[Qemu-devel] [PATCH v3] hw/unicore32: remove wrong assertion in puv machine init

Signed-off-by: Suramya Shah Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead --- hw/unicore32/puv3.c | 7 +-- 1 file changed, 5 insertions(+), 2

[Qemu-devel] [PATCH v2] hw/unicore32: remove wrong assertion in puv machine init

Signed-off-by: Suramya Shah Reviewed-by: Marcel Apfelbaum Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead --- hw/unicore32/puv3.c | 7 +-- 1

Re: [Qemu-devel] [PATCH] hw/unicore32: fix a kernel_filename!=NULL assertion error in puv3.c

Kindly have a look at the forwarded patch. On 30-Mar-2017 8:28 PM, "Suramya Shah" wrote: > Signed-off-by: Suramya Shah > --- > Running QEMU with qemu-system-unicore32 without the kernel parameter > results in an assertion error. > Fix this by.. > hw/unicore32/

[Qemu-devel] [PATCH] hw/unicore32: fix a kernel_filename!=NULL assertion error in puv3.c

Signed-off-by: Suramya Shah --- Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Fix this by.. hw/unicore32/puv3.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c index

[Qemu-devel] [PATCH v4] util: Removed unneeded header from path.c

Signed-off-by: Suramya Shah Reviewed-by: Eric Blake --- qemu-common.h is no longer necessary as of refactoring done in commit f348b6d. util/path.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/path.c b/util/path.c index 5479f76..7f9fc27 100644 --- a/util/path.c +++ b/util/path.c

[Qemu-devel] [PATCH v2]util:Removed header qemu-common.h from path.c

Signed-off-by: Suramya Shah --- fix of typo in v1 that broke compilation util/path.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/path.c b/util/path.c index 5479f76..7f9fc27 100644 --- a/util/path.c +++ b/util/path.c @@ -6,7 +6,6 @@ #include "qemu/osdep.h" #include

[Qemu-devel] [PATCH] Removed header qemu-common.h from path.c

Signed-off-by: Suramya Shah --- util/path.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/path.c b/util/path.c index 5479f76..7f9fc27 100644 --- a/util/path.c +++ b/util/path.c @@ -6,7 +6,6 @@ #include "qemu/osdep.h" #include #include -#include "qemu-common.h&q

[Qemu-devel] [PATCH] Removed header qemu-common.h from path.c

Signed-off-by: Suramya Shah --- util/path.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/util/path.c b/util/path.c index 5479f76..46a6098 100644 --- a/util/path.c +++ b/util/path.c @@ -6,8 +6,7 @@ #include "qemu/osdep.h" #include #include -#include &quo

[Qemu-devel] [[PATCH-2]] Removed support for DEPTH!=32 in sm501.c

Signed-off-by: Suramya Shah --- hw/display/sm501.c | 17 - 1 file changed, 17 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 040a0b9..faca906 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1173,23 +1173,6 @@ typedef void draw_line_func

[Qemu-devel] [PATCH] Removed support for depth!=32

Signed-off-by: Suramya Shah --- hw/display/sm501_template.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/display/sm501_template.h b/hw/display/sm501_template.h index f33e499..4e5801e 100644 --- a/hw/display/sm501_template.h +++ b/hw/display/sm501_template.h