Re: [Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

2019-09-03 Thread Sukrit Bhatnagar
On Thu, 29 Aug 2019 at 18:23, Yuval Shaia wrote: > > On Wed, Aug 28, 2019 at 07:53:28PM +0530, Sukrit Bhatnagar wrote: > > vmstate_pvrdma describes the PCI and MSIX states as well as the dma > > address for dsr and the gid table of device. > > vmstate_pvrdma_gids descr

Re: [Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

2019-09-03 Thread Sukrit Bhatnagar
On Sun, 1 Sep 2019 at 01:15, Marcel Apfelbaum wrote: > > > > On 8/28/19 5:23 PM, Sukrit Bhatnagar wrote: > > vmstate_pvrdma describes the PCI and MSIX states as well as the dma > > address for dsr and the gid table of device. > > vmstate_pvrdma_gids descr

[Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

2019-08-28 Thread Sukrit Bhatnagar
() maps to dsr using the loaded dma address, registers each loaded gid into the backend device, and finally calls load_dsr() to perform other mappings and ring init operations. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c | 77

[Qemu-devel] [PATCH v1 0/2] Add live migration support in the PVRDMA device

2019-08-28 Thread Sukrit Bhatnagar
the RFC v3 series posted earlier: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg04752.html https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg04753.html https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg04754.html Sukrit Bhatnagar (2): hw/pvrdma: make DSR mapping

[Qemu-devel] [PATCH v1 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr()

2019-08-28 Thread Sukrit Bhatnagar
and when needed. This aids the case where load_dsr() is called having DSR mapping already done, but the rest of map and init operations are pending, and prevents an unmap of the DSR. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c |

[Qemu-devel] [RFC v3 0/2] Add live migration support in the PVRDMA device

2019-07-20 Thread Sukrit Bhatnagar
-devel/2019-07/msg01850.html Link(s) to v1: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04924.html https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04923.html Sukrit Bhatnagar (2): hw/pvrdma: make DSR mapping idempotent in load_dsr() hw/pvrdma: add live migration suppor

[Qemu-devel] [RFC v3 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr()

2019-07-20 Thread Sukrit Bhatnagar
and when needed. This aids the case where load_dsr() is called having DSR mapping already done, but the rest of map and init operations are pending, and prevents an unmap of the DSR. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c |

[Qemu-devel] [RFC v3 2/2] hw/pvrdma: add live migration support

2019-07-20 Thread Sukrit Bhatnagar
() maps to dsr using the loaded dma address, registers each loaded gid into the backend device, and finally calls load_dsr() to perform other mappings and ring init operations. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c | 77

Re: [Qemu-devel] [RFC v2 2/2] hw/pvrdma: add live migration support

2019-07-10 Thread Sukrit Bhatnagar
On Mon, 8 Jul 2019 at 10:43, Yuval Shaia wrote: > > On Sat, Jul 06, 2019 at 09:39:40AM +0530, Sukrit Bhatnagar wrote: > > Use VMStateDescription for migrating device state. Currently, > > What do you mean by 'Currently'? I meant that 'vmstate_pvrdma' will

[Qemu-devel] [RFC v2 1/2] hw/pvrdma: make DSR mapping idempotent in load_dsr()

2019-07-05 Thread Sukrit Bhatnagar
and when needed. This aids the case where load_dsr() is called having DSR mapping already done, but the rest of map and init operations are pending, and prevents an unmap of the DSR. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c |

[Qemu-devel] [RFC v2 2/2] hw/pvrdma: add live migration support

2019-07-05 Thread Sukrit Bhatnagar
l have dma map operations when the init functions are called. If this takes noticeable time, it might be better to have lazy load instead. Cc: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c | 87 +++ 1 file c

[Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device

2019-07-05 Thread Sukrit Bhatnagar
we can move further, and in doing so, we will need this. Sukrit Bhatnagar (2): hw/pvrdma: make DSR mapping idempotent in load_dsr() hw/pvrdma: add live migration support hw/rdma/vmw/pvrdma_main.c | 104 +++--- 1 file changed, 96 insertions(+), 8 deleti

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-05 Thread Sukrit Bhatnagar
CIE based differentiation > > since at 'realize' time is decided if the device is PCI or PCIe, > > then the above macro is enough. > > > > Use the opportunity to move to the standard VMSTATE_MSIX > > instead of the deprecated SaveVMHandlers. > > > &g

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-05 Thread Sukrit Bhatnagar
> then the above macro is enough. > > Use the opportunity to move to the standard VMSTATE_MSIX > instead of the deprecated SaveVMHandlers. > > Signed-off-by: Marcel Apfelbaum Tested-by: Sukrit Bhatnagar > --- > hw/net/vmxnet3.c | 52 ++

Re: [Qemu-devel] [RFC 1/1] hw/pvrdma: Add live migration support

2019-06-30 Thread Sukrit Bhatnagar
On Sun, 30 Jun 2019 at 13:43, Yuval Shaia wrote: > > On Sat, Jun 29, 2019 at 06:15:21PM +0530, Sukrit Bhatnagar wrote: > > On Fri, 28 Jun 2019 at 16:56, Dr. David Alan Gilbert > > wrote: > > > > > > * Yuval Shaia (yuval.sh...@oracle.com) wrote: > > &g

Re: [Qemu-devel] [RFC 1/1] hw/pvrdma: Add live migration support

2019-06-29 Thread Sukrit Bhatnagar
On Fri, 28 Jun 2019 at 16:56, Dr. David Alan Gilbert wrote: > > * Yuval Shaia (yuval.sh...@oracle.com) wrote: > > On Fri, Jun 21, 2019 at 08:15:41PM +0530, Sukrit Bhatnagar wrote: > > > Define and register SaveVMHandlers pvrdma_save and > > > pvrdma_load for savin

Re: [Qemu-devel] [GSoC] Help needed in implementing live migration

2019-06-26 Thread Sukrit Bhatnagar
On Tue, 25 Jun 2019 at 00:11, Dr. David Alan Gilbert wrote: > > * Sukrit Bhatnagar (skrtbht...@gmail.com) wrote: > > Hi David, > > > > I am Sukrit, GSoC participant working on PVRDMA live migration. > > We had a short chat about vmxnet3 migration about a week ago >

[Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

2019-06-21 Thread Sukrit Bhatnagar
of the guest device in the host. I am looking for a workaround, if that is possible at all. I started a thread few days ago for the same on libvirt-users: https://www.redhat.com/archives/libvirt-users/2019-June/msg00011.html Sukrit Bhatnagar (1): hw/pvrdma: Add live migration support

[Qemu-devel] [RFC 1/1] hw/pvrdma: Add live migration support

2019-06-21 Thread Sukrit Bhatnagar
: Marcel Apfelbaum Cc: Yuval Shaia Signed-off-by: Sukrit Bhatnagar --- hw/rdma/vmw/pvrdma_main.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index adcf79cd63..cd8573173c 100644 --- a/hw/rdma/vmw

Re: [Qemu-devel] [PATCH RESEND v2 2/2] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-10 Thread Sukrit Bhatnagar
On Wed, 10 Apr 2019 at 17:20, Roman Bolshakov wrote: > > On Sun, Apr 07, 2019 at 05:28:39PM +0530, Sukrit Bhatnagar wrote: > > Keep the calls made to synchronize cpu by all hypervisors in one place > > inside cpu_synchronize_* functions in include/sysemu/hw_accel.h > > &

Re: [Qemu-devel] [PATCH RESEND v2 0/2] Move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-07 Thread Sukrit Bhatnagar
Hi, Are the patches in good enough shape to be merged? Thanks, Sukrit

[Qemu-devel] [PATCH RESEND v2 0/2] Move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-07 Thread Sukrit Bhatnagar
/msg06902.html Sukrit Bhatnagar (2): hvf: declare hvf_handle_io if NEED_CPU_H is defined cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions cpus.c| 12 include/sysemu/hvf.h | 4 include/sysemu/hw_accel.h | 10 ++ 3 files

[Qemu-devel] [PATCH RESEND v2 1/2] hvf: declare hvf_handle_io if NEED_CPU_H is defined

2019-04-07 Thread Sukrit Bhatnagar
hvf_handle_io needs the poisoned type CPUArchState as its argument. Declaring it if NEED_CPU_H is defined enables include/sysemu/hvf.h to be included for common object compilation as well. Cc: Roman Bolshakov Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- include/sysemu/hvf.h | 4

[Qemu-devel] [PATCH RESEND v2 2/2] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-07 Thread Sukrit Bhatnagar
Keep the calls made to synchronize cpu by all hypervisors in one place inside cpu_synchronize_* functions in include/sysemu/hw_accel.h Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- cpus.c| 12 include/sysemu/hw_accel.h | 10

[Qemu-devel] [PATCH v2 0/2] Move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-03-27 Thread Sukrit Bhatnagar
/msg06902.html Sukrit Bhatnagar (2): hvf: declare hvf_handle_io if NEED_CPU_H is defined cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions cpus.c| 12 include/sysemu/hvf.h | 4 include/sysemu/hw_accel.h | 10 ++ 3 files

[Qemu-devel] [PATCH v2 2/2] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-03-27 Thread Sukrit Bhatnagar
Keep the calls made to synchronize cpu by all hypervisors in one place inside cpu_synchronize_* functions in include/sysemu/hw_accel.h Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- cpus.c| 12 include/sysemu/hw_accel.h | 10

[Qemu-devel] [PATCH v2 1/2] hvf: declare hvf_handle_io if NEED_CPU_H is defined

2019-03-27 Thread Sukrit Bhatnagar
hvf_handle_io needs the poisoned type CPUArchState as its argument. Declaring it if NEED_CPU_H is defined enables include/sysemu/hvf.h to be included for common object compilation as well. Cc: Roman Bolshakov Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- include/sysemu/hvf.h | 4

[Qemu-devel] [PATCH v1] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-03-25 Thread Sukrit Bhatnagar
Keep the calls made to synchronize cpu by all hypervisors in one place inside cpu_synchronize_* functions in include/sysemu/hw_accel.h Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- cpus.c| 12 include/sysemu/hw_accel.h | 9

[Qemu-devel] [PATCH v1 0/1] Convert qdev pointer properties to QOM links

2019-03-18 Thread Sukrit Bhatnagar
DEFINE_PROP_PTR and set using qdev_prop_set_ptr, are removed Sukrit Bhatnagar (1): etraxfs: convert dma_out and dma_in pointer properties from qdev to qom links hw/net/etraxfs_eth.c | 13 ++--- include/hw/cris/etraxfs.h | 4 ++-- 2 files changed, 12 insertions(+), 5 deletions

[Qemu-devel] [PATCH v1 1/1] etraxfs: convert dma_out and dma_in pointer properties from qdev to qom links

2019-03-18 Thread Sukrit Bhatnagar
The ETRAXFS Ethernet device needs pointers to the dma controllers to operate. According to qdev-properties.h, properties of pointer types should be avoided. A QOM link type property is a good substitution. Cc: Edgar E. Iglesias Signed-off-by: Sukrit Bhatnagar --- hw/net/etraxfs_eth.c