Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-20 Thread Steve Grubb
On Friday, April 15, 2016 12:46:46 PM Richard W.M. Jones wrote: > On Fri, Apr 15, 2016 at 06:41:34AM -0400, Cole Robinson wrote: > > Libvirt currently rejects using host /dev/urandom as an input source for a > > virtio-rng device. The only accepted sources are /dev/random and > > /dev/hwrng. This i

Re: [Qemu-devel] Fwd: qemu code review

2009-11-21 Thread Steve Grubb
On Thursday 19 November 2009 04:09:48 am Kevin Wolf wrote: > >> ... > >> In hw/e1000.c at line 89, vlan is declared to be 4 bytes. At line 382 is > >> an attempt to do a memmove over it with a size of 12. > > > > Obviously this was intentional. Would replacing > > memmove(tp->vlan, tp->data