Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

2024-11-13 Thread Shukla, Santosh
On 11/13/2024 11:41 PM, Paolo Bonzini wrote: > On 11/13/24 15:49, Phil Dennis-Jordan wrote: >> It appears that existing call sites for the kvm_enable_x2apic() >> function rely on the compiler eliding the calls during optimisation >> when building with KVM disabled, or on platforms other than Lin

Re: [PATCH] i386/kvm: Fix kvm_enable_x2apic link error in non-KVM builds

2024-11-13 Thread Shukla, Santosh
On 11/14/2024 12:09 AM, Paolo Bonzini wrote: > On Wed, Nov 13, 2024 at 7:25 PM Shukla, Santosh > wrote: >> Same proposed at >> https://lore.kernel.org/qemu-devel/cebca38a-5896-e2a5-8a68-5edad5dc9...@amd.com/ >> and I think Phil confirmed that it works. > > T

Re: [PULL 32/65] amd_iommu: Check APIC ID > 255 for XTSup

2024-11-10 Thread Shukla, Santosh
Hi Phil, On 11/10/2024 4:36 PM, Phil Dennis-Jordan wrote: > Hi, > > This commit seems to be causing link errors, likely on all platforms > where KVM is not available, but at minimum that's what I'm seeing when > trying to build the staging branch on macOS. > > ld: Undefined symbols: > _kvm_ena

Re: [PATCH v3 0/5] Interrupt Remap support for emulated amd viommu

2024-10-28 Thread Shukla, Santosh
Hi there, Ping? Appreciate any further review comment or series is OK to pull, Please let me know. Thank you! Santosh On 10/9/2024 11:35 AM, Shukla, Santosh wrote: > > Ping? > Gentle reminder. > > Thanks, > Santosh > > On 9/27/2024 10:59 PM, Santosh Shukla wrote:

Re: [PATCH v3 0/5] Interrupt Remap support for emulated amd viommu

2024-10-08 Thread Shukla, Santosh
Ping? Gentle reminder. Thanks, Santosh On 9/27/2024 10:59 PM, Santosh Shukla wrote: > Series adds following feature support for emulated amd vIOMMU > 1) Pass Through(PT) mode > 2) Interrupt Remapping(IR) mode > > 1) PT mode > Introducing the shared 'nodma' memory region that can be aliased > b

Re: [PATCH v2 2/5] amd_iommu: Add support for pass though mode

2024-09-27 Thread Shukla, Santosh
On 9/21/2024 1:56 AM, Alejandro Jimenez wrote: > Hi Santosh, > > On 9/16/24 10:31, Santosh Shukla wrote: >> From: Suravee Suthikulpanit >> >> Introduce 'nodma' shared memory region to support PT mode >> so that for each device, we only create an alias to shared memory >> region when DMA-remapp

Re: [PATCH v2 4/5] amd_iommu: Send notification when invaldate interrupt entry cache

2024-09-23 Thread Shukla, Santosh
On 9/21/2024 1:56 AM, Alejandro Jimenez wrote: > In subject: > s/invaldate/invalidate/ > > On 9/16/24 10:31, Santosh Shukla wrote: >> From: Suravee Suthikulpanit >> >> In order to support AMD IOMMU interrupt remapping emulation with PCI >> pass-through devices, QEMU needs to notify VFIO when g

Re: [PATCH v2 0/5] Interrupt Remap support for emulated amd viommu

2024-09-23 Thread Shukla, Santosh
Hi Alejandro, On 9/21/2024 2:09 AM, Alejandro Jimenez wrote: > Hi Santosh, > > > On 9/16/24 10:31, Santosh Shukla wrote: >> Series adds following feature support for emulated amd vIOMMU >> 1) Pass Through(PT) mode >> 2) Interrupt Remapping(IR) mode >> >> 1) PT mode >> Introducing the shared 'nod

Re: [PATCH v2 5/5] amd_iommu: Check APIC ID > 255 for XTSup

2024-09-23 Thread Shukla, Santosh
On 9/21/2024 1:56 AM, Alejandro Jimenez wrote: > > > On 9/16/24 10:31, Santosh Shukla wrote: >> From: Suravee Suthikulpanit >> >> The XTSup mode enables x2APIC support for AMD IOMMU, which is needed >> to support vcpu w/ APIC ID > 255. >> >> Signed-off-by: Suravee Suthikulpanit >> Signed-off

Re: [PATCH 0/5] Interrupt Remap support for emulated amd viommu

2024-09-11 Thread Shukla, Santosh
Hi Michael, On 9/11/2024 1:44 AM, Michael S. Tsirkin wrote: > On Wed, Sep 04, 2024 at 05:02:52AM -0500, Santosh Shukla wrote: >> Series adds following feature support for emulated amd vIOMMU >> 1) Pass Through(PT) mode >> 2) Interrupt Remapping(IR) mode >> >> 1) PT mode >> Introducing the shared '