Re: [RFC PATCH] Fix race in live migration failure path

2025-01-23 Thread Shivam Kumar
> On 23 Jan 2025, at 9:57 PM, Peter Xu wrote: > > !---| > CAUTION: External Email > > |---! > > On Thu, Jan 23, 2025 at 09:53:16AM +

Re: [RFC PATCH] Fix race in live migration failure path

2025-01-23 Thread Shivam Kumar
> On 22 Jan 2025, at 10:10 PM, Peter Xu wrote: > > !---| > CAUTION: External Email > > |---! > > Hi, Shivam, > > On Wed, Jan 22, 20

Re: [RFC PATCH] Fix race in live migration failure path

2025-01-22 Thread Shivam Kumar
On 13 Jan 2025, at 9:59 PM, Peter Xu wrote: !---| CAUTION: External Email |---! On Fri, Jan 10, 2025 at 10:09:38AM -0300, Fabiano Rosas wrote: Shivam Kumar writes

[RFC PATCH] Fix race in live migration failure path

2025-01-10 Thread Shivam Kumar
capabilities affecting old migration's cleanup. Hence, set the status to 'failing' when a migration failure happens and once the cleanup is complete, set the migration status to MIGRATION_STATUS_FAILED. Signed-off-by: Shivam Kumar --- migration/m

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

2024-10-09 Thread Shivam Kumar
11:20:03AM -0300, Fabiano Rosas wrote: Peter Xu writes: On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: If the client calls the QMP command to reset the migration capabilities after the migration status is set to failed or cancelled Is cancelled ok? Asked because I think migrate_fd_c

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

2024-10-08 Thread Shivam Kumar
On 7 Oct 2024, at 9:56 PM, Peter Xu wrote: !---| CAUTION: External Email |---! On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: If the client calls

[PATCH] Use multifd state to determine if multifd cleanup is needed

2024-10-07 Thread Shivam Kumar
QEMU crashing due to the following assertion failure: yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)` failed Check multifd state to determine whether multifd was used or not for the migration rather than checking the state of multifd migration capability. Signed-off-by:

Re: [PATCH v3 03/20] multifd: Zero pages transmission

2024-01-14 Thread Shivam Kumar
> On 04-Jan-2024, at 6:14 AM, Hao Xiang wrote: > > From: Juan Quintela > > This implements the zero page dection and handling. > > Signed-off-by: Juan Quintela > --- > migration/multifd.c | 41 +++-- > migration/multifd.h | 5 + > 2 files changed, 44

Re: [PATCH v3 13/20] migration/multifd: Prepare to introduce DSA acceleration on the multifd path.

2024-01-14 Thread Shivam Kumar
> On 04-Jan-2024, at 6:14 AM, Hao Xiang wrote: > > 1. Refactor multifd_send_thread function. > 2. Implement buffer_is_zero_use_cpu to handle CPU based zero page > checking. > 3. Introduce the batch task structure in MultiFDSendParams. > > Signed-off-by: Hao Xiang > --- > include/qemu/dsa.h |

Re: [PATCH v3 01/20] multifd: Add capability to enable/disable zero_page

2024-01-14 Thread Shivam Kumar
> On 04-Jan-2024, at 6:14 AM, Hao Xiang wrote: > > From: Juan Quintela > > We have to enable it by default until we introduce the new code. > > Signed-off-by: Juan Quintela > --- > migration/options.c | 15 +++ > migration/options.h | 1 + > qapi/migration.json | 8 +++- > 3

Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2023-02-13 Thread Shivam Kumar
On 22/11/22 9:30 am, Shivam Kumar wrote: On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote: Hi, On 20/11/22 23:54, Shivam Kumar wrote: + +void dirty_quota_migration_start(void) +{ +    if (!kvm_state->dirty_quota_supported) { You are accessing an accelerator-specific variable in

Re: [RFC PATCH 0/1] QEMU: Dirty quota-based throttling of vcpus

2022-12-18 Thread Shivam Kumar
On 06/12/22 10:59 pm, Hyman Huang wrote: 在 2022/12/7 0:00, Peter Xu 写道: Hi, Shivam, On Tue, Dec 06, 2022 at 11:18:52AM +0530, Shivam Kumar wrote: [...] Note -- -- We understand that there is a good scope of improvement in the current implementation. Here is a list of

Re: [RFC PATCH 0/1] QEMU: Dirty quota-based throttling of vcpus

2022-12-05 Thread Shivam Kumar
On 21/11/22 4:24 am, Shivam Kumar wrote: This patchset is the QEMU-side implementation of a (new) dirty "quota" based throttling algorithm that selectively throttles vCPUs based on their individual contribution to overall memory dirtying and also dynamically adapts the throttle ba

Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2022-11-22 Thread Shivam Kumar
On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote: Hi, On 20/11/22 23:54, Shivam Kumar wrote: + +void dirty_quota_migration_start(void) +{ +    if (!kvm_state->dirty_quota_supported) { You are accessing an accelerator-specific variable in an accelerator-agnostic file, this doesn'

[RFC PATCH 0/1] QEMU: Dirty quota-based throttling of vcpus

2022-11-20 Thread Shivam Kumar
back to current auto-converge based throttling in cases where dirty quota throttling can overthrottle. Please stay tuned for the next patchset. Shivam Kumar (1): Dirty quota-based throttling of vcpus accel/kvm/kvm-all.c | 91 +++ include/exec/memory.h

[RFC PATCH 1/1] Dirty quota-based throttling of vcpus

2022-11-20 Thread Shivam Kumar
limit. Suggested-by: Shaju Abraham Suggested-by: Manish Mishra Co-developed-by: Anurag Madnawat Signed-off-by: Anurag Madnawat Signed-off-by: Shivam Kumar --- accel/kvm/kvm-all.c | 91 +++ include/exec/memory.h | 3 ++ include/hw/core/cpu.h | 5