Re: [PATCH 04/15] arc: TCG and decoder glue code and helpers

2021-01-15 Thread Shahab Vahedi
Hi Richard, On 12/1/20 10:35 PM, Richard Henderson wrote: > On 11/11/20 10:17 AM, cupertinomira...@gmail.com wrote: >> From: Cupertino Miranda >> +void helper_enter(CPUARCState *env, uint32_t u6) >> +{ >> +/* nothing to do? then bye-bye! */ >> +if (!u6) { >> +return; >> +} >>

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-05-04 Thread Shahab Vahedi
Thank YOU for all the supports along the way :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825359 Title: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH Status in QEMU: Fix Commi

Re: [Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type

2019-04-21 Thread Shahab Vahedi
Hi Peter, On Sat, Apr 20, 2019 at 07:57:31PM +0100, Peter Maydell wrote: > On Fri, 19 Apr 2019 at 12:46, Shahab Vahedi wrote: > > > > This change adapts io_readx() to its input access_type. Currently > > io_readx() treats any memory access as a read, although it has

[Qemu-devel] [PATCH v3] cputlb: Fix io_readx() to respect the access_type

2019-04-20 Thread Shahab Vahedi
the tlb_addr Buglink: https://bugs.launchpad.net/qemu/+bug/1825359 Signed-off-by: Shahab Vahedi --- Changelog: v3 - Only handle read/fetch. There must be no write access. v2 - Extra space before closing parenthesis is removed v1 - Initial submit accel/tcg/cputlb.c | 8 ++-- 1 fi

[Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type

2019-04-19 Thread Shahab Vahedi
the tlb_addr Buglink: https://bugs.launchpad.net/qemu/+bug/1825359 Signed-off-by: Shahab Vahedi --- Changelog: - Extra space before closing parenthesis is removed accel/tcg/cputlb.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/c

[Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type

2019-04-19 Thread Shahab Vahedi
the tlb_addr Buglink: https://bugs.launchpad.net/qemu/+bug/1825359 Signed-off-by: Shahab Vahedi --- accel/tcg/cputlb.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 88cc8389e9..0daac0e806 100644 --- a/accel/tcg/cputlb.c ++

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
This patch has fixed for me both issues. Although I am not very proud of the changes in the second hunk. Please let me know if there is a better way. ** Patch added: "respect address type for tlb_fill() and while using the address from "tlb_entry"" https://bugs.launchpad.net/qemu/+bug/182535

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
** Patch removed: "bug1825359_io_readx.patch" https://bugs.launchpad.net/qemu/+bug/1825359/+attachment/5256724/+files/bug1825359_io_readx.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/182535

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
READ_ACCESS_TYPE MMU_INST_FETCH #define ADDR_READ addr_code #else #define READ_ACCESS_TYPE MMU_DATA_LOAD #define ADDR_READ addr_read #endif ... WORD_TYPE helper_le_ld_name(...) { ... target_ulong tlb_addr = entry->ADDR_READ; ... } ** Changed in: qemu Assignee: (unassigned) =&g

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
I have to say, after applying this patch, my test still fails while fetching the instructions from this _small_ region. Although there is no MMU_DATA_LOAD anymore, a few iterations later (while guest code has just jumped to the beginning of the executable region), QEmu segfaults (call stack is atta

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
call stack for SEGFAULT that happens during the execution of small region. This will go away IF THE ENTRY ADDED TO TLB FOR THIS REGION IS OF SIZE TARGET_PAGE_SIZE. However, that would not be correct behavior. ** Attachment added: "segfault_bt.txt" https://bugs.launchpad.net/qemu/+bug/1825359/+

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
Should I make a patch then? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825359 Title: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH Status in QEMU: Confirmed Bug description:

[Qemu-devel] [Bug 1825359] Re: cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
** Patch added: "bug1825359_io_readx.patch" https://bugs.launchpad.net/qemu/+bug/1825359/+attachment/5256724/+files/bug1825359_io_readx.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825359

[Qemu-devel] [Bug 1825359] [NEW] cpu_ld*_code() triggers MMU_DATA_LOAD i.s.o. MMU_INST_FETCH

2019-04-18 Thread Shahab Vahedi
Public bug reported: commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5 Merge: c876180938 328eb60dc1 Author: Peter Maydell ; masked for anti-spamming purposes Date: Mon Mar 11 18:26:37 2019 + https://github.com/qemu/qemu/commit/377b155bde451d5ac545fbdcdfbf6ca17a4228f5 --

[Qemu-devel] [Bug 1813010] Re: Parallel builds fail (make -j >=2) when using --extra-cflags "--save-temps"

2019-01-23 Thread Shahab Vahedi
it seems like that "-save-temps" in "cflags" is the culprit. I removed it and it was possible to build with 8 instances: # removed "-save-temps" from the "cflags" > ./qemu/configure --target-list=riscv64-softmmu --enable-debug > --extra-cflags='-O0 -g3' --prefix=/install/riscv-qemu # build witho

[Qemu-devel] [Bug 1813010] Re: Parallel builds fail (make -j >=2) when using --extra-cflags "--save-temps"

2019-01-23 Thread Shahab Vahedi
putting the temporary files in object dir works as well: -save-temps=obj # "-save-temps=obj" from the "cflags" > ./qemu/configure --target-list=riscv64-softmmu --enable-debug > --extra-cflags='-O0 -g3 -save-temps=obj' --prefix=/install/riscv-qemu # build again without any problem > make -j 8 --

[Qemu-devel] [Bug 1813010] [NEW] Parallel builds fail (make -j >=2)

2019-01-23 Thread Shahab Vahedi
Public bug reported: specs: QEMU commit: 9f33051abce238ab43a23125e237aac8b0931b88 # of Cores: 8 Host kernel: Linux 4.19.16-1-lts Host type: x86_64 GNU/Linux Host distro: Archlinux Guest: we never get that far steps: # fresh copy of the latest commit > git clone https://git.qemu.org/git/qemu.git