[Qemu-devel] [PATCHv1] slirp: Use strcasecmp() to check tftp mode, tsize

2011-01-12 Thread Sergei Gavrikov
From: Sergei Gavrikov According to RFC 1350 (TFTP Revision 2) the mode field can contain any combination of upper and lower case; also RFC 2349 propagates that the transfer size option ("tsize") is case in-sensitive too. Current implementation of embedded TFTP server missed that what

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: > On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov > wrote: > > It was good to know. If you mean the below I "merge" that in one. Thank > > you for review. > > > > Sergei > > > > Signed-of

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: > On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov > wrote: > > diff --git a/slirp/tftp.c b/slirp/tftp.c > > index 55e4692..a455ad1 100644 > > --- a/slirp/tftp.c > > +++ b/slirp/tftp.c > > @@ -311,7 +311,7 @@ stat

[Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-11 Thread Sergei Gavrikov
On Mon, 10 Jan 2011, Sergei Gavrikov wrote: > According to RFC 1350 http://www.ietf.org/rfc/rfc1350.txt [Page 5]: > > The mode field contains the string "netascii", "octet", or "mail" > (or any combination of upper and lower case

[Qemu-devel] [PATCH] slirp/tftp.c: fix mode field

2011-01-10 Thread Sergei Gavrikov
ECMP(3), a patch is provided. Thanks, Sergei Signed-off-by: Sergei Gavrikov --- slirp/tftp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/slirp/tftp.c b/slirp/tftp.c index 55e4692..6ad1da0 100644 --- a/slirp/tftp.c +++ b/slirp/tftp.c @@ -311,7 +311,7 @@ static void