the check of top PMP is redundant and will not influence the return
value, so consider remove it
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1733
Reviewed-by: Weiwei Li
Reviewed-by: Alistair Francis
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 5 -
1 file changed, 5
change the initial values of sa_in and ea_in to false
* change the condition expression when address area fully in range
Ruibo Lu (2):
target/riscv: Remove redundant check in pmp_is_locked
target/riscv: Optimize ambiguous local variable in pmp_hart_has_privs
target/riscv/pmp.c | 27 ++
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index 1a9279ba88..ea3d29217a 100644
--- a/target/riscv/pmp.c
+++ b/target/riscv/pmp.c
-Daudé
Reviewed-by: Weiwei Li
Reviewed-by: Alistair Francis
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index 1a9279ba88..ea3d29217a 100644
--- a/target/riscv
the check of top PMP is redundant and will not influence the return
value, so consider remove it
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1733
Reviewed-by: Weiwei Li
Reviewed-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Ruibo Lu
---
target/riscv
the check of top PMP is redundant and will not influence the return
value, so consider remove it
Reviewed-by: Weiwei Li
Reviewed-by: Alistair Francis
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
These two values represents whether start/end address is in pmp_range.
However, the type and name of them is ambiguous. This commit change the
name and type of them to improve code readability and accuracy.
Reviewed-by: Weiwei Li
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Ruibo Lu
These two values represents whether start/end address is in pmp_range.
However, the type and name of them is ambiguous. This commit change the
name and type of them to improve code readability and accuracy.
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 20 ++--
1 file changed
Based-on: 4329d049d5b8d4af71c6b399d64a6d1b98856318
Ruibo Lu (2):
target/riscv: Remove redundant check in pmp_is_locked
target/riscv: Optimize ambiguous local variable in pmp_hart_has_privs
target/riscv/pmp.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions
the check of top PMP is redundant and will not influence the return
value, so consider remove it
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index 9d8db493e6..1a9279ba88 100644
--- a/target/riscv
These two values represents whether start/end address is in pmp_range.
However, the type and name of them is ambiguous. This commit change the
name and type of them to improve code readability and accuracy.
Signed-off-by: Ruibo Lu
---
target/riscv/pmp.c | 20 ++--
1 file changed
11 matches
Mail list logo