Re: [PATCH v2 1/2] qapi/migration.json: add reason to MIGRATION event

2024-02-21 Thread Roman Khapov
version of the series. On 2/19/24 11:35, Markus Armbruster wrote: Roman Khapov writes: To be clear: you meant that the description of the event must be extended, similar to its description on the commit message? Or you don't see its proper usage at all? The commit message doesn't real

Re: [PATCH v2 1/2] qapi/migration.json: add reason to MIGRATION event

2024-02-21 Thread Roman Khapov
sounds reasonable, thanks! But I'm not sure if I got the idea of changing migrate_set_error correctly, can you explain in more details, please? On 2/20/24 10:39, Peter Xu wrote: On Thu, Feb 15, 2024 at 05:27:58PM +0500, Roman Khapov wrote: migrate_set_state(&m

Re: [PATCH v2 1/2] qapi/migration.json: add reason to MIGRATION event

2024-02-18 Thread Roman Khapov
next version of the patch soon. On 2/16/24 11:17, Markus Armbruster wrote: Roman Khapov writes: This commit adds the optional field reason for the events, which contains the string, describing reason of status changing. For example: reason of migration fail. Function migrate_set_state now ac

[PATCH v2 2/2] migration: add error reason for failed MIGRATION events

2024-02-15 Thread Roman Khapov
This patch adds error description as reason for event MIGRATION in every place that generates MIGRATION_STATE_FAILED Signed-off-by: Roman Khapov --- migration/migration.c | 62 ++- migration/multifd.c | 8 +++--- migration/savevm.c| 12 - 3

[PATCH v2 1/2] qapi/migration.json: add reason to MIGRATION event

2024-02-15 Thread Roman Khapov
argument. Also migrate_set_state_err_reason was added to form reason from Error* Signed-off-by: Roman Khapov --- migration/colo.c | 6 +-- migration/migration.c | 86 ++- migration/migration.h | 5 ++- migration/multifd.c | 6 +-- migration/savevm.c

[PATCH v2 0/2] Field 'reason' for MIGRATION event

2024-02-15 Thread Roman Khapov
uot;qmp_capabilities"} {"return": {}} {"event": "MIGRATION", "data": {"status": "setup"}} {"event": "MIGRATION", "data": {"status": "failed", "reason": "Failed to connect to &

[PATCH 2/2] migration: add error reason for failed MIGRATION events

2024-02-15 Thread Roman Khapov
This patch adds error description as reason for event MIGRATION in every place that generates MIGRATION_STATE_FAILED Signed-off-by: Roman Khapov --- migration/migration.c | 62 ++- migration/multifd.c | 8 +++--- migration/savevm.c| 12 - 3

[PATCH] migration: add error reason for failed MIGRATION events

2024-02-15 Thread Roman Khapov
This patch adds error description as reason for event MIGRATION in every place that generates MIGRATION_STATE_FAILED Signed-off-by: Roman Khapov --- migration/migration.c | 62 ++- migration/multifd.c | 8 +++--- migration/savevm.c| 12 - 3

[PATCH 0/2] Add field reason to event MIGRATION

2024-02-15 Thread Roman Khapov
"setup"}} {"event": "MIGRATION", "data": {"status": "failed", "reason": "Failed to connect to '/tmp/sock.sock': No such file or directory"}} Roman Khapov (2): qapi/migration.json: add reason to MIGRATION event

[PATCH 1/2] qapi/migration.json: add reason to MIGRATION event

2024-02-15 Thread Roman Khapov
argument. Also migrate_set_state_err_reason was added to form reason from Error* Signed-off-by: Roman Khapov --- migration/colo.c | 6 +-- migration/migration.c | 86 ++- migration/migration.h | 5 ++- migration/multifd.c | 6 +-- migration/savevm.c