Re: [Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-30 Thread Reza Jelveh
On Mon, Mar 30, 2015 at 2:36 PM, Igor Mammedov wrote: > you are extending structure beyond of what specified by ACPI 1.0b spec, > that might break guests. > We probably can't change revision since Windows ACPI implementation > is mostly 1.0b based so we are stuck with it. > Patch needs to be test

[Qemu-devel] [RFC PATCH v2] acpi: add reset register to fadt

2015-03-30 Thread Reza Jelveh
Some operating systems such as FreeBSD and Mac OSX need the reset_register section of the FADT filled to know which port to write to for a system reset. Signed-off-by: Reza Jelveh --- hw/i386/acpi-build.c | 9 + hw/i386/acpi-defs.h | 2 ++ 2 files changed, 11 insertions(+) diff --git

[Qemu-devel] [RFC] acpi: add reset register to fadt

2015-03-28 Thread Reza Jelveh
Some operating systems such as FreeBSD and Mac OSX need the reset_register section of the FADT filled to know which port to write to for a system reset. What is the right way to set the reset_val and the reset addr in this case? --- hw/i386/acpi-build.c | 5 + hw/i386/acpi-defs.h | 2 ++ 2 f

Re: [Qemu-devel] [edk2] license for binary drivers

2014-08-06 Thread Reza Jelveh
On 06/08/14 14:51, Andrew Fish wrote: > How you write a GPL licensed FAT driver seems like a legal quagmire. Probably > something better discussed with a lawyer. From the outside looking in it > seems like the IP rights are enforced by charging licensing fees to devices > that support FAT. So f

[Qemu-devel] [PATCH_v2] ahci.c: mask unused flags when reading size PRDT DBC

2014-07-01 Thread reza . jelveh
From: Reza Jelveh The data byte count(DBC) read from the description information is defined for bits 21:00. Bits 30:22 are reserved and bit 31 is the Interrupt on Completion (I) flag. Completion interrupts are triggered after every transaction instead of on I-flag in QEMU. tbl_entry_size is a

[Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-29 Thread reza . jelveh
This requires a custom ovmf image with sata controller for testing [0] [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2

[Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-29 Thread reza . jelveh
From: Reza Jelveh The data byte count(DBC) read from the description information is defined for 21:00. 30:22 are reserved and 31 is the Interrupt on Completion (I) flag. Interrupt is not implemented in QEMU. tbl_entry_size is a signed integer and improperly reading the DBC leads to a negative

Re: [Qemu-devel] [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to read the correct size for the PRDT

2014-06-27 Thread Reza Jelveh
't see it when I posted the 2nd version of the patch. New version is attached. >From fd18e0a7f287cbe176dbb98a530dd54ea3cc27c7 Mon Sep 17 00:00:00 2001 From: Reza Jelveh Date: Fri, 27 Jun 2014 01:13:19 +0200 Subject: [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to

[Qemu-devel] [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to read the correct size for the PRDT

2014-06-26 Thread Reza Jelveh
Signed-off-by: Reza Jelveh --- hw/ide/ahci.c | 11 --- hw/ide/ahci.h | 2 ++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 9bae22e..ee3613f 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -639,6 +639,11 @@ static void