On 7/1/22 11:41, Hanna Reitz wrote:
On 13.04.22 14:26, Raphael Pour wrote:
>> }
- return ret;
+ /*
+ * Remove all keys from the generic layer which
+ * can't be converted by rbd
+ * >
Does any other driver do this? Shouldn’t we leave them there so tha
Hello everyone,
what do you think? Please tell me if something needs to be clarified or
improved.
Raphael
PS: Hopefully this second reply attempt isn't messed up (first:
https://lists.nongnu.org/archive/html/qemu-block/2022-06/msg00344.html)
On 4/13/22 14:26, Raphael Pour wrote:
Hello everyone,
what do you think? Tell me if something needs to be clarified or improved.
Raphael
OpenPGP_0xCDB1EBB785C5EB7E.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
.
Signed-off-by: Raphael Pour
---
block/rbd.c | 206 ++--
1 file changed, 201 insertions(+), 5 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 6caf35cbba..e7b45d1c50 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1029,19 +1029,213 @@ out
Public bug reported:
Qemu crashes on qmp/hmp command if client closes connection before
reading the whole response from the socket.
Reproducer:
1. Start arbitrary vm via qemu
2. Send e.g. hmp command 'info mem'
3. Abort before whole response came back
Stack Trace:
Stack trace of thread 6493:
nt and life would still be
>> fine. Or if you want a one-line comment, I might suggest:
>>
>> /* Remember parent's stderr if we will restoring it. */
>
> It helps if I don't hit 'send' too early.
>
> /* Remember parent's stderr if we will be
[...] introduced with e6df58a5, stderr won't get closed if the fork
option is __not__ set.
On 5/14/20 8:31 AM, Raphael Pour wrote:
> introduced with e6df58a5, stderr won't get closed if the fork option is
> set.
--
Hetzner Online GmbH
Am Datacenter-Park 1
08223 Falkenstein/Vo
Close inherited stderr of the parent if fork_process is false.
Otherwise no one will close it. (introduced by e6df58a5)
---
qemu-nbd.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 4aa005004e..a324d21c5e 100644
--- a/qemu-nbd.c
+++ b/qemu-
on is not set.
Raphael Pour (1):
qemu-nbd: Close inherited stderr
qemu-nbd.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
2.25.4
On 5/13/20 3:02 PM, Eric Blake wrote:
> Yes, now that we know about it, the bug will be fixed in 5.1; we can
> also cc: qemu-stable to get it backported to the next 5.0.x release
> (downstream developers are also more likely to backport it to their
> ports as well if it lands on qemu-stable). Wo
On 5/12/20 3:57 PM, Eric Blake wrote:
> Wouldn't it just be simpler to not dup in the first place?
>
> diff --git i/qemu-nbd.c w/qemu-nbd.c
> index 4aa005004ebd..6ba2544feb3a 100644
> --- i/qemu-nbd.c
> +++ w/qemu-nbd.c
> @@ -916,7 +916,9 @@ int main(int argc, char **argv)
> } else if (pi
Hello,
after e6df58a5, the inherited stderr 'old_stderr' won't get closed
anymore if 'fork_process' is false. This causes other processes relying
on EOF to infinitely block or crash.
From 47ab9b517038d13117876a8bb3ef45c53d7f2f9e Mon Sep 17 00:00:00 2001
From: "Ra
12 matches
Mail list logo
