Re: [Qemu-devel] [PATCH v3] i386: Add new Hygon 'Dhyana' CPU model

2019-04-17 Thread Pu Wen
On 2019/4/17 2:03, Eduardo Habkost wrote: On Tue, Apr 16, 2019 at 08:06:13PM +0800, Pu Wen wrote: Add a new base CPU model called 'Dhyana' to model processors from Hygon Dhyana(family 18h), which derived from AMD EPYC(family 17h). The following features bits have been removed comp

Re: [Qemu-devel] [PATCH v3] i386: Add new Hygon 'Dhyana' CPU model

2019-04-17 Thread Pu Wen
On 2019/4/16 22:17, Pavel Hrdina wrote: On Tue, Apr 16, 2019 at 08:06:13PM +0800, Pu Wen wrote: Add a new base CPU model called 'Dhyana' to model processors from Hygon Dhyana(family 18h), which derived from AMD EPYC(family 17h). The following features bits have been removed compare t

[Qemu-devel] [PATCH v3] i386: Add new Hygon 'Dhyana' CPU model

2019-04-16 Thread Pu Wen
upstream[1]. So add Hygon Dhyana support to Qemu is necessary to create Hygon's own CPU model. Reference: [1] https://git.kernel.org/tip/fec98069fb72fb656304a3e52265e0c2fc9adf87 Signed-off-by: Pu Wen --- v2->v3: - Remove the Dhyana machine types in the back-compat property tables

Re: [Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model

2019-04-16 Thread Pu Wen
On 2019/4/16 16:19, Daniel P. Berrangé wrote: On Tue, Apr 16, 2019 at 02:56:12PM +0800, Pu Wen wrote: On 2019/4/15 17:25, Daniel P. Berrangé wrote: On Sat, Apr 13, 2019 at 10:54:40AM +0800, Pu Wen wrote: @@ -152,6 +154,7 @@ GlobalProperty pc_compat_2_12[] = { { TYPE_X86_CPU, "to

Re: [Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model

2019-04-16 Thread Pu Wen
On 2019/4/16 4:40, Eduardo Habkost wrote: On Sat, Apr 13, 2019 at 10:54:40AM +0800, Pu Wen wrote: Add a new base CPU model called 'Dhyana' to model processors from Hygon Dhyana(family 18h), which derived from AMD EPYC(family 17h). The following features bits have been removed comp

Re: [Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model

2019-04-15 Thread Pu Wen
On 2019/4/15 17:25, Daniel P. Berrangé wrote: On Sat, Apr 13, 2019 at 10:54:40AM +0800, Pu Wen wrote: ... diff --git a/hw/i386/pc.c b/hw/i386/pc.c index f2c15bf..551bec9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -128,6 +128,8 @@ GlobalProperty pc_compat_3_1[] = { { "

[Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model

2019-04-12 Thread Pu Wen
upstream[1]. So add Hygon Dhyana support to Qemu is necessary to create Hygon's own CPU model. Reference: [1] https://git.kernel.org/tip/fec98069fb72fb656304a3e52265e0c2fc9adf87 Signed-off-by: Pu Wen --- v1->v2: - Remove CPU model 'Dhyana' and rename the CPU model 'Dhy

Re: [Qemu-devel] [PATCH RFC] i386: Add new Hygon 'Dhyana' and 'Dhyana-IBPB' CPU models

2019-04-12 Thread Pu Wen
amily 17h). 'Dhyana-IBPB' is a copy of the 'Dhyana' CPU model with >>> just CPUID_8000_0008_EBX_IBPB added. >> >> Do we really need to support both CPU variants ? > > Also, I think the compatibility properties are not needed for Dhyana chips. Will only keep one CPU model with IBPB feature by using the name 'Dhyana'. Thx. -- Regards, Pu Wen

Re: [Qemu-devel] [PATCH RFC] i386: Add new Hygon 'Dhyana' and 'Dhyana-IBPB' CPU models

2019-04-12 Thread Pu Wen
On 2019/4/12 21:25, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 08:37:49PM +0800, Pu Wen wrote: Add two new base CPU models called 'Dhyana' and 'Dhyana-IBPB' to model processors from Hygon Dhyana (family 18h), which derived from AMD EPYC (family 17h). 'Dhya

[Qemu-devel] [PATCH RFC] i386: Add new Hygon 'Dhyana' and 'Dhyana-IBPB' CPU models

2019-04-12 Thread Pu Wen
72fb656304a3e52265e0c2fc9adf87 Signed-off-by: Pu Wen --- hw/i386/pc.c | 6 target/i386/cpu.c | 98 +++ target/i386/cpu.h | 2 ++ 3 files changed, 106 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index f2c15bf..7e59f50