Re: [Qemu-devel] [PATCH] vnc: track LED state separately

2017-01-09 Thread Pierre Ossman
On 04/01/17 09:57, Gerd Hoffmann wrote: /me wonders how you've tested the patch ... That would be not at all. Or rather, just a compile. :) Tried, but checkpatch found some more issues: Fixed. New patch incoming. Regards -- Pierre Ossman Software Development Cend

[Qemu-devel] [PATCH] vnc: track LED state separately

2017-01-09 Thread Pierre Ossman
Piggy-backing on the modifier state array made it difficult to send out updates at the proper times. Signed-off-by: Pierre Ossman --- ui/vnc.c | 59 --- ui/vnc.h | 3 ++- 2 files changed, 18 insertions(+), 44 deletions(-) diff --git a/ui

Re: [Qemu-devel] [PATCH] vnc: track LED state separately

2016-12-16 Thread Pierre Ossman
t be (ledstate == vd->ledstate)? Right, sorry. Brain fart. :) Can you fix that up before commit or do you want a new patch? Regards -- Pierre Ossman Software Development Cendio AB https://cendio.com Teknikringen 8 https://twitter.com/ThinLinc 583 30 Linköping

[Qemu-devel] [PATCH] vnc: track LED state separately

2016-12-15 Thread Pierre Ossman
available directly when a client connects. Signed-off-by: Pierre Ossman --- ui/vnc.c | 56 +--- ui/vnc.h | 3 ++- 2 files changed, 15 insertions(+), 44 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 2c28a59..c449a7d 100644 --- a/ui/vnc.c

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-13 Thread Pierre Ossman
On 13/12/16 14:15, Daniel P. Berrange wrote: gtk-vnc implements the LED state extension. For testing, I've now pushed my work to get TigerVNC to support this: https://github.com/CendioOssman/tigervnc/tree/ledstate It's implemented for the client and Xvnc. Regards -- Pie

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-13 Thread Pierre Ossman
like this bug. It does respect the virtual keys sent, just that it doesn't inform the client properly. So my patch should help. Regards -- Pierre Ossman Software Development Cendio AB http://cendio.com Teknikringen 8 http://twitter.com/ThinLinc 583 30 Linköp

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-13 Thread Pierre Ossman
that implements this extension yet? I couldn't find anything. Regards -- Pierre Ossman Software Development Cendio AB http://cendio.com Teknikringen 8 http://twitter.com/ThinLinc 583 30 Linköpinghttp://facebook.com/ThinLinc Phone: +46-13-214600

Re: [Qemu-devel] VNC LED state buggy, interop issue

2016-12-12 Thread Pierre Ossman
On 10/12/16 16:30, Pierre Ossman wrote: There are two ways to fix this: a) Send an update to the client when the assumption doesn't hold. This will most likely be difficult in your case since there is no definite point where you can assume a LED change event should have occurred. b) R

[Qemu-devel] VNC LED state buggy, interop issue

2016-12-10 Thread Pierre Ossman
h older versions of QEMU. Regards -- Pierre Ossman Software Development Cendio AB http://cendio.com Teknikringen 8 http://twitter.com/ThinLinc 583 30 Linköpinghttp://facebook.com/ThinLinc Phone: +46-13-214600http://plus.google.com/+CendioThinLinc A:

[Qemu-devel] VNC LED state buggy, interop issue

2016-12-10 Thread Pierre Ossman
h older versions of QEMU. Regards -- Pierre Ossman Software Development Cendio AB http://cendio.com Teknikringen 8 http://twitter.com/ThinLinc 583 30 Linköpinghttp://facebook.com/ThinLinc Phone: +46-13-214600http://plus.google.com/+CendioThinLinc A: