On Tue, Jul 30, 2013 at 5:52 AM, Luiz Capitulino wrote:
>
> This doesn't apply anymore, can you rebase and resend?
>
Sure.
> By grepping around I can see that there are several instances of
> this bug in other commands. I'm surprised we never got a single
> bug report about this... Would you min
The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)
Signed-off-by: Pawit Pornkitprasan
---
migration.c |4 ++--
1 files changed, 2 insertions(+), 2 d
On Fri, Jul 19, 2013 at 7:57 PM, Eric Blake wrote:
>
> However, wouldn't it be nice if we improved the qapi generator to
> guarantee a sane default value for optional parameters, even when
> has_value is false?
>
I'm not a qemu expert or anything, but wouldn't that destroy the point
of has_value
The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)
Signed-off-by: Pawit Pornkitprasan
---
migration.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
The "completed" stage sets total_time but not has_total_time and
thus it is not sent via QMP reply (but sent via HMP nevertheless)
Signed-off-by: Pawit Pornkitprasan
---
migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration.c b/migration.c
index 9f5a423..4c16f2e 10
