Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Paolo Abeni
On 5/23/25 1:35 PM, Akihiko Odaki wrote: > On 2025/05/23 19:40, Paolo Abeni wrote: >> On 5/23/25 10:16 AM, Akihiko Odaki wrote: >>> On 2025/05/21 20:34, Paolo Abeni wrote: >>>> @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet >&g

Re: [PATCH RFC 00/16] virtio: introduce support for GSO over UDP tunnel

2025-05-23 Thread Paolo Abeni
On 5/23/25 9:19 AM, Akihiko Odaki wrote: > On 2025/05/21 20:33, Paolo Abeni wrote: >> Some virtualized deployments use UDP tunnel pervasively and are impacted >> negatively by the lack of GSO support for such kind of traffic in the >> virtual NIC driver. >> >> The

Re: [PATCH RFC 12/16] virtio-net: implement extended features support.

2025-05-23 Thread Paolo Abeni
On 5/23/25 10:09 AM, Akihiko Odaki wrote: > On 2025/05/21 20:34, Paolo Abeni wrote: >> Use the extended types and helpers to manipulate the virtio_net >> features. >> >> Note that offloads are still 64bits wide, as per specification, >> and extended offloa

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Paolo Abeni
On 5/23/25 12:54 PM, Akihiko Odaki wrote: > On 2025/05/23 19:40, Paolo Abeni wrote: >> On 5/23/25 10:16 AM, Akihiko Odaki wrote: >>> On 2025/05/21 20:34, Paolo Abeni wrote: >>>> @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet >&g

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Paolo Abeni
On 5/23/25 10:16 AM, Akihiko Odaki wrote: > On 2025/05/21 20:34, Paolo Abeni wrote: >> @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet >> *n) >> .ufo = !!(n->curr_guest_offloads & (1ULL << >> VIRTIO_NET

Re: [PATCH RFC 13/16] net: implement tunnel probing

2025-05-23 Thread Paolo Abeni
On 5/23/25 9:39 AM, Akihiko Odaki wrote: >> diff --git a/net/tap-linux.c b/net/tap-linux.c >> index 22ec2f45d2..2df601551e 100644 >> --- a/net/tap-linux.c >> +++ b/net/tap-linux.c >> @@ -37,6 +37,14 @@ >> >> #define PATH_NET_TUN "/dev/net/tun" >> >> +#ifndef TUN_F_UDP_TUNNEL_GSO >> +#define

Re: [PATCH RFC 01/16] linux-headers: Update to Linux v6.15-rc net-next

2025-05-23 Thread Paolo Abeni
On 5/23/25 11:50 AM, Akihiko Odaki wrote: > On 2025/05/21 20:33, Paolo Abeni wrote: >> @@ -235,4 +235,12 @@ >>*/ >> #define VHOST_VDPA_GET_VRING_SIZE _IOWR(VHOST_VIRTIO, 0x82, \ >>struct vhost_vring_state) &g

Re: [PATCH RFC 07/16] virtio-pci: implement support for extended features.

2025-05-23 Thread Paolo Abeni
On 5/23/25 9:23 AM, Akihiko Odaki wrote: >> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c >> index 0fa8fe4955..7815ef2d9b 100644 >> --- a/hw/virtio/virtio-pci.c >> +++ b/hw/virtio/virtio-pci.c >> @@ -123,7 +123,8 @@ static const VMStateDescription >> vmstate_virtio_pci_modern_state_

[PATCH RFC 08/16] vhost: add support for negotiating extended features.

2025-05-21 Thread Paolo Abeni
sk must be extended to the feature format, or the all highest bits will be unintentionally cleared. Note that 'protocol_features' are not extended: they are only used by vhost-user, and the latter device is not going to implement extended features soon. Signed-off-by: Paolo Abeni --

[PATCH RFC 04/16] virtio: serialize extended features state

2025-05-21 Thread Paolo Abeni
If the host supports 128 bit-wide features, and the driver use any of them, serialize the full features range leveraging newly introduced 128bits integer helpers. Signed-off-by: Paolo Abeni --- hw/virtio/virtio.c | 76 +- 1 file changed, 75 insertions

[PATCH RFC 06/16] virtio: add support for negotiating extended features.

2025-05-21 Thread Paolo Abeni
t support. Signed-off-by: Paolo Abeni --- hw/virtio/virtio-bus.c | 15 --- hw/virtio/virtio.c | 23 +-- include/hw/virtio/virtio.h | 8 +++- 3 files changed, 36 insertions(+), 10 deletions(-) diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virt

[PATCH RFC 09/16] vhost-backend: implement extended features support.

2025-05-21 Thread Paolo Abeni
changed belongs to the 64 bit range. Signed-off-by: Paolo Abeni --- hw/virtio/vhost-backend.c | 59 +++ 1 file changed, 53 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index 833804dd40..a5e28e15ee 100644 --- a/hw

[PATCH RFC 14/16] net: bundle all offloads in a single struct

2025-05-21 Thread Paolo Abeni
The set_offload() argument list is already pretty long and we are going to introduce soon a bunch of additional offloads. Replace the offload arguments with a single struct and update all the relevant call-sites. No functional changes intended. Signed-off-by: Paolo Abeni --- hw/net

[PATCH RFC 03/16] virtio: introduce extended features type

2025-05-21 Thread Paolo Abeni
nded space. Signed-off-by: Paolo Abeni --- hw/net/virtio-net.c | 2 +- hw/virtio/virtio-bus.c | 4 +- hw/virtio/virtio.c | 4 +- include/hw/virtio/virtio-features.h | 90 + include/hw/virtio/virtio.h | 9 +-

[PATCH RFC 12/16] virtio-net: implement extended features support.

2025-05-21 Thread Paolo Abeni
Use the extended types and helpers to manipulate the virtio_net features. Note that offloads are still 64bits wide, as per specification, and extended offloads will be mapped into such range. Signed-off-by: Paolo Abeni --- hw/net/virtio-net.c| 87

[PATCH RFC 10/16] vhost-net: implement extended features support.

2025-05-21 Thread Paolo Abeni
Update the features manipulation helpers to cope with the extended features, adjust the relevant format strings accordingly and always use the virtio features type for bitmask manipulation. Signed-off-by: Paolo Abeni --- hw/net/vhost_net-stub.c | 7 --- hw/net/vhost_net.c | 31

[PATCH RFC 16/16] net: make vhost-net aware of GSO over UDP tunnel hdr layout

2025-05-21 Thread Paolo Abeni
tunnel related feature: add them to host kernel supported features list, to allow qemu transder to such backend the needed information. Signed-off-by: Paolo Abeni --- hw/net/vhost_net.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 58d7619fc8

[PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-21 Thread Paolo Abeni
eventually enable the associated features. As per virtio specification, to convert features bit to offload bit, map the extended features into the reserved range. Signed-off-by: Paolo Abeni --- hw/net/virtio-net.c | 48 - include/net/net.h | 2 ++ net/net.c

[PATCH RFC 05/16] qmp: update virtio features map to support extended features

2025-05-21 Thread Paolo Abeni
Signed-off-by: Paolo Abeni --- hw/virtio/virtio-hmp-cmds.c | 3 ++- hw/virtio/virtio-qmp.c | 28 ++-- hw/virtio/virtio-qmp.h | 3 ++- qapi/virtio.json| 8 ++-- 4 files changed, 32 insertions(+), 10 deletions(-) diff --git a/hw/virtio/virtio

[PATCH RFC 07/16] virtio-pci: implement support for extended features.

2025-05-21 Thread Paolo Abeni
Allow the common read/write operation to access all the available features space. Signed-off-by: Paolo Abeni --- hw/virtio/virtio-pci.c | 19 +-- include/hw/virtio/virtio-pci.h | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio

[PATCH RFC 11/16] qdev-properties: add property for extended virtio features

2025-05-21 Thread Paolo Abeni
Virtio features extend above the 64 bit space, and GSO over UDP tunnels support is going to use some bits in the extended space. Introduce a new Property type to handle the extended feature defined in the previous patch. Signed-off-by: Paolo Abeni --- hw/core/qdev-properties.c| 46

[PATCH RFC 13/16] net: implement tunnel probing

2025-05-21 Thread Paolo Abeni
to support both of them or none. Signed-off-by: Paolo Abeni --- hw/net/virtio-net.c | 39 +++ include/net/net.h | 3 +++ net/net.c | 9 + net/tap-bsd.c | 5 + net/tap-linux.c | 19 +++ net/tap-solari

[PATCH RFC 02/16] migration: introduce support for 128 bit int state.

2025-05-21 Thread Paolo Abeni
The virtio specifications allows for up to 128 bits for the device features. Soon we are going to use some of the 'extended' bits features (above 64) for the virtio net driver. For platform natively supporting 128 bits, introduce a 128 bit integer state. Signed-off-by: Paolo Abeni --

[PATCH RFC 00/16] virtio: introduce support for GSO over UDP tunnel

2025-05-21 Thread Paolo Abeni
really appreciated, and any feedback about the features extension strategy would be more than welcome! Paolo Abeni (16): linux-headers: Update to Linux v6.15-rc net-next migration: introduce support for 128 bit int state. virtio: introduce extended features type virtio: serialize extended

[PATCH RFC 01/16] linux-headers: Update to Linux v6.15-rc net-next

2025-05-21 Thread Paolo Abeni
Update headers to include the virtio GSO over UDP tunnel features Signed-off-by: Paolo Abeni --- The relevant bits are not yet merged upstream, will update this patch after merge. --- include/standard-headers/asm-x86/setup_data.h | 4 +- include/standard-headers/drm/drm_fourcc.h | 41

Re: [PATCH v6] ptp: Add support for the AMZNC10C 'vmclock' device

2024-09-26 Thread Paolo Abeni
On 9/20/24 11:32, David Woodhouse wrote: From: David Woodhouse The vmclock device addresses the problem of live migration with precision clocks. The tolerances of a hardware counter (e.g. TSC) are typically around ±50PPM. A guest will use NTP/PTP/PPS to discipline that counter against an extern

Re: [PATCH v5] ptp: Add support for the AMZNC10C 'vmclock' device

2024-09-03 Thread Paolo Abeni
On 8/23/24 12:09, David Woodhouse wrote: diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index 604541dcb320..e98c9767e0ef 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -131,6 +131,19 @@ config PTP_1588_CLOCK_KVM To compile this driver as a module, choose M here: t

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Paolo Abeni
Hi, Just a bunch of 'nits below On 7/24/24 19:16, David Woodhouse wrote: diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c new file mode 100644 index ..9c508c21c062 --- /dev/null +++ b/drivers/ptp/ptp_vmclock.c [...] +/* + * Multiply a 64-bit count by a 64-bit t

Re: [RFC PATCH 0/5] mptcp support

2021-04-09 Thread Paolo Abeni
On Fri, 2021-04-09 at 10:42 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 09, 2021 at 10:34:30AM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > I had a quick go at trying NBD as w

Re: [RFC PATCH 4/5] migration/socket: Close the listener at the end

2021-04-09 Thread Paolo Abeni
Hello, On Fri, 2021-04-09 at 10:10 +0100, Daniel P. Berrangé wrote: > On Thu, Apr 08, 2021 at 08:11:58PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Delay closing the listener until the cleanup hook at the end; mptcp > > needs the listener to stay open w

Re: [RFC PATCH 0/5] mptcp support

2021-04-09 Thread Paolo Abeni
On Fri, 2021-04-09 at 10:34 +0100, Daniel P. Berrangé wrote: > On Thu, Apr 08, 2021 at 08:11:54PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This RFC set adds support for multipath TCP (mptcp), > > in particular on the migration path - but shou

[Qemu-devel] virtual PC block driver status

2007-03-25 Thread Paolo Abeni
hello, As noted before (http://lists.gnu.org/archive/html/qemu-devel/2006-10/msg00153.html) Microsoft has published the format of virtual pc drive VHD. It should be used also by xen. The specs are available here: http://download.microsoft.com/download/f/f/e/ffef50a5-07dd-4cf8-aaa3-442c0673a029/