On Tue, 21 Jul 2015, Paolo Bonzini wrote:
On 19/07/2015 22:39, pyssl...@ludd.ltu.se wrote:
From: Nils Carlson
Commit 812c1057 introduced HUP detection on unix and tcp sockets prior
to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2
which relied on the old behaviour where
Agree, this is more elegant, we keep the recv in a tight loop.
Acked-by: Nils Carlson
On Tue, 21 Jul 2015, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
qemu-char.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index
On Fri, 17 Jul 2015, Kirill Batuzov wrote:
On Fri, 17 Jul 2015, Nils Carlson wrote:
Hi,
The commit 812c1057f, Handle G_IO_HUP in tcp_chr_read for tcp chardev, broke
CloudStack. CloudStack was relying on fire-and-forget style messaging across a
unix socket to the VM. Because the host "
values from the tcp_chr_read
function, which seem a bit odd as they are all TRUE, even for failure
paths.
All feedback very much appreciated.
Best Regards,
Nils Carlson
From pyssl...@ludd.ltu.se Thu Jul 16 01:01:31 2015
Date: Wed, 15 Jul 2015 23:00:23 +
From: pyssl...@ludd.ltu.se
To: pbon
On Thu, 16 Jul 2015, Amit Shah wrote:
On (Wed) 15 Jul 2015 [23:44:52], Nils Carlson wrote:
On Mon, 13 Jul 2015, Nils Carlson wrote:
On Mon, 13 Jul 2015, Amit Shah wrote:
Also, returning TRUE there isn't right - if the connection ends, we
should return FALSE.
I agree that this
On Mon, 13 Jul 2015, Nils Carlson wrote:
On Mon, 13 Jul 2015, Amit Shah wrote:
Also, returning TRUE there isn't right - if the connection ends, we
should return FALSE.
I agree that this seems reasonable. I will change it and re-test.
I had a closer look, and it seems always retu
On Mon, 13 Jul 2015, Amit Shah wrote:
On (Mon) 13 Jul 2015 [12:15:22], Paolo Bonzini wrote:
On 13/07/2015 10:13, pyssl...@ludd.ltu.se wrote:
Commit 812c1057 introduced HUP detection on unix and tcp sockets prior
to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2
which relied
