Quoting Peter Maydell (2024-08-30 12:01:47)
> On Fri, 30 Aug 2024 at 06:48, Nico Boehr wrote:
> >
> > Quoting Peter Maydell (2024-08-29 17:53:02)
> > > I repro'd *something*, but it wasn't quite this. I got:
> > >
> > >
> > > [
Quoting Peter Maydell (2024-08-29 17:53:02)
> On Wed, 28 Aug 2024 at 09:13, Nico Boehr wrote:
> >
> > Quoting Nico Boehr (2024-08-26 14:08:20)
> > > There was a little hickup without the fixup to patch 2, but after Nina
> > > pushed the fixup, we did not obs
Quoting Peter Maydell (2024-08-29 15:35:30)
> On Thu, 29 Aug 2024 at 14:26, Nico Boehr wrote:
> >
> > Quoting Peter Maydell (2024-08-29 15:09:44)
> > > Thanks. I tried this repro, but mkosi falls over almost
> > > immediately:
>
> > In the meantime, loo
Quoting Peter Maydell (2024-08-29 15:09:44)
> Thanks. I tried this repro, but mkosi falls over almost
> immediately:
>
> ‣ Detaching namespace
> ‣ Setting up package cache…
> ‣ Setting up package cache /home/linux1/s390-failure/.mkosi-htsau2ot complete
> ‣ Setting up temporary workspace.
> ‣ Tempo
Quoting Peter Maydell (2024-08-28 17:46:42)
[...]
> Well, the series is *supposed* to be just a refactoring, not a change of
> behaviour, so I'm not sure. I don't suppose you have a reproduce case
> that I can run? (I do have access to an s390 machine if that helps.)
Well, it's on an internal test
Quoting Nico Boehr (2024-08-26 14:08:20)
> There was a little hickup without the fixup to patch 2, but after Nina
> pushed the fixup, we did not observe any failures related to your
> changes in our CI. Thanks!
Peter, after a few CI runs, we unfortunately did find some issues with y
Quoting Nina Schoetterl-Glausch (2024-08-22 12:34:14)
> I'll run it through our CI and see if anything pops up.
Nina is on holiday, she asked me to quickly report back.
There was a little hickup without the fixup to patch 2, but after Nina
pushed the fixup, we did not observe any failures related
Quoting Thomas Huth (2022-10-17 09:30:04)
[...]
> I know it's annoying when switching between kernel coding style and QEMU
> coding style, but please use curly braces when doing QEMU patches. I wonder
> why checkpatch.pl does not print any warnings here...?
Ooops, sorry for the oversight. You ar
he following warning message on save/restore of a PV guest:
warning: Unable to set KVM guest TOD clock: Operation not supported
[1] https://lore.kernel.org/all/20221011160712.928239-2-...@linux.ibm.com/
Fixes: c3347ed0d2ee ("s390x: protvirt: Support unpack facility")
Signed-off-by: Nico Boeh
Quoting Pierre Morel (2022-09-02 09:55:27)
> During a subsystem reset the Topology-Change-Report is cleared
> by the machine.
> Let's ask KVM to clear the Modified Topology Change Report (MTCR)
> bit of the SCA in the case of a subsystem reset.
>
> Signed-off-by: Pierre Mo
Quoting Pierre Morel (2022-09-02 09:55:24)
> The guest can use the STSI instruction to get a buffer filled
> with the CPU topology description.
>
> Let us implement the STSI instruction for the basis CPU topology
> level, level 2.
I like this. It is so much simpler. Thanks.
[...]
> diff --git a/
Quoting Pierre Morel (2022-09-02 09:55:23)
[...]
> diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c
> new file mode 100644
> index 00..a6ca006ec5
> --- /dev/null
> +++ b/hw/s390x/cpu-topology.c
[...]
> +void s390_topology_new_cpu(int core_id)
> +{
[...]
> +socket_id = core
Quoting Pierre Morel (2022-09-02 09:55:22)
> S390x do not support multithreading in the guest.
> Do not let admin falsely specify multithreading on QEMU
> smp commandline.
>
> Signed-off-by: Pierre Morel
> ---
> hw/s390x/s390-virtio-ccw.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --gi
_la2_m64a to load from storage into in2 and pass that to
the helper, which matches what we already do for SCKC.
This fixes the SCK test I sent here under TCG:
<https://www.spinics.net/lists/kvm/msg265169.html>
Suggested-by: David Hildenbrand
Signed-off-by: Nico Boehr
---
target/s390x/tcg/
On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote:
> I think you can actually just reuse in2_m2_64a, similar as we handle
> SCKC
I tried my SCK tests with your patch, it works just as well and seems
much cleaner, thanks.
Do you want to send this or should I make a v2 and add you as
Sugge
o a temporary and pass that to the helper.
This fixes the SCK test I sent here under TCG:
<https://www.spinics.net/lists/kvm/msg265169.html>
Signed-off-by: Nico Boehr
---
target/s390x/tcg/translate.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/target/s3
.
Fixes: db1c8f53bfb1 ("s390: Channel I/O basic definitions.")
Signed-off-by: Nico Boehr
Reviewed-by: Pierre Morel
Reviewed-by: Halil Pasic
Reviewed-by: Janosch Frank
---
include/hw/s390x/ioinst.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/s390x/
17 matches
Mail list logo
