RE: [PATCH] tests/tcg/hexagon: fix underspecifed asm constraints

2022-12-29 Thread Mukilan Thiyagarajan (QUIC)
2++#4) incrementing register %2. I've made the suggested changes in v2 of the patch: https://patchew.org/QEMU/20221229081836.12130-1-quic._5fmthiy...@quicinc.com/ Regards, Mukilan -Original Message- From: Taylor Simpson Sent: Wednesday, December 28, 2022 11:07 PM To: Mukilan Thiya

RE: [PATCH 1/2] linux-user/hexagon: fix signal context save & restore

2022-12-29 Thread Mukilan Thiyagarajan (QUIC)
if the formatting is still off. Thanks, Mukilan -Original Message- From: Taylor Simpson Sent: Wednesday, December 28, 2022 11:35 PM To: Mukilan Thiyagarajan (QUIC) ; qemu-devel@nongnu.org; laur...@vivier.eu Cc: Brian Cain ; richard.hender...@linaro.org; alex.ben...@linaro.org Subject: RE: [

RE: [PATCH 2/2] target/hexagon: rename aliased register HEX_REG_P3_0

2022-12-29 Thread Mukilan Thiyagarajan (QUIC)
_5fmthiy...@quicinc.com/ Please let me know if the formatting is still off in v2 of the patch for you. Thanks, Mukilan -Original Message- From: Taylor Simpson Sent: Wednesday, December 28, 2022 11:35 PM To: Mukilan Thiyagarajan (QUIC) ; qemu-devel@nongnu.org; laur...@vivier.eu Cc: Br

[PATCH v2 1/2] linux-user/hexagon: fix signal context save & restore

2022-12-29 Thread Mukilan Thiyagarajan
om/quic/toolchain_for_hexagon/issues/6 Signed-off-by: Mukilan Thiyagarajan Reviewed-by: Taylor Simpson --- linux-user/hexagon/signal.c| 17 +++--- tests/tcg/hexagon/Makefile.target | 1 + tests/tcg/hexagon/signal_context.c | 84 ++ 3 files changed, 96 insertions(

[PATCH v2 2/2] target/hexagon: rename aliased register HEX_REG_P3_0

2022-12-29 Thread Mukilan Thiyagarajan
. The hope is to prevent accidental misuse of this register e.g the issue reported for the signals tests failure [here][1]. [1]: https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg01102.html Signed-off-by: Mukilan Thiyagarajan Reviewed-by: Taylor Simpson --- target/hexagon/cpu.c | 6

[PATCH v2 0/2] Hexagon: fix signal context save & restore bug

2022-12-29 Thread Mukilan Thiyagarajan
test case Mukilan Thiyagarajan (2): linux-user/hexagon: fix signal context save & restore target/hexagon: rename aliased register HEX_REG_P3_0 linux-user/hexagon/signal.c| 17 +++--- target/hexagon/cpu.c | 6 +-- target/hexagon/genptr.c| 12 ++--- target

[PATCH v2] tests/tcg/hexagon: fix underspecifed asm constraints

2022-12-29 Thread Mukilan Thiyagarajan
7 is written to but not specified in the clobber list. Signed-off-by: Mukilan Thiyagarajan Reviewed-by: Taylor Simpson --- tests/tcg/hexagon/mem_noshuf.c | 2 +- tests/tcg/hexagon/misc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/tcg/hexagon/mem_noshu

[PATCH] tests/tcg/hexagon: fix underspecifed asm constraints

2022-12-28 Thread Mukilan Thiyagarajan
needs the early clobber modifier since the rest of the inputs are read after assignment to the output register. Signed-off-by: Mukilan Thiyagarajan --- tests/tcg/hexagon/mem_noshuf.c | 2 +- tests/tcg/hexagon/misc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/te

[PATCH 1/2] linux-user/hexagon: fix signal context save & restore

2022-12-27 Thread Mukilan Thiyagarajan
om/quic/toolchain_for_hexagon/issues/6 Signed-off-by: Mukilan Thiyagarajan --- linux-user/hexagon/signal.c| 17 +++--- tests/tcg/hexagon/Makefile.target | 1 + tests/tcg/hexagon/signal_context.c | 84 ++ 3 files changed, 96 insertions(+), 6 deletions(-)

[PATCH 2/2] target/hexagon: rename aliased register HEX_REG_P3_0

2022-12-27 Thread Mukilan Thiyagarajan
. The hope is to prevent accidental misuse of this register e.g the issue reported for the signals tests failure [here][1]. [1]: https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg01102.html Signed-off-by: Mukilan Thiyagarajan --- target/hexagon/cpu.c | 6 +++--- target/hexagon/genptr.c

[PATCH 0/2] Hexagon: fix signal context save & restore bug

2022-12-27 Thread Mukilan Thiyagarajan
s an aliased version of the individual predicate registers. - Mukilan Mukilan Thiyagarajan (2): linux-user/hexagon: fix signal context save & restore target/hexagon: rename aliased register HEX_REG_P3_0 linux-user/hexagon/signal.c| 17 +++--- target/hexagon/cpu.c

Re: [PULL 0/6] testing updates

2022-12-22 Thread Mukilan Thiyagarajan
Thank you, Alex! Here is the patch to fix the issue. I've also removed the comment which is no longer applicable. Regards, Mukilan --- .gitlab-ci.d/container-cross.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.gitlab-ci.d/container-cross.yml b/.gitlab-ci.d/container-cross.yml index

RE: [PULL 0/6] testing updates

2022-12-22 Thread Mukilan Thiyagarajan (QUIC)
I believe the error is caused by the QEMU_JOB_ONLY_FORKS: 1 line which needs to be removed from the definition of hexagon-cross-container. Alex, Peter, Shall I raise a patch to remove this line? Should the patch be created against the testing/next branch? Thanks, Mukilan -Original Message-

[PATCH] tests/docker: use prebuilt toolchain for debian-hexagon-cross

2022-12-19 Thread Mukilan Thiyagarajan
tcg/multiarch: remove unused variable in linux-test Signed-off-by: Mukilan Thiyagarajan --- .gitlab-ci.d/buildtest.yml| 4 - .gitlab-ci.d/container-cross.yml | 19 +-- tests/docker/Makefile.include | 4 - .../debian-hexagon-cross.d/build-toolc

[PATCH] tests/tcg/multiarch: remove unused variable in linux-test

2022-12-15 Thread Mukilan Thiyagarajan
LLVM 15.0.0 has improved diagnostics for the 'nounused-but-set-variable' warning and now warns when a variable is modified using pre/post increment/decrement operators but is otherwise never read. linux-tests.c has such an unused variable 'wcount' and since TCG tests are compiled with -Wall -Werro

RE: [PATCH] configure: Fix check-tcg not executing any tests

2022-12-14 Thread Mukilan Thiyagarajan (QUIC)
b/scm/utils/dash/dash.git/commit/?id=ebfdd97a10e34a5e70eadfc21ebfc033ef93a563 Regards, Mukilan -Original Message- From: Philippe Mathieu-Daudé Sent: Wednesday, December 7, 2022 2:37 PM To: Mukilan Thiyagarajan (QUIC) ; qemu-devel@nongnu.org; Brian Cain ; Matheus Bernardino (QUIC) Cc:

RE: [PATCH] configure: Fix check-tcg not executing any tests

2022-12-07 Thread Mukilan Thiyagarajan (QUIC)
Thank you for the pointers, Philippe 😊 Will keep them in mind for the future patches. Regards, Mukilan -Original Message- From: Philippe Mathieu-Daudé Sent: Wednesday, December 7, 2022 2:37 PM To: Mukilan Thiyagarajan (QUIC) ; qemu-devel@nongnu.org; Brian Cain ; Matheus Bernardino

[PATCH] configure: Fix check-tcg not executing any tests

2022-12-07 Thread Mukilan Thiyagarajan
target tests. Fixes: c3b570b5a9a24d25 (configure: don't enable cross compilers unless in target_list) Signed-off-by: Mukilan Thiyagarajan --- configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index 26c7bc5154..7a804fb657 100755 --- a/