Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax

2019-06-11 Thread Mike Snitzer
27;t set 'DAXDEV_SYNC' flag. > > 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn' > as argument so that the callers can pass the appropriate functions. > > Suggested-by: Mike Snitzer > Signed-off-by: Pankaj Gupta Thanks, and for the be

Re: [Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

2019-06-11 Thread Mike Snitzer
On Tue, Jun 11 2019 at 9:10am -0400, Pankaj Gupta wrote: > Hi Mike, > > Thanks for the review Please find my reply inline. > > > > > dm_table_supports_dax() is called multiple times (from > > dm_table_set_restrictions and dm_table_determine_type). It is strange > > to have a getter have a si

Re: [Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

2019-06-10 Thread Mike Snitzer
On Mon, Jun 10 2019 at 5:07am -0400, Pankaj Gupta wrote: > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. >

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 4:53pm -0500, Jens Axboe wrote: > On 11/26/2014 02:51 PM, Mike Snitzer wrote: > > > > But while you're here, I wouldn't mind getting your take on virtio-blk > > setting max_hw_sectors to -1U. > > > > As I said in my original

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 3:54pm -0500, Jens Axboe wrote: > On 11/26/2014 01:51 PM, Mike Snitzer wrote: > > On Wed, Nov 26 2014 at 2:48pm -0500, > > Jens Axboe wrote: > > > >> > >> That code isn't even in mainline, as far as I can tell... > >

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 2:48pm -0500, Jens Axboe wrote: > On 11/21/2014 08:49 AM, Mike Snitzer wrote: > > On Fri, Nov 21 2014 at 4:54am -0500, > > Christoph Hellwig wrote: > > > >> On Thu, Nov 20, 2014 at 02:00:59PM -0500, Mike Snitzer wrote: > >>>

Re: [Qemu-devel] virtio_blk: fix defaults for max_hw_sectors and max_segment_size

2014-11-21 Thread Mike Snitzer
On Fri, Nov 21 2014 at 4:54am -0500, Christoph Hellwig wrote: > On Thu, Nov 20, 2014 at 02:00:59PM -0500, Mike Snitzer wrote: > > virtio_blk incorrectly established -1U as the default for these > > queue_limits. Set these limits to sane default values to avoid crashing > >

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-05-31 Thread Mike Snitzer
On Tue, May 31 2011 at 2:39pm -0400, Anthony Liguori wrote: > On 05/31/2011 12:59 PM, Vivek Goyal wrote: > >On Tue, May 31, 2011 at 09:25:31AM -0500, Anthony Liguori wrote: > >>On 05/31/2011 09:04 AM, Vivek Goyal wrote: > >>>On Tue, May 31, 2011 at 08:50:40AM -0500, Anthony Liguori wrote: >

[Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-10-14 Thread Mike Snitzer
On Tue, Sep 14, 2010 at 1:56 AM, H. Peter Anvin wrote: > On 09/13/2010 06:37 PM, Amos Kong wrote: >> I've heard wonderful music (guest:win7), but mixed with a litte noise, not >> so fluent. >> The following debug msg is normal? > > Yes, all of that is normal.  I talked to malc earlier today, and