[PATCH] tcg: drop unused tcg_temp_free define

2023-10-14 Thread Mike Frysinger
Use of the API was removed a while back, but the define wasn't. Signed-off-by: Mike Frysinger --- include/tcg/tcg-op.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index 80cfcf8104b6..3ead59e4594d 100644 --- a/include/tcg/tcg-op.h

[PATCH] linux-user: move target_flat.h to target subdirs

2023-01-28 Thread Mike Frysinger
y other target_xxx.h header is handled. Signed-off-by: Mike Frysinger --- linux-user/aarch64/target_flat.h | 1 + linux-user/arm/target_flat.h | 1 + linux-user/{ => generic}/target_flat.h | 0 linux-user/m68k/target_flat.h | 1 + linux-user/microblaze/target_flat.h

[PATCH v2] linux-user: fix strace build w/out munlockall

2023-01-18 Thread Mike Frysinger
Signed-off-by: Mike Frysinger Reviewed-by: Philippe Mathieu-Daud?? --- linux-user/strace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 9ae5a812cd71..11a7c3df9498 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c

[PATCH] configure: do not quote $PKG_CONFIG

2023-01-17 Thread Mike Frysinger
flags directly to pkg-config via the env var where this normally works elsewhere, and it used to work in the past. Signed-off-by: Mike Frysinger --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9e407ce2e3a9..b5a19d1319a5 100755

[PATCH] linux-user: fix strace build w/out munlockall

2023-01-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/strace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/strace.c b/linux-user/strace.c index 9ae5a812cd71..f7912ad67f2b 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -1380,6 +1380,7 @@ UNUSED static struct flags

[Qemu-devel] [PATCH v2] linux-user: make getcpu optional

2018-02-16 Thread Mike Frysinger
Not all arches implement this, and the kernel doesn't require them to. Add ifdef logic to disable it when not available. Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 799c8e2

[Qemu-devel] [PATCH] linux-user: make getcpu optional

2018-02-16 Thread Mike Frysinger
Not all arches implement this, and the kernel doesn't require them to. Add ifdef logic to disable it when not available. Signed-off-by: Mike Frysinger --- linux-user/syscall.c| 4 target/bfin/op_helper.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH] build: fix typo in error message

2017-11-27 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index 030617b4ac0c..bc7224a27fe3 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -24,7 +24,7

Re: [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev

2017-02-14 Thread Mike Frysinger
On 10 Feb 2017 09:04, Peter Maydell wrote: > I still think that it's a shame that glibc is breaking > compatibility with where these macros have always been > kept on every OS that's implemented them back to 2BSD... i don't think that characterization is accurate. if it were, autoconf wouldn't ha

[Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev

2017-02-09 Thread Mike Frysinger
Linux C libs are moving away from implicit header pollution with sys/types.h Signed-off-by: Mike Frysinger --- include/qemu/osdep.h | 4 1 file changed, 4 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 56c9e22405ec..6aaace6cf37f 100644 --- a/include/qemu

[Qemu-devel] [PATCH] qemu log: wrap long text

2016-07-03 Thread Mike Frysinger
The existing help output is a bit hard to read due to the ad-hoc wrapping. This makes it a bit more programmatic (at least, it wraps it once, but that should be good enough for now). Signed-off-by: Mike Frysinger --- util/log.c | 36 ++-- 1 file changed, 30

[Qemu-devel] [PATCH] crypto: aes: always rename internal symbols

2016-06-06 Thread Mike Frysinger
From: Mike Frysinger OpenSSL's libcrypto always defines AES symbols with the same names as qemu's local aes code. This is problematic when enabling at least curl as that frequently also uses libcrypto. It might not be noticed when running, but if you try to statically link, everyt

[Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2014-12-30 Thread Mike Frysinger
looks like 79ae25af1569a50a0ec799901a1bb280c088f121 (which is in qemu-2.2.0) makes it work again for my test case. not sure if the OP wants to verify as well or just close this out now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Mike Frysinger
please don't take this the wrong way, but i don't see how any of your comments are relevant. i didn't say "POSIX" anywhere (which isn't to say your outline of POSIX semantics are incorrect), but the QEMU linux-user layer has nothing to do with POSIX. the linux-user layer in QEMU implements the

[Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-07 Thread Mike Frysinger
From: Mike Frysinger The current code always returns the length of the path when it should be returning the number of bytes it wrote to the output string. Further, readlink is not supposed to append a NUL byte, but the current snprintf logic will always do just that. Even further, if you pass

[Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: rewrite to make user friendly & easier to maintain

2014-06-05 Thread Mike Frysinger
people can easily run it and integrate into their system, and make it easier for CPU maintainers to add new targets. There's also a few fixes smattered about, but considering the whole file has been written from scratch, not sure they need splitting out. Signed-off-by: Mike Frysinger --- scri

[Qemu-devel] [PATCH] virtfs-proxy-helper: fix call to accept

2014-04-19 Thread Mike Frysinger
From: Tim Comer The current code calls accept() without initializing the size parameter which means the accept call might write too much to the stack. URL: https://bugs.gentoo.org/486714 Signed-off-by: Tim Comer Signed-off-by: Mike Frysinger --- fsdev/virtfs-proxy-helper.c | 1 + 1 file

[Qemu-devel] [PATCH] configure: detect endian via compile test

2013-06-30 Thread Mike Frysinger
This avoids needing to execute a program and keeping an (incomplete) list when cross-compiling. Signed-off-by: Mike Frysinger --- configure | 40 ++-- 1 file changed, 14 insertions(+), 26 deletions(-) diff --git a/configure b/configure index 2206a87..19d0856

Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-25 Thread Mike Frysinger
On Tuesday 25 June 2013 17:23:57 Richard Henderson wrote: whee, got a review! :) i've snipped items that were obvious in the "i'll go do this" category rather than just copying & pasting "OK" many times. got a long flight coming up soon, so hopefully i can tackle the majority of this work the

[Qemu-devel] [PATCH 4/5] Blackfin: add test suite

2013-06-17 Thread Mike Frysinger
To run it, simply add the bfin-elf compiler to your PATH and do: make -C tests/tcg/bfin Signed-off-by: Mike Frysinger --- Deleted test content due to size (~2 MiB). It's all just Blackfin assembly at any rate. Code can be found here: git://sources.blackfin.uclinux.org/git/users/v

[Qemu-devel] [PATCH 5/5] linux-user: add support for Blackfin syscalls

2013-06-17 Thread Mike Frysinger
The Blackfin arch supports a simple sram allocator for userspace, as well as a DMA memcpy function to access the sram. Signed-off-by: Mike Frysinger --- linux-user/strace.list | 9 ++ linux-user/syscall.c | 74 ++ 2 files changed, 83

[Qemu-devel] [PATCH 3/5] Blackfin: add linux-user support

2013-06-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- default-configs/bfin-linux-user.mak | 1 + linux-user/bfin/syscall.h | 59 ++ linux-user/bfin/syscall_nr.h| 389 linux-user/bfin/target_flat.h | 92 + linux-user/bfin

[Qemu-devel] [PATCH 0/5] Initial Blackfin support (linux-user only)

2013-06-17 Thread Mike Frysinger
d DSP insns, then you should probably stick with the GNU sim for now. The port started off against a much older version, so I might have missed some stuff that needs to be done for the latest master branch. Mike Frysinger (5): Blackfin: add disassembler support Blackfin: initial port Blackfin

[Qemu-devel] [PATCH v2] configure: do not quote $PKG_CONFIG

2013-06-16 Thread Mike Frysinger
flags directly to pkg-config via the env var where this normally works elsewhere, and it used to work in the past. Signed-off-by: Mike Frysinger --- v2 - rebased onto latest master - people were happy with this in the previous thread: http://permalink.gmane.org

[Qemu-devel] [PATCH] qemu-log: wrap long text

2013-06-16 Thread Mike Frysinger
ng on whitespace, but not sure how much time we really want to invest here. Signed-off-by: Mike Frysinger --- qemu-log.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/qemu-log.c b/qemu-log.c index 797f2af..ba432f5 100644 --- a/qemu-log.c +++ b/qemu-

Re: [Qemu-devel] [PATCH] fix no-sdl builds

2013-06-16 Thread Mike Frysinger
On Sunday 16 June 2013 20:52:18 Andreas Färber wrote: > Am 17.06.2013 00:48, schrieb Mike Frysinger: > > The no_frame var is only defined when SDL support is enabled. > > > > Signed-off-by: Mike Frysinger > > There was already a different patch to the same

[Qemu-devel] [PATCH] fix no-sdl builds

2013-06-16 Thread Mike Frysinger
The no_frame var is only defined when SDL support is enabled. Signed-off-by: Mike Frysinger --- vl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 9f8fd6e..aaa14bb 100644 --- a/vl.c +++ b/vl.c @@ -3524,9 +3524,6 @@ int main(int argc, char **argv

[Qemu-devel] [PATCH] qemu-log: wrap long text

2013-06-09 Thread Mike Frysinger
ng on whitespace, but not sure how much time we really want to invest here. Signed-off-by: Mike Frysinger --- qemu-log.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/qemu-log.c b/qemu-log.c index 797f2af..ba432f5 100644 --- a/qemu-log.c +++ b/qemu-

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-17 Thread Mike Frysinger
On Monday 17 September 2012 03:19:54 Jan Kiszka wrote: > On 2012-09-16 22:55, Mike Frysinger wrote: > > On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: > >> Am 16.09.2012 22:11, schrieb Mike Frysinger: > >>> +libcacard/vscclient +a.out* +.gdb_history +core +g

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-16 Thread Mike Frysinger
On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: > Am 16.09.2012 22:11, schrieb Mike Frysinger: > > +libcacard/vscclient > > +a.out* > > +.gdb_history > > +core > > +gmon.out > > +*.diff > > +*.patch > > +*.rej > > IMHO .gitignore sh

[Qemu-devel] [PATCH] ignore more generated files

2012-09-16 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |8 1 file changed, 8 insertions(+) diff --git a/.gitignore b/.gitignore index 824c0d2..25c134e 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ trace-dtrace.dtrace *-darwin-user *-linux-user *-bsd-user +libcacard/vscclient

[Qemu-devel] [PATCH v2] allow make {dist, }clean work w/out configure

2012-09-16 Thread Mike Frysinger
There's no reason to require configure to run before running a clean target, so check MAKECMDGOALS before. Signed-off-by: Mike Frysinger --- v2 - handle edge cases Makefile |4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 1cd5bc8..0a37369 1

Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure

2012-09-16 Thread Mike Frysinger
On Sunday 16 September 2012 05:52:47 Paolo Bonzini wrote: > Il 16/09/2012 02:30, Mike Frysinger ha scritto: > > There's no reason to require configure to run before running a clean > > target, so check MAKECMDGOALS before. > > > > --- a/Makefile > > +++ b/

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-16 Thread Mike Frysinger
On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: > Am 15.07.2012 22:26, schrieb Mike Frysinger: > > We should not quote the PKG_CONFIG setting as this deviates from the > > canonical upstream behavior that gets integrated with all other build > > systems, and deviates from h

[Qemu-devel] [PATCH] include address in invalid memory region accesses

2012-09-16 Thread Mike Frysinger
The current code to display invalid memory accesses isn't terribly useful as it doesn't tell you what address is actually being accessed. Include it in the error message. Signed-off-by: Mike Frysinger --- memory.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) di

Re: [Qemu-devel] [PATCH] fix warnings from printf target addresses

2012-09-16 Thread Mike Frysinger
On Sunday 16 September 2012 03:24:22 Blue Swirl wrote: > On Sun, Sep 16, 2012 at 12:05 AM, Mike Frysinger wrote: > > Current code triggers: > > memory.c: In function 'invalid_read': > > memory.c:1001: warning: format '%#x' expects type 'unsi

[Qemu-devel] [PATCH] allow make {dist,}clean work w/out configure

2012-09-15 Thread Mike Frysinger
There's no reason to require configure to run before running a clean target, so check MAKECMDGOALS before. Signed-off-by: Mike Frysinger --- Makefile |4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 1cd5bc8..e75740c 100644 --- a/Makefile +++ b/Mak

[Qemu-devel] [PATCH] fix warnings from printf target addresses

2012-09-15 Thread Mike Frysinger
mat '%#x' expects type 'unsigned int', but argument 4 has type 'target_phys_addr_t' Signed-off-by: Mike Frysinger --- memory.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/memory.c b/memory.c index 58a242d..7d5f4a3 100644 ---

[Qemu-devel] [PATCH] fix gcc warnings when RESERVED_VA is 0

2012-09-15 Thread Mike Frysinger
_maps': linux-user/syscall.c:4960: warning: comparison of unsigned expression < 0 is always false linux-user/syscall.c:4960: warning: comparison of unsigned expression < 0 is always false Signed-off-by: Mike Frysinger --- cpu-all.h |8 +++- 1 file changed, 7 insertions(+), 1

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-07-18 Thread Mike Frysinger
On Monday 16 July 2012 11:58:55 Stefan Weil wrote: > Am 16.07.2012 17:39, schrieb Eric Blake: > > On 07/15/2012 01:54 PM, Stefan Weil wrote: > >> Am 15.07.2012 22:26, schrieb Mike Frysinger: > >>> We should not quote the PKG_CONFIG setting as this deviates fro

Re: [Qemu-devel] [PATCH] cpu-defs.h: pull in qemu-common.h for HOST_LONG_BITS

2012-07-18 Thread Mike Frysinger
On Monday 16 July 2012 01:26:50 Stefan Weil wrote: > Am 15.07.2012 23:54, schrieb Mike Frysinger: > > On Sunday 15 July 2012 15:34:33 Stefan Weil wrote: > >> Am 15.07.2012 22:25, schrieb Mike Frysinger: > >>> This file uses the define HOST_LONG_BITS, but doesn&#

Re: [Qemu-devel] [PATCH] cpu-defs.h: pull in qemu-common.h for HOST_LONG_BITS

2012-07-15 Thread Mike Frysinger
On Sunday 15 July 2012 15:34:33 Stefan Weil wrote: > Am 15.07.2012 22:25, schrieb Mike Frysinger: > > This file uses the define HOST_LONG_BITS, but doesn't explicitly include > > qemu-common.h for it leading to build warnings for some setups: > > In file included from

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-07-15 Thread Mike Frysinger
On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: > Am 15.07.2012 22:26, schrieb Mike Frysinger: > > We should not quote the PKG_CONFIG setting as this deviates from the > > canonical upstream behavior that gets integrated with all other build > > systems, and deviates from h

[Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-07-15 Thread Mike Frysinger
flags directly to pkg-config via the env var where this normally works elsewhere, and it used to work in the past. Signed-off-by: Mike Frysinger --- configure |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 83fa1ca..bd12ed3 100755 --- a

[Qemu-devel] [PATCH] cpu-defs.h: pull in qemu-common.h for HOST_LONG_BITS

2012-07-15 Thread Mike Frysinger
defined Signed-off-by: Mike Frysinger --- cpu-defs.h |1 + 1 file changed, 1 insertion(+) diff --git a/cpu-defs.h b/cpu-defs.h index f49e950..0d6018d 100644 --- a/cpu-defs.h +++ b/cpu-defs.h @@ -28,6 +28,7 @@ #include #include #include "osdep.h" +#include "qemu-com

Re: [Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Mike Frysinger
On Monday 09 July 2012 09:21:52 Andreas Färber wrote: > Am 09.07.2012 15:04, schrieb Mike Frysinger: > > The current bss clear logic assumes the target mmap address and host > > address are the same. Use g2h to translate from the target address > > space to the host so we

[Qemu-devel] [PATCH] flatload: fix bss clearing

2012-07-09 Thread Mike Frysinger
The current bss clear logic assumes the target mmap address and host address are the same. Use g2h to translate from the target address space to the host so we can call memset on it. Signed-off-by: Mike Frysinger --- linux-user/flatload.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] simulation paper with Blackfin and QEMU + GNU sim

2011-07-01 Thread Mike Frysinger
Robin and i wrote a paper on simulation that focused on QEMU and the GNU sim with the Blackfin architecture. it covers implementation, testing, and benchmarking. maybe some people will find it useful. maybe not. http://docs.blackfin.uclinux.org/lib/exe/fetch.php?media=presentations:ols-2011-sim.p

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Enforce pselect6 sigset size restrictions

2011-06-28 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part.

[Qemu-devel] [PATCH v2] linux-user: add pselect6 syscall support

2011-06-03 Thread Mike Frysinger
Some architectures (like Blackfin) only implement pselect6 (and skip select/newselect). So add support for it. Signed-off-by: Mike Frysinger --- v2 - handle null sigptr in a valid 6th sig struct linux-user/syscall.c | 149 +++-- 1 files

Re: [Qemu-devel] [PATCH] linux-user: add pselect6 syscall support

2011-06-03 Thread Mike Frysinger
On Fri, Jun 3, 2011 at 14:10, riku voipio wrote: > On 05/18/2011 03:14 AM, Mike Frysinger wrote: >> Some architectures (like Blackfin) only implement pselect6 (and skip >> select/newselect).  So add support for it using existing newselect code. > > There is a blackfin qemu

Re: [Qemu-devel] [PATCH] ignore patch related files

2011-05-17 Thread Mike Frysinger
On Tue, May 17, 2011 at 18:17, Peter Maydell wrote: > On 17 May 2011 22:10, Mike Frysinger wrote: >> --- a/.gitignore >> +++ b/.gitignore >> @@ -58,6 +58,10 @@ QMP/qmp-commands.txt >>  *.orig >>  .pc >>  patches >> +*.diff >> +*.patch >>

[Qemu-devel] [PATCH v2] ignore patch related files

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- v2 - drop *.orig as it has been merged already .gitignore |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 08013fc..790dc12 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,9 @@ QMP/qmp

[Qemu-devel] [PATCH] linux-user: add pselect6 syscall support

2011-05-17 Thread Mike Frysinger
Some architectures (like Blackfin) only implement pselect6 (and skip select/newselect). So add support for it using existing newselect code. Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 145 +++--- 1 files changed, 126 insertions(+), 19

[Qemu-devel] [PATCH] ignore new compiled vscclient tool

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 306baee..e5a51f3 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ trace-dtrace.dtrace *-darwin-user *-linux-user *-bsd-user +libcacard

[Qemu-devel] [PATCH] ignore more gdb related files

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index e6557c3..306baee 100644 --- a/.gitignore +++ b/.gitignore @@ -35,6 +35,8 @@ qemu-io qemu-monitor.texi QMP/qmp-commands.txt .gdbinit

[Qemu-devel] [PATCH] ignore patch related files

2011-05-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 08013fc..e6557c3 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,10 @@ QMP/qmp-commands.txt *.orig .pc patches +*.diff +*.patch +*.rej

[Qemu-devel] [PATCH] configure: check for -Wendif-labels support

2011-05-17 Thread Mike Frysinger
Older gcc compilers do not support -Wendif-labels, so move it from the hardcoded list to the dynamically detected list. Signed-off-by: Mike Frysinger --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 019bc8d..8b775a4 100755

Re: [Qemu-devel] [PATCH] Fix buffer overrun in sched_getaffinity

2011-04-16 Thread Mike Frysinger
ret, p, zero)) { >>                          goto efault; >>                      } >>                      arg2 = ret; > > Reviewed-by: Stefan Hajnoczi > > Note that mainline Linux does not zero unwritten bytes.  I would drop > the entire arg2 > ret case and instead copy only ret bytes to user. both changes make sense to me Acked-by: Mike Frysinger -mike

[Qemu-devel] [PATCH] configure: add --version flag

2011-04-06 Thread Mike Frysinger
Standard autoconf scripts include a --version flag so people can easily query things. Add this to qemu's configure so it too can integrate with build systems that have standard autotool helpers. Signed-off-by: Mike Frysinger --- configure |2 ++ 1 files changed, 2 insertions(

[Qemu-devel] [PATCH 5/9] linux-user/FLAT: fix auto-stack sizing

2011-02-07 Thread Mike Frysinger
4KiB. So rather than rely on the NOMMU calculation (which is only there because NOMMU can't easily allocate gobs of contiguous mem), calc the full space actually needed and let the MMU host make space. Signed-off-by: Mike Frysinger --- linux-user/flatload.c | 11 +-- 1 files ch

[Qemu-devel] [PATCH 6/9] linux-user/FLAT: allow targets to override FLAT processing

2011-02-07 Thread Mike Frysinger
This brings flatload.c more in line with the current Linux FLAT loader which allows targets to handle various FLAT aspects in their own way. For the common behavior, the new functions get stubbed out. Signed-off-by: Mike Frysinger --- Makefile.target |2 +- linux-user/flatload.c

[Qemu-devel] [PATCH 7/9] linux-user: implement sched_{g, s}etaffinity

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index bb6ef43..4412a9b 100644 --- a/linux-user/syscall.c +++ b/linux-user

[Qemu-devel] [PATCH 8/9] user: speed up init_paths a bit

2011-02-07 Thread Mike Frysinger
over 1000 syscalls from being made at every invocation of a target binary, and I only have a C library installed. Signed-off-by: Mike Frysinger --- path.c | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/path.c b/path.c index 0d2bf14..ef3f277

[Qemu-devel] [PATCH 9/9] linux-user: fix build errors for mmap2-only ports

2011-02-07 Thread Mike Frysinger
The current print_mmap func is only enabled when the target supports the mmap syscall, but both mmap and mmap2 syscalls use it. This leads to a build failure when the target supports mmap2 but not mmap. Signed-off-by: Mike Frysinger --- linux-user/strace.c |2 +- 1 files changed, 1

Re: [Qemu-devel] [PATCH 2/2] ignore more gdb related files

2011-02-07 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 04:48, Mike Frysinger wrote: > --- a/.gitignore > +++ b/.gitignore > @@ -35,6 +35,8 @@ qemu-io >  qemu-monitor.texi >  QMP/qmp-commands.txt >  .gdbinit > +.gdb_history > +core >  *.a >  *.aux >  *.cp ping ... -mike

[Qemu-devel] [PATCH 1/9] linux-user: fix sizeof handling for getsockopt

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/syscall.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 499c4d7..6116ab5 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1448,7 +1448,7 @@ static abi_long

[Qemu-devel] [PATCH 4/9] linux-user: decode MAP_{UNINITIALIZED, EXECUTABLE} in strace

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/strace.c |4 linux-user/syscall_defs.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index bf9a0d9..a8786bb 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c

[Qemu-devel] [PATCH 2/9] linux-user/elfload: add FDPIC support

2011-02-07 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- elf.h| 19 + linux-user/elfload.c | 71 ++ linux-user/qemu.h|7 + 3 files changed, 97 insertions(+), 0 deletions(-) diff --git a/elf.h b/elf.h index 7067c90..d2f24f4

[Qemu-devel] [PATCH 3/9] linux-user: add ppoll syscall support

2011-02-07 Thread Mike Frysinger
Some architectures (like Blackfin) only implement ppoll (and skip poll). So add support for it using existing poll code. Reviewed-by: Peter Maydell Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 57 - 1 files changed, 55 insertions

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 13:45, Peter Maydell wrote: > On 1 February 2011 18:16, Mike Frysinger wrote: >> On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: >>> That's OK too, that would fall into my category (3). >> >> so the TB invalidation checking can be taken

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 05:31, Peter Maydell wrote: > So for instance here: > > +static void gen_hwloop_check(DisasContext *dc) > +{ > +    bool loop1, loop0; > +    int endl; > + > +    loop1 = (dc->pc == dc->env->lbreg[1]); > +    loop0 = (dc->pc == dc->env->lbreg[0]); > > I suspect that this chec

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: > On 1 February 2011 17:20, Mike Frysinger wrote: >> On Tue, Feb 1, 2011 at 05:31, Peter Maydell wrote: >>> I suspect that this check of pc against the lbreg[] >>> values should be being done in the generated code

[Qemu-devel] [PATCH v2] linux-user: implement sched_{g, s}etaffinity

2011-02-01 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- v2 - handle host/target size mismatches (32 on a 64) linux-user/syscall.c | 67 ++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-01-31 Thread Mike Frysinger
On Mon, Jan 31, 2011 at 09:00, Edgar E. Iglesias wrote: > * Some operations seem to translate to large amounts of tcg code, >  maybe you should consider using helpers for those. An example >  is gen_rot_tl. seems like generated native code is better even if it is larger > * Maybe you should renam

[Qemu-devel] [PATCH] linux-user: fix build errors for mmap2-only ports

2011-01-29 Thread Mike Frysinger
The current print_mmap func is only enabled when the target supports the mmap syscall, but both mmap and mmap2 syscalls use it. This leads to a build failure when the target supports mmap2 but not mmap. Signed-off-by: Mike Frysinger --- linux-user/strace.c |2 +- 1 files changed, 1

[Qemu-devel] [PATCH] linux-user: implement sched_{g,s}etaffinity

2011-01-26 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 50 ++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3e285c6..f95429f 100644 --- a/linux-user/syscall.c +++ b/linux-user

[Qemu-devel] [PATCH] user: speed up init_paths a bit

2011-01-26 Thread Mike Frysinger
over 1000 syscalls from being made at every invocation of a target binary, and I only have a C library installed. Signed-off-by: Mike Frysinger --- path.c | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/path.c b/path.c index 0d2bf14..ef3f277

Re: [Qemu-devel] [PATCH v2] linux-user/FLAT: allow targets to override FLAT processing

2011-01-26 Thread Mike Frysinger
On Tue, Jan 25, 2011 at 01:15, Mike Frysinger wrote: > This brings flatload.c more in line with the current Linux FLAT loader > which allows targets to handle various FLAT aspects in their own way. > For the common behavior, the new functions get stubbed out. > > Signed-off-by:

Re: [Qemu-devel] Re: [PATCH] linux-user/FLAT: allow targets to override FLAT reloc processing

2011-01-26 Thread Mike Frysinger
On Wed, Jan 26, 2011 at 16:21, riku voipio wrote: > On 01/24/2011 11:48 AM, Mike Frysinger wrote: >> This brings flatload.c more in line with the current Linux FLAT loader >> which allows targets to handle FLAT relocations in their own way.  For >> the common behavior,

Re: [Qemu-devel] Re: IRC channel movement -> FreeNode to OFTC

2011-01-25 Thread Mike Frysinger
On Tue, Jan 25, 2011 at 15:05, Brian Jackson wrote: > On 1/24/2011 1:13 PM, Mike Frysinger wrote: >> On Thu, Dec 9, 2010 at 17:44, Brian Jackson wrote: >>> C. They have strange rules about groups and channel ownership >> >> ive never had a problem > > Yea

[Qemu-devel] [PATCH v4] linux-user: add ppoll syscall support

2011-01-25 Thread Mike Frysinger
Some architectures (like Blackfin) only implement ppoll (and skip poll). So add support for it using existing poll code. Signed-off-by: Mike Frysinger --- v4 - handle null signal set ... this wasn't failing as Blackfin ELFs default to VMA of 0 and thus lock_user() on a

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Mike Frysinger
On Tue, Jan 25, 2011 at 03:47, Stefano Bonifazi wrote: > On 01/25/2011 02:36 AM, Richard Henderson wrote: >> On 01/24/2011 01:44 PM, Stefano Bonifazi wrote: >>> Wow wonderful! So you fixed the code for PIC (ET_DYN) support? >> >> Yes. >> >>> how can I get your sources? >> >> I was mistaken -- a lat

[Qemu-devel] [PATCH v2] linux-user/FLAT: allow targets to override FLAT processing

2011-01-24 Thread Mike Frysinger
This brings flatload.c more in line with the current Linux FLAT loader which allows targets to handle various FLAT aspects in their own way. For the common behavior, the new functions get stubbed out. Signed-off-by: Mike Frysinger --- v2 - also add flat_argvp_envp_on_stack() just like

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 19:06, Mike Frysinger wrote: > On Mon, Jan 24, 2011 at 11:29, Mulyadi Santosa wrote: >> I wrote an article about understanding ELF years ago, here is the URL: >> http://www.linuxforums.org/articles/understanding-elf-using-readelf-and-objdump_125.html &g

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 11:29, Mulyadi Santosa wrote: > I wrote an article about understanding ELF years ago, here is the URL: > http://www.linuxforums.org/articles/understanding-elf-using-readelf-and-objdump_125.html i also highly recommend Linkers & Loaders: http://linker.iecc.com/ some pie

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 16:52, Stefano Bonifazi wrote: >> but that can happen with the app running natively too, so any app not >> handling MAP_FIXED failures is buggy and not qemu's problem. > > How? For what I learned each process executing on a OS with an mmu sees its > virtual address space, an

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 16:44, Stefano Bonifazi wrote: >>   http://lists.gnu.org/archive/html/qemu-devel/2010-07/msg01626.html > > A noob question, how can I get your sources? Is there a simpler solution > than "copy&paste" all the code from your messages into patches and then > applying them? Can

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 17:24, Stefano Bonifazi wrote: >> how can the ldso possibly prevent clashes ?  it has no idea what >> addresses an app will ask for at runtime. >> >> plus, if the kernel is employing ASLR (which isnt uncommon nowadays), >> the load addresses could be anywhere. > > Well not a

Re: [Qemu-devel] Re: [RFC/PATCH] elfload: add FDPIC support

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 16:06, Stefano Bonifazi wrote: > I don't understand.. what is the difference between pie binary for pcc and > for your architecture? as i said, i think this is all irrelevant to what you want to do. but since you asked and i feel like writing ... i have no idea what "pcc"

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 15:58, Stefano Bonifazi wrote: >> review the mmap() man page ... MAP_FIXED is always a *suggestion* and >> never a requirement. the app must check the return value to see what >> the kernel actually gave it. > > Sorry, wrong! > > MAP_FIXED > Don't interpret ad

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 13:16, Stefano Bonifazi wrote: >> Start address in which address the ELF code section, in reality (not >> under qemu-user) should be mapped. in x86 32 bit it's 08048000, you >> can check it by yourself by executing: >> cat /proc/self/maps > > Wait, like that I don't understa

Re: [Qemu-devel] Re: IRC channel movement -> FreeNode to OFTC

2011-01-24 Thread Mike Frysinger
On Thu, Dec 9, 2010 at 17:44, Brian Jackson wrote: > A. Must be registered to talk in a channel i'm fairly certain that is a per-channel setting > C. They have strange rules about groups and channel ownership ive never had a problem > D. Their non-profit status in the US was terminated for fail

Re: [Qemu-devel] Re: [RFC/PATCH] elfload: add FDPIC support

2011-01-24 Thread Mike Frysinger
On Mon, Jan 24, 2011 at 08:34, Stefano Bonifazi wrote: > Is FDPIC something different than simply PIC code (position independent > code)? FDPIC ELF is the ELF PIE format used on NOMMU systems so that both the text and data regions may be located anywhere. it is the only ELF format supported under

[Qemu-devel] [PATCH 3/4] Blackfin: add linux-user support

2011-01-24 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- configure |1 + default-configs/bfin-linux-user.mak |1 + linux-user/bfin/syscall.h | 59 ++ linux-user/bfin/syscall_nr.h| 388 +++ linux-user/bfin/target_flat.h

[Qemu-devel] Blackfin: add disassembler support

2011-01-24 Thread Mike Frysinger
compressing & attaching since this is big (and i dont know what the qemu mailing list limit is set to), and it is simply a copy & paste of the Blackfin disassembler from binutils -mike Makefile.objs |1 + bfin-dis.c| 4903 +++

[Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-01-24 Thread Mike Frysinger
ing Blackfin code, but I easily see about ~400mips with qemu. Obviously your numbers will vary based on workload, but hopefully not too much ... My git tree with everything necessary can be found here: git://sources.blackfin.uclinux.org/git/users/vapier/qemu.git Mike Frysinger (4):

[Qemu-devel] [PATCH] linux-user/FLAT: allow targets to override FLAT reloc processing

2011-01-24 Thread Mike Frysinger
This brings flatload.c more in line with the current Linux FLAT loader which allows targets to handle FLAT relocations in their own way. For the common behavior, the new functions get stubbed out. Signed-off-by: Mike Frysinger --- Makefile.target |2 +- linux-user/flatload.c

[Qemu-devel] [PATCH 2/2] ignore more gdb related files

2011-01-24 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index dadb01a..81717f3 100644 --- a/.gitignore +++ b/.gitignore @@ -35,6 +35,8 @@ qemu-io qemu-monitor.texi QMP/qmp-commands.txt .gdbinit

[Qemu-devel] [PATCH] linux-user/FLAT: fix auto-stack sizing

2011-01-24 Thread Mike Frysinger
4KiB. So rather than rely on the NOMMU calculation (which is only there because NOMMU can't easily allocate gobs of contiguous mem), calc the full space actually needed and let the MMU host make space. Signed-off-by: Mike Frysinger --- linux-user/flatload.c | 11 +-- 1 files ch

  1   2   >