Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

Thanks Alex On Wed, Aug 30, 2023, 14:47 Alex Bennée wrote: > > Matt Borgerson writes: > > > Translation logic may partially decode an instruction, then abort and > > remove the instruction from the TB. This can happen for example when an > > instruction spans two p

Re: [PATCH] accel/tcg: Fix guest instruction address in output assembly log

On Sat, Jul 22, 2023 at 3:11 AM Richard Henderson wrote: > > On 7/18/23 02:35, Matt Borgerson wrote: > > If CF_PCREL is enabled, generated host assembly logging (command line > > option `-d out_asm`) may incorrectly report guest instruction virtual > > addresses as

[PATCH] accel/tcg: Fix guest instruction address in output assembly log

If CF_PCREL is enabled, generated host assembly logging (command line option `-d out_asm`) may incorrectly report guest instruction virtual addresses as page offsets instead of absolute addresses. This patch corrects the reported guest address. Signed-off-by: Matt Borgerson --- accel/tcg

Re: [PATCH] target/i386: Check CR0.TS before enter_mmx

Thanks Paolo! On Fri, Jul 14, 2023 at 7:28 AM Paolo Bonzini wrote: > > Queued, thanks. > > Paolo >

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

Thanks Alex! On Mon, Jul 17, 2023 at 8:34 AM Alex Bennée wrote: > > > Alex Bennée writes: > > > Matt Borgerson writes: > > > >> Translation logic may partially decode an instruction, then abort and > >> remove the instruction from the TB. This can h

[PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

in the TB. This patch updates plugin_gen_tb_end to set the final instruction count. Signed-off-by: Matt Borgerson --- accel/tcg/plugin-gen.c| 5 - accel/tcg/translator.c| 2 +- include/exec/plugin-gen.h | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/accel/tcg

Re: [PATCH] plugins: Set final instruction count in plugin_gen_tb_end

Hi Philippe, > num_insns is a 'size_t'. You are right. I copied the `int` type from `DisasContextBase`, but it should really be `size_t`. I'll send an updated patch. Thanks, Matt On Fri, Jul 14, 2023 at 11:09 AM Philippe Mathieu-Daudé wrote: > > Hi Matt, > > On

[PATCH] plugins: Set final instruction count in plugin_gen_tb_end

in the TB. This patch updates plugin_gen_tb_end to set the final instruction count. Signed-off-by: Matt Borgerson --- accel/tcg/plugin-gen.c| 5 - accel/tcg/translator.c| 2 +- include/exec/plugin-gen.h | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/accel/tcg

[PATCH] target/i386: Check CR0.TS before enter_mmx

resetting FPU state before the guest has a chance to save it. Signed-off-by: Matt Borgerson --- target/i386/tcg/decode-new.c.inc | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc index 46afd9960b

Re: [PATCH] memory: Fix start offset for bitmap log_clear hook

eb 18, 2020 at 9:53 AM Peter Xu wrote: > > On Tue, Feb 18, 2020 at 03:19:10AM -0700, Matt Borgerson wrote: > > Currently only the final page offset is being passed to the `log_clear` > > hook via `memory_region_clear_dirty_bitmap` after it is use

[PATCH] memory: Fix start offset for bitmap log_clear hook

Currently only the final page offset is being passed to the `log_clear` hook via `memory_region_clear_dirty_bitmap` after it is used as an iterator in `cpu_physical_memory_test_and_clear_dirty`. This patch corrects the start address and size of the region. Signed-off-by: Matt Borgerson