Steven Sistare writes:
> On 7/25/2025 9:50 AM, Markus Armbruster wrote:
>> The machine name g_strdup()ed by add_machine_test_case() is freed by
>> test_machine(). Since the former runs for all machines, whereas the
>> latter runs only for the selected test case'
Steven Sistare writes:
> On 7/25/2025 9:50 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/qtest/qom-test.c | 4
>> 1 file changed, 4 deletions(-)
>> diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
>&
nditional to fix this module, we break the others.
Instead of complicating the code to compute the conjunction, simplify
it: generate the output marshalling code right into qmp_marshal_C().
This duplicates it when multiple commands return the same type. The
impact on code size is negligible: qe
Steven, this is follow-up to your work. Care to review?
I took the liberty to post my version as "[PATCH 3/3]
docs/devel/qapi-code-gen: Update cross-reference syntax" to speed up
things. Hope you don't mind.
these targets to use since, but neglected to
update doc comment markup documentation. Do that now.
Co-developed-by: John Snow
Signed-off-by: John Snow
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 11 ---
docs/devel/qapi-domain.rst | 1 +
2 files chang
Markus Armbruster (3):
docs/devel/qapi-code-gen: Add two cross-references we missed
docs/devel/qapi-code-gen: Fix typos in QAPI schema language grammar
docs/devel/qapi-code-gen: Update cross-reference syntax
docs/devel/qapi-code-gen.rst | 19 ---
docs/devel/qapi-domain.rst
Missed in commit 9c66762a601 (docs/qapi-code-gen: add
cross-references).
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index dfdbeac5a5
Wrong subject, please ignore.
Fixes: 3248c1aaf2db (docs: update the documentation upfront about schema
configuration)
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index
Missed in commit 9c66762a601 (docs/qapi-code-gen: add
cross-references).
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index dfdbeac5a5
these targets to use since, but neglected to
update doc comment markup documentation. Do that now.
Co-developed-by: John Snow
Signed-off-by: John Snow
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 11 ---
docs/devel/qapi-domain.rst | 1 +
2 files chang
Markus Armbruster (3):
docs/devel/qapi-code-gen: Add two cross-references we missed
docs/devel/qapi-code-gen: Fix typos in QAPI schema language grammar
docs/devel/qapi-code-gen: Update cross-reference syntax
docs/devel/qapi-code-gen.rst | 19 ---
docs/devel/qapi-domain.rst
Fixes: 3248c1aaf2db (docs: update the documentation upfront about schema
configuration)
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index
Queued. Thanks for the review!
Queued.
Queued. Thanks for the review!
t;). Fix the markup.
Fixes: 18da42ee4273 (qapi/accel: Move definitions related to accelerators in
their own file)
Signed-off-by: Markus Armbruster
Message-ID: <20250724091742.1950167-2-arm...@redhat.com>
---
qapi/accelerator.json | 4 +++-
1 file changed, 3 insertions(+), 1 dele
(docs/sphinx: remove special parsing for freeform sections)
Signed-off-by: Markus Armbruster
Message-ID: <20250724091742.1950167-3-arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Reviewed-by: John Snow
---
tests/qapi-schema/doc-non-first-section.err | 1 -
tests/qapi-schema/do
2025-07-29
--------
Markus Armbruster (5):
qapi: Add more cross-references
qapi/accelerator: Fix markup of heading
tests/qapi-schema: Bury dead test case doc-non-first-section
docs/qapi-domain: Fix typos
MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
M
Signed-off-by: Markus Armbruster
Message-ID: <20250729091642.3513895-2-arm...@redhat.com>
Reviewed-by: Manos Pitsidianakis
---
docs/devel/qapi-domain.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-domain.rst b/docs/devel/qapi-domain.rst
Section QAPI already covers it, and that's fine. It's missing from
"Sphinx documentation configuration and build machinery". Add it
there.
Signed-off-by: Markus Armbruster
Message-ID: <20250729091642.3513895-3-arm...@redhat.com>
Reviewed-by: Manos Pitsidianakis
We recently (merge commit 504632dcc631) enclosed command and type
names in `backquotes`, so they become links in generated HTML. Take
care of a few we missed.
Signed-off-by: Markus Armbruster
Message-ID: <20250717115751.3832597-1-arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Revie
Markus Armbruster writes:
> Manos Pitsidianakis writes:
>
>> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster wrote:
>>>
>>> Signed-off-by: Markus Armbruster
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
Manos Pitsidianakis writes:
> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster wrote:
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
&g
Philippe Mathieu-Daudé writes:
> On 29/7/25 13:12, Markus Armbruster wrote:
>> xenfb_mouse_event() has a switch statement whose controlling
>> expression move->axis is an enum InputAxis. The enum values are
>> INPUT_AXIS_X and INPUT_AXIS_Y, encoded as 0 and 1. The switc
hat move->axis can be greater than 1. It
duly reports a buffer overrun when it is used to subscript an array
with two elements.
Replace the unreachable code by abort().
Resolves: Coverity CID 1613906
Signed-off-by: Markus Armbruster
---
hw/display/xenfb.c | 3 +--
1 file changed, 1 insertion
Markus Armbruster (2):
docs/qapi-domain: Fix typos
MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
MAINTAINERS| 1 +
docs/devel/qapi-domain.rst | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.49.0
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-domain.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-domain.rst b/docs/devel/qapi-domain.rst
index b71890f660..fe540d1e40 100644
--- a/docs/devel/qapi-domain.rst
+++ b/docs/devel/qapi-domain.rst
Signed-off-by: Markus Armbruster
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f1bd69c3db..9c22e921e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4432,6 +4432,7 @@ F: docs/requirements.txt
F: docs/sphinx/
F: docs/_templates/
F: docs
Daniel P. Berrangé writes:
> On Mon, Jul 28, 2025 at 04:57:47PM +0200, Markus Armbruster wrote:
>> This reverts commit 30ea13e9d97dcbd4ea541ddf9e8857fa1d5cb30f.
>
> You had conflicts in this revert I presume ? That commit added
> 6 qos_printf calls, but this commit removes 1
s a commit meant to ease
debugging. Revert it until a better solution is found.
Signed-off-by: Markus Armbruster
---
tests/qtest/qos-test.c| 5 -
tests/qtest/vhost-user-test.c | 27 +--
2 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/tests
Paolo Bonzini writes:
> On 7/23/25 16:28, Markus Armbruster wrote:
>> Noise starting with "stdout: " has been polluting output of "make check"
>> for a while. I traced it to qos-test. Output of "make
>> check-qtest-aarch64" appended a
John Snow writes:
> On Thu, Jul 17, 2025 at 7:57 AM Markus Armbruster wrote:
>>
>> We recently (merge commit 504632dcc631) enclosed command and type
>> names in `backquotes`, so they become links in generated HTML. Take
>> care of a few we missed.
>>
&g
Queued. Thanks for the reviews!
ned-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250717115246.3830007-4-arm...@redhat.com>
Reviewed-by: John Snow
---
qga/qapi-schema.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
iously
no worse. For instance, guest-info's documentation changes from
Return:
GuestAgentInfo -- GuestAgentInfo
to
Return:
GuestAgentInfo
The auto-generated returns all are in the exact same spot.
We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial
"Ret
tion about route of network.
Return:
[GuestNetworkRoute] -- List of route info of guest.
Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
Signed-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250717115246.3830007-2-arm.
2025-07-28
--------
Markus Armbruster (4):
qga: Fix guest-network-get-route return value documentation
qga: Remove trivial "Returns:" sections
qga: Rephrase return docs to avoid type name
qga: Add cross-references
qga/qa
Enclose command and type names in `backquotes`, so they become links
in generated HTML.
We did this for qapi/ in merge commit 504632dcc631.
Signed-off-by: Markus Armbruster
Message-ID: <20250717115246.3830007-5-arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé
Reviewed-by: John Snow
--
Markus Armbruster writes:
> This series touches only doc comments. I'd like to get it into 10.1.
Kostiantyn, Michael, would you like me to do the PR for this?
Kostiantyn Kostiuk writes:
> Issue reported to GLib https://gitlab.gnome.org/GNOME/glib/-/issues/3740
> PR with fix https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4716
>
> @Markus Armbruster
> Based on the documentation from this PR, do you have any other objections
>
Signed-off-by: Markus Armbruster
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a462345618..12e7767909 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3445,6 +3445,7 @@ F: qom/
F: tests/unit/check-qom-interface.c
F: tests/unit/check-qom
This test traverses the QOM sub-tree rooted at /machine. Traverse the
entire tree instead.
The x86_64 test runs some 40 additional QMP commands, and stays under
5s for me.
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
ed to dup in the first place, so don't.
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
index 4ade1c728c..cb5dbfe329 100644
--- a/tests/qtest/qom-test.c
+++ b/t
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c | 4
1 file changed, 4 deletions(-)
diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
index d358b69c7e..6421f2d9d9 100644
--- a/tests/qtest/qom-test.c
+++ b/tests/qtest/qom-test.c
@@ -215,10 +215,6 @@ static void
QOM
property getters. Traversing it twice not so much.
Make the qom-list / qom-get test shallow unless -m slow is given:
don't recurse. Cuts the number of commands to around 600, and run
time to under 5s for me.
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c | 2 +-
1
Markus Armbruster (5):
qtest/qom-test: Plug memory leak with -p
qtest/qom-test: Shallow testing of qom-list / qom-get
qtest/qom-test: Traverse entire QOM tree
qtest/qom-test: Don't bother to execute QMP command quit
MAINTAINERS: Cover tests/qtest/qom-test.c
MAINTAINERS
John Snow writes:
> The blurb about @foo style references in qapi-code-gen.rst is out of
> date now, update it.
>
> Signed-off-by: John Snow
> ---
> docs/devel/qapi-code-gen.rst | 11 ---
> docs/devel/qapi-domain.rst | 1 +
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff
t;). Fix the markup.
Fixes: 18da42ee4273 (qapi/accel: Move definitions related to accelerators in
their own file)
Signed-off-by: Markus Armbruster
---
qapi/accelerator.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/accelerator.json b/qapi/accelerator.json
index 28
(docs/sphinx: remove special parsing for freeform sections)
Signed-off-by: Markus Armbruster
---
tests/qapi-schema/doc-non-first-section.err | 1 -
tests/qapi-schema/doc-non-first-section.json | 6 --
tests/qapi-schema/doc-non-first-section.out | 0
3 files changed, 7 deletions(-)
delete
Alright, that was a tad long. Here's the shortest feedback I can give.
Thesis: the prime use case for the index is looking up commands and
events. See my long reply for why.
Usability baseline: an index page with links "A", ... "Z" at the top,
each linking to a flat list of commands and events
Markus Armbruster (2):
qapi/accelerator: Fix markup of heading
tests/qapi-schema: Bury dead test case doc-non-first-section
qapi/accelerator.json| 4 +++-
tests/qapi-schema/doc-non-first-section.err | 1 -
tests/qapi-schema/doc-non-first-section.json | 6
I refreshed my memory on this. It's been a while. Instead of replying
to your replies long after you wrote them, I'm going to write up my
thoughts in one place.
= General observations =
* We have three QAPI-generated manuals: QEMU QMP Reference Manual, QEMU
Storage Daemon QMP Reference Manua
One more thing just caught my eye: every command starts with "mcd-", and
every type starts with "MCD". This makes the index less useful than it
could be. Not a show-stopper, but perhaps you'd like to consider
dropping the command prefix.
Noise starting with "stdout: " has been polluting output of "make check"
for a while. I traced it to qos-test. Output of "make
check-qtest-aarch64" appended as an example.
Blessed silence if I revert commit 30ea13e9d97d (tests/qtest: use
qos_printf instead of g_test_message).
Alex, what shall w
Markus Armbruster (2):
i386/kvm/vmsr_energy: Plug memory leak on failure to connect socket
vfio scsi ui: Error-check qio_channel_socket_connect_sync() the same
way
hw/vfio-user/proxy.c | 2 +-
scsi/pr-manager-helper.c | 9 ++---
target/i386/kvm/vmsr_energy.c | 6
vmsr_open_socket() leaks the Error set by
qio_channel_socket_connect_sync(). Plug the leak by not creating the
Error.
Fixes: 0418f90809ae (Add support for RAPL MSRs in KVM/Qemu)
Signed-off-by: Markus Armbruster
---
target/i386/kvm/vmsr_energy.c | 6 +-
1 file changed, 1 insertion(+), 5
qio_channel_socket_connect_sync() returns 0 on success, and -1 on
failure, with errp set. Some callers check the return value, and some
check whether errp was set.
For consistency, always check the return value, and always check it's
negative.
Signed-off-by: Markus Armbruster
---
hw/vfio
: add tracing)
Signed-off-by: Markus Armbruster
---
ui/keymaps.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/ui/keymaps.c b/ui/keymaps.c
index 6ceaa97085..2359dbfe7e 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -86,19 +86,25 @@ static int
x27;,
> '}',
> cond=cond,
> event_lineno=event.lineno,
> diff --git a/util/log.c b/util/log.c
> index 58d24de48a..abdcb6b311 100644
> --- a/util/log.c
> +++ b/util/log.c
> @@ -145,10 +145,28 @@ void qemu_log_unlock(FILE *logfile)
>
> void qemu_log(const char *fmt, ...)
> {
> -FILE *f = qemu_log_trylock();
> +FILE *f;
> +g_autofree const char *timestr = NULL;
> +
> +/*
> + * Prepare the timestamp *outside* the logging
> + * lock so it better reflects when the message
> + * was emitted if we are delayed acquiring the
> + * mutex
> + */
> +if (message_with_timestamp) {
> +g_autoptr(GDateTime) dt = g_date_time_new_now_utc();
> +timestr = g_date_time_format_iso8601(dt);
> +}
Duplicates real_time_iso8601() from error-report.c. Tolerable.
> +
> +f = qemu_log_trylock();
> if (f) {
> va_list ap;
>
> +if (timestr) {
> +fprintf(f, "%s ", timestr);
> +}
> +
> va_start(ap, fmt);
> vfprintf(f, fmt, ap);
> va_end(ap);
Reviewed-by: Markus Armbruster
Kostiantyn Kostiuk writes:
> On Sat, Jul 19, 2025 at 9:27 AM Markus Armbruster wrote:
>
>> Kostiantyn Kostiuk writes:
>>
>> > g_win32_error_message - translate a Win32 error code
>> > (as returned by GetLastError()) into the corresponding message.
Paolo Abeni writes:
> Extend the VirtioDeviceFeatures struct with an additional u64
> to track unknown features in the 64-127 bit range and decode
> the full virtio features spaces for vhost and virtio devices.
>
> Also add entries for the soon-to-be-supported virtio net GSO over
> UDP features.
Kostiantyn Kostiuk writes:
> g_win32_error_message - translate a Win32 error code
> (as returned by GetLastError()) into the corresponding message.
>
> In the same time, we call error_setg_win32_internal with
> error codes from different Windows componets like VSS or
> Performance monitor that pr
Daniel P. Berrangé writes:
> On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>> > Adam Williamson writes:
>> >
>> >> In cfcacba an `error_report` was added to this file, but the
>> >>
Markus Armbruster writes:
> Adam Williamson writes:
>
>> In cfcacba an `error_report` was added to this file, but the
>> corresponding include of `qemu/error-report.h` was missed. This
>> only becomes apparent when building against Xen 4.20+.
>>
>> Signed-of
Adam Williamson writes:
> In cfcacba an `error_report` was added to this file, but the
> corresponding include of `qemu/error-report.h` was missed. This
> only becomes apparent when building against Xen 4.20+.
>
> Signed-off-by: Adam Williamson
> ---
> hw/xen/xen_pt.c | 1 +
> 1 file changed, 1
We recently (merge commit 504632dcc631) enclosed command and type
names in `backquotes`, so they become links in generated HTML. Take
care of a few we missed.
Signed-off-by: Markus Armbruster
---
qapi/dump.json | 2 +-
qapi/machine.json | 2 +-
qapi/migration.json | 4 ++--
qapi/misc
Enclose command and type names in `backquotes`, so they become links
in generated HTML.
We did this for qapi/ in merge commit 504632dcc631.
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 80 ++--
1 file changed, 40 insertions(+), 40
tion about route of network.
Return:
[GuestNetworkRoute] -- List of route info of guest.
Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
Signed-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
qga/qapi-schema.json | 1 +
1 file
ned-off-by: Markus Armbruster
Reviewed-by: Daniel P. Berrangé
---
qga/qapi-schema.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index a9cc9150dc..6c26ace3c9 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -53
This series touches only doc comments. I'd like to get it into 10.1.
v2:
* PATCH 4: More cross-references [Daniel]
Markus Armbruster (4):
qga: Fix guest-network-get-route return value documentation
qga: Remove trivial "Returns:" sections
qga: Rephrase return docs to avoid
iously
no worse. For instance, guest-info's documentation changes from
Return:
GuestAgentInfo -- GuestAgentInfo
to
Return:
GuestAgentInfo
The auto-generated returns all are in the exact same spot.
We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial
"Ret
Daniel P. Berrangé writes:
> On Thu, Jul 17, 2025 at 10:21:17AM +0200, Markus Armbruster wrote:
>> Enclose command and type names in `backquotes`, so they become links
>> in generated HTML.
>>
>> We did this for qapi/ in merge commit 504632dcc631.
>>
&g
ned-off-by: Markus Armbruster
---
qga/qapi-schema.json | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index a9cc9150dc..6c26ace3c9 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -534,8 +534,7 @@
# discarded. T
tion about route of network.
Return:
[GuestNetworkRoute] -- List of route info of guest.
Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 1 +
1 file changed, 1 insertion(+)
diff --git a/qg
This series touches only doc comments. I'd like to get it into 10.1.
Markus Armbruster (4):
qga: Fix guest-network-get-route return value documentation
qga: Remove trivial "Returns:" sections
qga: Rephrase return docs to avoid type name
qga: Add cross-references
qga/q
iously
no worse. For instance, guest-info's documentation changes from
Return:
GuestAgentInfo -- GuestAgentInfo
to
Return:
GuestAgentInfo
The auto-generated returns all are in the exact same spot.
We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial
"Ret
Enclose command and type names in `backquotes`, so they become links
in generated HTML.
We did this for qapi/ in merge commit 504632dcc631.
Signed-off-by: Markus Armbruster
---
qga/qapi-schema.json | 50 ++--
1 file changed, 25 insertions(+), 25
Brian Song writes:
> This work provides an initial implementation of fuse-over-io_uring
> support for QEMU export. According to the fuse-over-io_uring protocol
> specification, the userspace side must create the same number of queues
> as the number of CPUs (nr_cpu), just like the kernel. Current
The following changes since commit f96b157ebb93f94cd56ebbc99bc20982b8fd86ef:
Merge tag 'accel-20250715' of https://github.com/philmd/qemu into staging
(2025-07-16 07:13:40 -0400)
are available in the Git repository at:
https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2025-07-16
for you to
ed if they
are present and functional. The version used for building docs on
readthedocs is pinned to the recommended version, 6.2.1.)
Signed-off-by: Akihiko Odaki
Tested-by: Markus Armbruster
Reviewed-by: John Snow
Signed-off-by: John Snow
Message-ID: <20250715212848.171879-2-js...@redhat.
From: Steve Sistare
Use qom-list-get to speed up the qom-tree command.
Signed-off-by: Steve Sistare
Acked-by: Markus Armbruster
Message-ID: <1752248703-217318-3-git-send-email-steven.sist...@oracle.com>
Tested-by: Markus Armbruster
[Lint picked off to mollify make check-minreqs]
Sign
From: Akihiko Odaki
Add docs/requirements.txt to
"Sphinx documentation configuration and build machinery".
Signed-off-by: Akihiko Odaki
Signed-off-by: John Snow
Message-ID: <20250715212848.171879-3-js...@redhat.com>
Reviewed-by: Thomas Huth
Signed-off-by: Markus Armbruster
From: Steve Sistare
Add a unit test for qom-list-get.
Signed-off-by: Steve Sistare
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-4-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
tests/qtest/qom-test.c
--- 80.9.0 8.2.3
pkgsrc_current 3.12.11 25.1.1 80.9.0 8.2.3
Signed-off-by: John Snow
Message-ID: <20250715222548.19-1-js...@redhat.com>
Tested-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
python/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2
ed-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Message-ID: <1752248703-217318-2-git-send-email-steven.sist...@oracle.com>
Signed-off-by: Markus Armbruster
---
qapi/qom.json | 50 +++
qom/qom-qmp-
Queued for 10.1. Thanks!
John Snow writes:
> On Wed, Jul 16, 2025, 11:04 AM Markus Armbruster wrote:
>
>> Okay to include this in my next QAPI PR?
>>
>
> That would be very convenient, thank you!
>
> (And thanks to Akihiko Odaki for spotting and fixing the issue, even if it
> took me a
t;
> Until that time, we can make use of a transitional feature in
> pip/setuptools to use "legacy" editable installs, which is enough to fix
> "make check-dev" on modern local workstations for now.
This fixes "make check-dev" for me on Fedora 41. Thank you!
Tested-by: Markus Armbruster
[...]
Okay to include this in my next QAPI PR?
Daniel P. Berrangé writes:
> On Wed, Jul 16, 2025 at 12:41:31PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Tue, Jul 15, 2025 at 10:35:16AM +0200, Philippe Mathieu-Daudé wrote:
>> >> @errp is always NULL. Remove it, as unused.
Daniel P. Berrangé writes:
> On Tue, Jul 15, 2025 at 10:35:17AM +0200, Philippe Mathieu-Daudé wrote:
>> @errp is always NULL. Remove it, as unused.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/system/os-win32.h | 2 +-
>> util/aio-win32.c | 2 +-
>> util/oslib-win32
Daniel P. Berrangé writes:
> On Tue, Jul 15, 2025 at 10:35:16AM +0200, Philippe Mathieu-Daudé wrote:
>> @errp is always NULL. Remove it, as unused.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/system/os-win32.h | 2 +-
>> io/channel-socket.c | 4 ++--
>> util/oslib-win32
John Snow writes:
> On Fri, Jul 11, 2025, 10:47 AM Markus Armbruster wrote:
[...]
>> Exception ignored in: > 0x7fcfcd080d60>
>> Traceback (most recent call last):
>> File "/work/armbru/qemu/scripts/qmp/../../python/qemu/qmp/legacy.py",
>> line 31
Philippe Mathieu-Daudé writes:
> Hi Markus,
I missed this one, sorry!
> On 3/7/25 12:54, Philippe Mathieu-Daudé wrote:
>> Extract TCG and KVM definitions from machine.json to accelerator.json.
>> Signed-off-by: Philippe Mathieu-Daudé
>> Reviewed-by: Pierrick Bouvier
>> Reviewed-by: Zhao Liu
oss-references to sockets.json
qapi: add cross-references to ui.json
qapi: add cross-references to virtio.json
qapi: add cross-references to yank.json
qapi: add cross-references to misc modules
Markus Armbruster (2):
qapi: Clean up "This command will do ..." com
Stefan Hajnoczi writes:
> On Mon, Jul 14, 2025 at 11:14 AM Markus Armbruster wrote:
>>
>> The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
>>
>> Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into
>> st
tput. This is a bug fix.
Signed-off-by: John Snow
Message-ID: <20250618165353.1980365-4-js...@redhat.com>
Acked-by: Markus Armbruster
Fixes: b61a4eb3f32 (docs/qapidoc: support header-less freeform sections)
[Tweak commit message to say it's a bug fix, add Fixes:]
Signed-off-by: Ma
as
invalid QAPI doc section heading in free-form comments.
Signed-off-by: John Snow
Message-ID: <20250618165353.1980365-5-js...@redhat.com>
Reviewed-by: Markus Armbruster
[Add more detail to commit message]
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.
1 - 100 of 12222 matches
Mail list logo
