Hey,
Here's one for the calendar - a 2 day track at FOSDEM devoted to Open
Source Virtualization and Cloud.
Hope to see you there! :)
Cheers,
Mark.
Forwarded Message
> From: Thierry Carrez
> To: openst...@lists.launchpad.net
> Subject: [Openstack] OpenStack at FOSDEM
> Date:
rge them himself), there's plenty of time.
>
> > Or who should initially receive related patches now?
> >
> > Jan
>
> I think running ./scripts/get_maintainer.pl is generally
> a good idea. For net you'd get:
>
> [qemu]$ ./scripts/get_maintainer.pl -f net.c net/
> Anthony Liguori (maintainer:Network device
> layer,commit_signer:4/16=25%)
> Mark McLoughlin (maintainer:Network device layer)
This is clearly out of date - feel free to remove it
Cheers,
Mark.
lients() checks only VLAN clients, fix
> net: info network shows only VLAN clients, fix
> net: Monitor command set_link finds only VLAN clients, fix
Nice. They all look good to me
Acked-by: Mark McLoughlin
Cheers,
Mark.
On Mon, 2009-12-14 at 15:10 +, Daniel P. Berrange wrote:
> The model I had in mind was for the proxy to define a VNC extension that
> allows the client to query what 'desktops' are available and request
> switching between them at any time. The list of desktop would of course
> be authorized p
On Fri, 2009-12-11 at 13:38 -0600, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > On Fri, 2009-12-11 at 13:04 -0600, Anthony Liguori wrote:
> >
> >> But to introduce another protocol where a user has to make a choice to
> >> use Spice over VNC, I think we
On Fri, 2009-12-11 at 13:04 -0600, Anthony Liguori wrote:
> But to introduce another protocol where a user has to make a choice to
> use Spice over VNC, I think we need a really good justification for
> that. It's really about complexity. A user shouldn't have to know
> about Spice or VNC. Th
Hi Dave,
On Fri, 2009-12-11 at 14:59 +1000, Dave Airlie wrote:
> Hi guys,
>
> Building 0.11.0, qemu -vga vmware -sdl works fine.
> with git I just get a blank screen.
>
> I'm trying to bisect but I keep running into a big chunk of NIC changes
> where none of the drivers compile, so I thought may
the long run.
>
> Signed-off-by: Arnd Bergmann
Looks fine to me
Acked-by: Mark McLoughlin
Cheers,
Mark.
On Wed, 2009-11-25 at 20:36 +, Blue Swirl wrote:
> On Wed, Nov 25, 2009 at 6:49 PM, Mark McLoughlin wrote:
> > A replacement for qemu_new_vlan_client(), using NetClientInfo to
> > replace most arguments.
>
> > +VLANClientState *qemu_new_net_cl
Signed-off-by: Mark McLoughlin
---
hw/stellaris_enet.c | 34 +++---
1 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c
index 2252f1a..d1d755e 100644
--- a/hw/stellaris_enet.c
+++ b/hw/stellaris_enet.c
@@ -66,7
Print an error if the user specifies vnet_hdr=1 on the cmdline.
Signed-off-by: Mark McLoughlin
---
net/tap-solaris.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/net/tap-solaris.c b/net/tap-solaris.c
index ef4e60c..e14fe36 100644
--- a/net/tap-solaris.c
Signed-off-by: Mark McLoughlin
---
hw/musicpal.c | 31 ++-
1 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/hw/musicpal.c b/hw/musicpal.c
index 264669f..4a33e28 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -151,7 +151,7 @@ typedef struct
Signed-off-by: Mark McLoughlin
---
net/dump.c | 47 +++
1 files changed, 27 insertions(+), 20 deletions(-)
diff --git a/net/dump.c b/net/dump.c
index 05a102b..4ed3f5f 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -28,7 +28,7 @@
#include "qemu-
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c | 41 +
1 files changed, 25 insertions(+), 16 deletions(-)
diff --git a/hw/dp8393x.c b/hw/dp8393x.c
index 5143cc8..be9714d 100644
--- a/hw/dp8393x.c
+++ b/hw/dp8393x.c
@@ -154,7 +154,8 @@ typedef struct
This structure holds data which is common to all instances of a given
net client type/model.
Signed-off-by: Mark McLoughlin
---
net.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/net.h b/net.h
index 9ffcfe3..56c5849 100644
--- a/net.h
+++ b/net.h
@@ -42,6
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c | 73 +-
1 files changed, 39 insertions(+), 34 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 2f147e5..4f8d89e 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -31,7
Signed-off-by: Mark McLoughlin
---
net/socket.c | 74 +++--
1 files changed, 45 insertions(+), 29 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 551fc2b..7331d87 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -33,7 +33,7
Signed-off-by: Mark McLoughlin
---
hw/rtl8139.c | 43 ---
1 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index c166db0..931cde9 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -459,7 +459,7 @@ typedef struct
Signed-off-by: Mark McLoughlin
---
hw/e1000.c | 47 ++-
1 files changed, 26 insertions(+), 21 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 00f6a57..683fdcc 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -75,7 +75,7 @@ enum {
typedef
Signed-off-by: Mark McLoughlin
---
hw/smc91c111.c | 35 ---
1 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/hw/smc91c111.c b/hw/smc91c111.c
index b7398c9..c1a88c9 100644
--- a/hw/smc91c111.c
+++ b/hw/smc91c111.c
@@ -18,7 +18,7 @@
typedef
Signed-off-by: Mark McLoughlin
---
hw/eepro100.c | 43 ---
1 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index 8734907..eb16a51 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -195,7 +195,7 @@ typedef
Add a NetClientInfo pointer to VLANClientState and use that
for the typecode and function pointers.
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c|4 ++--
hw/virtio-net.c |2 +-
net.c | 45 -
net.h | 10
Signed-off-by: Mark McLoughlin
---
hw/mcf_fec.c | 58 +-
1 files changed, 33 insertions(+), 25 deletions(-)
diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
index 8242c8a..4e7fbed 100644
--- a/hw/mcf_fec.c
+++ b/hw/mcf_fec.c
@@ -25,7 +25,8 @@ do
From: Pierre Riteau
This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message
on kernels without TUNSETOFFLOAD support.
Signed-off-by: Pierre Riteau
Signed-off-by: Mark McLoughlin
---
net/tap-linux.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
di
Signed-off-by: Mark McLoughlin
---
hw/etraxfs_eth.c | 45 +++--
1 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c
index 2cc2332..dedd107 100644
--- a/hw/etraxfs_eth.c
+++ b/hw/etraxfs_eth.c
@@ -319,7
net_tap_init() always sets vnet_hdr using qemu_opt_get_bool(), but
initialize it in net_init_tap() just to reduce confusion.
Signed-off-by: Mark McLoughlin
---
net/tap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index a327a9a..0d8b424 100644
Signed-off-by: Mark McLoughlin
---
hw/usb-net.c | 57 +++--
1 files changed, 31 insertions(+), 26 deletions(-)
diff --git a/hw/usb-net.c b/hw/usb-net.c
index 7b8cc7a..2556e05 100644
--- a/hw/usb-net.c
+++ b/hw/usb-net.c
@@ -610,7 +610,6
Reported-by: Markus Armbruster
Signed-off-by: Mark McLoughlin
---
net.c | 16 +++-
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/net.c b/net.c
index c71699d..13bdbb2 100644
--- a/net.c
+++ b/net.c
@@ -1055,12 +1055,18 @@ int net_client_init(Monitor *mon, QemuOpts
Signed-off-by: Mark McLoughlin
---
net.c | 20
net.h |2 ++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/net.c b/net.c
index a1ec243..c71699d 100644
--- a/net.c
+++ b/net.c
@@ -326,6 +326,26 @@ qemu_find_vlan_client_by_name(Monitor *mon, int vlan_id
... and VLANClientState::opaque and qemu_find_vlan_client().
All of these are now unused
Signed-off-by: Mark McLoughlin
---
net.c | 44
net.h | 13 -
2 files changed, 0 insertions(+), 57 deletions(-)
diff --git a/net.c b/net.c
index
Signed-off-by: Mark McLoughlin
---
hw/xilinx_ethlite.c | 35 ---
1 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c
index b7129d5..37e33ec 100644
--- a/hw/xilinx_ethlite.c
+++ b/hw/xilinx_ethlite.c
@@ -51,7
Signed-off-by: Mark McLoughlin
---
net/vde.c | 45 -
1 files changed, 28 insertions(+), 17 deletions(-)
diff --git a/net/vde.c b/net/vde.c
index 4d09967..42b4633 100644
--- a/net/vde.c
+++ b/net/vde.c
@@ -34,7 +34,7 @@
#include "sys
From: Pierre Riteau
vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
the kernel doesn't support IFF_VNET_HDR.
Signed-off-by: Pierre Riteau
Signed-off-by: Mark McLoughlin
---
net/tap-linux.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ne
Now that we have a way to iterate NICs.
Signed-off-by: Mark McLoughlin
---
savevm.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/savevm.c b/savevm.c
index 4668843..3cfc5aa 100644
--- a/savevm.c
+++ b/savevm.c
@@ -123,24 +123,24 @@ static
Signed-off-by: Mark McLoughlin
---
hw/lan9118.c | 45 +
1 files changed, 25 insertions(+), 20 deletions(-)
diff --git a/hw/lan9118.c b/hw/lan9118.c
index 6394f3a..ba982d1 100644
--- a/hw/lan9118.c
+++ b/hw/lan9118.c
@@ -137,7 +137,7 @@ typedef
Signed-off-by: Mark McLoughlin
---
net/slirp.c | 61 +++---
1 files changed, 37 insertions(+), 24 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index d6d5772..3f91c4b 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -64,8 +64,8 @@ struct
This is probably a little drastic, but the includes in this file are
now totally out of control when compared with what includes are
actually needed.
This may break the build on e.g. *BSD, but it will be easily fixed by
re-instating an include.
Signed-off-by: Mark McLoughlin
---
net.c | 74
Was used by hot-unplug, but not anymore.
Signed-off-by: Mark McLoughlin
---
net.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net.h b/net.h
index bc8392b..9ffcfe3 100644
--- a/net.h
+++ b/net.h
@@ -124,7 +124,6 @@ struct NICInfo {
char *devaddr;
VLANState
Signed-off-by: Mark McLoughlin
---
hw/ne2000-isa.c | 22 ++
hw/ne2000.c | 35 +--
hw/ne2000.h |2 +-
3 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c
index 729e8e2..0260f84
Signed-off-by: Mark McLoughlin
---
net/tap-win32.c | 39 +++
1 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/net/tap-win32.c b/net/tap-win32.c
index ea66471..ef63782 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -630,25 +630,24
Signed-off-by: Mark McLoughlin
---
hw/lance.c | 14 +++---
hw/pcnet.c | 43 +++
hw/pcnet.h |7 ---
3 files changed, 38 insertions(+), 26 deletions(-)
diff --git a/hw/lance.c b/hw/lance.c
index 0a96644..98033a4 100644
--- a/hw/lance.c
Signed-off-by: Mark McLoughlin
---
hw/xen_nic.c | 46 +-
1 files changed, 29 insertions(+), 17 deletions(-)
diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index bcf161c..08055b8 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -41,6 +41,7 @@
#include
Signed-off-by: Mark McLoughlin
---
Makefile |2 +-
net.c | 35 ++-
net/util.c | 60
net/util.h | 32
4 files changed, 95 insertions(+), 34 deletions
Signed-off-by: Mark McLoughlin
---
hw/mipsnet.c | 45 +++--
1 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/mipsnet.c b/hw/mipsnet.c
index 67160a4..a066f63 100644
--- a/hw/mipsnet.c
+++ b/hw/mipsnet.c
@@ -35,7 +35,8 @@ typedef struct
Signed-off-by: Mark McLoughlin
---
net/tap.c | 82 +---
1 files changed, 45 insertions(+), 37 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index b2e5908..d34feec 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -47,7 +47,7 @@
#define
Nothing qdev specific about this, make it available throughtout.
Signed-off-by: Mark McLoughlin
---
hw/qdev.h | 10 --
osdep.h | 10 ++
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/qdev.h b/hw/qdev.h
index 41642ee..8d53754 100644
--- a/hw/qdev.h
Common state for all NICs.
The opaque member will replace the opaque member in VLANClientState
since only NICs need it.
The conf member will allow us to iterate over NICs, access the MAC
addr for the NIC and send a packet from each NIC in qemu_announce_self().
Signed-off-by: Mark McLoughlin
A replacement for qemu_new_vlan_client(), using NetClientInfo to
replace most arguments.
Signed-off-by: Mark McLoughlin
---
net.c | 70 +---
net.h |5
2 files changed, 54 insertions(+), 21 deletions(-)
diff --git a/net.c b
Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c | 10 +-
hw/etraxfs_eth.c | 10 +-
hw/mcf_fec.c | 10 +-
hw/mipsnet.c | 10 +-
hw/usb-net.c
Signed-off-by: Mark McLoughlin
---
Makefile|1 +
monitor.c |1 +
net.c | 718 +---
net.h |8 +-
net/slirp.c | 752 +++
net/slirp.h | 51
vl.c
Signed-off-by: Mark McLoughlin
---
Makefile |1 +
net.c | 127 +--
net/dump.c | 151
net/dump.h | 33 +
4 files changed, 186 insertions(+), 126 deletions
Signed-off-by: Mark McLoughlin
---
Makefile |1 +
net.c | 102 +-
net/vde.c | 124 +
net/vde.h | 36 ++
4 files changed, 162 insertions(+), 101 deletions
Hi,
Here's a new series of patches mainly to fix qemu_announce_self()
with -netdev as discussed earlier on the list.
I would have liked to have split the series in three, but there
would be conflicts between each, so here goes:
1) Patches 01 to 05 - net.c cleanups
These p
Signed-off-by: Mark McLoughlin
---
Makefile |1 +
net.c| 530 +--
net/socket.c | 561 ++
net/socket.h | 33
4 files changed, 596 insertions(+), 529 deletions
On Wed, 2009-11-25 at 11:04 +0100, Pierre Riteau wrote:
> This avoids the "TUNSETOFFLOAD ioctl() failed: Invalid argument" message
> on kernels without TUNSETOFFLOAD support.
>
> Signed-off-by: Pierre Riteau
Acked-by: Mark McLoughlin
Thanks,
Mark.
> ---
> net/t
On Tue, 2009-11-24 at 22:27 +0100, Pierre Riteau wrote:
> On 24 nov. 2009, at 12:22, Mark McLoughlin wrote:
>
> > On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote:
> >> Isn't there a way to detect whether the kernel supports the
> >> TUNSETOFFLOAD ioctl a
On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote:
> On 24 nov. 2009, at 11:28, Mark McLoughlin wrote:
>
> > On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
> >> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
> >> the kerne
On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
> the kernel doesn't support IFF_VNET_HDR.
>
> Signed-off-by: Pierre Riteau
Thanks Pierre, I see why this is needed now
Acked-by: Mark McLoughlin
Cheers,
Mark.
u?
Thanks,
Mark.
From: Mark McLoughlin
Subject: [PATCH] net: initialize vnet_hdr in net_tap_init()
Don't assume that all tap_open() implementations will set it to
zero if VNET_HDR support isn't found.
Fixes tap networking on host kernels lacking IFF_VNET_HDR support.
Reported-by: Pi
460fec67ee introduced a use-after free in slirp.
Cc: Jan Kiszka
Signed-off-by: Mark McLoughlin
---
Untested fix, but it's obvious.
Also, this is needed on stable-0.11.
slirp/mbuf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mbuf.c
Hi Gerd,
Thanks for looking, you're absolutely right that this approach just
isn't right with e.g. -device
On Mon, 2009-11-16 at 10:28 +0100, Gerd Hoffmann wrote:
> On 11/12/09 21:29, Mark McLoughlin wrote:
> > No doubt this is the worst idea ever, but the requirement is simpl
On Thu, 2009-11-12 at 20:29 +, Mark McLoughlin wrote:
...
> +printf("qemu_announce_self_iter() mac = %p\n", mac);
> +
> +len = announce_self_create(buf, mac);
> +
> +printf("sending packet from %s\n", client->name);
Ooops, some debugging
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c| 10 +-
hw/e1000.c | 10 +-
hw/eepro100.c | 10 +-
hw/etraxfs_eth.c| 11 +--
hw/mcf_fec.c| 10 +-
hw/mipsnet.c| 15 ++-
hw/musicpal.c
No valid users left except the announce_self() code which currently
crashes when used with -netdev.
Note the assertion in the xen code. Need to figure out how to support
the -netdev arg with xen.
Signed-off-by: Mark McLoughlin
---
hw/integratorcp.c|3 +-
hw/mcf5208.c |3
vlan.
Another advantage is that we can easily get the client associated with
a qdev.
Signed-off-by: Mark McLoughlin
---
hw/qdev-properties.c | 25 +
hw/qdev.h|5 +
net.h|8 +---
3 files changed, 35 insertions(+), 3 deletions(-
Now that we have a sane way of iterating over NICs.
Signed-off-by: Mark McLoughlin
---
savevm.c | 43 ++-
1 files changed, 26 insertions(+), 17 deletions(-)
diff --git a/savevm.c b/savevm.c
index 039740c..3736588 100644
--- a/savevm.c
+++ b/savevm.c
Hi,
The recent "fix" to qemu_announce_self() will segfault if you use
-netdev. The real root cause of the regression was the removal of the
assignment to NICInfo::vc that used to live in qdev_get_vlan_client().
Now that NICs are qdev-ified, we should just iterate over the
qdev tre
Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.
Signed-off-by: Mark McLoughlin
---
hw/dp8393x.c | 10 +-
hw/etraxfs_eth.c | 10 +-
hw/mcf_fec.c | 10 +-
hw/mipsnet.c | 10 +-
hw/usb-net.c
Probably the second worst idea in the world, ever.
While iterating over all NICs in the system, we need to be
able to query their 'net-client' and 'macaddr' properties.
Signed-off-by: Mark McLoughlin
---
hw/qdev-properties.c | 31 ---
hw/qdev
No doubt this is the worst idea ever, but the requirement is simple -
some way to iterate all NICs in the system.
Signed-off-by: Mark McLoughlin
---
hw/qdev.c | 20
hw/qdev.h |3 +++
2 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
On Thu, 2009-11-12 at 03:31 +, Armin Garcia wrote:
> I have the next problem I configure the tun/tap and all great any error,
> I have an IP from my dhcp, I can see my virtual machine (winxp) from my
> other computers, but In my virtual machine I cant connect to internet,
> I mean, whe
On Tue, 2009-11-10 at 18:03 +0100, Juan Quintela wrote:
> Mark McLoughlin wrote:
> > On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote:
> >> commit b04c4134d6de28c249277de19e523bfbe4aebbd6
> >> broke incoming migration. After talking with Gleb, code was intend
On Fri, 2009-11-06 at 15:58 +0100, Juan Quintela wrote:
> commit b04c4134d6de28c249277de19e523bfbe4aebbd6
> broke incoming migration. After talking with Gleb, code was intended
> to be the way is in this fix. This fixes migration here.
Tried to reproduce and it works fine for me. More details?
On Tue, 2009-11-10 at 15:44 +, Paul Brook wrote:
> On Thursday 08 October 2009, Mark McLoughlin wrote:
> > Hi,
> > Here's a series of patches which gets the ball rolling on adding
> > a -netdev option.
> >...
> > The idea is to de-emphas
Hey,
Just a heads up - on 32 bit hosts where qemu was using preadv and
pwritev, we were seeing data corruption due to file offset being
truncated:
https://bugzilla.redhat.com/533063
https://bugzilla.redhat.com/526549
The glibc headers fix is posted here:
http://sources.redh
On Fri, 2009-10-30 at 16:15 -0500, Dustin Kirkland wrote:
> On Thu, Oct 29, 2009 at 10:34 AM, Dustin Kirkland
> wrote:
> > whitelist host virtio networking features
> >
> > This patch is a followup to 8eca6b1bc770982595db2f7207c65051572436cb,
> > fixing crashes when guests with 2.6.25 virtio drive
Hi,
On Fri, 2009-10-30 at 11:04 +0100, juha.riihim...@nokia.com wrote:
> On Oct 22, 2009, at 19:43, ext Mark McLoughlin wrote:
>
> > Hey,
> >Over a year ago we added some code to qemu-kvm.git which takes
> > advantage of the recent tun/tap IFF_VNET_HDR f
On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Okay, let's try re-enabling the drain-entire-queue behaviour, with a
> > difference - before each subsequent packet, use qemu_can_send_packet()
> > to check that we can send it. This
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 15:01 +0000, Mark McLoughlin wrote:
> > Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct
>
> Brilliant!
>
> Works like a champ. I'll send a patch in a subsequent email. Would
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote:
> > Ah, it all makes sense now.
> >
> > I was getting confused between HOST_* and GUEST_*
> >
> > this should have been:
> >
>
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote:
> On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote:
> > In the mean time, Hardy's kernel is in git here:
> >
> > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary
>
> I'll save you a few clicks...
>
> http://kernel.
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote:
> >
> >> Mark McLoughlin wrote:
> >>
> >>>> tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn:
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> >
> >>tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1)
> >> being called and get an mtu of 1500 on virbr0 using his birdge.sh script.
> >>
> >> virtio_net_recei
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote:
> Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009:
> > Assuming this is something like the virtio-net in 2.6.26, there was no
> > receivable buffers support so (as Scott points out) it must be that
> > we've read a packe
Hi Dustin,
On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote:
> I believe that we have identified a regression in qemu-kvm-0.11.0.
Regression versus which previous version of qemu-kvm?
> The kvm process crashes for older guests with virtio networking, when
> the guest's incoming network c
On Wed, 2009-10-28 at 10:26 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Hi Anthony,
> > Thanks for merging this stuff ...
> >
> > In the process of merging it all into qemu-kvm, I noticed a couple of
> > problems:
> >
> > 1) bb6
Hi Anthony,
Thanks for merging this stuff ...
In the process of merging it all into qemu-kvm, I noticed a couple of
problems:
1) bb6e63644 lacked the change to add the type code to
qemu_new_vlan_client() so that and the subsequent 14 commits are
unbuildable
2) 93d
.
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 93294af..4b09a93 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -837,6 +837,7 @@ VirtIODevice *virtio_net_init(DeviceState *dev
On Wed, 2009-10-28 at 11:36 +0800, Scott Tsai wrote:
> > Scott, Sven, if you could test the tap-drain-queue branch from
> > my tree, that would be great:
> > http://repo.or.cz/w/qemu/markmc.git
> >
> > Thanks,
> > Mark.
>
> Mark,
> I've tested http://repo.or.cz/w/qemu/markmc.git and it
time.
Reported-by: Scott Tsai
Tested-by: Sven Rudolph
Signed-off-by: Mark McLoughlin
---
net.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/net.c b/net.c
index 3d3829d..7466961 100644
--- a/net.c
+++ b/net.c
@@ -1378,17 +1378,15 @@ static void tap_se
ceive(), but instead just allow
receive() to return zero when this condition occurs and have the caller
handle queueing the packet.
Signed-off-by: Mark McLoughlin
---
hw/virtio-net.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/hw/virtio-net.c b/h
le it.
This patch should be a performance improvement since we no longer have
to go through the mainloop for each packet.
Signed-off-by: Mark McLoughlin
---
net/tap.c | 33 ++---
1 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/net/tap.c b/net/tap.c
buffer space is available.
Signed-off-by: Mark McLoughlin
---
net.c | 49 ++---
net.h |1 +
2 files changed, 39 insertions(+), 11 deletions(-)
diff --git a/net.c b/net.c
index 661bbc1..9dea615 100644
--- a/net.c
+++ b/net.c
@@ -423,11 +423,13
Hey,
Scott points out that the current behaviour of draining the
entire queue in tap_send() doesn't work with non-virtio NICs because
we drop a packet when the NIC queue fills up.
This series of patches first disables this behaviour, fixes
various aspects of the queueing logic and
time.
Reported-by: Scott Tsai
Tested-by: Sven Rudolph
Signed-off-by: Mark McLoughlin
---
net/tap.c | 33 +++--
1 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index 60354e4..f32226b 100644
--- a/net/tap.c
+++ b/net/tap.c
@@
Now that we disable any receiver whose queue is full, we do not require
senders to handle a zero return by supplying a sent callback.
This is a second step towards allowing can_receive() handlers to return
true even if no buffer space is available.
Signed-off-by: Mark McLoughlin
---
net
[v2: handle building in a separate dir]
Signed-off-by: Mark McLoughlin
---
Makefile | 10 +++---
configure |2 +-
net.h |2 +-
net-queue.c => net/queue.c |2 +-
net-queue.h => net/queue.h |0
5 files chang
On Fri, 2009-10-23 at 08:44 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > On Thu, 2009-10-22 at 15:34 -0500, Anthony Liguori wrote:
> >
> >> This series doesn't build for me. I get dependency errors even after a
> >> full rebuild. I
On Fri, 2009-10-23 at 20:25 +0400, Michael Tokarev wrote:
> I've two questions:
>
> o what's the intended usage of all-vlan-equal case, when kvm (or qemu)
>reflects packets from one interface to another? It's what bridge
>in linux is for, I think.
I don't think it's necessarily an intend
On Fri, 2009-10-23 at 17:41 +0400, malc wrote:
> On Fri, 23 Oct 2009, malc wrote:
>
> > On Fri, 23 Oct 2009, Mark McLoughlin wrote:
> >
> > > Hi,
> > >
> > > Any ideas on this segfault a Fedora 12 user (Gene, cc-ed) is seeing?
>
> [..s
1 - 100 of 164 matches
Mail list logo
