[PATCH] util/qemu-error: prepend guest name to error message to identify affected VM owner

2020-06-26 Thread Mario Smarduch
having the guest name enables identify of owner and customer. Signed-off-by: Mario Smarduch --- Test verification summary: a) qemu-system-x86_64 -msg help guest-name= - Prepends guest name for error messages but only if -name is set otherwise option is ignored timestamp= b) qemu-system-x86_64

Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread Mario Smarduch
On 10/09/2019 02:19 PM, Paolo Bonzini wrote: > On 09/10/19 18:44, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >> - if VM crashes on AR mce

[PATCHv2 2/2] target/i386: log MCE guest and host addresses

2019-10-09 Thread Mario Smarduch
3d6f5000 addr of type BUS_MCEERR_AR injected qemu-system-x86_64 amsNams3node The first log had a corresponding mce log entry, the second didnt (logging thresholds) we can infer from second entry same PA and mce type. Signed-off-by: Mario Smarduch --- target/i386/kvm.c | 29

[PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-09 Thread Mario Smarduch
Signed-off-by: Mario Smarduch --- include/qemu/error-report.h | 1 + qemu-options.hx | 10 ++ util/qemu-error.c | 31 +++ vl.c| 5 + 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/include/qemu

[PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs

2019-10-09 Thread Mario Smarduch
type BUS_MCEERR_AR injected with enterprise logging environment we can to take further actions. v1 -> v2: - split into two patches one to get the gustname second to log MCEs - addressed comments for MCE logging Mario Smarduch (2): util/qemu-error: add guest name helper with -msg opti

Re: [PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-07 Thread Mario Smarduch
On 10/07/2019 03:27 AM, Philippe Mathieu-Daudé wrote: > Hi Mario, > > On 10/5/19 1:53 AM, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >&g

Re: [PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-06 Thread Mario Smarduch
On 10/06/2019 09:11 AM, Paolo Bonzini wrote: > On 05/10/19 01:53, Mario Smarduch wrote: >> Guest [Droplet-12345678] 2019-08-02T05:00:11.940270Z qemu-system-x86_64: >> Guest MCE Memory Error at qemu addr 0x7f3c7622f000 and guest 78e42f000 >> addr of type BUS_MCEERR_A

[PATCH] target/i386: log guest name and memory error type AO, AR for MCEs

2019-10-04 Thread Mario Smarduch
type BUS_MCEERR_AR injected with enterprise logging environment we can to take further actions. Signed-off-by: Mario Smarduch --- target/i386/kvm.c | 27 ++- util/qemu-error.c | 24 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-26 Thread Mario Smarduch
On 05/25/2015 10:11 AM, Andrew Jones wrote: > On Fri, May 22, 2015 at 06:08:30PM -0700, Mario Smarduch wrote: >> On 05/18/2015 08:53 AM, Catalin Marinas wrote: >>> On Thu, May 14, 2015 at 02:46:44PM +0100, Andrew Jones wrote: >>>> On Thu, May 14, 2015 at 01:05:09PM

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-22 Thread Mario Smarduch
On 05/18/2015 08:53 AM, Catalin Marinas wrote: > On Thu, May 14, 2015 at 02:46:44PM +0100, Andrew Jones wrote: >> On Thu, May 14, 2015 at 01:05:09PM +0200, Christoffer Dall wrote: >>> On Wed, May 13, 2015 at 01:31:52PM +0200, Andrew Jones wrote: Provide a method to change normal, cacheable mem

Re: [Qemu-devel] [RFC/RFT PATCH v2 3/3] arm/arm64: KVM: implement 'uncached' mem coherency

2015-05-20 Thread Mario Smarduch
On 05/15/2015 10:04 AM, Andrew Jones wrote: > On Fri, May 15, 2015 at 08:02:59AM -0700, Christoffer Dall wrote: >> On Thu, May 14, 2015 at 03:32:13PM +0200, Andrew Jones wrote: >>> On Thu, May 14, 2015 at 12:55:49PM +0200, Christoffer Dall wrote: On Wed, May 13, 2015 at 01:31:54PM +0200, Andre

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix return check for KVM_GET_DIRTY_LOG ioctl

2014-03-20 Thread Mario Smarduch
you may see issues like that. - Mario On 03/20/2014 08:45 AM, Michael Tokarev wrote: > 19.03.2014 21:24, Mario Smarduch wrote: >> >> Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to >> handle internal failures or no support for memory slot dirty

[Qemu-devel] [PATCH] fix return check for KVM_GET_DIRTY_LOG ioctl

2014-03-19 Thread Mario Smarduch
Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to handle internal failures or no support for memory slot dirty bitmap. Otherwise the ioctl succeeds and continues with migration. Addresses BUG# 1294227 Signed-off-by: Mario Smarduch --- kvm-all.c |2 +- 1 file cha

[Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2014-03-18 Thread Mario Smarduch
Public bug reported: In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1. Found during KVM-ARM migration which apperead to go through but was actually failing getting memslot dirty bitmap. static int kvm_physical_sync_dirty_bitmap()

Re: [Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-03-03 Thread Mario Smarduch
Mar 03, 2014 at 01:37:46PM +0100, Stefan Hajnoczi wrote: > On Fri, Feb 28, 2014 at 05:40:19PM -, Mario Smarduch wrote: > > When using indpendent transport and backend in this case virtio-net- > > device transport, none of the acceleration features are set after > > guest prob

[Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-02-28 Thread Mario Smarduch
Public bug reported: When using indpendent transport and backend in this case virtio-net- device transport, none of the acceleration features are set after guest probes the transport the backend is plugged into. For virtio-net this leads to low throughput/performance. This holds true for virtio-

Re: [Qemu-devel] [PATCH] virtio: set virtio-mmio transport features for various backends

2014-02-27 Thread Mario Smarduch
ow to handle. Thanks, Mario On 02/26/2014 05:22 PM, Mario Smarduch wrote: > virtio: set virtio-mmio transport features for various backends > > Hi Peter, i.e others - > > This is a second attempt at setting transport backend features, for > back-ends that are instan

[Qemu-devel] [PATCH] virtio: set virtio-mmio transport features for various backends

2014-02-26 Thread Mario Smarduch
with the back-end device when it's plugged in. Thanks, Mario. Signed-off-by: Mario Smarduch --- hw/virtio/virtio-bus.c |5 + hw/virtio/virtio-mmio.c| 46 include/hw/virtio/virtio-bus.h |4 3 files change

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
On 02/20/2014 02:47 PM, Peter Maydell wrote: > On 20 February 2014 22:36, Mario Smarduch wrote: >> On 02/20/2014 02:10 PM, Peter Maydell wrote: >>> On 20 February 2014 21:59, Mario Smarduch wrote: >>>> On 02/20/2014 11:35 AM, Peter Maydell wrote: >>>>&

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
On 02/20/2014 02:10 PM, Peter Maydell wrote: > On 20 February 2014 21:59, Mario Smarduch wrote: >> On 02/20/2014 11:35 AM, Peter Maydell wrote: >>> On 20 February 2014 19:09, Mario Smarduch wrote: >>>> host features since you don't know what virtio device will

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
On 02/20/2014 11:35 AM, Peter Maydell wrote: > On 20 February 2014 19:09, Mario Smarduch wrote: >> host features since you don't know what virtio device will be plugged >> in later. > > I think this function is the right place to set these properties, > yes. What I

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
fairly new to qemu community. - Mario On 02/20/2014 10:30 AM, Peter Maydell wrote: > On 20 February 2014 18:12, Mario Smarduch wrote: >> >> Hello, >> >> any feedback on this patch, after a brief email exchange Anthony deferred to >> Peter. >> >> Lack

Re: [Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-20 Thread Mario Smarduch
e of qemu, especially virtio stuff. - Mario On 02/14/2014 03:49 PM, Peter Maydell wrote: > CCing the virtio maintainers. > > thanks > -- PMM > > On 13 February 2014 21:13, Mario Smarduch wrote: >> virtio: set virtio-net/virtio-mmio host features >> >> Patch s

Re: [Qemu-devel] Make virtio-net.c ring size configurable?

2014-02-14 Thread Mario Smarduch
On 02/14/2014 05:43 AM, Luke Gorrie wrote: > Howdy! > > Observation: virtio-net.c hard-codes the vring size to 256 buffers. > > Could this reasonably be made configurable, or would that be likely to > cause a problem? > > In Snabb Switch we are creating a 1:1 mapping between Virtio-net > descrip

[Qemu-devel] [PATCH] virtio: set virtio-net/virtio-mmio host features

2014-02-13 Thread Mario Smarduch
virtio: set virtio-net/virtio-mmio host features Patch sets 'virtio-net/virtio-mmio' host features to enable network features based on peer capabilities. Currently host features turn of all features by default. Signed-off-by: Mario Smarduch --- hw/virtio/virtio-mmi

[Qemu-devel] [PATCH] set virtio-net/virtio-mmio host features to improve, performance

2014-02-12 Thread Mario Smarduch
ier but at the time 'virtio-mmio' is created the device to be plugged in is unknown. Signed-off-by: Mario Smarduch --- hw/virtio/virtio-mmio.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 882