[PATCH 1/1] MAINTAINERS: remove myself from sbsa-ref

2024-12-18 Thread Marcin Juszkiewicz
I am ending my time with Linaro and do not have plans to continue working on SBSA Reference Platform anymore. Signed-off-by: Marcin Juszkiewicz --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 822f34344b..776e0b997d 100644 --- a/MAINTAINERS

Re: [PATCH 1/1] tests/avocado: update sbsa-ref firmware

2024-12-16 Thread Marcin Juszkiewicz
W dniu 16.12.2024 o 13:46, Peter Maydell pisze: On Mon, 25 Nov 2024 at 13:25, Peter Maydell wrote: On Mon, 25 Nov 2024 at 12:54, Marcin Juszkiewicz wrote: Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0). Used versions: - Trusted Firmware v2.12.0 - Tian

Re: [PATCH 1/1] hw/arm/sbsa-ref: bump default memory size to 2GB

2024-12-05 Thread Marcin Juszkiewicz
W dniu 5.12.2024 o 15:53, Peter Maydell pisze: This is sbsa-ref not sbc-ref. Let it just have that 2GB of ram. None of existing SBSA systems comes with such low amount. Yes, I think I agree here. Changing the default RAM size based on whether the CPU does or does not have a particular feature

Re: [PATCH 1/1] hw/arm/sbsa-ref: bump default memory size to 2GB

2024-12-05 Thread Marcin Juszkiewicz
W dniu 4.12.2024 o 21:50, Philippe Mathieu-Daudé pisze: On 4/12/24 13:17, Leif Lindholm wrote: On 2024-12-02 10:53, Marcin Juszkiewicz wrote: W dniu 26.11.2024 o 14:14, Peter Maydell pisze: On Tue, 26 Nov 2024 at 08:49, Marcin Juszkiewicz wrote: We are working on adding RME support to SBSA

Re: [PATCH v2] tests/functional/aarch64: add tests for FEAT_RME

2024-12-02 Thread Marcin Juszkiewicz
W dniu 1.12.2024 o 19:09, Pierrick Bouvier pisze: Hi Marcin, On 12/1/24 05:34, Marcin Juszkiewicz wrote: So RME tests probably need longer timeouts or would not run at all. By any chance, are you running those tests in debug mode? zOMG, thanks! Turned out that I left "--enable-debu

Re: [PATCH 1/1] hw/arm/sbsa-ref: bump default memory size to 2GB

2024-12-02 Thread Marcin Juszkiewicz
W dniu 26.11.2024 o 14:14, Peter Maydell pisze: On Tue, 26 Nov 2024 at 08:49, Marcin Juszkiewicz wrote: We are working on adding RME support to SBSA Reference Platform. When RME is enabled then RMM (Realm Managment Monitor) takes 1072MB of memory for own use. Which ends with firmware panic on

Re: [PATCH v2] tests/functional/aarch64: add tests for FEAT_RME

2024-12-01 Thread Marcin Juszkiewicz
W dniu 28.11.2024 o 22:37, Pierrick Bouvier pisze: This boot an OP-TEE environment, and launch a nested guest VM inside it using the Realms feature. We do it for virt and sbsa-ref platforms. Signed-off-by: Pierrick Bouvier diff --git a/tests/functional/meson.build b/tests/functional/meson.bu

[PATCH 1/1] hw/arm/sbsa-ref: bump default memory size to 2GB

2024-11-26 Thread Marcin Juszkiewicz
We are working on adding RME support to SBSA Reference Platform. When RME is enabled then RMM (Realm Managment Monitor) takes 1072MB of memory for own use. Which ends with firmware panic on 1GB machine. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/1] tests/avocado: update sbsa-ref firmware

2024-11-25 Thread Marcin Juszkiewicz
Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0). Used versions: - Trusted Firmware v2.12.0 - Tianocore EDK2 stable202411 - Tianocore EDK2 Platforms code commit 4b3530d Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsar

Re: [PATCH 3/7] docs/devel: add b4 for patch retrieval

2024-11-19 Thread Marcin Juszkiewicz
W dniu 19.11.2024 o 11:07, Daniel P. Berrangé pisze: On Tue, Nov 19, 2024 at 10:56:36AM +0100, Marcin Juszkiewicz wrote: W dniu 19.11.2024 o 10:14, Daniel P. Berrangé pisze: +b4 shazam $msg-id I'm wondering how b4 knows where to find the mails for $msg-id for QEMU ? It goes for

Re: [PATCH 3/7] docs/devel: add b4 for patch retrieval

2024-11-19 Thread Marcin Juszkiewicz
W dniu 19.11.2024 o 10:14, Daniel P. Berrangé pisze: +b4 shazam $msg-id I'm wondering how b4 knows where to find the mails for $msg-id for QEMU ? It goes for https://lore.kernel.org/qemu-devel/$msg-id by default or checks b4.midmask in git config.

Re: [PATCH 2/7] docs/devel: add git-publish for patch submitting

2024-11-19 Thread Marcin Juszkiewicz
W dniu 18.11.2024 o 18:23, Pierrick Bouvier pisze: Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 349c32ee3a9..953682f20cb 10

Re: [edk2-devel] [RFC PATCH v2 1/1] hw/arm/sbsa-ref: Support CXL Host Bridge & CFMW

2024-11-12 Thread Marcin Juszkiewicz
W dniu 7.11.2024 o 13:04, Jonathan Cameron pisze: On Tue, 5 Nov 2024 18:43:46 +0800 "Yuquan Wang" wrote: This creates a default pxb-cxl (bus_nr=0xc0) bridge with two cxl root ports on sbsa-ref. And the memory layout places 64K space for the cxl host bridge register regions(CHBCR) in the sbsa-r

Re: [PATCH v2 1/1] pcie: enable Extended tag field support

2024-10-31 Thread Marcin Juszkiewicz
W dniu 23.10.2024 o 13:38, Marcin Juszkiewicz pisze: From what I read PCI has 32 transactions, PCI Express devices can handle 256 with Extended tag enabled (spec mentions also larger values but I lack PCIe knowledge). Ping? QEMU leaves 'Extended tag field' with 0 as value: Ca

[PATCH v2 1/1] pcie: enable Extended tag field support

2024-10-23 Thread Marcin Juszkiewicz
wired to 1 1. https://developer.arm.com/documentation/den0094/c/ This change enables Extended tag field. All versioned platforms should have it disabled for older versions (tested with Arm/virt). Signed-off-by: Marcin Juszkiewicz --- hw/core/machine.c| 4 +++- hw/pci/pci.c | 2 ++

Re: [PATCH] pcie: enable Extended tag field capability

2024-10-18 Thread Marcin Juszkiewicz
W dniu 17.10.2024 o 18:58, Michael S. Tsirkin pisze: diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 4b2f0805c6..54c0f1ec67 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -86,7 +86,8 @@ pcie_cap_v1_fill(PCIDevice *dev, uint8_t port, uint8_t type, uint8_t version) * Specification, Revi

Re: [PATCH] pcie: enable Extended tag field capability

2024-10-17 Thread Marcin Juszkiewicz
W dniu 17.10.2024 o 18:58, Michael S. Tsirkin pisze: diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 4b2f0805c6..54c0f1ec67 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -86,7 +86,8 @@ pcie_cap_v1_fill(PCIDevice *dev, uint8_t port, uint8_t type, uint8_t version) * Specification, Revi

Re: [PATCH v3 1/7] hw/core: Make CPU topology enumeration arch-agnostic

2024-10-17 Thread Marcin Juszkiewicz
W dniu 12.10.2024 o 12:44, Zhao Liu pisze: Cache topology needs to be defined based on CPU topology levels. Thus, define CPU topology enumeration in qapi/machine.json to make it generic for all architectures. I have a question: how to create other than default cache topology in C source? If

[PATCH] pcie: enable Extended tag field capability

2024-10-17 Thread Marcin Juszkiewicz
PCI has 32 transactions, PCI Express devices can handle 256. SBSA ACS checks for this capability to be enabled on Arm server systems. Signed-off-by: Marcin Juszkiewicz --- SBSA Reference Platform work goes on so I am looking at PCIe related tests. SBSA ACS has test 824 which checks for PCIe

Re: [PATCH] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1

2024-09-20 Thread Marcin Juszkiewicz
stop incorrectly reporting FEAT_XS as present, and now report the presence of FEAT_BF16. Cc: qemu-sta...@nongnu.org Reported-by: Marcin Juszkiewicz Signed-off-by: Peter Maydell --- target/arm/tcg/cpu64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/cpu64.c b/targe

[PATCH v5 0/4] tests: updates for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
it but we move to FreeBSD 14.x due to longer support cycles (OpenBSD 7.3 we use is already EoL). Signed-off-by: Marcin Juszkiewicz --- Changes in v5: - update to post-avocado system - drop all OpenBSD tests - Link to v4: https://lore.kernel.org/r/20240703-b4-move-to-freebsd-v4-0-07191f958...@

[PATCH v5 4/4] tests: drop OpenBSD tests for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
OpenBSD 7.3 we use is EoL. Both 7.4 and 7.5 releases do not work on anything above Neoverse-N1 due to PAC emulation: https://marc.info/?l=openbsd-arm&m=171050428327850&w=2 OpenBSD 7.6 is not yet released. Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref

[PATCH v5 2/4] tests: add FreeBSD tests for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
FreeBSD has longer support cycle for stable release (14.x EoL in 2028) than OpenBSD (7.3 we use is already EoL). Also bugfixes are backported so we can stay on 14.x for longer. Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 43

[PATCH v5 3/4] tests: expand timeout information for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
'Test might timeout' means nothing. Replace it with useful information that it is emulation of pointer authentication what makes this test run too long. Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 15 ++- 1 file changed, 10 insert

[PATCH v5 1/4] tests: use default cpu for aarch64/sbsa-ref

2024-09-10 Thread Marcin Juszkiewicz
We want to run tests using default cpu without having to remember which Arm core is it. Change Neoverse-N1 (old default) test to use default cpu (Neoverse-N2 at the moment). Signed-off-by: Marcin Juszkiewicz --- tests/functional/test_aarch64_sbsaref.py | 18 ++ 1 file changed

Re: [RFC PATCH 1/2] hw/arm/sbsa-ref: Enable CXL Host Bridge by pxb-cxl

2024-09-09 Thread Marcin Juszkiewicz
On 30.08.2024 06:15, Yuquan Wang wrote: The memory layout places 1M space for 16 host bridge register regions in the sbsa-ref memmap. In addition, this creates a default pxb-cxl (bus_nr=0xfe) bridge with one cxl-rp on sbsa-ref. With this patchset applied I no longer can add pcie devices to sbsa

Re: [RFC PATCH 0/2] Specifying cache topology on ARM

2024-09-02 Thread Marcin Juszkiewicz
On 23.08.2024 14:54, Alireza Sanaee via wrote: Failure cases: 1) there are cases where QEMU might not have any clusters selected in the -smp option, while user specifies caches to be shared at cluster level. In this situations, qemu returns error. 2) There are other scenario

Re: [PATCH v3] tests/functional: Convert Aarch64 SBSA-Ref avocado tests

2024-08-23 Thread Marcin Juszkiewicz
354.35s 11 subtests passed M1 Pro, Fedora Linux. 600s feels fine. ... Signed-off-by: Philippe Mathieu-Daudé --- Based-on:<20240821082748.65853-1-th...@redhat.com> Reviewed-by: Marcin Juszkiewicz

Re: [PATCH v2] tests/functional: Convert Aarch64 SBSA-Ref avocado tests

2024-08-22 Thread Marcin Juszkiewicz
On 22.08.2024 16:39, Philippe Mathieu-Daudé wrote: On 22/8/24 16:06, Marcin Juszkiewicz wrote: Maybe for QEMU project this is a progress. For me it is moving tests from working ones to "sorry, timeout, find out why" ones. OK, problem was found (check my previous mail). Tests to

Re: [PATCH v2] tests/functional: Convert Aarch64 SBSA-Ref avocado tests

2024-08-22 Thread Marcin Juszkiewicz
On 22.08.2024 13:41, Philippe Mathieu-Daudé wrote: Straight forward conversion. Since SBSA_FLASH files are not tarballs, use lzma_uncompress() method. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20240821082748.65853-1-th...@redhat.com> --- diff --git a/tests/avocado/machine_aarch64_

Re: [PATCH v2] tests/functional: Convert Aarch64 SBSA-Ref avocado tests

2024-08-22 Thread Marcin Juszkiewicz
On 22.08.2024 13:41, Philippe Mathieu-Daudé wrote: # Timeouts for individual tests that can be slow e.g. with debugging enabled test_timeouts = { + 'aarch64_sbsaref' : 180, What kind of machine is able to run those tests in 180s? I bumped them to 2400s and got timeout (Macbook with M1 Pro

Re: [PATCH 4/4] hw/arm/sbsa-ref: Use two-stage SMMU

2024-08-19 Thread Marcin Juszkiewicz
& stage2 support : Result: PASS Reviewed-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index ae37a923015..396abe9c1bd 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -621,6 +621,7 @

Re: [PATCH v2 7/9] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support

2024-08-06 Thread Marcin Juszkiewicz
On 6.08.2024 19:31, Cleber Rosa wrote: This makes use of the avocado.utils.archive support for zstd. In order to not duplicate code, the skip condition uses a private utility from the module which is going to become public in Avocado versions 103.1 LTS (and also in versions >= 107.0). Reference

Re: [PATCH v2 0/9] Bump Avocado to 103.0 LTS and update tests for compatibility and new features

2024-08-06 Thread Marcin Juszkiewicz
what I should in terms of testing before posting. I apologize for the miscalculation. Nevertheless, as pointed out, on the ML, these changes are needed NOW. Tested-by: Marcin Juszkiewicz SBSA Reference Platform tests can be done in 1/3rd of time is a nice update. Serial run: real6m20,324s

Re: [PATCH 1/1] target/arm: calculate cache sizes properly

2024-07-11 Thread Marcin Juszkiewicz
On 11.07.2024 12:19, Peter Maydell wrote: On Wed, 10 Jul 2024 at 18:35, Marcin Juszkiewicz wrote: Neoverse-V1 TRM says that NumSets are [27:13] not :32 like in code. NumSets in fields [27:13] is the 32-bit CCSIDR_EL1 format (i.e. what you have when FEAT_CCIDX is not implemented). The

[PATCH 1/1] target/arm: calculate cache sizes properly

2024-07-10 Thread Marcin Juszkiewicz
Neoverse-V1 TRM says that NumSets are [27:13] not :32 like in code. With this fix all cores which use make_ccsidr64() function have proper size of cpu caches. Signed-off-by: Marcin Juszkiewicz --- target/arm/tcg/cpu64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target

[PATCH v4 1/2] tests/avocado: sbsa-ref: add FreeBSD tests

2024-07-03 Thread Marcin Juszkiewicz
. Moved from Neoverse-N1 to Neoverse-N2 as sbsa-ref defaults were changed. Timeout messages expanded to mention being affected by PAuth emulation. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 73 1 file changed, 55 insertions(+), 18

[PATCH v4 2/2] tests/avocado: add test for default sbsa-ref cpu

2024-07-03 Thread Marcin Juszkiewicz
We changed sbsa-ref cpu several times already and may do it again in a future. To newer core or to enable/disable some properties. This change switches Neoverse-N2 tests to 'let test default cpu' ones. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsar

[PATCH v4 0/2] tests/avocado: updates for sbsa-ref testing

2024-07-03 Thread Marcin Juszkiewicz
AVOCADO_TEST_LEGACY_OS variable. At same time we add test to run on default cpu settings. For now it is plain Neoverse-N2 but we are considering either disabling PAuth or going with 'impdef' way. Signed-off-by: Marcin Juszkiewicz --- Changes in v4: - hide OpenBSD test behind AVOCADO_TEST_LEGACY

Re: [PATCH v3 1/2] tests/avocado: update firmware for sbsa-ref

2024-06-30 Thread Marcin Juszkiewicz
W dniu 30.06.2024 o 16:37, Ard Biesheuvel pisze: On Thu, 20 Jun 2024 at 12:20, Marcin Juszkiewicz wrote: Update firmware to have graphics card memory fix from EDK2 commit c1d1910be6e04a8b1a73090cf2881fb698947a6e: OvmfPkg/QemuVideoDxe: add feature PCD to remap framebuffer W/C Some

[PATCH v3 0/2] tests/avocado: updates for sbsa-ref testing

2024-06-24 Thread Marcin Juszkiewicz
test to run on default cpu settings. For now it is plain Neoverse-N2 but we are considering either disabling PAuth or going with 'impdef' way. Signed-off-by: Marcin Juszkiewicz --- Changes in v3: - kept OpenBSD/Cortex-A57 test for local runs (by request of Philippe) - Link to

[PATCH v3 2/2] tests/avocado: add test for default sbsa-ref cpu

2024-06-24 Thread Marcin Juszkiewicz
We changed sbsa-ref cpu several times already and may do it again in a future. To newer core or to enable/disable some properties. This change switches Neoverse-N2 tests to 'let test default cpu' ones. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsar

[PATCH v3 1/2] tests/avocado: sbsa-ref: add FreeBSD tests

2024-06-24 Thread Marcin Juszkiewicz
. Moved from Neoverse-N1 to Neoverse-N2 as sbsa-ref defaults were changed. Timeout messages expanded to mention being affected by PAuth emulation. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 75 1 file changed, 56 insertions(+), 19

[PATCH v2 0/2] tests/avocado: updates for sbsa-ref testing

2024-06-24 Thread Marcin Juszkiewicz
considering either disabling PAuth or going with 'impdef' way. Signed-off-by: Marcin Juszkiewicz --- Marcin Juszkiewicz (2): tests/avocado: sbsa-ref: switch from OpenBSD to FreeBSD tests/avocado: add test for default sbsa-ref cpu tests/avocado/machine_aarch64_sbsar

[PATCH v2 2/2] tests/avocado: add test for default sbsa-ref cpu

2024-06-24 Thread Marcin Juszkiewicz
We changed sbsa-ref cpu several times already and may do it again in a future. To newer core or to enable/disable some properties. This change switches Neoverse-N2 tests to 'let test default cpu' ones. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsar

[PATCH v2 1/2] tests/avocado: sbsa-ref: switch from OpenBSD to FreeBSD

2024-06-24 Thread Marcin Juszkiewicz
) Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 53 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index 6bb82f2a03..d52f89f756

[PATCH v3 2/2] tests/avocado: use default amount of cores on sbsa-ref

2024-06-20 Thread Marcin Juszkiewicz
firmware we're using for the test, we can make the test use all the cores on the board, so we are testing the SMP boot path. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref

[PATCH v3 0/2] tests/avocado: make sbsa-ref working with >1 core

2024-06-20 Thread Marcin Juszkiewicz
c: Rebecca Cran Signed-off-by: Marcin Juszkiewicz --- Changes in v3: - first update firmware, then use all cores (for bisecting) - changed commit message in 'use all cores' patch --- Marcin Juszkiewicz (2): tests/avocado: update firmware for sbsa-ref tests/avocado: use defaul

[PATCH v3 1/2] tests/avocado: update firmware for sbsa-ref

2024-06-20 Thread Marcin Juszkiewicz
DXE services to set the desired capabilities and attributes. Hide this behavior under a feature PCD so only platforms that really need it can enable it. (OVMF on x86 has no need for this) With this fix enabled we can boot sbsa-ref with more than one cpu core. Signed-off-by: Marcin

Re: [PATCH v2 1/2] tests/avocado: use default amount of cores on sbsa-ref

2024-06-20 Thread Marcin Juszkiewicz
W dniu 20.06.2024 o 11:34, Peter Maydell pisze: On Thu, 20 Jun 2024 at 07:00, Marcin Juszkiewicz wrote: I was wondering why avocado tests passed with firmware which crashes when anyone else is using it. Turned out that amount of cores matters. Have to find out why still. This commit

[PATCH v2 0/2] tests/avocado: make sbsa-ref working with >1 core

2024-06-19 Thread Marcin Juszkiewicz
I have no idea why previous firmware worked with 1 cpu core and failed with any higher number. Marcin Juszkiewicz (2): tests/avocado: use default amount of cores on sbsa-ref tests/avocado: update firmware for sbsa-ref tests/avocado/machine_aarch64_sbsaref.py | 16 +++- 1 file

[PATCH v2 1/2] tests/avocado: use default amount of cores on sbsa-ref

2024-06-19 Thread Marcin Juszkiewicz
I was wondering why avocado tests passed with firmware which crashes when anyone else is using it. Turned out that amount of cores matters. Have to find out why still. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH v2 2/2] tests/avocado: update firmware for sbsa-ref

2024-06-19 Thread Marcin Juszkiewicz
DXE services to set the desired capabilities and attributes. Hide this behavior under a feature PCD so only platforms that really need it can enable it. (OVMF on x86 has no need for this) With this fix enabled we can boot sbsa-ref with more than one cpu core. Signed-off-by: Marcin

[PATCH 1/1] tests/avocado: use default amount of cores on sbsa-ref

2024-06-19 Thread Marcin Juszkiewicz
I was wondering why avocado tests passed with firmware which crashes when anyone else is using it. Turned out that amount of cores matters. Have to find out why still. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH 1/1] BootLogoLib: align logo coords to be even

2024-06-17 Thread Marcin Juszkiewicz
nd if coords are odd then they are bumped a bit to make things work. Signed-off-by: Marcin Juszkiewicz This should be fixed in the SBSA firmware One coffee was not enough so I sent it to QEMU devel instead of EDK2 devel mailing list... unaligned accesses are fine on arm64 as long as they

[PATCH 1/1] BootLogoLib: align logo coords to be even

2024-06-17 Thread Marcin Juszkiewicz
make things work. Signed-off-by: Marcin Juszkiewicz --- .../Library/BootLogoLib/BootLogoLib.c | 4 MdeModulePkg/Logo/Logo.bmp| Bin 12446 -> 34010 bytes 2 files changed, 4 insertions(+) diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeM

Re: [PATCH v5 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine

2024-06-14 Thread Marcin Juszkiewicz
tested-by: Marcin Juszkiewicz Reviewed-by: Marcin Juszkiewicz

[PATCH 1/1] hw/arm/sbsa-ref: switch to 1GHz timer frequency

2024-05-31 Thread Marcin Juszkiewicz
Updated firmware for QEMU CI is already in merge queue so we can move platform to be future proof. All supported cpus work fine with 1GHz timer frequency when firmware is fresh enough. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 12 1 file changed, 4 insertions(+), 8

[PATCH 0/1] hw/arm/sbsa-ref: switch to 1GHz timer frequency

2024-05-31 Thread Marcin Juszkiewicz
Trusted Firmware 2.11 got released, EDK2 202405 got released as well. Both were built for QEMU CI and proper patch is now in arm.next queue. So all requirements to move from legacy 62.5MHz to armv8.6-ready 1GHz frequency are fulfiled. Marcin Juszkiewicz (1): hw/arm/sbsa-ref: switch to 1GHz

Re: [PATCH 1/1] tests/avocado: update sbsa-ref firmware

2024-05-29 Thread Marcin Juszkiewicz
W dniu 29.05.2024 o 15:12, Leif Lindholm pisze: On 2024-05-28 19:29, Marcin Juszkiewicz wrote: Partial support for NUMA setup: - cpu nodes - memory nodes Used versions: - Trusted Firmware v2.11.0 - Tianocore EDK2 stable202405 - Tianocore EDK2 Platforms code commit 4bbd0ed Firmware is built

[PATCH 1/1] tests/avocado: update sbsa-ref firmware

2024-05-28 Thread Marcin Juszkiewicz
Partial support for NUMA setup: - cpu nodes - memory nodes Used versions: - Trusted Firmware v2.11.0 - Tianocore EDK2 stable202405 - Tianocore EDK2 Platforms code commit 4bbd0ed Firmware is built using Debian 'bookworm' cross toolchain (gcc 12.2.0). --- tests/avocado/machine_aarch64_sbsaref.py

Re: [PATCH] target/arm: Disable SVE extensions when SVE is disabled

2024-05-26 Thread Marcin Juszkiewicz
W dniu 26.05.2024 o 22:45, Richard Henderson pisze: From: Marcin Juszkiewicz Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2304 Reported-by: Marcin Juszkiewicz Signed-off-by: Richard Henderson Signed-off-by: Marcin Juszkiewicz --- Marcin added the

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine

2024-05-23 Thread Marcin Juszkiewicz
Yining tested-by: Marcin Juszkiewicz I had some thinking about it recently. This patch exported whole /cpus/cpu-map/ tree which we then parse in TF-A to get amount of sockets/clusters/cores/threads. Why not export them directly? Kind of: cpus { topology

[PATCH 1/1] tests/avocado: sbsa-ref: switch from OpenBSD to FreeBSD

2024-05-23 Thread Marcin Juszkiewicz
-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 65 1 file changed, 43 insertions(+), 22 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index 98c76c1ff7..c3c7c0e639 100644 --- a/tests

[PATCH 1/1] arm/sbsa-ref: move to Neoverse-N2 as default

2024-05-23 Thread Marcin Juszkiewicz
ble set of features enabled by default. It is still supported and can be selected with "--cpu" argument. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 57c337fd92..e88469

Re: [PATCH] hvf: arm: Fix encodings for ID_AA64PFR1_EL1 and debug System registers

2024-05-05 Thread Marcin Juszkiewicz
W dniu 3.05.2024 o 17:34, Zenghui Yu pisze: We wrongly encoded ID_AA64PFR1_EL1 using {3,0,0,4,2} in hvf_sreg_match[] so we fail to get the expected ARMCPRegInfo from cp_regs hash table with the wrong key. Fix it with the correct encoding {3,0,0,4,1}. With that fixed, the Linux guest can properly

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-02 Thread Marcin Juszkiewicz
W dniu 2.05.2024 o 15:13, Peter Maydell pisze: On Thu, 2 May 2024 at 14:11, Marcin Juszkiewicz wrote: W dniu 2.05.2024 o 15:04, Dorjoy Chowdhury pisze: Should "return" also have "(1 << 24) |" to have MT=1 set? Otherwise MPIDR_EL1 = 0x000100 can mean core0 in clu

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-02 Thread Marcin Juszkiewicz
W dniu 2.05.2024 o 15:04, Dorjoy Chowdhury pisze: Should "return" also have "(1 << 24) |" to have MT=1 set? Otherwise MPIDR_EL1 = 0x000100 can mean core0 in cluster1 or core1 in cluster0. Value 0x1000100 shows MT=1 so thread0 in core1 in cluster0. I don't know all the details but from what I

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-02 Thread Marcin Juszkiewicz
W dniu 19.04.2024 o 20:31, Dorjoy Chowdhury pisze: -uint64_t arm_build_mp_affinity(int idx, uint8_t clustersz) +uint64_t arm_build_mp_affinity(ARMCPU *cpu, int idx, uint8_t clustersz) { +if (cpu->has_smt) { +/* + * Right now, the ARM CPUs with SMT supported by QEMU only have

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-02 Thread Marcin Juszkiewicz
W dniu 2.05.2024 o 12:37, Peter Maydell pisze: * what are the constraints on the Aff* fields (eg that kernel commit suggests Aff0 shouldn't be > 15)? This one is apparently related to GICv3 -- if the GIC doesn't implement RangeSelector support in ICC_SGI0R_EL1 and other places (advertise

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-01 Thread Marcin Juszkiewicz
W dniu 22.04.2024 o 17:21, Richard Henderson pisze: For Arm's CPUs they fall into two categories:   * older ones don't set MT in their MPIDR, and the Aff0     field is effectively the CPU number   * newer ones do set MT in their MPIDR, but don't have     SMT, so their Aff0 is always 0 and their A

Re: [PATCH v2 2/4] hw/arm/sbsa-ref: Force CPU generic timer to 62.5MHz

2024-04-28 Thread Marcin Juszkiewicz
ur avocado test Aarch64SbsarefMachine.test_sbsaref_alpine_linux_max_pauth_impdef before we can do that. Signed-off-by: Peter Maydell --- I leave it up to the sbsa-ref maintainers exactly when they want to shift to 1GHz (probably after a TF-A release with the fix?) Reviewed-by: Marcin Juszkiewicz TF-A 2.11 will be released in June. It will hav

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine

2024-04-28 Thread Marcin Juszkiewicz
W dniu 26.04.2024 o 18:06, Richard Henderson pisze: Isn't this basically what MPIDR_EL1 is supposed to indicate? We do not yet implement all of that in QEMU, but should. QEMU has socket/cluster/core/thread model which could map to aff3/aff2/aff1/aff0 (or aff0/1/2/3) of MPIDR_EL1 register, righ

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine

2024-04-26 Thread Marcin Juszkiewicz
Yining tested-by: Marcin Juszkiewicz Thanks. Checked with TF-A and EDK2 patches applied. PPTT table will be more detailed now. Reviewed-by: Marcin Juszkiewicz

Re: [PATCH 0/3] target/arm: Make the counter frequency default 1GHz for new CPUs, machines

2024-04-23 Thread Marcin Juszkiewicz
W dniu 22.04.2024 o 17:37, Marcin Juszkiewicz pisze: It also seems to be hardcoded in TF-A's support for the virt board too, annoyingly. I looked at it and it seems that TF-A can just read what is in CNTFRQ_EL0 instead of hardcoding the value. Submitted patch:

Re: [PATCH 0/3] target/arm: Make the counter frequency default 1GHz for new CPUs, machines

2024-04-22 Thread Marcin Juszkiewicz
W dniu 22.04.2024 o 16:18, Peter Maydell pisze: On Mon, 22 Apr 2024 at 14:38, Marcin Juszkiewicz From what I see in EDK2 code we read CNTFREQ_EL0: GetPlatformTimerFreq() checks for PcdArmArchTimerFreqInHz variable which sbsa-ref has set to 0. So it calls ArmGenericTimerGetTimerFreq

Re: [PATCH 0/3] target/arm: Make the counter frequency default 1GHz for new CPUs, machines

2024-04-22 Thread Marcin Juszkiewicz
W dniu 22.04.2024 o 14:56, Peter Maydell pisze: On Fri, 19 Apr 2024 at 19:46, Peter Maydell wrote: The upshot is that the only CPU type that changes is 'max'; but any new type we add in future (whether v8.6 or not) will also get the new 1GHz default (assuming we spot in code review any attemp

How to use pxb-pcie in correct way?

2024-04-08 Thread Marcin Juszkiewicz
For quite a while I am experimenting with PCI Express setup on SBSA-Ref system. And finally decided to write. We want to play with NUMA setup and "pxb-pcie" can be assigned to NUMA node other than cpu0 one. But adding it makes other cards dissapear... When I boot sbsa-ref I have plain PCIe se

Re: /util/cpuinfo-aarch64.c:58:22: error: 'HWCAP_USCAT' undeclared

2024-04-01 Thread Marcin Juszkiewicz
W dniu 1.04.2024 o 21:55, Liviu Ionescu pisze: On 1 Apr 2024, at 21:48, Richard Henderson wrote: You were told back in September that Ubuntu 18.04 is no longer supported. Sorry, I missed that. BTW, according to ubuntu.com: "With Ubuntu Pro, the 18.04 LTS will be fully supported until 2028.".

Re: [PATCH 1/1] docs: sbsa: update specs, add dt note

2024-03-28 Thread Marcin Juszkiewicz
W dniu 28.03.2024 o 16:43, Peter Maydell pisze: On Tue, 26 Mar 2024 at 09:58, Marcin Juszkiewicz wrote: Hardware of sbsa-ref board is nowadays defined by both BSA and SBSA specifications. Then BBR defines firmware interface. Added note about DeviceTree data passed from QEMU to firmware. It

[PATCH v2 1/1] docs: sbsa: update specs, add dt note

2024-03-28 Thread Marcin Juszkiewicz
by DeviceTree. Signed-off-by: Marcin Juszkiewicz --- docs/system/arm/sbsa.rst | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/docs/system/arm/sbsa.rst b/docs/system/arm/sbsa.rst index bca61608ff..2bf22a1d0b 100644 --- a/docs/system/arm

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Marcin Juszkiewicz
W dniu 27.03.2024 o 17:54, Philippe Mathieu-Daudé pisze: diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7b548519b5..345c35507f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -208,6 +208,13 @@ is no longer packaged in any distro making it harder

How to add pcie-root-port and device behind it in C?

2024-03-27 Thread Marcin Juszkiewicz
I was going through Arm (S)BSA tests run against sbsa-ref. Many of them check for presence of other cards than "Root Complex Integrated Endpoint" ones. The "-device root-pcie-port" etc arguments can be used to add such ones but I was wondering how to add them directly in C code. Tried to find

[PATCH 1/1] docs: sbsa: update specs, add dt note

2024-03-26 Thread Marcin Juszkiewicz
by DeviceTree. Signed-off-by: Marcin Juszkiewicz --- docs/system/arm/sbsa.rst | 37 - 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/docs/system/arm/sbsa.rst b/docs/system/arm/sbsa.rst index bca61608ff..d4d1f2efe3 100644 --- a/docs/system/arm

Re: [RFC PATCH 00/12] SMMUv3 nested translation support

2024-03-25 Thread Marcin Juszkiewicz
W dniu 25.03.2024 o 11:13, Mostafa Saleh pisze: Currently, QEMU supports emulating either stage-1 or stage-2 SMMUs but not nested instances. This patch series adds support for nested translation in SMMUv3, this is controlled by property “arm-smmuv3.stage=nested”, and advertised to guests as (IDR0

Re: [PATCH v2 0/2] ARM Sbsa-ref: Enable CPU cluster topology

2024-03-22 Thread Marcin Juszkiewicz
W dniu 22.03.2024 o 19:51, Peter Maydell pisze: On Tue, 12 Mar 2024 at 08:32, Xiong Yining xiongyining1480 (2): hw/arm/sbsa-ref:Enable CPU cluster on ARM sbsa machine hw/arm/sbsa-ref: Add cpu-map to device tree Thanks for these patches. I think we should squash the two patches together

Re: [RFC v2 2/2] hw/riscv: Add server platform reference machine

2024-03-22 Thread Marcin Juszkiewicz
W dniu 22.03.2024 o 09:50, Heinrich Schuchardt pisze: >>> I see no mention of device trees in the spec, but I do see ACPI. Do we >>> really expect a server platform to use DTs? >> >> This platform "kind of" follows sbsa-ref where we have very >> minimalistic device tree sharing information qemu->f

Re: [RFC v2 2/2] hw/riscv: Add server platform reference machine

2024-03-22 Thread Marcin Juszkiewicz
W dniu 22.03.2024 o 05:55, Alistair Francis pisze: I see no mention of device trees in the spec, but I do see ACPI. Do we really expect a server platform to use DTs? This platform "kind of" follows sbsa-ref where we have very minimalistic device tree sharing information qemu->firmware. libfd

[PATCH v3 0/4] tests/avocado: update sbsa-ref firmware to latest

2024-03-18 Thread Marcin Juszkiewicz
/11) test_sbsaref_openbsd73_max_pauth_impdef: PASS (16.11 s) (11/11) test_sbsaref_openbsd73_max: PASS (16.08 s) Signed-off-by: Marcin Juszkiewicz --- Changes in v3: - left OpenBSD at 7.3 (7.4+ is known to not boot) https://gitlab.com/qemu-project/qemu/-/issues/2224 https://marc.info/?l=openbsd-a

[PATCH v3 1/4] tests/avocado: update sbsa-ref firmware

2024-03-18 Thread Marcin Juszkiewicz
hieu-Daudé # SPDX-FileContributor: Marcin Juszkiewicz # @@ -32,34 +32,36 @@ def fetch_firmware(self): """ Flash volumes generated using: -- Fedora GNU Toolchain version 13.2.1 20230728 (Red Hat 13.2.1-1) +Toolchain from Debian: +aarc

[PATCH v3 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests

2024-03-18 Thread Marcin Juszkiewicz
sbsa-ref is supposed to emulate real hardware so virtio-rng-pci does not fit here Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 8 1 file changed, 8 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado

[PATCH v3 4/4] tests/avocado: sbsa-ref: add OpenBSD tests for misc 'max' setup

2024-03-18 Thread Marcin Juszkiewicz
PAuth makes run timeout on CI so add tests using 'max' without it and with impdef one. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tests/avocado/machine_aarch64_

[PATCH v3 3/4] tests/avocado: sbsa-ref: add Alpine tests for misc 'max' setup

2024-03-18 Thread Marcin Juszkiewicz
PAuth makes run timeout on CI so add tests using 'max' without it and with impdef one. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tes

Re: [PATCH v2 3/4] tests/avocado: use OpenBSD 7.4 for sbsa-ref

2024-03-14 Thread Marcin Juszkiewicz
W dniu 14.03.2024 o 15:56, Alex Bennée pisze: If we are not going to delete the entries then at least use a @skip instead of commenting. Maybe: @skip("Potential un-diagnosed upstream bug?") Daniel or Peter suggested to open a GitLab issue and use @skip("https://gitlab.com/qemu-project/

Re: [PATCH v2 3/4] tests/avocado: use OpenBSD 7.4 for sbsa-ref

2024-03-14 Thread Marcin Juszkiewicz
W dniu 14.03.2024 o 13:14, Alex Bennée pisze: +# OpenBSD 7.4 does not boot on current max cpu. +# +# def test_sbsaref_openbsd_max_pauth_off(self): +# """ +# :avocado: tags=cpu:max +# :avocado: tags=os:openbsd +# """ +# self.boot_openbsd("max,pauth=off") If we are

[PATCH v2 4/4] tests/avocado: sbsa-ref: add Alpine tests for misc 'max' setup

2024-03-14 Thread Marcin Juszkiewicz
PAuth makes run timeout on CI so add tests using 'max' without it and with impdef one. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tes

[PATCH v2 0/4] tests/avocado: update sbsa-ref firmware to latest

2024-03-14 Thread Marcin Juszkiewicz
PASS (29.27 s) (6/8) test_sbsaref_alpine_linux_max: PASS (80.13 s) (7/8) test_sbsaref_openbsd_cortex_a57: PASS (16.01 s) (8/8) test_sbsaref_openbsd_neoverse_n1: PASS (16.05 s) Signed-off-by: Marcin Juszkiewicz --- Changes in v2: - disabled 'max' tests on OpenBSD - moved tags to 'one tag per line' - add

[PATCH v2 1/4] tests/avocado: update sbsa-ref firmware

2024-03-14 Thread Marcin Juszkiewicz
hieu-Daudé # SPDX-FileContributor: Marcin Juszkiewicz # @@ -32,34 +32,36 @@ def fetch_firmware(self): """ Flash volumes generated using: -- Fedora GNU Toolchain version 13.2.1 20230728 (Red Hat 13.2.1-1) +Toolchain from Debian: +aarc

[PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests

2024-03-14 Thread Marcin Juszkiewicz
sbsa-ref is supposed to emulate real hardware so virtio-rng-pci does not fit here Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 8 1 file changed, 8 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado

[PATCH v2 3/4] tests/avocado: use OpenBSD 7.4 for sbsa-ref

2024-03-14 Thread Marcin Juszkiewicz
7.4 was released in October 2023, time to update before 7.3 gets dropped. Disabled tests for 'max' cpu as OpenBSD fails there. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_aarch64_sbsaref.py | 47 +++- 1 file changed, 34 insertions(+), 13

  1   2   3   >