his field can be used as a reliable indicator on when we require to
s/on when we require/for when we are required/
Also, note that you have commit message lines are longer than 76
characters (longer than 80, for that matter).
But aside from those nits:
Reviewed-by: Maran Wilson
Thanks,
-Ma
}
}
Reviewed-by: Maran Wilson
Thanks,
-Maran
;nested_state->hdr.vmx;
Reviewed-by: Maran Wilson
Thanks,
-Maran
Just a bunch of grammar and style nits below. As for the actual code
changes:
Reviewed-by: Maran Wilson
Tested-by: Maran Wilson
Thanks,
-Maran
On 7/5/2019 2:06 PM, Liran Alon wrote:
Previous to this change, a vCPU exposed with VMX running on a kernel without
KVM_CAP_NESTED_STATE
or
On 6/28/2019 2:05 PM, Sergio Lopez wrote:
Maran Wilson writes:
This seems like a good overall direction to be headed with Qemu.
But there is a lot of Linux OS specific startup details being baked
into the Qemu machine type here. Things that are usually pushed into
firmware or option ROM
This seems like a good overall direction to be headed with Qemu.
But there is a lot of Linux OS specific startup details being baked into
the Qemu machine type here. Things that are usually pushed into firmware
or option ROM.
Instead of hard coding all the Zero page stuff into the Qemu machin
zation does not support live migration
yet");
+ "Kernel do not provide required capabilities for "
s/do/does/
And with that change:
Reviewed-by: Maran Wilson
Thanks,
-Maran
+ "nested virtualization migration. "
kwards-compatability
+* to old definition of kvm_nested_state in order to avoid changing
+* KVM_{GET,PUT}_NESTED_STATE ioctl values.
+*/
+ union {
+ struct kvm_vmx_nested_state_data vmx[0];
+ } data;
};
#endif /* _ASM_X86_KVM_H */
Reviewed-by: Maran Wilson
Thanks,
-Maran
On 6/19/2019 1:33 PM, Liran Alon wrote:
On 19 Jun 2019, at 23:30, Maran Wilson wrote:
On 6/19/2019 9:21 AM, Liran Alon wrote:
Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker")
added migration blocker for vCPU exposed with Intel VMX because QEMU
doesn't yet
On 6/19/2019 9:21 AM, Liran Alon wrote:
Commit d98f26073beb ("target/i386: kvm: add VMX migration blocker")
added migration blocker for vCPU exposed with Intel VMX because QEMU
doesn't yet contain code to support migration of nested virtualization
workloads.
However, that commit missed adding de
On 6/17/2019 10:27 AM, Paolo Bonzini wrote:
On 17/06/19 13:34, Liran Alon wrote:
Putting this all together, in case kernel doesn’t support extracting
nested-state, there is no decent way to know if guest is running
nested-virtualization. Which means that in theory we always need to
fail migratio
_pt,
&vmstate_msr_virt_ssbd,
&vmstate_svm_npt,
+#ifdef CONFIG_KVM
+&vmstate_nested_state,
+#endif
NULL
}
};
I'm not sure it's comprehensive enough to qualify for a "Tested-by"
line, but I did run this latest patch series in my environment and
confirm that I was able to save/restore L1 VMs that had created active
L2 VMs of their own. Previously those tests would always result in a L1
kernel failure upon restoration. I also verified that cpu_pre_save() was
properly catching and preventing the save when the host kernel did not
support KVM_CAP_NESTED_STATE.
And aside from the 0x1000 magic value, this latest version of the patch
looks good.
Reviewed-by: Maran Wilson
Thanks,
-Maran
ker,
+ "AMD SVM does not support live migration yet");
+r = migrate_add_blocker(svm_mig_blocker, &local_err);
if (local_err) {
error_report_err(local_err);
-error_free(nested_virt_mig_blocker);
+error_free(svm_mig_block
(Such as i386)
currently do not free memory that it have allocated in
kvm_arch_init_vcpu().
Suggested-by: Maran Wilson
Signed-off-by: Liran Alon
---
accel/kvm/kvm-all.c | 5 +
include/sysemu/kvm.h | 1 +
target/arm/kvm32.c | 5 +
target/arm/kvm64.c | 5 +
target/i386/kvm.c
On 6/17/2019 10:56 AM, Liran Alon wrote:
Improve the KVM_{GET,SET}_NESTED_STATE structs by detailing the format
of VMX nested state data in a struct.
In order to avoid changing the ioctl values of
KVM_{GET,SET}_NESTED_STATE, there is a need to preserve
sizeof(struct kvm_nested_state). This is do
e_add_blocker(nested_virt_mig_blocker, &local_err);
if (local_err) {
error_report_err(local_err);
-error_free(vmx_mig_blocker);
+error_free(nested_virt_mig_blocker);
return r;
}
}
Reviewed-by: Maran Wilson
Thanks,
-Maran
On 1/9/2019 11:53 AM, Boris Ostrovsky wrote:
On 1/9/19 6:53 AM, Stefano Garzarella wrote:
Hi Liam,
On Tue, Jan 8, 2019 at 3:47 PM Liam Merwick wrote:
QEMU sets the hvm_modlist_entry in load_linux() after the call to
load_elfboot() and then qboot loads it in boot_pvh_from_fw_cfg()
But the cur
On 12/12/2018 7:28 AM, Stefano Garzarella wrote:
On Tue, Dec 11, 2018 at 7:35 PM Maran Wilson wrote:
On 12/11/2018 9:11 AM, Stefano Garzarella wrote:
Hi Liam,
in order to support PVH also with SeaBIOS, I'm going to work on a new
option rom (like linuxboot/multiboot) that can be used in
On 12/11/2018 9:11 AM, Stefano Garzarella wrote:
Hi Liam,
in order to support PVH also with SeaBIOS, I'm going to work on a new
option rom (like linuxboot/multiboot) that can be used in this case.
That is awesome. Yes, please keep us posted when you have something working.
Just FYI, before swi
On 12/6/2018 2:38 AM, Stefan Hajnoczi wrote:
On Wed, Dec 05, 2018 at 10:04:36AM -0800, Maran Wilson wrote:
On 12/5/2018 5:20 AM, Stefan Hajnoczi wrote:
On Tue, Dec 04, 2018 at 02:44:33PM -0800, Maran Wilson wrote:
On 12/3/2018 8:35 AM, Stefano Garzarella wrote:
On Mon, Dec 3, 2018 at 4:44 PM
On 12/5/2018 2:37 PM, Liam Merwick wrote:
For certain applications it is desirable to rapidly boot a KVM virtual
machine. In cases where legacy hardware and software support within the
guest is not needed, QEMU should be able to boot directly into the
uncompressed Linux kernel binary with minimal
On 12/5/2018 5:20 AM, Stefan Hajnoczi wrote:
On Tue, Dec 04, 2018 at 02:44:33PM -0800, Maran Wilson wrote:
On 12/3/2018 8:35 AM, Stefano Garzarella wrote:
On Mon, Dec 3, 2018 at 4:44 PM Rob Bradford wrote:
Hi Stefano, thanks for capturing all these numbers,
On Mon, 2018-12-03 at 15:27 +0100
On 12/3/2018 8:35 AM, Stefano Garzarella wrote:
On Mon, Dec 3, 2018 at 4:44 PM Rob Bradford wrote:
Hi Stefano, thanks for capturing all these numbers,
On Mon, 2018-12-03 at 15:27 +0100, Stefano Garzarella wrote:
Hi Rob,
I continued to investigate the boot time, and as you suggested I
looked a
ndrew Jones wrote:
On Wed, Jul 25, 2018 at 11:40:54AM +0100, Marc Zyngier wrote:
On 24/07/18 19:35, Maran Wilson wrote:
It's been a few months since this email thread died off. Has anyone
started working on a potential solution that would allow VCPU hotplug on
KVM/ARM ? Or is this a proje
It's been a few months since this email thread died off. Has anyone
started working on a potential solution that would allow VCPU hotplug on
KVM/ARM ? Or is this a project that is still waiting for an owner who
has the time and inclination to get started?
Thanks,
-Maran
On 2/27/2018 5:21 AM,
25 matches
Mail list logo
