Re: [Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-23 Thread Maksim Kozlov
20.07.2012 18:32, Peter Maydell пишет: On 12 July 2012 17:54, Maksim Kozlov wrote: Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 40 +--- 1 files changed, 33 insertions(+), 7 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c

Re: [Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-22 Thread Maksim Kozlov
20.07.2012 18:32, Peter Maydell пишет: On 12 July 2012 17:54, Maksim Kozlov wrote: Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 40 +--- 1 files changed, 33 insertions(+), 7 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c

Re: [Qemu-devel] [PATCH v4 1/2] ARM: exynos4210: CMU support

2012-07-17 Thread Maksim Kozlov
17.07.2012 01:05, Peter Maydell пишет: On 4 July 2012 17:27, Maksim Kozlov wrote: Add exynos4210 Clock Management Units emulation General comment, which I suspect you're not going to like... Underlying the exynos-specific code here, there's a general mechanism of "I'

[Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-12 Thread Maksim Kozlov
Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 40 +--- 1 files changed, 33 insertions(+), 7 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index 7f09c79..96588d9 100644 --- a/hw/exynos4210_pmu.c +++ b/hw/exynos4210_pmu.c

[Qemu-devel] [PATCH v2 3/4] ARM: exynos4210_pmu: Introduced exynos4210_pmu_get_register_index

2012-07-12 Thread Maksim Kozlov
This patch just introduces exynos4210_pmu_get_register_index function to get index of the register's value in the array on its offset. And functions _read and _write were modified accordingly. Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c |

[Qemu-devel] [PATCH v2 2/4] ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set.

2012-07-12 Thread Maksim Kozlov
It make possible to set DEBUG_PMU and DEBUG_PMU_EXTEND independently of each other Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index 2be7e08

[Qemu-devel] [PATCH v2 1/4] ARM: exynos4210_pmu: just formatting changes

2012-07-12 Thread Maksim Kozlov
Mainly to make 'exynos4210_pmu_regs' array more readable. Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 324 ++- 1 files changed, 164 insertions(+), 160 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c ind

[Qemu-devel] [PATCH v2 0/4] ARM: exynos4210 PMU modifications

2012-07-12 Thread Maksim Kozlov
register's index 4. add software reset First three patches are standalone, but the fourth depends on the third. Changelog: v1->v2: Deleted the irrelevant comment Maksim Kozlov (4): ARM: exynos4210_pmu: just formatting changes ARM: exynos4210_pmu: changes in PRINT_DEBUG macro se

Re: [Qemu-devel] [PATCH 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-12 Thread Maksim Kozlov
I didn't delete comment in this file. This comment become irrelevant after apply this patch. I'll send new patch set. 06.07.2012 19:49, Maksim Kozlov пишет: Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 34 +- 1 files changed, 33 insert

[Qemu-devel] [PATCH 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-06 Thread Maksim Kozlov
Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 34 +- 1 files changed, 33 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index 7f09c79..2ae3b60 100644 --- a/hw/exynos4210_pmu.c +++ b/hw/exynos4210_pmu.c @@ -25,6

[Qemu-devel] [PATCH 1/4] ARM: exynos4210_pmu: just formatting changes

2012-07-06 Thread Maksim Kozlov
Mainly to make 'exynos4210_pmu_regs' array more readable. Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 324 ++- 1 files changed, 164 insertions(+), 160 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c ind

[Qemu-devel] [PATCH 2/4] ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set.

2012-07-06 Thread Maksim Kozlov
It make possible to set DEBUG_PMU and DEBUG_PMU_EXTEND independently of each other Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c | 23 +-- 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index 2be7e08

[Qemu-devel] [PATCH 3/4] ARM: exynos4210_pmu: Introduced exynos4210_pmu_get_register_index

2012-07-06 Thread Maksim Kozlov
This patch just introduces exynos4210_pmu_get_register_index function to get index of the register's value in the array on its offset. And functions _read and _write were modified accordingly. Signed-off-by: Maksim Kozlov --- hw/exynos4210_pmu.c |

[Qemu-devel] [PATCH 0/4] ARM: exynos4210 PMU modifications

2012-07-06 Thread Maksim Kozlov
register's index 4. add software reset First three patches are standalone, but fourth is depend on the third. Maksim Kozlov (4): ARM: exynos4210_pmu: just formatting changes ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set. ARM: exynos4210_pmu: Introduced exynos4210_pmu_get_register_

[Qemu-devel] [PATCH v4 0/2] ARM: Samsung Exynos4210 CMU support

2012-07-04 Thread Maksim Kozlov
fier was added to global structures and arrays which shouldn't be changed in runtime. Also, useless type casts were deleted. - hw/exynos4210_uart.c: code style was fixed and useless type cast was deleted. Maksim Kozlov (2): ARM: exynos4210: CMU support exynos4210: UART: Adde

[Qemu-devel] [PATCH v4 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-07-04 Thread Maksim Kozlov
Add using of functionality provided by CMU - get_rate and register_clock_handler. Signed-off-by: Maksim Kozlov --- hw/exynos4210_uart.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
04.07.2012 18:14, Dunrong Huang пишет: + +static void exynos4210_cmu_set_pll(void *opaque, Exynos4210ClockState *pll) +{ +Exynos4210CmuState *s = opaque; +Exynos4210ClockState *source; +target_phys_addr_t offset = pll->div_reg; +ClockChangeEntry *cce; +uint32_t pdiv, mdiv, s

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
04.07.2012 17:54, Peter Maydell пишет: On 4 July 2012 14:45, Maksim Kozlov wrote: 04.07.2012 14:38, Dunrong Huang пишет: +PRINT_DEBUG("%s rate: %llu\n", pll->name, pll->rate); pll->rate is of type uint64_t incompatible with "%llu" Type uint64_t is includ

Re: [Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
04.07.2012 14:38, Dunrong Huang пишет: +void exynos4210_register_clock_handler(ClockChangeHandler *func, + Exynos4210Clock clock_id, void *opaque) +{ +ClockChangeEntry *cce = g_malloc0(sizeof(ClockChangeEntry)); +Exynos4210ClockState *clock = exynos4

[Qemu-devel] [PATCH v3 1/2] ARM: exynos4210: CMU support

2012-07-04 Thread Maksim Kozlov
Add exynos4210 Clock Management Units emulation Signed-off-by: Maksim Kozlov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16 + hw/exynos4210.h | 42 ++ hw/exynos4210_cmu.c | 1464 ++ 4 files changed, 1523 insertions(+), 0

[Qemu-devel] [PATCH v3 0/2] ARM: Samsung Exynos4210 CMU support

2012-07-04 Thread Maksim Kozlov
ere deleted. - hw/exynos4210_uart.c: code style was fixed and useless type cast was deleted. Maksim Kozlov (2): ARM: exynos4210: CMU support exynos4210: UART: Added using of CMU-callback functionality hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16 + hw/exynos4210.h | 42 ++

[Qemu-devel] [PATCH v3 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-07-04 Thread Maksim Kozlov
Add using of functionality provided by CMU - get_rate and register_clock_handler. Signed-off-by: Maksim Kozlov --- hw/exynos4210_uart.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw

[Qemu-devel] [PATCH v2 1/2] ARM: exynos4210: CMU support

2012-07-02 Thread Maksim Kozlov
Add exynos4210 Clock Management Units emulation Signed-off-by: Maksim Kozlov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16 + hw/exynos4210.h | 42 ++ hw/exynos4210_cmu.c | 1464 ++ 4 files changed, 1523 insertions(+), 0

[Qemu-devel] [PATCH v2 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-07-02 Thread Maksim Kozlov
Add using of functionality provided by CMU - get_rate and register_clock_handler. Signed-off-by: Maksim Kozlov --- hw/exynos4210_uart.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw

[Qemu-devel] [PATCH v2 0/2] ARM: Samsung Exynos4210 CMU support

2012-07-02 Thread Maksim Kozlov
ss type casts were deleted. - hw/exynos4210_uart.c: code style was fixed and useless type cast was deleted. Maksim Kozlov (2): ARM: exynos4210: CMU support exynos4210: UART: Added using of CMU-callback functionality hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16

[Qemu-devel] [PATCH 1/2] ARM: exynos4210: CMU support

2012-06-29 Thread Maksim Kozlov
Add exynos4210 Clock Management Units emulation Signed-off-by: Maksim Kozlov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16 + hw/exynos4210.h | 42 ++ hw/exynos4210_cmu.c | 1462 ++ 4 files changed, 1521 insertions(+), 0

[Qemu-devel] [PATCH 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-06-29 Thread Maksim Kozlov
Add using of functionality provided by CMU - get_rate and register_clock_handler. Signed-off-by: Maksim Kozlov --- hw/exynos4210_uart.c | 36 +++- 1 files changed, 35 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c index

[Qemu-devel] [PATCH 0/2] ARM: Samsung Exynos4210 CMU support

2012-06-29 Thread Maksim Kozlov
These patches add exynos4210 Clock Management Unit emulation and usage of it by exynos4210 UART Maksim Kozlov (2): ARM: exynos4210: CMU support exynos4210: UART: Added using of CMU-callback functionality hw/arm/Makefile.objs |1 + hw/exynos4210.c | 16 + hw/exynos4210.h

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-06 Thread Maksim Kozlov
04.04.2012 21:37, Dmitry Zhurikhin пишет: On 2012-04-04 20:16, Maksim Kozlov wrote: 04.04.2012 16:35, Dmitry Zhurikhin пишет: On 2012-04-04 15:55, Maksim Kozlov wrote: 04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Maksim Kozlov
04.04.2012 16:35, Dmitry Zhurikhin пишет: On 2012-04-04 15:55, Maksim Kozlov wrote: 04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/exynos4210_pmu.c | 11 +++ 1 files changed, 11 insertions

Re: [Qemu-devel] [PATCH] Support system reset in Exynos4210

2012-04-04 Thread Maksim Kozlov
04.04.2012 14:08, Dmitry Zhurikhin пишет: Reset the system when 1 is written to SWRESET register Signed-off-by: Dmitry Zhurikhin --- hw/exynos4210_pmu.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c index c12d750.

Re: [Qemu-devel] [PATCH 6/9] Fix bit test to use & instead of && and enable -Wlogical-op warning

2012-04-02 Thread Maksim Kozlov
02.04.2012 16:27, Peter Maydell пишет: On 2 April 2012 11:50, Daniel P. Berrange wrote: diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c index 73a9c18..4b20105 100644 --- a/hw/exynos4210_uart.c +++ b/hw/exynos4210_uart.c @@ -246,7 +246,7 @@ static uint32_t exynos4210_uart_Tx_FIFO_trigg

qemu-devel@nongnu.org

2012-04-02 Thread Maksim Kozlov
02.04.2012 17:43, Daniel P. Berrange пишет: From: "Daniel P. Berrange" * hw/exynos4210_uart.c: s/&&/&/ Signed-off-by: Daniel P. Berrange --- hw/exynos4210_uart.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c index 73