On 2021-04-30 11:53:24 Fri, Oliver O'Halloran wrote:
> On Thu, Apr 29, 2021 at 7:02 PM Mahesh J Salgaonkar
> wrote:
> >
> > On 2021-04-28 22:33:45 Wed, Oliver O'Halloran wrote:
> > > On Tue, Apr 27, 2021 at 9:56 PM Mahesh Salgaonkar
> > > wrote:
&g
On 2021-04-30 07:52:58 Fri, Daniel Henrique Barboza wrote:
>
>
> On 4/29/21 6:02 AM, Mahesh J Salgaonkar wrote:
> > On 2021-04-28 22:33:45 Wed, Oliver O'Halloran wrote:
> > > On Tue, Apr 27, 2021 at 9:56 PM Mahesh Salgaonkar
> > > wrote:
> > > &g
of card 1's PE then the guest will see an unexpected
> reset of card 2 as well. From the hypervisor's point of view the two
> are in the same PE so this is a legitimate thing to do, but due to
> this patch the guest doesn't know that.
Agree. I realize my fix is not correctly handling this. The current code
under ibm,set-eeh-option is checking for individual PCI device presence.
Better fix should be to check if there is any PCI device (vfio-pci)
present under specified bus and enable the EEH if found. And no change
in return value of get-config-addr-info2. What do you say ?
--
Mahesh J Salgaonkar
On 2020-03-17 17:11:22 Tue, Greg Kurz wrote:
> On Tue, 17 Mar 2020 08:51:50 -0700 (PDT)
> no-re...@patchew.org wrote:
>
> > Patchew URL:
> > https://patchew.org/QEMU/158444819283.31599.12155058652686614304.stgit@jupiter/
> >
> >
> >
> > Hi,
> >
> > This series seems to have some coding style
On 2020-03-17 00:26:07 Tue, Nicholas Piggin wrote:
> The option is called "FWNMI", and it involves more than just machine
> checks, also machine checks can be delivered without the FWNMI option,
> so re-name various things to reflect that.
>
> Signed-off-by: Nicholas Piggin
> ---
> hw/ppc/spapr.
panicked(NULL);
> +return;
> +}
> +
> +addr = rtas_addr + RTAS_ERROR_LOG_MAX + cs->cpu_index *
> sizeof(uint64_t)*2;
> +stq_be_phys(&address_space_memory, addr, env->gpr[3]);
> +stq_be_phys(&address_space_memory, addr + sizeof(uint64_t), 0);
> +env->gpr[3] = addr;
> +}
> +ppc_cpu_do_system_reset(cs, spapr->fwnmi_system_reset_addr);
> }
>
> static void spapr_nmi(NMIState *n, int cpu_index, Error **errp)
> --
> 2.23.0
>
>
--
Mahesh J Salgaonkar
194,9 +194,10 @@ struct SpaprMachineState {
>
> /* State related to FWNMI option */
>
> -/* Machine Check Notification Routine address
> +/* System Reset and Machine Check Notification Routine addresses
> * registered by "ibm,nmi-register" RTAS call.
> */
> +target_ulong fwnmi_system_reset_addr;
> target_ulong fwnmi_machine_check_addr;
>
> /* Machine Check FWNMI synchronization, fwnmi_machine_check_interlock is
> --
> 2.23.0
>
>
--
Mahesh J Salgaonkar
