get that change upstream-ed to
> the kernel, but looking forward to seeing your solutions.
The problem is that the shared memory mapping doesn't have a struct page
as required by lots of networking code.
--
Måns Rullgård
insn & 0x0f10) == 0x0e00) {
>> +/* cdp2 */
>> +if (disas_coproc_insn(env, s, insn))
>> +goto illegal_op;
>> +return;
>> +}
>
> This hunk is oddly placed, because it's neither next to the neon
> decode (which is further up) nor the mrc2/mcr2 decode (which is
> further down).
That's because it is neither. It is CDP2, previously not decoded at all.
This seemed as logical a place as any to me. If you disagree, please
say where you'd prefer that it go.
--
Måns Rullgård
m...@mansr.com
t; the necessary bits of decode in the ld/st excl arm to
> cause the patterns to undef (then the lda/stl patch
> can fill in extra cases in the switch() that this
> patch would introduce.)
You're quite right. Keeping that one line in the big patch is probably
the simplest after all.
--
Måns Rullgård
m...@mansr.com
break;
>
> So does SEVL need to be implemented? Then the TODO should be updated.
> Otherwise moving it a line down may be clearer.
It needs to be implemented when/if SEV and WFE are.
--
Måns Rullgård
m...@mansr.com
"Michael S. Tsirkin" writes:
> Heh, configure script runs the program it's built
> in a couple of places. This probably does not
> work for cross-builds:
>
> if compile_prog "" "" ; then
> $TMPE && bigendian="yes"
> else
> echo big/little test failed
> fi
>
> likely
: \"$cc\" does not have a working stdio.h"
> +exit 1
> +fi
> +
> check_define() {
> cat > $TMPC < #if !defined($1)
This makes cross-compiling impossible. Is that really desirable?
--
Måns Rullgård
m...@mansr.com
Juan Quintela writes:
> Loïc Minier wrote:
>> On Wed, Jan 20, 2010, Måns Rullgård wrote:
>>> If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
>>> Likewise if you set the value first.
>>
>> Ok; see attached patches
>
&g
X spec says this:
If IFS is not set, the shell shall behave as if the value of IFS is
, , and
> +local_ifs="$IFS"
> [...]
> +IFS=:
> [...]
> +IFS="$local_ifs"
> +return 0
> [...]
> +IFS="$local_ifs"
> +return 1
If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
Likewise if you set the value first.
--
Måns Rullgård
m...@mansr.com
n"`
> + solinst=`path_of $install`
>if test -z "$solinst" ; then
> echo "Solaris install program not found. Use --install=/usr/ucb/install
> or"
> echo "install fileutils from www.blastwave.org using pkg-get -i
> fileutils"
> @@ -776,7 +813,7 @@ if test "$solaris" = "yes" ; then
> echo "using pkg-get -i fileutils, or use --install=/usr/ucb/install"
> exit 1
>fi
> - sol_ar=`which ar 2> /dev/null | /usr/bin/grep -v "no ar in"`
> + sol_ar=`path_of ar`
>if test -z "$sol_ar" ; then
> echo "Error: No path includes ar"
> if test -f /usr/ccs/bin/ar ; then
Is the full path of these tools really important? Doesn't look like
it to me.
--
Måns Rullgård
m...@mansr.com
gt; an executable in the PATH. This also replaces all uses of "which" in
>> ./configure. (This should be applied on top of the sdl-config patch.)
>>
>> Thanks,
>
> Why don't you use "type -P" for "path_of" ?"
The standard "type" has no options.
--
Måns Rullgård
m...@mansr.com
Stefan Weil writes:
> Måns Rullgård schrieb:
>> Loïc Minier writes:
>>
>>
>>> Hi
>>>
>>> On systems were sdl-config isn't installed, ./configure triggers this
>>> warning:
>>> ./configure: 957: sdl
config --version | sed 's/[^0-9]//g'`
> +else
> + sdl=no
> fi
"which" isn't a standard command. Would simply 2>/dev/null do the
trick just as well? If you really need to test for the existence of
something, use "type".
--
Måns Rullgård
m...@mansr.com
hould be used
except in the rare cases where keeping it all on a single line
improves readability.
--
Måns Rullgård
m...@mansr.com
13 matches
Mail list logo
