Re: [Qemu-devel] [PATCH] RISC-V: Fix pmpcfg register indexing

2019-06-29 Thread Luke Nelson
On Wed, Feb 13, 2019 at 10:12 AM Palmer Dabbelt wrote: > > On Fri, 08 Feb 2019 10:57:17 PST (-0800), alistai...@gmail.com wrote: > > > > Good catch! > > > > Reviewed-by: Alistair Francis > > Ya, thanks -- that's a somewhat embarrassing bug, as someone else just fixed > one on the line below :).

[Qemu-devel] [PATCH] RISC-V: Fix pmpcfg register indexing

2019-01-30 Thread Luke Nelson
configuration index will be 16-23, which should be 8-15. A correct way is to use (reg_index * 4) instead, which works for both RV32 and RV64. Cc: Xi Wang Signed-off-by: Luke Nelson --- target/riscv/pmp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/riscv/pmp.c