Re: [PATCH 0/1] Add missing function names to symbol list

On 10/18/21 13:18, Alex Bennée wrote: Lukas Jünger writes: On 9/7/21 13:43, Alex Bennée wrote: Lukas Jünger writes: Hi all, I have been trying to use the hwprofile and cache plugin on qemu-system-riscv64. They failed to load with an undefined symbol error. It looks like some of the

Re: [PATCH 0/1] Add missing function names to symbol list

On 9/7/21 13:43, Alex Bennée wrote: Lukas Jünger writes: Hi all, I have been trying to use the hwprofile and cache plugin on qemu-system-riscv64. They failed to load with an undefined symbol error. It looks like some of the plugin API functions are missing from the symbol list, so I added

[PATCH 0/1] Add missing function names to symbol list

is segfaulting on shutdown, but that is a separate, unrelated issue). Hope that's okay. BR, Lukas Lukas Jünger (1): plugins/: Add missing functions to symbol list plugins/qemu-plugins.symbols | 3 +++ 1 file changed, 3 insertions(+) -- 2.31.1

[PATCH 1/1] plugins/: Add missing functions to symbol list

Some functions of the plugin API were missing in the symbol list. However, they are all used by the contributed example plugins. QEMU fails to load the plugin if the function symbol is not exported. Signed-off-by: Lukas Jünger --- plugins/qemu-plugins.symbols | 3 +++ 1 file changed, 3

[PATCH v5 2/2] hw/char: QOMify sifive_uart

This QOMifies the SiFive UART model. Migration and reset have been implemented. Signed-off-by: Lukas Jünger Reviewed-by: Bin Meng --- include/hw/char/sifive_uart.h | 11 ++-- hw/char/sifive_uart.c | 114 +++--- 2 files changed, 109 insertions(+), 16

[PATCH v5 1/2] hw/char: Consistent function names for sifive_uart

This cleans up function names in the SiFive UART model. Signed-off-by: Lukas Jünger Reviewed-by: Alistair Francis Reviewed-by: Bin Meng --- hw/char/sifive_uart.c | 46 ++- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/hw/char

[PATCH v5 0/2] QOMify Sifive UART Model

Hello, I cleaned up the commit message as requested by Bin. Best regards, Lukas Lukas Jünger (2): hw/char: Consistent function names for sifive_uart hw/char: QOMify sifive_uart include/hw/char/sifive_uart.h | 11 ++- hw/char/sifive_uart.c | 152

[PATCH v4 0/2] QOMify Sifive UART Model

Hello, I have updated the commit message as requested by Bin. Best regards, Lukas Lukas Jünger (2): hw/char: Consistent function names for sifive_uart hw/char: QOMify sifive_uart include/hw/char/sifive_uart.h | 11 ++- hw/char/sifive_uart.c | 152

[PATCH v4 2/2] hw/char: QOMify sifive_uart

This QOMifies the SiFive UART model. Migration and reset have been implemented. Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 11 ++-- hw/char/sifive_uart.c | 114 +++--- 2 files changed, 109 insertions(+), 16 deletions(-) diff --git a

[PATCH v4 1/2] hw/char: Consistent function names for sifive_uart

This cleanes up function names in the SiFive UART model. Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 46 ++- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index fe12666789

[PATCH v3 2/2] hw/char: sifive_uart

QOMify sifive_uart model Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 11 ++-- hw/char/sifive_uart.c | 114 +++--- 2 files changed, 109 insertions(+), 16 deletions(-) diff --git a/include/hw/char/sifive_uart.h b/include/hw/char

[PATCH v3 0/2] QOMify Sifive UART Model

Hello, I have cleaned up the indentation as requested by Philippe. Also I added reset and migration capabilities as requested by Peter. Thank you for your feedback. I hope this is satisfactory now. Best regards, Lukas Lukas Jünger (2): hw/char: sifive_uart hw/char: sifive_uart include/hw

[PATCH v3 1/2] hw/char: sifive_uart

Make function names consistent Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 46 ++- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index fe12666789..5df8212961 100644 --- a/hw/char

[PATCH v2 2/2] hw/char: sifive_uart

QOMify sifive_uart model Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13 deletions(-) diff --git a/include/hw/char/sifive_uart.h b/include/hw/char/sifive_uart.h

[PATCH v2 0/2] QOMify Sifive UART Model

UART model before. If I understand correctly, I would not be able to test it. It should probably be a different patch set adding migration for the entire machine. I hope that's okay. Best regards, Lukas Lukas Jünger (2): hw/char: sifive_uart hw/char: sifive_uart include/hw/char/sifive_u

[PATCH v2 1/2] hw/char: sifive_uart

Make function names consistent Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index fe12666789..101d68d8cf 100644 --- a/hw/char

Re: [PATCH 2/2] QOMify sifive_uart model

On 5/11/21 2:26 PM, Philippe Mathieu-Daudé wrote: Hi Lukas, On 5/4/21 5:34 PM, Lukas Jünger wrote: Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13

[PATCH 1/2] Consistent function names for sifive uart read and write function

Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 3a00ba7f00..cb70374ead 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -65,7 +65,7

[PATCH 0/2] QOMify Sifive UART model

Hello, This patch QOMifies the Sifive UART model. It is split into two commits. The first commit makes the sifive uart read and write function names more consistent. The second commit QOMifies the model. Looking forward to hear from you, Lukas Lukas Jünger (2): Consistent function names for

[PATCH 2/2] QOMify sifive_uart model

Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13 deletions(-) diff --git a/include/hw/char/sifive_uart.h b/include/hw/char/sifive_uart.h index 3e962be659