t;
> Therefore, I am asking permission from the current authors of this
> tool to loosen the license. At present, those people are:
>
> - John Snow (me!), 411/609
> - Luiz Capitulino, Author, 97/609
> - Daniel Berrangé, 81/609
> - Eduardo Habkost, 10/609
> - Marc-André Lureau
On Wed, 23 Jan 2019 17:12:35 +0100
Max Reitz wrote:
> On 23.01.19 17:04, Luiz Capitulino wrote:
> > On Wed, 23 Jan 2019 16:48:49 +0100
> > Max Reitz wrote:
> >
> >> Hi,
> >>
> >> When running 169 in parallel (e.g. like so:
> >>
>
On Wed, 23 Jan 2019 16:48:49 +0100
Max Reitz wrote:
> Hi,
>
> When running 169 in parallel (e.g. like so:
>
> $ while TEST_DIR=/tmp/t0 ./check -T -qcow2 169; do; done
> $ while TEST_DIR=/tmp/t1 ./check -T -qcow2 169; do; done
> $ while TEST_DIR=/tmp/t2 ./check -T -qcow2 169; do; done
> $ while
On Thu, 13 Sep 2018 03:06:27 -0400 (EDT)
Pankaj Gupta wrote:
> >
> > > This patch adds virtio-pmem Qemu device.
> > >
> > > This device presents memory address range information to guest
> > > which is backed by file backend type. It acts like persistent
> > > memory device for KVM guest.
On Thu, 13 Sep 2018 02:58:21 -0400 (EDT)
Pankaj Gupta wrote:
> Hi Luiz,
>
> Thanks for the review.
>
> >
> > > This patch adds virtio-pmem driver for KVM guest.
> > >
> > > Guest reads the persistent memory range information from
> > > Qemu over VIRTIO and registers it on nvdimm_bus. It als
On Fri, 31 Aug 2018 19:00:19 +0530
Pankaj Gupta wrote:
> This patch adds virtio-pmem Qemu device.
>
> This device presents memory address range information to guest
> which is backed by file backend type. It acts like persistent
> memory device for KVM guest. Guest can perform read and
> p
On Fri, 31 Aug 2018 19:00:18 +0530
Pankaj Gupta wrote:
> This patch adds virtio-pmem driver for KVM guest.
>
> Guest reads the persistent memory range information from
> Qemu over VIRTIO and registers it on nvdimm_bus. It also
> creates a nd_region object with the persistent memory
> range infor
On Thu, 19 Jul 2018 15:58:20 +0200
David Hildenbrand wrote:
> On 19.07.2018 14:16, Stefan Hajnoczi wrote:
> > On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote:
> >>
> >>>
> This patch adds virtio-pmem Qemu device.
>
> This device presents memory address range in
On Thu, 19 Jul 2018 08:48:19 -0400
Luiz Capitulino wrote:
> > It will be necessary to define specific constants for virtio-pmem
> > instead of passing errno from the host to guest.
>
> Yes, defining your own constants work. But I think the only fsync()
> error that wi
On Thu, 19 Jul 2018 13:16:35 +0100
Stefan Hajnoczi wrote:
> On Thu, Jul 19, 2018 at 01:48:13AM -0400, Pankaj Gupta wrote:
> >
> > >
> > > > This patch adds virtio-pmem Qemu device.
> > > >
> > > > This device presents memory address range information to guest
> > > > which is backed by
On Thu, 19 Jul 2018 01:48:13 -0400 (EDT)
Pankaj Gupta wrote:
> >
> > > This patch adds virtio-pmem Qemu device.
> > >
> > > This device presents memory address range information to guest
> > > which is backed by file backend type. It acts like persistent
> > > memory device for KVM guest.
On Fri, 13 Jul 2018 13:22:32 +0530
Pankaj Gupta wrote:
> This patch adds virtio-pmem Qemu device.
>
> This device presents memory address range information to guest
> which is backed by file backend type. It acts like persistent
> memory device for KVM guest. Guest can perform read and persi
On Mon, 16 Jul 2018 07:46:30 -0400 (EDT)
Pankaj Gupta wrote:
> >
> > > This patch adds virtio-pmem driver for KVM guest.
> > >
> > > Guest reads the persistent memory range information from Qemu over
> > > VIRTIO and registers it on nvdimm_bus. It also creates a nd_region
> > > object with th
On Fri, 13 Jul 2018 13:22:31 +0530
Pankaj Gupta wrote:
> This patch adds virtio-pmem driver for KVM guest.
>
> Guest reads the persistent memory range information from Qemu over
> VIRTIO and registers it on nvdimm_bus. It also creates a nd_region
> object with the persistent memory range infor
On Fri, 13 Jul 2018 13:22:30 +0530
Pankaj Gupta wrote:
> This patch adds functionality to perform flush from guest to host
> over VIRTIO. We are registering a callback based on 'nd_region' type.
> As virtio_pmem driver requires this special flush interface, for rest
> of the region types we are r
On Tue, 13 Feb 2018 13:30:02 +0100
Viktor Mihajlovski wrote:
> On 12.02.2018 19:15, Luiz Capitulino wrote:
> > On Mon, 12 Feb 2018 13:14:32 +0100
> > Viktor Mihajlovski wrote:
> >
> >> -{ 'struct': 'CpuInfoFast',
>
On Mon, 12 Feb 2018 13:14:32 +0100
Viktor Mihajlovski wrote:
> -{ 'struct': 'CpuInfoFast',
> - 'data': {'cpu-index': 'int', 'qom-path': 'str',
> - 'thread-id': 'int', '*props': 'CpuInstanceProperties' } }
> +{ 'union': 'CpuInfoFast',
> + 'base': {'cpu-index': 'int', 'qom-path': 'str',
On Mon, 12 Feb 2018 13:14:30 +0100
Viktor Mihajlovski wrote:
> Presently s390x is the only architecture not exposing specific
> CPU information via QMP query-cpus. Upstream discussion has shown
> that it could make sense to report the architecture specific CPU
> state, e.g. to detect that a CPU h
On Fri, 9 Feb 2018 15:50:00 +0100
Viktor Mihajlovski wrote:
> On 09.02.2018 15:27, Eduardo Habkost wrote:
> [...]
> >> I'm keeping it mainly for s390. Viktor, libvirt is still using
> >> this field in s390, no?
> >>
> >> Dropping halted and having management software still using query-cpus
> >> b
On Fri, 9 Feb 2018 08:56:19 +0100
Viktor Mihajlovski wrote:
> On 08.02.2018 21:33, Eduardo Habkost wrote:
> > On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote:
> > [...]
> >> The "halted" field is somewhat controversial. On the one hand,
>
On Thu, 8 Feb 2018 18:02:07 +0100
Viktor Mihajlovski wrote:
> On 08.02.2018 17:22, Luiz Capitulino wrote:
> > On Thu, 8 Feb 2018 16:52:28 +0100
> > Viktor Mihajlovski wrote:
> >
> >> diff --git a/qapi-schema.json b/qapi-schema.json
> >> index
On Thu, 8 Feb 2018 16:52:28 +0100
Viktor Mihajlovski wrote:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 12c7dc8..0b36860 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -607,7 +607,27 @@
> ##
> { 'struct': 'CpuInfo2',
>'data': {'cpu-index': 'int', '*halted': 'bo
ge even
before query-cpus-fast has returned. This makes one wonder if
this field should be dropped all together. Having the "halted"
field as optional gives a better option for dropping it in
the future, since we can just stop returning it.
Signed-off-by: Luiz Capitulino
---
o v2
- Many
On Thu, 8 Feb 2018 16:21:26 +0100
Cornelia Huck wrote:
> On Thu, 8 Feb 2018 09:09:04 -0500
> Luiz Capitulino wrote:
>
> > On Thu, 8 Feb 2018 10:48:08 +0100
> > Viktor Mihajlovski wrote:
> >
> > > Presently s390x is the only architecture not exposing sp
On Thu, 8 Feb 2018 10:48:08 +0100
Viktor Mihajlovski wrote:
> Presently s390x is the only architecture not exposing specific
> CPU information via QMP query-cpus. Upstream discussion has shown
> that it could make sense to report the architecture specific CPU
> state, e.g. to detect that a CPU h
On Thu, 8 Feb 2018 09:29:28 +
Daniel P. Berrangé wrote:
> On Wed, Feb 07, 2018 at 12:50:14PM -0500, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino
> > ---
> > qapi-schema.json | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --gi
On Thu, 8 Feb 2018 08:41:31 +0100
Viktor Mihajlovski wrote:
> On 07.02.2018 18:50, Luiz Capitulino wrote:
> > The query-cpus command has an extremely serious side effect:
> > it always interrupt all running vCPUs so that they can run
> > ioctl calls. This can cause a huge pe
On Wed, 7 Feb 2018 12:50:59 -0600
Eric Blake wrote:
> On 02/07/2018 11:50 AM, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino
> > ---
> > qapi-schema.json | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/qapi-schema.json
before query-cpus-fast has returned. This makes one wonder if
this field should be dropped all together. Having the "halted"
field as optional gives a better option for dropping it in
the future, since we can just stop returning it.
Signed-off-by: Luiz Capitulino
---
cpus.c
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 4
1 file changed, 4 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index 82d6f12b53..0665a14dba 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -526,6 +526,10 @@
#
# Returns a list of information about each
se in production.
More details in individual patches.
Luiz Capitulino (2):
qmp: add query-cpus-fast
qmp: document query-cpus performance issue
cpus.c | 44 ++
hmp-commands-info.hx | 14 ++
hmp.c| 24 +
On Fri, 2 Feb 2018 12:50:14 -0200
Eduardo Habkost wrote:
> (CCing qemu-devel)
>
> On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote:
> > On Fri, 2 Feb 2018 14:19:38 +
> > Daniel P. Berrangé wrote:
> > > On Fri, Feb 02, 2018 at 12:15:54P
On Wed, 20 Dec 2017 18:37:37 +0800
"那个秀才" wrote:
> Hi,
> Dear master. Where can i get a latest full verson of QAPI ? I wanna
> read some file in VMs by qemu-quest-agent, since then, i found things below:
> https://wiki.qemu.org/QMPhttps://wiki.qemu.org/Features/GuestAgent
>
; -QFloat *qf;
> > -const double value = -42.23423;
> > -
> > -qf = qfloat_from_double(value);
> > -g_assert(qf != NULL);
> > -g_assert(qf->value == value);
> > -g_assert(qf->base.refcnt == 1);
> > -g_assert(qobject_type(QOBJECT(qf)) == QTYPE_QFLO
/dev/null
> > +++ b/tests/check-qnum.c
> > @@ -0,0 +1,131 @@
> > +/*
> > + * QNum unit-tests.
> > + *
> > + * Copyright (C) 2009 Red Hat Inc.
> > + *
> > + * Authors:
> > + * Luiz Capitulino
> > + *
> > + * This work is licensed unde
On Wed, 05 Oct 2016 18:22:28 +0200
Markus Armbruster wrote:
> In the beginning, there was only monitor.c, and it provided what we
> today call HMP, at just under 500 SLOC.
>
> Since then, most (but not all) HMP commands have moved elsewhere, either
> to the applicable subsystem, or to hmp.c. Co
s(-)
Guys,
Thank you very much for taking up maintainership of those
subsystems!
Acked-by: Luiz Capitulino
On Thu, 22 Sep 2016 21:32:38 +0200
Thomas Huth wrote:
> The hmp-commands-info.hx, hmp.h and include/monitor/hmp-target.h
> files were classified as unmaintained. Let's add them to the
> HMP section.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Luiz Capitulino
I probably
ff-by: David Gibson
> ---
> monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Anyone want to volunteer to take this through their tree? If not, I
> can take it through my ppc tree.
Please do.
Reviewed-by: Luiz Capitulino
>
> diff --git a/monitor.c b/
est's tracing
> > >> system
> > >> to emit all events through the hypertrace channel, providing a unified
> > >> and fully
> > >> synchronized trace log. Another use case is timing the performance of
> > >> guest code
> > >>
On Thu, 18 Aug 2016 11:54:24 +0100
Stefan Hajnoczi wrote:
> On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote:
> > The hypertrace channel allows guest code to emit events in QEMU (the host)
> > using
> > its tracing infrastructure (see "docs/trace.txt"). This works in both
> > 'sys
On Tue, 9 Aug 2016 21:35:04 +0800
Peter Xu wrote:
> On Tue, Aug 09, 2016 at 10:28:41AM +0200, Igor Mammedov wrote:
> > On Mon, 8 Aug 2016 16:57:14 +0800
> > Peter Xu wrote:
> >
> > > On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote:
> > > > HI, everyone.
> > > >
> > > > We have don
"acutal: %d
> oldacutal: %d"
> +virtio_balloon_get_config(uint32_t num_pages, uint32_t actual) "num_pages:
> %d actual: %d"
> +virtio_balloon_set_config(uint32_t actual, uint32_t oldactual) "actual: %d
> oldactual: %d"
> virtio_balloon_to_target(uint64_t target, uint32_t num_pages) "balloon
> target: %"PRIx64" num_pages: %d"
>
> # hw/intc/apic_common.c
Reviewed-by: Luiz Capitulino
On Thu, 24 Mar 2016 13:16:20 +0800
Peter Xu wrote:
> Hi, Steven,
>
> On Fri, Mar 04, 2016 at 08:23:11AM -0500, Steven Rostedt wrote:
> > My idea for a trace-cmd server, is to have a --client operation, for
> > running on the guest.
> >
> > trace-cmd server --client
> >
> > The connection wil
Very recently, trace-cmd got a few new features that allow you
to merge the host and guest kernel traces using the host TSC.
Those features originated in the tracing we're doing to debug spikes
in real-time KVM. However, as real-time KVM uses a very specific
setup and as we have so far debugged a
-mem-prealloc.
Signed-off-by: Luiz Capitulino
---
numa.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/numa.c b/numa.c
index 425ef8d..0e1638d 100644
--- a/numa.c
+++ b/numa.c
@@ -418,12 +418,13 @@ static void allocate_system_memory_nonnuma(MemoryRegion
*mr, Object
Markus, are you planning a pull request soon?
Reviewed-by: Luiz Capitulino
>
> ===
> From b0363f4c0e91671064dd7ffece8a6923c8dcaf20 Mon Sep 17 00:00:00 2001
> From: Prasad J Pandit
> Date: Thu, 17 Dec 2015 17:47:15 +0530
> Subject: [PATCH] hmp: avoid redundant null te
at:
>
> Reviewed-by: Markus Armbruster
Reviewed-by: Luiz Capitulino
>
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > ---
> > monitor.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > di
On Tue, 3 Nov 2015 14:53:59 +0100
Paolo Bonzini wrote:
> On 03/11/2015 14:46, Luiz Capitulino wrote:
> >> > Can you explain why that would make sense? :) (Especially since there
> >> > is another extension---JSON5---that does exactly what we're doing, so it
>
On Tue, 3 Nov 2015 06:40:32 -0700
Eric Blake wrote:
> On 11/03/2015 06:19 AM, Luiz Capitulino wrote:
> > On Tue, 03 Nov 2015 08:17:58 +0100
> > Markus Armbruster wrote:
> >
> >>> So at this point, I want to see if lloyd makes any progress towards an
> >&g
On Tue, 3 Nov 2015 14:38:38 +0100
Paolo Bonzini wrote:
>
>
> On 03/11/2015 14:19, Luiz Capitulino wrote:
> > > The value proposition of replacing our flawed JSON parser isn't in
> > > saving big on maintenance, it's in not having to find and fix its flaws.
On Tue, 03 Nov 2015 08:17:58 +0100
Markus Armbruster wrote:
> > So at this point, I want to see if lloyd makes any progress towards an
> > actual yajl release and/or adding a co-maintainer, before even trying to
> > get formal upstream support for single quoting. We could always create
> > a git
[I thought I had replied to this thread, but it doesn't seem so. So,
I'll try again]
On Fri, 30 Oct 2015 13:45:48 -0600
Eric Blake wrote:
> Loaded question in response to
> https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06988.html, but
> posting as a new thread to call attention to i
On Thu, 29 Oct 2015 17:23:43 +0100
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Thu, 29 Oct 2015 12:15:09 +0100
> > Markus Armbruster wrote:
> >
> >> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
> >>
> >> Signed-o
On Thu, 29 Oct 2015 12:15:09 +0100
Markus Armbruster wrote:
> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Luiz Capitulino
I think this can go through your tree?
> ---
> monitor.c | 1 +
> 1 file changed, 1 inse
y tree, since got a QMP series
> based on it (to be posted shortly).
Please do.
Reviewed-by: Luiz Capitulino
Btw, what do you think about this patch? :)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9bd2b8f..aa03f3d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1010,7 +1010,7 @@ F: qemu-timer.c
ity (well, one could
wrap qemu in bash and pass this by default but this is not ideal)
- A true logging facility would also log responses and events
- I don't think it's important to log HMP
>
> Signed-off-by: Pavel Butsykin
> Signed-off-by: Denis V. Lunev
> CC: Ma
p/README => qmp-intro.txt} (100%)
> rename docs/{qmp => }/qmp-spec.txt (100%)
>
Reviewed-by: Luiz Capitulino
On Fri, 11 Sep 2015 20:22:38 -0400
Programmingkid wrote:
> Could you make a tutorial on how to use the QDict type?
There are several examples in tests/check-qdict.c.
On Tue, 8 Sep 2015 09:04:56 -0400 (EDT)
Paolo Bonzini wrote:
>
> > > This should be added in patch 4, not now.
> > >
> > > > +const MonitorDef *target_monitor_defs(void) __attribute__((weak));
> > > > +
> > > > +const MonitorDef *target_monitor_defs(void)
> > > > +{
> > > > +return NULL;
>
On Tue, 8 Sep 2015 11:54:46 +0200
Paolo Bonzini wrote:
>
>
> On 08/09/2015 09:09, Denis V. Lunev wrote:
> > qemu-monitor-info.texi | 151 +++
>
> This should be added in patch 4, not now.
>
> > +const MonitorDef *target_monitor_defs(void) __attribute__((weak));
> > +
> > +const
gt; (qemu) info iothreads
> iothread-1: thread_id=123
> iothread-2: thread_id=456
>
> Signed-off-by: Ting Wang
Reviewed-by: Luiz Capitulino
Markus will take this patch via his tree.
> ---
> v5: use "for" instead of "while"
> ---
> hmp-commands.hx |
On Thu, 23 Jul 2015 09:36:38 +0200
Markus Armbruster wrote:
> John Snow writes:
>
> > On 07/02/2015 11:31 AM, Luiz Capitulino wrote:
> >> On Wed, 1 Jul 2015 14:25:49 -0400
> >> John Snow wrote:
> >>
> >>> I should probably document the
On Wed, 1 Jul 2015 14:25:49 -0400
John Snow wrote:
> I should probably document the changes that were made.
>
> Signed-off-by: John Snow
Looks good to me, CC'ing maintainer.
> ---
> scripts/qmp/qmp-shell | 35 +++
> 1 file changed, 35 insertions(+)
>
> diff
On Tue, 23 Jun 2015 13:57:08 +0200
Markus Armbruster wrote:
> Ting Wang writes:
>
> > Hi Luiz and Markus,
> >
> > Would you like to pick up this patch, which has
> > been reviewed by Stefan and Fam?
>
> Looks like this fell through the cracks back in March. You should've
> asked for merge muc
On Tue, 16 Jun 2015 15:08:41 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Sat, 13 Jun 2015 16:20:47 +0200
> > Markus Armbruster wrote:
> >
> >> After a bit over a year and many patches, QError is finally ripe. All
> >> that'
ew this series, but unfortunately my review is
a bit weak because I'm not that familiar with some code paths
(like QemuOpts) and I was unable to apply patches starting with patch 04/11.
But it does look good to me:
Reviewed-by: Luiz Capitulino
>
> The diffstat looks a bit scary, but t
On Sat, 13 Jun 2015 16:20:51 +0200
Markus Armbruster wrote:
> Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used
> in new code. Hiding them in QERR_ macros makes new uses hard to spot.
> Fortunately, there's just one such macro left. Eliminate it with this
> coccinelle semant
On Thu, 28 May 2015 16:18:41 -0400
Luiz Capitulino wrote:
> On Mon, 18 May 2015 13:22:16 +0200
> hw.clau...@gmail.com wrote:
>
> > From: Claudio Fontana
> >
> > This is the latest iteration of the memory search patch,
> > including a trivial replacement fo
On Thu, 28 May 2015 15:54:12 -0400
Luiz Capitulino wrote:
> On Fri, 15 May 2015 16:24:58 -0600
> Eric Blake wrote:
>
> > Passing around an 'int' for a QBool type is weird, when we already
> > use a C99 compiler and have a sane 'bool' that does just f
ound to doing a monitor/HMP pull request, I'm happy to take
> this series along, if it gets your Acked-by.
I'd be immensely grateful if you pick this series along with the
other ones, as we've spoken in pvt. Thanks a lot Markus for your
help!
Acked-by: Luiz Capitulino
void a conflict with monitor_disas which
> is touched by both patches. If one patch gets acked, the other nacked then
> either can be merged independently with trivial edits.
Unfortunately, I'm quite busy and won't have time to push this
through my tree. Markus is going to pick
Engineer
> Samsung Electronics Research center Russia
>
>
> > -Original Message-
> > From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mailto:qemu-devel-
> > bounces+p.fedin=samsung@nongnu.org] On Behalf Of Pavel Fedin
> > Sent: Thursday, Ma
On Tue, 2 Jun 2015 01:06:11 -0700
Peter Crosthwaite wrote:
> Ping!
>
> So there was some uncertainty around maintainerships earlier (on some
> follow up work to this one) and I wonder what the target queue is for
> this stuff.
It's the monitor queue, for which I'm the maintainer. But I won't ha
and(JSONMessageParser
> *parser, QList *tokens)
> goto err_out;
> }
> if (invalid_qmp_mode(mon, cmd, &local_err)) {
> -qerror_report_err(local_err);
> goto err_out;
> }
Reviewed-by: Luiz Capitulino
>
>
On Fri, 29 May 2015 16:19:28 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 29 May 2015 11:56:50 +0200
> > Markus Armbruster wrote:
> >
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> monitor.c | 18 +
found", cmd_name);
> goto err_out;
> }
> -if (invalid_qmp_mode(mon, cmd)) {
> +if (invalid_qmp_mode(mon, cmd, &local_err)) {
> +qerror_report_err(local_err);
I don't think you need to call qerror_report_err() here, and you could
have changed invalid_qmp_mode() to return void. You can make those changes
before applying if you choose to do them:
Reviewed-by: Luiz Capitulino
> goto err_out;
> }
>
On Fri, 15 May 2015 16:24:58 -0600
Eric Blake wrote:
> Passing around an 'int' for a QBool type is weird, when we already
> use a C99 compiler and have a sane 'bool' that does just fine.
>
> I half-debated sending this through qemu-trivial, but think it
> better belongs through the QMP tree. Th
On Mon, 18 May 2015 13:22:16 +0200
hw.clau...@gmail.com wrote:
> From: Claudio Fontana
>
> This is the latest iteration of the memory search patch,
> including a trivial replacement for the memmem function for systems
> which don't provide one (notably Windows).
>
> It detects the presence of m
free to add this once
you fix the bug:
Reviewed-by: Luiz Capitulino
>
> v2:
> * Trivially rebased
> * PATCH 01: Drop another async remnant [Eric]
> * PATCH 01+02+18: Improve commit messages
> * PATCH 03+04: client_migrate_info still hasn't been implemented VNC,
> de-docum
On Tue, 26 May 2015 17:20:48 +0200
Markus Armbruster wrote:
> The previous commits narrowed use of QError to handle_qmp_command()
> and its helpers monitor_protocol_emitter(), build_qmp_error_dict().
> Narrow it further to just the command handler call: instead of
> converting Error to QError thr
On Tue, 26 May 2015 17:20:39 +0200
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> hmp-commands.hx | 3 +--
> hmp.c| 17 +
> hmp.h| 1 +
> monitor.c| 42 ++
>
On Tue, 26 May 2015 17:20:44 +0200
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> monitor.c | 65
> ---
> 1 file changed, 33 insertions(+), 32 deletions(-)
>
> diff --git a/monitor.c b/
On Fri, 24 Apr 2015 14:39:48 +0200
hw.clau...@gmail.com wrote:
> From: Claudio Fontana
>
> usage is similar to the commands x, xp.
>
> Example with string: looking for "ELF" header in memory:
>
> (qemu) s/100cb 0x40001000 "ELF"
> searching memory area [40001000-400f5240]
>
On Mon, 11 May 2015 13:53:47 +0100
Peter Maydell wrote:
> On 8 May 2015 at 14:34, Luiz Capitulino wrote:
> > The following changes since commit f8340b360b9bc29d48716ba8aca79df2b9544979:
> >
> > hw/ptimer: Do not artificially limit timers when using icount (2015-05-0
ke
Tested-by: Kashyap Chamarthy
Signed-off-by: Luiz Capitulino
---
scripts/qmp/qmp-shell | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index 1df2ca7..65280d2 100755
--- a/scripts/qmp/qmp-shell
+++ b
ch does
not improve this functionality.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Tested-by: Kashyap Chamarthy
Signed-off-by: Luiz Capitulino
---
scripts/qmp/qmp-shell | 63 ++-
1 file changed, 47 insertions(+), 16 deletions(-)
diff --gi
still the maintainer of HMP and QObjects, but I'm
looking for someone to take over those too.
PS: This commit also fixes the file listing for the QMP
entry.
Signed-off-by: Luiz Capitulino
Reviewed-by: Michael Roth
Signed-off-by: Markus Armbruster
---
MAINTAINERS | 18 +--
shell: add transaction subshell
scripts: qmp-shell: Add verbose flag
Luiz Capitulino (1):
MAINTAINERS: New maintainer for QMP and QAPI
Markus Armbruster (2):
qobject: Clean up around qtype_code
qobject: Add a special null QObject
MAINTAINERS| 18 +++---
bl
: '\x02' '\x00' '\xb7' '\x00'
Example with value: looking for 64bit variable value 0x990088
(qemu) s/100xg 0x90004200 0x990088
searching memory area [90004200-9000427a1200]
9000424b3000
9000424c1000
Signed-off-by: Claudio Fontana
-by: Luiz Capitulino
---
scripts/qmp/qmp-shell | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
index e0e848b..a9632ec 100755
--- a/scripts/qmp/qmp-shell
+++ b/scripts/qmp/qmp-shell
@@ -88,16 +88,8 @@ class
regardless of which shell mode you are in.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Tested-by: Kashyap Chamarthy
Signed-off-by: Luiz Capitulino
---
scripts/qmp/qmp-shell | 42 +-
1 file changed, 41 insertions(+), 1 deletion(-)
diff --git a/scri
": []}}
{"execute":"qmp_capabilities","id":null}
{"return": {}, "id": null}
{"id":{"a":null,"b":[1,null]},"execute":"quit"}
{"return": {}, "id": {"a": null, &q
s intentionally unrelated
to them.
Signed-off-by: Markus Armbruster
Signed-off-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
include/qapi/qmp/qobject.h | 11 ++-
qobject/Makefile.objs | 2 +-
qobject/qjson.c| 3 +++
qobject/qnull.c
Signed-off-by: Luiz Capitulino
---
qjson.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qjson.c b/qjson.c
index 0cda269..e478802 100644
--- a/qjson.c
+++ b/qjson.c
@@ -24,6 +24,8 @@ struct QJSON {
bool omit_comma;
};
+#define QJSON(obj) OBJECT_CHECK
member qtype's type: it's a qtype_code.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
block/qapi.c | 3 ---
include/hw/qdev-core.h | 2 +-
include/qapi/qmp/qobject.h | 2 +-
qobject/qjson.c| 3 +--
4 files
On Wed, 29 Apr 2015 15:14:00 -0400
John Snow wrote:
> The qmp-shell is a little rudimentary, but it can be hacked
> to give us some transactional support without too much difficulty.
>
> (1) Prep.
> (2) Add support for serializing json arrays and
> improve the robustness of QMP parsing
> (3)
On Mon, 4 May 2015 16:09:58 -0300
Eduardo Habkost wrote:
> This will allow clients to query additional information directly using
> qom-get on the CPU objects.
Eduardo, I'm not applying this patch this time because Eric's comments
have to be addressed.
>
> Signed-off-by: Eduardo Habkost
> --
still the maintainer of HMP and QObjects, but I'm
looking for someone to take over those too.
PS: This commit also fixes the file listing for the QMP
entry.
Signed-off-by: Luiz Capitulino
---
PPS: I'll post a last QMP pull request this week.
MAINTAINERS | 18 +
On Wed, 6 May 2015 07:38:53 -0300
Eduardo Habkost wrote:
> On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote:
> > On Tue, 5 May 2015 10:14:32 -0300
> > Eduardo Habkost wrote:
> >
> > > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote:
> > > > The HMP command info cp
1 - 100 of 5376 matches
Mail list logo
