On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote:
> On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan Hajnoczi wrote:
> > On Fri, Aug 01, 2014 at 03:39:58PM +0200, Levente Kurusa wrote:
> > > Fixed size VPC images do not have a footer, hence the current probe
> >
> On Mon, Aug 04, 2014 at 05:06:21PM +0200, Levente Kurusa wrote:
> > It was expecting an integer, however the sole usecase of it just
> > checked whether it was assigned to or not. Hence, remove integerness,
> > and add a new bitfield instead.
> >
> > Signed-
> The function fstat() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang
Acked-by: Levente Kurusa
Thanks!
Levente Kurusa
iting for fstat fd '%d' failed: %s\n",
> +fd, strerror(errno));
exiting for fstat?
I would go with something like this:
"ivshmem: exiting: fstat on fd %d failed: %s"
... or something among the lines.
Thanks!
Levente Kurusa
ing message and return 0?
> what's your opinion? Thanks.
Yes, please return -1. All the errors fstat(2) can return in this scenario
will be fatal to ivshmem.
Exiting is probably not the best way to go, but I'm working on a fix for
that at the moment, and for now, let's just exit, like all the other error
paths do.
Thanks,
Levente Kurusa
It was expecting an integer, however the sole usecase of it just
checked whether it was assigned to or not. Hence, remove integerness,
and add a new bitfield instead.
Signed-off-by: Levente Kurusa
---
hw/misc/ivshmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw
ivsmem_offset was removed, however this debug statement was not updated.
Modify the statement to fit the new mechanic.
Signed-off-by: Levente Kurusa
---
hw/misc/ivshmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index bb1f67c
Two simple patches.
The first one fixes a build error when IVSHMEM_DEBUG is enabled,
and the second one converts an argument from integer to a bitfield,
and makes all (1) callsites use ivshmem_has_feature.
Levente Kurusa (2):
ivshmem: fix building when debug mode is enabled
ivshmem: convert
: Levente Kurusa
---
block/vpc.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index a6a7213..b12354a 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -164,8 +164,27 @@ static int vpc_check_signature(const void *buf)
static int
-by: Andrew Jones
Signed-off-by: Levente Kurusa
---
block.c | 2 +-
block/bochs.c | 3 ++-
block/cloop.c | 3 ++-
block/cow.c | 3 ++-
block/dmg.c | 3 ++-
block/parallels.c | 3 ++-
block/qcow.c | 3 ++-
block/qc
to the probe functions, hence giving them a chance to read
the extra bytes they might need.
Levente Kurusa (3):
block: format: pass down the current state to the format's probe
function
block: vpc: introduce vpc_check_signature function
block: vpc: handle fixed size images in
Check the signature in a helper function instead of in plain
code in order to avoid code duplication
Reviewed-by: Andrew Jones
Signed-off-by: Levente Kurusa
---
block/vpc.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 2ba8fc2
12 matches
Mail list logo
