Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread LI, BO XUAN
Gotcha, thanks for the tip! Best regards, Boxuan Li On Sat, May 4, 2019 at 1:00 AM Alex Bennée wrote: > > LI, BO XUAN writes: > > > Hi Alex, > > > > Sorry about that, I am still trying to get familiar with the patch > > submission process. Since my patc

Re: [Qemu-devel] [PATCH v4] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread LI, BO XUAN
Hi Alex, Sorry about that, I am still trying to get familiar with the patch submission process. Since my patch has been changed from your last review, I thought it would be safe to not include the r-b tag from last time. Will take care next time! Best regards, Boxuan Li On Sat, May 4, 2019 at 12

Re: [Qemu-devel] [PATCH v3] hw/virtio/virtio-mmio: Convert DPRINTF to trace and log

2019-05-03 Thread LI, BO XUAN
Gotcha, thanks for the tip! I'll resend updated patch soon. On Fri, May 3, 2019 at 5:12 PM Philippe Mathieu-Daudé wrote: > Hi Li, > > On 5/3/19 10:46 AM, Boxuan Li wrote: > > Use traces for debug message and qemu_log_mask for errors. > > > > Signed-off-by: Boxuan Li > > --- > > v1: > https://pa

Re: [Qemu-devel] [PATCH v2] hw/virtio/virtio-mmio: Convert DPRINTF to traces

2019-05-02 Thread LI, BO XUAN
Hi Yuval and Alex, Thanks for the suggestions. I'll update and send a patch v3 soon. Best regards, Boxuan Li On Wed, May 1, 2019 at 11:17 PM Alex Bennée wrote: > > Yuval Shaia writes: > > > On Wed, May 01, 2019 at 08:42:35PM +0800, LI, BO XUAN wrote: > >>O

Re: [Qemu-devel] [PATCH v2] hw/virtio/virtio-mmio: Convert DPRINTF to traces

2019-05-01 Thread LI, BO XUAN
On Wed, May 1, 2019 at 4:58 PM Yuval Shaia wrote: > On Wed, May 01, 2019 at 04:10:39PM +0800, Boxuan Li wrote: > > Signed-off-by: Boxuan Li > > --- > > v2: Instead of using conditional debugs, convert DPRINTF to traces > > --- > > hw/virtio/trace-events | 13 + > > hw/virtio/virtio

Re: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-30 Thread LI, BO XUAN
Hi Eric and Phil, Thanks for your reviews. I am looking into trace events and I'll send a patch v2 soon. Eric Blake 於 2019年4月30日週二 下午11:03寫道: > On 4/30/19 5:15 AM, Philippe Mathieu-Daudé wrote: > > Hi Li, > > > > On 4/28/19 1:02 PM, Boxuan Li wrote: > >> Wrap printf calls inside debug macros (D