Thank you! Grateful for it.
Regards,
Kshitij Suri
On 11/05/22 1:16 pm, Paolo Bonzini wrote:
+if png.found()
+ softmmu_ss.add(png)
+endif
Queued, thanks. However, this can be just "softmmu_ss.add(png) without
the if, so I adjusted that.
Paolo
Hi,
I have sent the fix out at
https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg01980.html.
Would be grateful for your review.
Regards,
Kshitij Suri
On 06/05/22 7:07 pm, Peter Maydell wrote:
On Wed, 27 Apr 2022 at 18:33, Gerd Hoffmann wrote:
From: Kshitij Suri
Currently
Currently png support is dependent on vnc for linking object file to
libpng. This commit makes the parameter independent of vnc as it breaks
system emulator with --disable-vnc unless --disable-png is added.
Fixes: 9a0a119a382867dc9a5c2ae9348003bf79d84af2
Signed-off-by: Kshitij Suri
---
ui
Hi,
Apologies for missing the references. Should I send an updated patch for
the same?
Regards,
Kshitij Suri
On 26/04/22 11:05 pm, Richard Henderson wrote:
y detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace
use of
Suri
On 08/04/22 12:43 pm, Kshitij Suri wrote:
This patch series aims to add PNG support using libpng to screendump method.
Currently screendump only supports PPM format, which is uncompressed.
PATCH 1 phases out CONFIG_VNC_PNG parameter and replaces it with CONFIG_PNG
which detects libpng support
ot;: "/tmp/image",
"format":"png" } }
HMP example usage:
screendump /tmp/image -f png
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/718
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
diff to v4:
- Modified format to be an optional flag ba
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
meson.build| 12
ad of string.
- Improved error handling.
Kshitij Suri (2):
Replacing CONFIG_VNC_PNG with CONFIG_PNG
Added parameter to take screenshot with screendump as PNG
hmp-commands.hx| 11 ++---
meson.build| 12 +++---
meson_options.txt | 4 +-
monitor/hmp-cmds.c | 12 +-
qapi/ui.json
On 01/04/22 4:50 pm, Markus Armbruster wrote:
Dave, please have a look at the HMP compatibility issue in
hmp-command.hx below.
Kshitij Suri writes:
Currently screendump only supports PPM format, which is un-compressed and not
standard.
If "standard" means "have to
On 30/03/22 2:39 am, Paolo Bonzini wrote:
On 3/29/22 15:42, Kshitij Suri wrote:
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace
use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
d QEMU support version.
v1->v2:
- Removed repeated alpha conversion operation.
- Modified logic to mirror png conversion in vnc-enc-tight.c file.
- Added a new CONFIG_PNG parameter for libpng support.
- Changed input format to enum instead of string.
- Improved error handling.
Kshiti
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
diff to v3:
- Added condition to check for libpng
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
meson.build| 9
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
ration.
- Modified logic to mirror png conversion in vnc-enc-tight.c file.
- Added a new CONFIG_PNG parameter for libpng support.
- Changed input format to enum instead of string.
- Improved error handling.
Kshitij Suri (2):
Replacing CONFIG_VNC_PNG with CONFIG_PNG
Added parameter to take scre
gh
getting that one wrong doesn't really have much ill effect.
thanks
-- PMM
Oh so regarding this PNG issue which has 2 patches, one to phase out
VNC_PNG and one for core logic, should I send with a cover-letter?
Thank you for our advice!
Regards,
Kshitij Suri
On 29/03/22 2:31 pm, Daniel P. Berrangé wrote:
On Tue, Mar 29, 2022 at 09:59:55AM +0200, Markus Armbruster wrote:
Kshitij Suri writes:
On 29/03/22 12:12 pm, Markus Armbruster wrote:
If I count correctly, this is the fifth posting tagged "v2". Don't do
that, please
On 29/03/22 1:29 pm, Markus Armbruster wrote:
Kshitij Suri writes:
On 29/03/22 12:12 pm, Markus Armbruster wrote:
If I count correctly, this is the fifth posting tagged "v2". Don't do
that, please, as it's quite confusing.
Thank you for your review and I apologise
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
meson.build| 9
on updates should be done only
when there are significant design changes to the patch which didn't
happen in the v2 version. Will update it to v3 and send the patch.
Regards,
Kshitij Suri
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
meson.build| 9
On 28/03/22 3:22 pm, Daniel P. Berrangé wrote:
On Tue, Mar 22, 2022 at 10:49:53AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG ima
Hi, Hope this mail finds you well. I have updated the code as required
and would be grateful if you could review and suggest changes that are
needed to be implemented. In case no change is required, please do let
me know the next steps for the same.
Regards,
Kshitij Suri
On 22/03/22 4:19 pm
Hi, Hope this mail finds you well. I have updated the code as required
and would be grateful if you could review and suggest changes that are
needed to be implemented. In case no change is required, please do let
me know the next steps for the same.
Regards,
Kshitij Suri
On 22/03/22 4:19 pm
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
meson.build| 9
On 22/03/22 3:45 pm, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump c
On 22/03/22 3:17 pm, Daniel P. Berrangé wrote:
On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG ima
On 22/03/22 3:12 pm, Daniel P. Berrangé wrote:
On Tue, Mar 22, 2022 at 08:18:44AM +, Kshitij Suri wrote:
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
---
meson.build| 9 -
meson_options.txt | 4 ++--
ui/vnc-enc-tight.c
On 16/03/22 6:55 pm, Markus Armbruster wrote:
Kshitij Suri writes:
From: "kshitij.suri"
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image captu
On 15/03/22 3:49 pm, Daniel P. Berrangé wrote:
On Tue, Mar 15, 2022 at 11:06:31AM +0100, Markus Armbruster wrote:
Kshitij Suri writes:
On 11/03/22 5:50 pm, Markus Armbruster wrote:
Kshitij Suri writes:
Currently screendump only supports PPM format, which is un-compressed and not
;png" } }
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/718
Signed-off-by: Kshitij Suri
---
diff to v1:
- Removed repeated alpha conversion operation.
- Modified logic to mirror png conversion in vnc-enc-tight.c file.
- Added a new CONFIG_PNG parameter for libpng supp
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
---
meson.build| 9 -
meson_options.txt | 4 ++--
ui/vnc-enc-tight.c
On 11/03/22 5:50 pm, Markus Armbruster wrote:
Kshitij Suri writes:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image capture using libpng. The param was add
Hi,
Hope this mail finds you well. I have updated the code as required and
request you to review and suggest changes that are needed to be
implemented. In case no change is required, please do let me know the
next steps for the same.
Regards,
Kshitij Suri
On 01/03/22 12:14 pm, Kshitij
Hi,
Hope this mail finds you well. I have updated the code as required and
request you to review and suggest changes that are needed to be
implemented. In case no change is required, please do let me know the
next steps for the same.
Regards,
Kshitij Suri
On 01/03/22 12:14 pm, Kshitij
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
---
meson.build| 9 -
meson_options.txt | 4 ++--
ui/vnc-enc-tight.c
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
---
meson.build| 10 +-
meson_options.txt | 4 ++--
ui/vnc-enc-tight.c
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
On 26/02/22 12:42 am, Daniel P. Berrangé wrote:
On Fri, Feb 25, 2022 at 11:58:29AM +, Kshitij Suri wrote:
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG
On 26/02/22 12:37 am, Eric Blake wrote:
On Fri, Feb 25, 2022 at 11:58:30AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image cap
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
---
meson.build| 10 +-
meson_options.txt | 4 ++--
ui/vnc-enc-tight.c
On 25/02/22 2:40 pm, Daniel P. Berrangé wrote:
On Fri, Feb 25, 2022 at 11:26:20AM +0530, Kshitij Suri wrote:
On 24/02/22 9:48 pm, Daniel P. Berrangé wrote:
On Thu, Feb 24, 2022 at 11:59:08AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and
On 24/02/22 9:48 pm, Daniel P. Berrangé wrote:
On Thu, Feb 24, 2022 at 11:59:08AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG ima
On 24/02/22 9:32 pm, Eric Blake wrote:
On Thu, Feb 24, 2022 at 11:59:08AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image cap
On 23/02/22 4:30 pm, Dr. David Alan Gilbert wrote:
* Kshitij Suri (kshitij.s...@nutanix.com) wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added an "format" parameter to qemu monitor screendump capabilites
to support PNG image cap
On 22/02/22 10:04 pm, Daniel P. Berrangé wrote:
On Tue, Feb 22, 2022 at 03:27:58PM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added an "format" parameter to qemu monitor screendump capabilites
to support PNG ima
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
) function which converts
pixman_image to PNG. HMP command equivalent was also modified to support the
feature.
Example usage:
{ "execute": "screendump", "arguments": { "filename": "/tmp/image",
"format":"png" } }
Resolves
56 matches
Mail list logo
