Re: [PATCH RFC -qemu 0/2] hw/cxl: Support Back Invalidation

2025-07-31 Thread Jonathan Cameron via
On Tue, 29 Jul 2025 09:54:39 -0700 Davidlohr Bueso wrote: > Hello, > > The following allows support for component basic back invalidation discovery > and config, by exposing the BI routing table and decoder registers. Instead > of going the type2[1] route, this series proposes adding support for

Re: [RFC PATCH 3/3] tests/qtest/migration: Change cpu for aarch64

2025-07-31 Thread Jonathan Cameron via
On Wed, 30 Jul 2025 17:52:45 -0300 Fabiano Rosas wrote: > Don't use the 'max' cpu for migration testing of aarch64. That cpu > does not provide a stable set of features and is expected to break > migration from time to time. Whilst I can see the motivation, doesn't this leave us with a lack of c

Re: [PATCH] hw/arm: add static NVDIMMs in device tree

2025-07-31 Thread Jonathan Cameron via
On Wed, 30 Jul 2025 15:21:41 +0300 Manos Pitsidianakis wrote: > NVDIMM is used for fast rootfs with EROFS, for example by kata > containers. To allow booting with static NVDIMM memory, add them to the > device tree in arm virt machine. > > This allows users to boot directly with nvdimm memory de

Re: [PATCH] hw/i386/pc: Avoid overlap between CXL window and PCI 64bit BARs in QEMU

2025-07-28 Thread Jonathan Cameron via
On Sat, 26 Jul 2025 20:50:35 +0800 peng guo wrote: > On Fri, Jul 25, 2025 at 02:53:37PM +0100, Jonathan Cameron wrote: > > On Fri, 18 Jul 2025 21:35:45 +0800 > > peng guo wrote: > > > > > When using a CXL Type 3 device together with a virtio 9p device in QEMU, > > > the > > > 9p device fails

Re: [RFC PATCH v3 2/2] pci-host/cxl: Support creation of a new CXL Host Bridge

2025-07-25 Thread Jonathan Cameron via
On Tue, 17 Jun 2025 12:06:49 +0800 wangyuquan wrote: > From: Yuquan Wang > > Define a new CXL host bridge type (TYPE_CXL_HOST). This is an > independent CXL host bridge which combined GPEX features (ECAM, MMIO > windows and irq) and CXL Host Bridge Component Registers (CHBCR). > > The root bus

Re: [RFC PATCH v3 1/2] hw/pxb-cxl: Rename the pxb cxl host bridge

2025-07-25 Thread Jonathan Cameron via
On Tue, 17 Jun 2025 12:06:48 +0800 wangyuquan wrote: > This renames some descriptions and definitions of pxb cxl host > bridge, since the original names can be confusing. > > Signed-off-by: Yuquan Wang Fair enough. Reviewed-by: Jonathan Cameron > --- > hw/pci-bridge/pci_expander_bridge.c | 8

Re: [RFC PATCH v6] hw/arm/sbsa-ref: Support CXL Host Bridge & CFMW

2025-07-25 Thread Jonathan Cameron via
On Tue, 17 Jun 2025 12:19:46 +0800 wangyuquan wrote: > From: Yuquan Wang > > This creates a specific CXL host bridge (0001:00) with two cxl > root ports on sbsa-ref. And the memory layout provides separate > space windows for the cxl host bridge in the sbsa-ref memmap: > > - 64K CXL Host Brid

Re: [PATCH v2 2/2] hw/cxl: Add Physical Port Control (Opcode 5102h)

2025-07-25 Thread Jonathan Cameron via
On Thu, 10 Jul 2025 20:13:38 +0530 Arpit Kumar wrote: > -added assert-deassert PERST implementation > for physical ports (both USP and DSP's). > -assert PERST involves bg operation for holding 100ms. > -reset PPB implementation for physical ports. > > Signed-off-by: Arpit Kumar Hi Arpit, Mino

Re: [PATCH v2 1/2] hw/cxl: Refactored Identify Switch Device & Get Physical Port State

2025-07-25 Thread Jonathan Cameron via
On Thu, 10 Jul 2025 20:13:37 +0530 Arpit Kumar wrote: > -Storing physical ports info during enumeration. > -Refactored changes using physical ports info for > Identify Switch Device (Opcode 5100h) & Get Physical Port State > (Opcode 5101h) physical switch FM-API command set. > > Signed-off-by:

Re: [PATCH] hw/i386/pc: Avoid overlap between CXL window and PCI 64bit BARs in QEMU

2025-07-25 Thread Jonathan Cameron via
On Fri, 18 Jul 2025 21:35:45 +0800 peng guo wrote: > When using a CXL Type 3 device together with a virtio 9p device in QEMU, the > 9p device fails to initialize properly. The kernel reports the following: > > virtio: device uses modern interface but does not have VIRTIO_F_VERSION_1 > 9p

Re: [PATCH qemu v4 7/7] hw/cxl: Add emulation for memory sparing control feature

2025-07-25 Thread Jonathan Cameron via
On Mon, 21 Jul 2025 18:22:28 +0100 wrote: > From: Shiju Jose > > Memory sparing is defined as a repair function that replaces a portion of > memory with a portion of functional memory at that same DPA. The > subclasses for this operation vary in terms of the scope of the sparing > being perform

Re: [PATCH qemu v4 6/7] hw/cxl: Add Maintenance support

2025-07-25 Thread Jonathan Cameron via
On Mon, 21 Jul 2025 18:22:27 +0100 wrote: > From: Davidlohr Bueso I tweaked the title to mention Post Package Repair. If anyone is ever looking for that particular maintenance command they might want to know it is in here from the title. > > This adds initial support for the Maintenance comm

Re: [PATCH qemu v4 1/7] hw/cxl/events: Update for rev3.2 common event record format

2025-07-25 Thread Jonathan Cameron via
On Mon, 21 Jul 2025 18:22:22 +0100 wrote: > From: Shiju Jose > > CXL spec 3.2 section 8.2.9.2.1 Table 8-55, Common Event Record > format has updated with optional Maintenance Operation Subclass, > LD ID and ID of the device head information. > > Add updates for the above optional parameters in

Re: [PATCH] hw/i386/pc: Avoid overlap between CXL window and PCI 64bit BARs in QEMU

2025-07-24 Thread Jonathan Cameron via
On Thu, 24 Jul 2025 03:43:56 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 18, 2025 at 09:35:45PM +0800, peng guo wrote: > > When using a CXL Type 3 device together with a virtio 9p device in QEMU, the > > 9p device fails to initialize properly. The kernel reports the following: > > > > vi

Re: [PATCH 4/4] tests: acpi: update expected blobs

2025-07-21 Thread Jonathan Cameron via
On Fri, 18 Jul 2025 19:20:45 +0300 Vadim Chichikalyuk wrote: > Previous patch changed the SPCR ACPI table for AArch64 virt: > @@ -15,2 +15,2 @@ > -[008h 0008 001h]Revision : 02 > -[009h 0009 001h]Checksum : B1 > +[008h 0008 001h]Revision

Re: [PATCH 1/4] hw: acpi: add support for SPCR revision 3

2025-07-21 Thread Jonathan Cameron via
On Fri, 18 Jul 2025 19:20:42 +0300 Vadim Chichikalyuk wrote: > The UART clock frequency field of the SPCR table was added in revision 3. > Currently, build_spcr() treats revision 3 tables the same as revision 2 and > only includes this field in revision 4 tables. Given this isn't in the ACPI spe

Re: [PATCH 3/4] hw: arm: acpi: add UART clock frequency to SPCR table

2025-07-21 Thread Jonathan Cameron via
On Fri, 18 Jul 2025 19:20:44 +0300 Vadim Chichikalyuk wrote: > On the ARM virt machine, there is currently no way to programmatically > discover the frequency of the UART reference clock solely through the use of > UEFI/ACPI (without the DTB). The SPCR table can include this information > as of r

Re: [PATCH 2/4] tests: acpi: whitelist expected blobs

2025-07-21 Thread Jonathan Cameron via
On Fri, 18 Jul 2025 19:20:43 +0300 Vadim Chichikalyuk wrote: > Signed-off-by: Vadim Chichikalyuk > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > b/tests/qtest/bios-tables-test-allowed-di

Re: [RFC PATCH v3 08/15] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback

2025-07-16 Thread Jonathan Cameron via
On Tue, 15 Jul 2025 10:01:21 -0700 Nicolin Chen wrote: > On Tue, Jul 15, 2025 at 11:29:41AM +0100, Jonathan Cameron wrote: > > > +if (!iommufd_backend_alloc_viommu(idev->iommufd, idev->devid, > > > + IOMMU_VIOMMU_TYPE_ARM_SMMUV3, > > > +

Re: [RFC PATCH v3 15/15] hw/arm/smmu-common: Add accel property for SMMU dev

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:41 +0100 Shameer Kolothum wrote: > Now user can set "accel=on". Have fun! > > Signed-off-by: Shameer Kolothum Hard to argue with this one ;) Reviewed-by: Jonathan Cameron > --- > hw/arm/smmu-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm

Re: [RFC PATCH v3 14/15] Read and validate host SMMUv3 feature bits

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:40 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Not all fields in the SMMU IDR registers are meaningful for userspace. > Only the following fields can be used: > >   - IDR0: ST_LEVEL, TERM_MODEL, STALL_MODEL, TTENDIAN, CD2L, ASID16, TTF   >   - IDR1: SIDSIZE

Re: [RFC PATCH v3 13/15] hw/arm/smmuv3: Forward invalidation commands to hw

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:39 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Use the provided smmuv3-accel helper functions to issue the > invalidation commands to host SMMUv3. > > Signed-off-by: Nicolin Chen > Signed-off-by: Shameer Kolothum > --- > hw/arm/smmuv3-internal.h | 11 +++

Re: [RFC PATCH v3 12/15] hw/arm/smmuv3-accel: Introduce helpers to batch and issue cache invalidations

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:38 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Helpers will batch the commands and issue at once to host SMMUv3. > > Signed-off-by: Nicolin Chen > Signed-off-by: Shameer Kolothum > --- > hw/arm/smmuv3-accel.c| 65 +

Re: [RFC PATCH v3 08/15] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:34 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Implement a set_iommu_device callback: > -If found an existing viommu reuse that. >(Devices behind the same physical SMMU should share an S2 HWPT) > -Else, > Allocate a viommu with the nested parent S2

Re: [RFC PATCH v3 06/15] hw/arm/smmuv3-accel: Restrict accelerated SMMUv3 to vfio-pci endpoints with iommufd

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:32 +0100 Shameer Kolothum wrote: > Accelerated SMMUv3 is only useful when the device can take advantage of > the host's SMMUv3 in nested mode. To keep things simple and correct, we > only allow this feature for vfio-pci endpoint devices that use the iommufd > backend. We

Re: [RFC PATCH v3 05/15] hw/arm/smmuv3-accel: Introduce smmuv3 accel device

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:31 +0100 Shameer Kolothum wrote: > Also setup specific PCIIOMMUOps for accel SMMUv3 as accel > SMMUv3 will have different handling for those ops callbacks > in subsequent patches. > > The "accel" property is not yet added, so users cannot set it at this > point. It will

Re: [RFC PATCH v3 04/15] hw/arm/smmu-common: Introduce smmu_iommu_ops_by_type() helper

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:30 +0100 Shameer Kolothum wrote: > Allows to retrieve the PCIIOMMUOps based on the SMMU type. This will be > useful when we add support for accelerated SMMUV3 in subsequent patches > as that requires a different set of callbacks for iommu ops. > > No special handling is

Re: [RFC PATCH v3 03/15] hw/arm/smmu-common: Factor out common helper functions and export

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:29 +0100 Shameer Kolothum wrote: > Subsequent patches for smmuv3 accel support will make use of this. > > Signed-off-by: Nicolin Chen > Reviewed-by: Eric Auger > Signed-off-by: Shameer Kolothum Various trivial things inline. In general looks fine. J > --- > hw/ar

Re: [RFC PATCH v3 02/15] backends/iommufd: Introduce iommufd_vdev_alloc

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:28 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Add a helper to allocate an iommufd device's virtual device (in the user > space) per a viommu instance. Same trivial suggestion as in patch 1. Also feel free to ignore.

Re: [RFC PATCH v3 01/15] backends/iommufd: Introduce iommufd_backend_alloc_viommu

2025-07-15 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 16:59:27 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Add a helper to allocate a viommu object. > > Signed-off-by: Nicolin Chen > Reviewed-by: Eric Auger > Signed-off-by: Shameer Kolothum One trivial comment inline. Feel free to ignore. > --- > backends/iomm

Re: [PATCH v7 00/36] ACPI PCI Hotplug support on ARM

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 10:04:44 +0200 Eric Auger wrote: > This series enables ACPI PCI hotplug/hotunplug on ARM. > It is not enabled by default and ACPI PCI hotplug can > be selected by setting: > > -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > > Expected benefits should be similar t

[PATCH qemu v2 09/11] hw/cxl: Create helper function to create DC Event Records from extents

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su Prepatory patch for following FMAPI Add/Release Patches. Refactors part of qmp_cxl_process_dynamic_capacity_prescriptive() into a helper function to create DC Event Records and insert in the event log. Moves definition for CXL_NUM_EXTENTS_SUPPORTED to cxl.h so it can be accessed b

[PATCH qemu v2 06/11] hw/mem: cxl_type3: Add DC Region bitmap lock

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su Add a lock on the bitmap of each CXLDCRegion in preparation for the next patch which implements FMAPI Set DC Region Configuration. This command can modify the block size, which means the region's bitmap must be updated accordingly. The lock becomes necessary when commands that add

[PATCH qemu v2 11/11] hw/cxl: mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section 7.6.7.6.6 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 88 ++ 1 file changed, 88 insertions(+) diff --git

[PATCH qemu v2 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section 7.6.7.6.3 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 of set to merge: - Fixed blksize check in set dc region config - Added check that it is a power of 2 (and host-ut

[PATCH qemu v2 10/11] hw/cxl: mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section 7.6.7.6.5 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 4 ++ hw/cxl/cxl-mailbox-utils.c | 109 hw/mem

[PATCH qemu v2 08/11] hw/cxl: mailbox-utils: 0x5603 - FMAPI Get DC Region Extent Lists

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5603 implemented per CXL r3.2 Spec Section 7.6.7.6.4 Very similar to previously implemented command 0x4801. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 for merge: - Added a missing : in a comment similar to Fan

[PATCH qemu v2 04/11] hw/cxl: mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section 7.6.7.6.2 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 106 + 1 file changed, 106 insertions(+) diff --gi

[PATCH qemu v2 05/11] hw/cxl: Move definition for dynamic_capacity_uuid and enum for DC event types to header

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su Move definition/enum to cxl_events.h for shared use in next patch Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_events.h | 15 +++ hw/mem/cxl_type3.c | 15 --- 2 files changed, 15 insertions(

[PATCH qemu v2 03/11] hw/mem: cxl_type3: Add dsmas_flags to CXLDCRegion struct

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su Add booleans to DC Region struct to represent dsmas flags (defined in CDAT) in preparation for the next command, which returns the flags in the next mailbox command 0x5601. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 for merge - Added some

[PATCH qemu v2 02/11] hw/cxl: mailbox-utils: 0x5600 - FMAPI Get DCD Info

2025-07-14 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5600 implemented per CXL 3.2 Spec Section 7.6.7.6.1. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- v2 series for merge. - Modify the code that fills in the support blk sizes to not do effectively 2**log2(x) when we

[PATCH qemu v2 01/11] hw/cxl: fix DC extent capacity tracking

2025-07-14 Thread Jonathan Cameron via
From: Fan Ni Per cxl r3.2 Section 9.13.3.3, extent capacity tracking should include extents in different states including added, pending, etc. Before the change, for the in-device extent number tracking purpose, we only have "total_extent_count" defined, which only tracks the number of extents a

[PATCH qemu v2 00/11] hw/cxl: DCD Fabric Management Command Set (for 10.1)

2025-07-14 Thread Jonathan Cameron via
v2: - Missing colon and tags (Fan) - Simpler handling block size parameters. The spec constrains these to be power of 2 so the v1 code of BITUL((int)log2(x) is equivalent of just using x directly. (Michael) - Check for power of 2 (Fan + Anisa) Hi Michael, I consider these ready for upstream

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 17:21:10 + Anisa Su wrote: > On Mon, Jul 14, 2025 at 06:02:26PM +0100, Jonathan Cameron wrote: > > On Mon, 14 Jul 2025 09:45:31 -0700 > > Fan Ni wrote: > > > > > On Mon, Jul 14, 2025 at 03:16:38PM +0100, Jonathan Cameron wrote: > > > > On Mon, 14 Jul 2025 15:15:12 +0

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 09:45:31 -0700 Fan Ni wrote: > On Mon, Jul 14, 2025 at 03:16:38PM +0100, Jonathan Cameron wrote: > > On Mon, 14 Jul 2025 15:15:12 +0100 > > Jonathan Cameron wrote: > > > > > On Mon, 14 Jul 2025 15:02:18 +0100 > > > Jonathan Cameron wrote: > > > > > > > On Mon, 14 Jul 2

Re: [PATCH v6 3/4] hw/acpi/aml-build: Build a root node in the PPTT table

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 11:57:19 -0400 "Michael S. Tsirkin" wrote: > On Mon, Jul 14, 2025 at 03:10:41PM +0100, Alireza Sanaee wrote: > > On Mon, 14 Jul 2025 09:09:10 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jun 04, 2025 at 12:52:32PM +0100, Alireza Sanaee wrote: > > > > From: Yic

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 15:02:18 +0100 Jonathan Cameron wrote: > On Mon, 14 Jul 2025 05:32:19 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 02, 2025 at 05:02:13PM +0100, Jonathan Cameron wrote: > > > From: Anisa Su > > > > > > FM DCD Management command 0x5602 implemented per CXL r3.2 Sp

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 15:15:12 +0100 Jonathan Cameron wrote: > On Mon, 14 Jul 2025 15:02:18 +0100 > Jonathan Cameron wrote: > > > On Mon, 14 Jul 2025 05:32:19 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 02, 2025 at 05:02:13PM +0100, Jonathan Cameron wrote: > > > > From: An

Re: [PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-14 Thread Jonathan Cameron via
On Mon, 14 Jul 2025 05:32:19 -0400 "Michael S. Tsirkin" wrote: > On Wed, Jul 02, 2025 at 05:02:13PM +0100, Jonathan Cameron wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section > > 7.6.7.6.3 > > > > Reviewed-by: Fan Ni > > Signed-off-by: An

Re: [PATCH qemu 10/11] hw/cxl: mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-04 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 16:23:57 + Fan Ni wrote: > On Wed, Jul 02, 2025 at 05:02:16PM +0100, Jonathan Cameron wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > > 7.6.7.6.5 > > > > Signed-off-by: Anisa Su > > Signed-off-by: Jonathan Came

Re: [PATCH v5 36/36] qtest/bios-tables-test: Generate reference blob for DSDT.acpipcihp

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:36 +0200 Eric Auger wrote: > The disassembled DSDT table is given below. I think the aim for this one should be to highlight the blobs where it differs from the previous rather than having the whole thing. > > /* > * Intel ACPI Component Architecture > * AML/ASL+ Di

Re: [PATCH v5 35/36] qtest/bios-tables-test: Generate reference blob for DSDT.hpoffacpiindex

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:35 +0200 Eric Auger wrote: > The disassembled DSDT table is given below I'd suggest maybe a spot of cropping to bring this down to a reasonable length. See inline. Otherwise LGTM Reviewed-by: Jonathan Cameron > > * Original Table Header: > * Signature

Re: [PATCH v5 32/36] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:32 +0200 Eric Auger wrote: > Set up the IO registers used to communicate between QEMU > and ACPI. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v5 28/36] hw/acpi/ged: Prepare the device to react to PCI hotplug events

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:28 +0200 Eric Auger wrote: > QEMU will notify the OS about PCI hotplug/hotunplug events through > GED interrupts. Let the GED device handle a new PCI hotplug event. > On its occurrence it calls the \\_SB.PCI0.PCNT method with the BLCK > mutex held. > > The GED device us

Re: [PATCH v5 22/36] tests/qtest/bios-tables-test: Update ARM DSDT reference blobs

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:22 +0200 Eric Auger wrote: > Changes relate to the introduction of pieces related to > acpi-index static support along with root ports with no hotplug. > > + > +Scope (\_SB.PCI0) > +{ > +Method (EDSM, 5, Serialized) > +{ > +If

Re: [PATCH v5 19/36] qtest/bios-tables-test: Generate DSDT.viot

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:19 +0200 Eric Auger wrote: > Use a specific DSDT.viot reference blob instead of relying on > the default DSDT blob. The context has not changed. So this is the same as the default until the next patch? Maybe should introduce the file only then instead. Not important th

Re: [PATCH v5 17/36] qtest/bios-tables-test: Prepare for fixing the aarch64 viot test

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:17 +0200 Eric Auger wrote: > The test misses a variant and this puts the mess on subsequent > rebuild-expected-aml.sh where a first DSDT reference blob is > overriden by another one. > > Signed-off-by: Eric Auger For completeness.. Reviewed-by: Jonathan Cameron

Re: [PATCH v5 18/36] qtest/bios-tables-test: Add a variant to the aarch64 viot test

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 14:35:18 +0200 Eric Auger wrote: > Signed-off-by: Eric Auger The wide range of ways setting variant up is coded in this file is a bit more creative than I'd like and makes it hard to spot if there are other cases of this. I 'think' this is only one other than base tests tha

Re: [PATCH v3 1/7] hw/cxl/events: Update for rev3.2 common event record format

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 10:16:50 +0100 wrote: > From: Shiju Jose > > CXL spec 3.2 section 8.2.9.2.1 Table 8-55, Common Event Record > format has updated with optional Maintenance Operation Subclass, > LD ID and ID of the device head information. > > Add updates for the above optional parameters in

[PATCH qemu v17 5/5] qtest/cxl: Add aarch64 virt test for CXL

2025-07-03 Thread Jonathan Cameron via
Add a single complex case for aarch64 virt machine. Given existing much more comprehensive tests for x86 cover the common functionality, a single test should be enough to verify that the aarch64 part continues to work. Tested-by: Itaru Kitayama Reviewed-by: Eric Auger Signed-off-by: Jonathan Ca

[PATCH qemu v17 4/5] docs/cxl: Add an arm/virt example.

2025-07-03 Thread Jonathan Cameron via
Only add one very simple example as all the i386/pc examples will work for arm/virt with a change to appropriate executable and appropriate standard launch line for arm/virt. Note that max cpu is used to ensure we have plenty of physical address space. Suggested-by: Peter Maydell Reviewed-by: Eri

[PATCH qemu v17 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-03 Thread Jonathan Cameron via
Code based on i386/pc enablement. The memory layout places space for 16 host bridge register regions after the GIC_REDIST2 in the extended memmap. This is a hole in the current map so adding them here has no impact on placement of other memory regions (tested with enough CPUs for GIC_REDIST2 to be

[PATCH qemu v17 2/5] hw/cxl: Make the CXL fixed memory windows devices.

2025-07-03 Thread Jonathan Cameron via
Previously these somewhat device like structures were tracked using a list in the CXLState in each machine. This is proving restrictive in a few cases where we need to iterate through these without being aware of the machine type. Just make them sysbus devices. Restrict them to not user created as

[PATCH qemu v17 1/5] hw/cxl-host: Add an index field to CXLFixedMemoryWindow

2025-07-03 Thread Jonathan Cameron via
To enable these to be found in a fixed order, that order needs to be known. This will later be used to sort a list of these structures so that address map and ACPI table entries are predictable. Tested-by: Li Zhijian Reviewed-by: Li Zhijian Reviewed-by: Fan Ni Reviewed-by: Eric Auger Signed-of

[PATCH qemu v17 0/5] arm/virt: CXL support via pxb_cxl

2025-07-03 Thread Jonathan Cameron via
v17: Thanks to Eric for review - Add a comment to the high memory map to reduce the chance of nasty surprises in the future as similar to device_memory, the CXL Fixed Memory Windows are of variable size as so can't be represented by explicit entries in the map. - Updated a couple of patch des

Re: [PATCH v6 01/12] hw/arm/virt-acpi-build: Don't create ITS id mappings by default

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 09:46:32 +0100 Shameer Kolothum wrote: > Commit d6afe18b7242 ("hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables > when its=off") moved ITS group node generation under the its=on condition. > However, it still creates rc_its_idmaps unconditionally, which results in > duplic

Re: [QEMU PATCH v4 09/10] cxl-mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 04:17:28 + Fan Ni wrote: > On Thu, Jun 26, 2025 at 10:23:32PM +, anisa.su...@gmail.com wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > > 7.6.7.6.5 > > > > Signed-off-by: Anisa Su > > --- > > Minor commen

Re: [QEMU PATCH v4 10/10] cxl-mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-07-03 Thread Jonathan Cameron via
On Thu, 3 Jul 2025 04:21:25 + Fan Ni wrote: > On Thu, Jun 26, 2025 at 10:23:33PM +, anisa.su...@gmail.com wrote: > > From: Anisa Su > > > > FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section > > 7.6.7.6.6 > > > > Signed-off-by: Anisa Su > > --- > Minor comments

[PATCH qemu 11/11] hw/cxl: mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section 7.6.7.6.6 Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/hw/cxl/cxl-mailbox

[PATCH qemu 09/11] hw/cxl: Create helper function to create DC Event Records from extents

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su Prepatory patch for following FMAPI Add/Release Patches. Refactors part of qmp_cxl_process_dynamic_capacity_prescriptive() into a helper function to create DC Event Records and insert in the event log. Moves definition for CXL_NUM_EXTENTS_SUPPORTED to cxl.h so it can be accessed b

[PATCH qemu 10/11] hw/cxl: mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section 7.6.7.6.5 Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 4 ++ hw/cxl/cxl-mailbox-utils.c | 109 hw/mem/cxl_type3.c

[PATCH qemu 07/11] hw/cxl: mailbox-utils: 0x5602 - FMAPI Set DC Region Config

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5602 implemented per CXL r3.2 Spec Section 7.6.7.6.3 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 3 ++ include/hw/cxl/cxl_mailbox.h | 6 +++ hw/cxl/cxl-mailbox-utils.c | 86 +

[PATCH qemu 08/11] hw/cxl: mailbox-utils: 0x5603 - FMAPI Get DC Region Extent Lists

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5603 implemented per CXL r3.2 Spec Section 7.6.7.6.4 Very similar to previously implemented command 0x4801. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 76 +

[PATCH qemu 06/11] hw/mem: cxl_type3: Add DC Region bitmap lock

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su Add a lock on the bitmap of each CXLDCRegion in preparation for the next patch which implements FMAPI Set DC Region Configuration. This command can modify the block size, which means the region's bitmap must be updated accordingly. The lock becomes necessary when commands that add

[PATCH qemu 05/11] hw/cxl: Move definition for dynamic_capacity_uuid and enum for DC event types to header

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su Move definition/enum to cxl_events.h for shared use in next patch Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_events.h | 15 +++ hw/mem/cxl_type3.c | 15 --- 2 files changed, 15 insertions(

[PATCH qemu 04/11] hw/cxl: mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section 7.6.7.6.2 Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 106 + 1 file changed, 106 insertions(+) diff --gi

[PATCH qemu 02/11] hw/cxl: mailbox-utils: 0x5600 - FMAPI Get DCD Info

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su FM DCD Management command 0x5600 implemented per CXL 3.2 Spec Section 7.6.7.6.1. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 1 + hw/cxl/cxl-mailbox-utils.c | 59 + hw/mem/c

[PATCH qemu 03/11] hw/mem: cxl_type3: Add dsmas_flags to CXLDCRegion struct

2025-07-02 Thread Jonathan Cameron via
From: Anisa Su Add booleans to DC Region struct to represent dsmas flags (defined in CDAT) in preparation for the next command, which returns the flags in the next mailbox command 0x5601. Reviewed-by: Fan Ni Signed-off-by: Anisa Su Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_devic

[PATCH qemu 00/11] hw/cxl: DCD Fabric Management Command Set (for 10.1)

2025-07-02 Thread Jonathan Cameron via
Hi Michael, I consider these ready for upstream. They are only lightly tweaked from Anisa's last posting to drop some long lines and change a few patch titles + drag them to be directly based on upstream rather than on top of some stuff on my gitlab tree (trivial fuzz + context stuff only in the

[PATCH qemu 01/11] hw/cxl: fix DC extent capacity tracking

2025-07-02 Thread Jonathan Cameron via
From: Fan Ni Per cxl r3.2 Section 9.13.3.3, extent capacity tracking should include extents in different states including added, pending, etc. Before the change, for the in-device extent number tracking purpose, we only have "total_extent_count" defined, which only tracks the number of extents a

Re: [PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-01 Thread Jonathan Cameron via
On Tue, 1 Jul 2025 18:12:39 +0200 Eric Auger wrote: > Hi Jonathan, > On 7/1/25 5:52 PM, Jonathan Cameron wrote: > > On Tue, 1 Jul 2025 17:34:36 +0200 > > Eric Auger wrote: > > > >> Hi Jonathan, > >> > >> On 6/25/25 6:19 PM, Jonathan Cameron

Re: [PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-01 Thread Jonathan Cameron via
On Tue, 1 Jul 2025 17:34:36 +0200 Eric Auger wrote: > Hi Jonathan, > > On 6/25/25 6:19 PM, Jonathan Cameron via wrote: > > Code based on i386/pc enablement. > > The memory layout places space for 16 host bridge register regions after > > the GIC_REDIST2 in the extende

Re: [PATCH qemu v16 3/5] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-07-01 Thread Jonathan Cameron via
On Tue, 1 Jul 2025 15:26:26 +0200 Eric Auger wrote: > Hi Jonathan, > > On 6/25/25 6:19 PM, Jonathan Cameron via wrote: > > Code based on i386/pc enablement. > > The memory layout places space for 16 host bridge register regions after > > the GIC_REDIST2 in the extende

Re: [HACK QEMU PATCH v1 1/1] hw/cxl: Fix MCTP Binding Check

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 16:38:16 + Anisa Su wrote: > On Fri, Jun 27, 2025 at 10:48:59AM +0100, Jonathan Cameron wrote: > > On Thu, 26 Jun 2025 23:41:15 + > > anisa.su...@gmail.com wrote: > > > > > From: Anisa Su > > > > > > Per the spec, FMAPI commands (0x51-0x59) must be bound with > >

Re: [QEMU PATCH v4 10/10] cxl-mailbox-utils: 0x5605 - FMAPI Initiate DC Release

2025-06-30 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 22:23:33 + anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5605 implemented per CXL r3.2 Spec Section > 7.6.7.6.6 > > Signed-off-by: Anisa Su A few more long line related tweaks. > --- > hw/cxl/cxl-mailbox-utils.c | 79 ++

Re: [QEMU PATCH v4 09/10] cxl-mailbox-utils: 0x5604 - FMAPI Initiate DC Add

2025-06-30 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 22:23:32 + anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5604 implemented per CXL r3.2 Spec Section > 7.6.7.6.5 There are a few long lines in here check patch doesn't like. I tweaked as described inline whilst picking them up. > > Si

Re: [QEMU PATCH v4 03/10] cxl-mailbox-utils: 0x5601 - FMAPI Get Host Region Config

2025-06-30 Thread Jonathan Cameron via
On Thu, 26 Jun 2025 22:23:26 + anisa.su...@gmail.com wrote: > From: Anisa Su > > FM DCD Management command 0x5601 implemented per CXL r3.2 Spec Section > 7.6.7.6.2 > > Reviewed-by: Fan Ni > Signed-off-by: Anisa Su > --- > hw/cxl/cxl-mailbox-utils.c | 103

Re: [PATCH v4 31/32] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:20 +0200 Eric Auger wrote: > From: Gustavo Romero > > Add 2 new tests: > - test_acpi_aarch64_virt_acpi_pci_hotplug tests the acpi pci hotplug > using -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > - test_acpi_aarch64_virt_pcie_root_port_hpoff tests static

Re: [PATCH v4 30/32] tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp tests

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:19 +0200 Eric Auger wrote: > From: Gustavo Romero > > Soon we will introduce new tests related to ACPI PCI hotplug and > acpi-index that will use a new reference blob: > > tests/data/acpi/aarch64/virt/DSDT.acpipcihp > tests/data/acpi/aarch64/virt/DSDT.hpoffacpiindex >

Re: [PATCH v4 29/32] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:18 +0200 Eric Auger wrote: > Set up the IO registers used to communicate between QEMU > and ACPI. > > Signed-off-by: Eric Auger Follow on comment inline. Otherwise LGTM Reviewed-by: Jonathan Cameron > > --- > v2 -> v3: > - remove acpi_ged_state->pcihp_state.use_ac

Re: [PATCH v4 28/32] hw/arm/virt: Minor code reshuffling in create_acpi_ged

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:17 +0200 Eric Auger wrote: > Use a local SysBusDevice handle. Also use the newly introduced > sysbus_mmio_map_name which brings better readability about the region > being mapped. GED device has regions which exist depending on some > external properties and it becomes d

Re: [PATCH v4 25/32] hw/acpi/ged: Prepare the device to react to PCI hotplug events

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:14 +0200 Eric Auger wrote: > QEMU will notify the OS about PCI hotplug/hotunplug events through > GED interrupts. Let the GED device handle a new PCI hotplug event. > On its occurrence it calls the \\_SB.PCI0.PCNT method with the BLCK > mutex held. > > The GED device us

Re: [PATCH v4 26/32] hw/acpi/ged: Support migration of AcpiPciHpState

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:15 +0200 Eric Auger wrote: > Add a subsection to migrate the AcpiPciHpState state. > > Signed-off-by: Eric Auger > Reviewed-by: Igor Mammedov Reviewed-by: Jonathan Cameron

Re: [PATCH v4 24/32] hw/acpi/pcihp: Remove root arg in acpi_pcihp_init

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:13 +0200 Eric Auger wrote: > Let pass the root bus to ich9 and piix4 through a property link > instead of through an argument passed to acpi_pcihp_init(). > > Also make sure the root bus is set at the entry of acpi_pcihp_init(). > > The rationale of that change is to b

Re: [PATCH v4 20/32] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:09 +0200 Eric Auger wrote: > Modify the DSDT ACPI table to enable ACPI PCI hotplug. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 19/32] tests/qtest/bios-tables-test: Update ARM DSDT reference blobs

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 12:00:51 +0200 Eric Auger wrote: > Hi, > > On 6/27/25 11:55 AM, Eric Auger wrote: > > Changes relate to the introduction of pieces related to > > acpi-index static support along with root ports with no hotplug. > > > > + > > +Scope (\_SB.PCI0) > > +{ > > +Meth

Re: [PATCH v4 18/32] hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:07 +0200 Eric Auger wrote: > hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index > > Add the requested ACPI bits requested to support static acpi-index > for non hotplug ports. > > Signed-off-by: Eric Auger Matches up with the i386 code so LGTM Rev

Re: [PATCH v4 17/32] tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT table

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:06 +0200 Eric Auger wrote: > From: Gustavo Romero > > This commit adds DSDT blobs to the whilelist in the prospect to > allow changes in the arm virt DSDT method. > > Signed-off-by: Gustavo Romero > Signed-off-by: Eric Auger > Always feels slightly silly to give ta

Re: [PATCH v4 16/32] hw/i386/acpi-build: Move aml_pci_edsm to a generic place

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:55:05 +0200 Eric Auger wrote: > Move aml_pci_edsm to pci-bridge.c since we want to reuse that for > ARM and acpi-index support. Also rename it into build_pci_bridge_edsm. > > Signed-off-by: Eric Auger Reviewed-by: Jonathan Cameron

Re: [PATCH v4 10/32] tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change

2025-06-30 Thread Jonathan Cameron via
On Fri, 27 Jun 2025 11:54:59 +0200 Eric Auger wrote: > Update the reference DSDT blobs after GPEX _OSC change. The _OSC change > affects the aarch64 'virt' and the x86 'microvm' machines. > > DSDT diff is the same for all the machines/tests: > > * Original Table Header: > * Signature

  1   2   3   4   5   6   7   8   9   10   >