Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-09 Thread Jevon Qiao
Hi Greg, Thank you for spending time reviewing this patch. On 7/4/16 23:50, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-05 Thread Jevon Qiao
On 5/4/16 23:31, Greg Kurz wrote: On Tue, 5 Apr 2016 23:27:33 +0800 Jevon Qiao wrote: Hi Greg, Any further comment? Thanks, Jevon Hi Jevon, Yes ! I could at last resume the review of your patch today. You can expect an answer this week. Ok, thanks. /Jevon Cheers. -- Greg On 15/3/16

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-05 Thread Jevon Qiao
Hi Greg, Any further comment? Thanks, Jevon On 15/3/16 22:16, Jevon Qiao wrote: On 15/3/16 21:46, Greg Kurz wrote: On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao wrote: On 15/3/16 17:30, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Jevon Qiao
Hi Michael, Thank you for the comment below. On 15/3/16 21:52, Michael S. Tsirkin wrote: On Tue, Mar 15, 2016 at 12:02:48AM +0800, Jevon Qiao wrote: diff --git a/hw/9pfs/9p-cephfs.c b/hw/9pfs/9p-cephfs.c new file mode 100644 index 000..e2d659d --- /dev/null +++ b/hw/9pfs/9p-cephfs.c

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Jevon Qiao
On 15/3/16 21:46, Greg Kurz wrote: On Tue, 15 Mar 2016 21:39:45 +0800 Jevon Qiao wrote: On 15/3/16 17:30, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-15 Thread Jevon Qiao
On 15/3/16 17:30, Greg Kurz wrote: On Tue, 15 Mar 2016 00:02:48 +0800 Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looking at Manila

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-13 Thread Jevon Qiao
Hi Greg, Thank you very much for reviewing the code, I've revised the code per your comments, will post it later. Meanwhile, please see my answers to your questions below. +} +fs->dir = (DIR *)result; +if (!fs->dir) { +fprintf(stderr, "ceph_opendir return NULL for ceph_di

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-07 Thread Jevon Qiao
Any further comment on this patch? Thanks, Jevon On 2/3/16 23:41, Jevon Qiao wrote: Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looking at Manila and

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-03-02 Thread Jevon Qiao
Any further question/comment on this patch? Thanks, Jevon On 24/2/16 15:04, Jevon Qiao wrote: [Removing ceph-devel alias] Hi Aneesh, Any further comment on my reply below? Thanks, Jevon On 19/2/16 16:56, Jevon Qiao wrote: Hi Aneesh, I am not sure I understand the details correctly. iounit

[Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-03-02 Thread Jevon Qiao
support in VirtFS. Signed-off-by: Jevon Qiao --- configure | 33 ++ fsdev/qemu-fsdev.c| 1 + fsdev/qemu-fsdev.h| 3 +- hw/9pfs/9p-cephfs.c | 739 ++ hw/9pfs/Makefile.objs | 3

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-23 Thread Jevon Qiao
[Removing ceph-devel alias] Hi Aneesh, Any further comment on my reply below? Thanks, Jevon On 19/2/16 16:56, Jevon Qiao wrote: Hi Aneesh, I am not sure I understand the details correctly. iounit is the size that we use in client_read to determine the size in which we should request I/O

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-19 Thread Jevon Qiao
Hi Greg, From: Jevon Qiao Date: Sun, 14 Feb 2016 15:11:08 +0800 Subject: [PATCH] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize. Per the previous implementation, iounit will be assigned to be 0 after the first if statement as (s->msize - P9_IOHD

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-19 Thread Jevon Qiao
Hi Aneesh, I am not sure I understand the details correctly. iounit is the size that we use in client_read to determine the size in which we should request I/O from the client. But we still can't do I/O in size larger than s->msize. If you look at the client side (kernel 9p fs), you will find

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-02-17 Thread Jevon Qiao
On 17/2/16 17:37, Daniel P. Berrange wrote: On Wed, Feb 17, 2016 at 03:32:06PM +0800, Jevon Qiao wrote: Hi Daniel, Thank you for reviewing my code, please see my reply in-line. On 15/2/16 17:17, Daniel P. Berrange wrote: On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote: + +static

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-02-17 Thread Jevon Qiao
On 17/2/16 17:04, Greg Kurz wrote: On Wed, 17 Feb 2016 16:49:33 +0800 Jevon Qiao wrote: On 17/2/16 16:01, Greg Kurz wrote: On Wed, 17 Feb 2016 15:32:06 +0800 Jevon Qiao wrote: Hi Daniel, Thank you for reviewing my code, please see my reply in-line. On 15/2/16 17:17, Daniel P. Berrange

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-02-17 Thread Jevon Qiao
On 17/2/16 16:01, Greg Kurz wrote: On Wed, 17 Feb 2016 15:32:06 +0800 Jevon Qiao wrote: Hi Daniel, Thank you for reviewing my code, please see my reply in-line. On 15/2/16 17:17, Daniel P. Berrange wrote: On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote: diff --git a/configure b

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-02-16 Thread Jevon Qiao
Hi Daniel, Thank you for reviewing my code, please see my reply in-line. On 15/2/16 17:17, Daniel P. Berrange wrote: On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote: diff --git a/configure b/configure index 83b40fc..cecece7 100755 --- a/configure +++ b/configure @@ -1372,6 +1377,7

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-16 Thread Jevon Qiao
Hi Aneesh, Thank you for reviewing my code, please see my reply in-line. On 14/2/16 21:38, Aneesh Kumar K.V wrote: Jevon Qiao writes: The following patch is to fix alignment issue when host filesystem block size is larger than client msize. Thanks, Jevon That is not the right format to

[Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-13 Thread Jevon Qiao
The following patch is to fix alignment issue when host filesystem block size is larger than client msize. Thanks, Jevon From: Jevon Qiao Date: Sun, 14 Feb 2016 15:11:08 +0800 Subject: [PATCH] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize. Per

[Qemu-devel] [PATCH 1/2] add CephFS support in VirtFS

2016-02-13 Thread Jevon Qiao
Per Aneesh's comment, I separated the patch listed below into two. Change the Subject and send the other one in a separate email. Thanks, Jevon On 14/2/16 13:06, Jevon Qiao wrote: The following patch made over v2.5.50 of the upstream Qemu aims to add functionality needed to support Ceph

Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-02-13 Thread Jevon Qiao
On 14/2/16 14:01, Aneesh Kumar K.V wrote: diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index f972731..385c01d 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -1326,7 +1326,7 @@ out_nofid: static int32_t get_iounit(V9fsPDU *pdu, V9fsPath *path) { struct statfs

[Qemu-devel] [PATCH] add CephFS support in VirtFS

2016-02-13 Thread Jevon Qiao
From: Jevon Qiao Date: Sun, 10 Jan 2016 13:52:29 +0800 Subject: [PATCH] add CephFS support in VirtFS Ceph as a promising unified distributed storage system is widely used in the world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and object (S3/Swift) are unsurprisingly looki