#x27;s been
fairly stable, but its not doing in-depth testing.
jeff
It looks like using
https://cdimage.debian.org/cdimage/ports/snapshots/2021-04-17/debian-10.0.0
-m68k-NETINST-1.iso instead fixes the issue. Perhaps the instruction on
https://wiki.qemu.org/Documentation/Platforms/m68k should be updated.
--
You received this bug notification because you are a mem
The kernel in my m68k disk image is vmlinux-4.16.0-1-m68k which is
presumably what comes from
https://cdimage.debian.org/cdimage/ports/10.0/m68k/iso-cd/debian-10.0
-m68k-NETINST-1.iso. Is there a debian image that uses a newer kernel?
--
You received this bug notification because you are a member
I also see the same problem with version 4.2.1
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1926497
Title:
dp83932 stops working after a short while
Status in QEMU:
New
Bug description:
Foll
Public bug reported:
Following the instructions here
https://wiki.qemu.org/Documentation/Platforms/m68k I was able to
successfully install debian. However, running apt-get update stalls
after the first 1-2MB.
root@debian:~# apt-get update
Get:1 http://ftp.ports.debian.org/debian-ports sid InRelea
On 1/13/2020 9:41 PM, Richard Henderson wrote:
> On 1/10/20 8:02 AM, Jeff Kubascik wrote:
>> -env->pc -= insn_len;
>> +if (env->aarch64)
>> +env->pc -= insn_len;
>> +else
>> +env->regs[15] -= insn_len;
>
helper function.
However, this correction is done to env->pc, which only applies to AArch64
mode. For AArch32, the program counter is stored in env->regs[15]. This
adds an if-else statement to modify the correct program counter location
based on the the current CPU mode.
Signed-off-by: Jeff Ku
dated.
Signed-off-by: Jeff Kubascik
---
Hello,
I am using the ARMv8 version of QEMU configured with the gicv3 interrupt
controller to run the Xen hypervisor with RTEMS as a guest VM (AArch32). I
have noticed that when Xen injects a virtual irq to the guest VM, the guest
gets stuck in the interrupt ha
helper function.
However, this correction is done to env->pc, which only applies to AArch64
mode. For AArch32, the program counter is stored in env->regs[15]. This
adds an if-else statement to modify the correct program counter location
based on the the current CPU mode.
Signed-off-by: Jeff Ku
On 12/19/2019 7:43 AM, Peter Maydell wrote:
> On Wed, 18 Dec 2019 at 01:03, Richard Henderson
> wrote:
>>
>> On 12/17/19 11:02 AM, Jeff Kubascik wrote:
>>> diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c
>>> index 5feb312941..e63f8bda29 1006
instruction length. For load/store instructions, the instruction
length bit is stored with the instruction syndrome data, to be later used if
the data abort occurs.
Signed-off-by: Jeff Kubascik
---
Hello,
I am using the ARMv8 version of QEMU to run the Xen hypervisor with a guest
virtual machine compiled
On Tue, Sep 24, 2019 at 11:03:38AM +0200, Christian Schoenebeck wrote:
> > Yes, the resulting mail would be correct, in the sense that it could be
> > applied just fine by git-am. But I think it would be uglier. IOW, I
> > consider the presence of the in-body From to be a clue that something
> > i
On Mon, Sep 23, 2019 at 01:19:18PM +0200, Christian Schoenebeck wrote:
> > if (cmit_fmt_is_mail(pp->fmt)) {
> > - if (pp->from_ident && ident_cmp(pp->from_ident, &ident)) {
> > + if (pp->always_use_in_body_from ||
> > + (pp->from_ident && ident_cmp(pp->from_id
On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote:
> > But as you can already read from the manual, the overall behaviour of git
> > regarding a separate "From:" line in the email body was intended solely for
> > the use case sender != author. So in practice (at least in my git version)
On Mon, Sep 2, 2019 at 5:25 AM Stefan Hajnoczi wrote:
>
> On Thu, Aug 29, 2019 at 06:13:34PM +0200, Andrea Bolognani wrote:
> > On Thu, 2019-08-29 at 16:48 +0100, Stefan Hajnoczi wrote:
> > > Hi Jeff,
> > > Philippe noticed that the git HTTPS clone URL
> > >
Dan Williams writes:
> On Mon, Apr 22, 2019 at 8:59 AM Jeff Moyer wrote:
>>
>> Dan Williams writes:
>>
>> > On Thu, Apr 18, 2019 at 9:18 AM Christoph Hellwig
>> > wrote:
>> >>
>> >> On Thu, Apr 18, 2019 at 09:05:05AM -0700,
make it a new common kernel coding
> practice to do:
>
> if (!object->op)
> generic_op(object);
> else
> object->op(object);
>
> ...in hot paths?
I don't think nvdimm_flush is a hot path. Numbers of some
representative workload would prove one of us right.
-Jeff
Dan Williams writes:
> On Fri, Apr 12, 2019 at 6:12 AM Jeff Moyer wrote:
>>
>> Jan Kara writes:
>>
>> > On Thu 11-04-19 07:51:48, Dan Williams wrote:
>> >> On Tue, Apr 9, 2019 at 9:09 PM Pankaj Gupta wrote:
>> >> > + } else
either add a comment about avoiding retpoline overhead here or just
> make ->flush == NULL mean generic_nvdimm_flush(). Just so that people don't
> get confused by the code.
Isn't this premature optimization? I really don't like adding things
like this without some numbers to show it's worth it.
-Jeff
Changes from v1:
- cc'ed Peter (meant to for v1, forgot)
- added John's 'jobs' branch to his git url
- kept myself as maintainer for vhdx
- moved sheepdog to 'Odd Fixes'
I'm not going to be involved with day-to-day qemu development, so
this ne
rsonal email address as a maintainer, as I can
answer questions or send the occassional bug fix. Leaving it as
'Supported', instead of 'Odd Fixes', because I think the rest of the
block layer maintainers and developers will upkeep it as well, if
needed.
Signed-off-by: Jeff Cody
--
I'll not be involved with day-to-day qemu development, and John
Snow is a block jobs wizard. Have him take over block job
maintainership duties.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
On Tue, Sep 25, 2018 at 03:49:36PM +0800, Fam Zheng wrote:
> On Tue, 09/25 09:37, Markus Armbruster wrote:
> > Do we want to have a dedicated VHDX driver submaintainer again? Fam,
> > you're maintaining VMDK, could you cover VHDX as well?
>
> I don't know a lot VHDX internals. Considering my capa
On Tue, Sep 25, 2018 at 12:09:15AM -0400, Jeff Cody wrote:
> I'll not be involved with day-to-day qemu development, and John
> Snow is a block jobs wizard. Have him take over block job
> maintainership duties.
>
> Signed-off-by: Jeff Cody
> ---
> MAINTAINERS | 4
I'll not be involved in day-to-day qemu development. Remove
myself as maintainer from the remainder of the network block drivers
(and vhdx), and revert them to the general block layer maintainership.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 14 --
1 file changed, 14 dele
I'll not be involved with day-to-day qemu development, and John
Snow is a block jobs wizard. Have him take over block job
maintainership duties.
Signed-off-by: Jeff Cody
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
I'm not going to be involved with day-to-day qemu development, so
this necessitates some changes.
Jeff Cody (2):
MAINTAINERS: Replace myself with John Snow for block jobs
MAINTAINERS: Remove myself as block maintainer
MAINTAINERS | 18 ++
1 file changed, 2 insertions(+
On Wed, Sep 12, 2018 at 09:18:49AM -0400, Jeff Cody wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2'
> into staging (2018-08-27 16:44:20 +0100)
>
&
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
15b332e5432ad069441f7275a46080f465d789a0.1536704
Signed-off-by: Jeff Cody
Message-id:
647f5b5ab7efd8bf567a504c832b1d2d6f719b23.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index a43fcf4835
file: SSL: no alternative
certificate subject name matches target host name '8.8.8.8'
Could not open backing image to determine size.
Further information about the two settings is available here:
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYH
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
f830580e339b974a83ed4870d11adcdc17f49a47.1536704901.git.jc...@redhat.com
rl patches
Jeff Cody (4):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd: add iotest for rbd legacy keyvalue filename parsing
block/rbd: add deprecation documentation for filename keyvalue pairs
R
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
Message-id:
5b49a980f2cde6610ab1df41bb0277d00b5db893.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c
On Sat, Sep 22, 2018 at 08:18:26AM +0200, Markus Armbruster wrote:
> Jeff Cody writes:
>
> > When we converted rbd to get rid of the older key/value-centric
> > encoding format, we broke compatibility with image files with backing
> > file strings encoded in the old forma
tate)
> curl_easy_setopt(state->curl, CURLOPT_URL, s->url);
> curl_easy_setopt(state->curl, CURLOPT_SSL_VERIFYPEER,
> (long) s->sslverify);
> +curl_easy_setopt(state->curl, CURLOPT_SSL_VERIFYHOST,
> + s->sslverify ? 2L : 0L);
> if (s->cookie) {
> curl_easy_setopt(state->curl, CURLOPT_COOKIE, s->cookie);
> }
> --
> 2.19.0.rc0
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc block
-Jeff
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
Message-id:
5b49a980f2cde6610ab1df41bb0277d00b5db893.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
block/rbd.c
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
f830580e339b974a83ed4870d11adcdc17f49a47.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
Message-id:
647f5b5ab7efd8bf567a504c832b1d2d6f719b23.1536704901.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007f12
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
Message-id:
15b332e5432ad069441f7275a46080f465d789a0.1536704
es for RBD
Jeff Cody (4):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd: add iotest for rbd legacy keyvalue filename parsing
block/rbd: add deprecation documentation for filename keyvalue pairs
b
On Tue, Sep 11, 2018 at 06:32:29PM -0400, Jeff Cody wrote:
> Changes from v3:
>
>
> Patch 4: Typo fixed [Eric]
> Added examples [Eric]
>
> Changes from v2:
> =
>
> Patch 4: New, document deprecation. [Eric]
> Patch 3,2:
On Wed, Sep 12, 2018 at 08:42:15AM -0400, Jeff Cody wrote:
> On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote:
> > Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben:
> > > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
> > > > Once we load
On Wed, Sep 12, 2018 at 12:38:56PM +0200, Kevin Wolf wrote:
> Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben:
> > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
> > > Once we load the image, will the header get rewritten into a compliant
> > > format?
>
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007f12..8d285b281e 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -190,6 +190,21 @@ used instead.
In
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/
}':
Parameter 'pool' is missing
unable to get monitor info from DNS SRV with service name: ceph-mon
no monitors specified to connect to.
qemu-img: Could not open
'json:{'file.driver':'rbd','file.pool':'rbd','file.image':&#
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/231 | 62 ++
tests/qe
On Tue, Sep 11, 2018 at 04:56:36PM -0500, Eric Blake wrote:
> [MAINTAINERS says libvir-list should have been cc'd; not sure why that
> didn't happen]
>
Thanks
> On 9/11/18 4:34 PM, Jeff Cody wrote:
> >Signed-off-by: Jeff Cody
>
> In the sub
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
block/
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a
V with service name: ceph-mon
no monitors specified to connect to.
qemu-img: Could not open
'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}':
error connecting: No such
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/231 | 62 ++
tests/qe
Signed-off-by: Jeff Cody
---
qemu-deprecated.texi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 1b9c007f12..4df8ac442d 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -190,6 +190,13 @@ used instead.
In order to
On Tue, Sep 11, 2018 at 04:05:45PM -0500, Eric Blake wrote:
> On 9/11/18 3:43 PM, Jeff Cody wrote:
> >When we converted rbd to get rid of the older key/value-centric
> >encoding format, we broke compatibility with image files with backing
> >file strings encoded in the ol
#x27;rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}':
error connecting: No such file or directory
Failures: 231
Failed 1 of 1 tests
Jeff Cody (3):
block/rbd: pull out qemu_rbd_convert_options
b
.
The failure behavior prior to the patch series that has this test, is
qemu-img complaining about mandatory options (e.g. 'pool') not being
provided.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/231 | 62 ++
tests/qemu-iotests/23
eprecation warning has been added, although care should be taken
when actually deprecating since the impact is not limited to
commandline or qapi usage, but also opening existing images.
Signed-off-by: Jeff Cody
---
block/rbd.c | 53 +++--
1 file c
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a
On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote:
>
>
> On 09/11/2018 01:15 AM, Jeff Cody wrote:
> > When we converted rbd to get rid of the older key/value-centric
> > encoding format, we broke compatibility with image files with backing
> > file string
On Tue, Sep 11, 2018 at 01:03:44PM -0500, Eric Blake wrote:
> On 9/11/18 12:15 AM, Jeff Cody wrote:
> >When we converted rbd to get rid of the older key/value-centric
> >encoding format, we broke compatibility with image files with backing
> >file strings encoded in the ol
On Tue, Sep 11, 2018 at 01:15:49AM -0400, Jeff Cody wrote:
> When we converted rbd to get rid of the older key/value-centric
> encoding format, we broke compatibility with image files with backing
> file strings encoded in the old format.
>
> This leaves a bit of an ugly conundr
This series enables filename parsing on open, on the old key/value pair.
Recent changes to new option formats for rbd broke some images. See
Patch 2 for more details.
Jeff Cody (2):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd.c | 66
me options supplied the new way, and some the old way, we may not
catch all the old options if they are not required options (since it
won't cause the initial failure).
Signed-off-by: Jeff Cody
---
block/rbd.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
dif
Code movement to pull the conversion from Qdict to BlockdevOptionsRbd
into a helper function.
Signed-off-by: Jeff Cody
---
block/rbd.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index ca8e5bbace
On Thu, Sep 06, 2018 at 09:02:22AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 14 ++
> qapi/block-core.json | 30 --
> 2 files changed, 42 insertio
On Thu, Sep 06, 2018 at 09:02:24AM -0400, John Snow wrote:
> Fix documentation to match the other jobs amended for 3.1.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> qapi/block-core.json | 18 ++
> 1 file changed
On Thu, Sep 06, 2018 at 09:02:23AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 9 +
> hmp.c| 5 +++--
> qapi/block-core.json | 16 +++-
> 3 files c
d need to be audited at that time.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 0cf8febe6c..d4b42403df 100644
> --- a/blo
On Thu, Sep 06, 2018 at 09:02:21AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> blockdev.c | 8
> qapi/block-core.json | 16 +++-
> 2 files changed, 23 insertions(+), 1 deletion(-)
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> tests/test-blockjob.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c
> index 8e8b68041
_bh_schedule_oneshot.
>
> Move these three functions down into job.c to eliminate a
> forward reference.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> include/qemu/job.h | 11
> job.c | 77
> +
On Thu, Sep 06, 2018 at 09:02:19AM -0400, John Snow wrote:
> The exit callback in this test actually only performs cleanup.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> tests/test-blockjob-txn.c | 4 ++--
> 1 file changed, 2 inser
On Thu, Sep 06, 2018 at 09:02:17AM -0400, John Snow wrote:
> These tests don't actually test blockjobs anymore, they test
> generic Job lifetimes. Change the types accordingly.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
>
On Thu, Sep 06, 2018 at 09:02:16AM -0400, John Snow wrote:
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/stream.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/block/stre
== 0);
Not something to hold the series up, but in case a v6 is called for due to
other changes: I think it may be worth a comment in mirror_exit_common()
that if abort is true, and we don't return success, QEMU will hit an assert.
Mainly to prevent someone from includin
On Thu, Sep 06, 2018 at 09:02:14AM -0400, John Snow wrote:
> In cases where we abort the block/mirror job, there's no point in
> installing the new backing chain before we finish aborting.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 2
gt; complete -> abort -> clean
>
> During refactor, a potential problem with bdrv_drop_intermediate
> was identified, The patched behavior is no worse than the pre-patch
> behavior, so leave a FIXME for now to be fixed in a future patch.
>
> Signed-off-by: John S
file_str,
&local_err);
if (ret < 0) {
bdrv_abort_perm_update(base);
error_report_err(local_err);
goto exit;
}
}
[...]
}
We could fail this but still have modi
speed, granularity, buf_size, backing_mode,
> on_source_error, on_target_error, unmap, NULL, NULL,
> &mirror_job_driver, is_none_mode, base, false,
This is another one of those comments that do not pertain directly to this
patch, so it
On Fri, Aug 31, 2018 at 06:28:55PM -0400, John Snow wrote:
> Add support for taking and passing forward job creaton flags.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
(with the misspelling that Eric pointed out fixed):
Reviewed-by: Jeff Cody
> ---
> block/strea
On Fri, Aug 31, 2018 at 06:28:53PM -0400, John Snow wrote:
> Add support for taking and passing forward job creation flags.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/commit.c| 5 +++--
> blockdev
ext in which we call .exit, this is safe to
> defer the possible flushing of any nodes to the job_finalize_single
> cleanup stage.
>
> Signed-off-by: John Snow
Reviewed-by: Jeff Cody
> ---
> block/mirror.c | 29 +++--
> 1 file changed, 11 insertions(+
hd() to fail. */
> block_job_remove_all_bdrv(bjob);
>
> -job_completed(job, ret);
> -g_free(data);
> -
Not having to allocate, track, and free this cumbersome return value for
each of these job specific completions now is pretty nice.
Reviewed-by: Jeff Cody
> /*
rom outside
> of the aio_context, which should allow for job cleanup code to run with
> only one lock, which makes cleanup callbacks less tricky to write.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> include/qemu/job.h | 11 +++
ob_completed
> function.
>
> Signed-off-by: John Snow
> Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
> ---
> block/backup.c| 7 ---
> block/commit.c| 7 ---
> block/create.c| 8 +---
> block/mirror.c
Signed-off-by: Jeff Cody
Reviewed-by: John Snow
Message-id:
df317f617fbe5affcf699cb8560e7b0c2e028a64.1534868459.git.jc...@redhat.com
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/229.out | 23 +
tests/qemu
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
ob patches
Jeff Cody (2):
block: for jobs, do not clear user_paused until after the resume
block: iotest to catch abort on forced blockjob cancel
job.c | 2 +-
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/22
On Tue, Aug 21, 2018 at 12:26:18PM -0400, Jeff Cody wrote:
> v3 changes:
> Rebased to master
> Patch 2: Wait for pause after mirror instead of error, to gobble the
> right message (Thanks John)
> Patch 2: Replace a hard-coded 'qcow2' with '$
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/229.out | 23 +
tests/qemu-iotests/group | 1 +
3 files changed, 119 insertions(+)
create mode 100755 tests/qemu-iotests/229
create mode 100644 tests/qemu-iotests
quot;type": "mirror"}}
-*** done
+QEMU_PROG: blockjob.c:460: block_job_iostatus_reset: Assertion
`job->job.user_paused && job->job.pause_count > 0' failed.
+Wrong response matching Assertion on handle 0
Failures: 229
Failed 1 of 1 tests
git-backport-diff,
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
--
On Mon, Aug 20, 2018 at 05:26:23PM -0400, John Snow wrote:
>
>
> On 08/16/2018 02:46 PM, Jeff Cody wrote:
> > Signed-off-by: Jeff Cody
> > ---
> > tests/qemu-iotests/229 | 95 ++
> > tests/qemu-iotests/229.out | 23 ++
is set to true.
Unfortunately, right before calling this function, it has explicitly
been set to false.
The fix is pretty simple: set job->user_paused to false only after the
job user_resume() function has been called.
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Jeff Cody
--
2097152, "offset":
1048576, "speed": 0, "type": "mirror"}}
-*** done
+QEMU_PROG: blockjob.c:460: block_job_iostatus_reset: Assertion
`job->job.user_paused && job->job.pause_count > 0' failed.
+Wrong response matching Assertion on hand
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/229 | 95 ++
tests/qemu-iotests/229.out | 23 +
tests/qemu-iotests/group | 1 +
3 files changed, 119 insertions(+)
create mode 100755 tests/qemu-iotests/229
create mode 100644 tests/qemu-iotests
On Wed, Aug 15, 2018 at 05:23:43PM -0400, John Snow wrote:
>
>
> On 08/15/2018 11:59 AM, Jeff Cody wrote:
> > The function job_cancel_async() will always cause an assert for blockjob
> > user resume. We set job->user_paused to false, and then call
> > job->drive
On Wed, Aug 15, 2018 at 04:25:16PM -0500, Eric Blake wrote:
> On 08/15/2018 10:59 AM, Jeff Cody wrote:
> >The function job_cancel_async() will always cause an assert for blockjob
> >user resume. We set job->user_paused to false, and then call
> >job->driver->
1 - 100 of 2448 matches
Mail list logo
