Re: [PATCH V2] hw/arm: enable qxl for aarch64

On Mon, 2023-05-15 at 09:52 +0100, Daniel P. Berrangé wrote: > On Fri, May 12, 2023 at 05:31:08PM +0800, Hao Zeng wrote: > > Qemu does not support qxl graphics cards in arm, it is recommended > > to enable > > Who recommends this and why ? > > The recommendations f

[PATCH V2] hw/arm: enable qxl for aarch64

Qemu does not support qxl graphics cards in arm, it is recommended to enable Signed-off-by: Hao Zeng --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 0f42c556d7..d0bedf9347 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -32,6

[PATCH] hw/arm: enable qxl for aarch64

Qemu does not support qxl graphics cards in arm, it is recommended to enable Signed-off-by: Hao Zeng --- hw/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 0f42c556d7..0305a4f4f3 100644 --- a/hw/arm/Kconfig +++ b/hw/arm

Re: [PATCH v5] cxl-cdat:Fix open file not closed in ct3_load_cdat

hi Jonathan: Thank you very much Best regards --- Hao On Fri, 2023-04-21 at 14:14 +0100, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 20:23:58 +0800 > Hao Zeng wrote: > > > Open file descriptor not closed in error paths. Fix by replace > > open coded handling of read

Re: [PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

On Thu, 2023-04-13 at 12:17 +0100, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 17:33:28 +0800 > Hao Zeng wrote: > > > opened file processor not closed,May cause file processor leaks > > Patch description needs to say more on how this is fixed. > Perhaps something like:

Re: [PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

On Thu, 2023-04-13 at 12:17 +0100, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 17:33:28 +0800 > Hao Zeng wrote: > > > opened file processor not closed,May cause file processor leaks > > Patch description needs to say more on how this is fixed. > Perhaps something like:

[PATCH v5] cxl-cdat:Fix open file not closed in ct3_load_cdat

Open file descriptor not closed in error paths. Fix by replace open coded handling of read of whole file into a buffer with g_file_get_contents() Fixes: aba578bdac ("hw/cxl: CDAT Data Object Exchange implementation") Signed-off-by: Zeng Hao Suggested-by: Philippe Mathieu-Daudé Suggested-by: Pe

[PATCH v4] cxl-cdat:Fix open file not closed in ct3_load_cdat

opened file processor not closed,May cause file processor leaks Fixes: aba578bdac ("hw/cxl: CDAT Data Object Exchange implementation") Signed-off-by: Zeng Hao Suggested-by: Philippe Mathieu-Daudé Suggested-by: Peter Maydell --- ChangeLog: v3-v4: Modify commit information,No code

[PATCH v3] cxl-cdat:Fix open file not closed in ct3_load_cdat

opened file processor not closed,May cause file processor leaks Fixes: aba578bdac ("hw/cxl: CDAT Data Object Exchange implementation") ChangeLog: v2->v3: Submission of v3 on the basis of v2, based on Philippe Mathieu-Daudé's suggestion "Pointless bzero in g_malloc0, however t

[PATCH v2 2/2] cxl-cdat:Fix the check on the return value of fread()

The bug in this code (CID 1507822) is that the check on the return value of fread() is wrong. fread() returns the number of items read or written, so checking for == 0 only catches "no data read at all", not "only read half the data". Signed-off-by: Zeng Hao Suggested-by: Peter Maydell --- hw/c

[PATCH v2 1/2] cxl-cdat:Fix open file not closed in ct3_load_cdat

opened file processor not closed,May cause file processor leaks Fixes:aba578bdace5303a441f8a37aad781b5cb06f38c Signed-off-by: Zeng Hao Suggested-by: Xie Ming --- hw/cxl/cxl-cdat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c index 137abd0992..ba7ed1a

[PATCH v2 0/2] cxl-cdat:Fix two problems of ct3_load_cdat

This v2 contains a change suggested by Peter Maydell in patch v1. v1 link:https://lore.kernel.org/all/20230403084245.54861-1-zeng...@kylinos.cn/ ChangeLog: v1->v2: - Patch 1: No change in patch v1 - Patch 2: Fix the check on the return value of fread() in ct3_load_cdat Hao Zeng

Re: [PATCH] Subject:[PATCH] cxl-cdat:Fix open file not closed in ct3_load_cdat

On Tue, 2023-04-11 at 16:39 +0100, Peter Maydell wrote: Dear Peter Thank you for taking the time to reply to my email. I appreciate your the valuable information you have provided. > On Mon, 3 Apr 2023 at 13:51, zenghao wrote: > > > > opened file processor not closed,May cause file processor lea