Hello! Thank you for your review!Sorry I forgot to cc other maintainers so I
resend this mail.
From: "Cédric Le Goater"
Date: 2023-08-16 16:32:58
To: Hang Yu ,qemu-devel@nongnu.org
Cc: koml...@google.com,pe...@pjd.dev,Peter Maydell
,Andrew Jeffery ,Joel Stanley
,"open l
move it
from I2CC_POOL_CTRL to I2CD_POOL_CTRL.
Hang Yu.
Hang Yu (3):
hw/i2c/aspeed: Fix Tx count and Rx size error in buffer pool mode
hw/i2c/aspeed: Fix TXBUF transmission start position error
hw/i2c/aspeed: Add support for buffer organization
hw/i2c/aspeed_i2c.c | 39
to plus 1, and mistake Rx count for Rx size.
Signed-off-by: Hang Yu
Fixes: 3be3d6ccf2ad ("aspeed: i2c: Migrate to registerfields API")
---
v2-->v3:
1. Merged patch1 and patch2 in v2
2. added fixes tag
3. Fixed typos
hw/i2c/aspeed_i2c.c | 8
include/hw/i2c/asp
transmitted,and M_TX_CMD should not be cleared
at this condition.The driver url is:
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v5.15/drivers/i2c/busses/i2c-ast2600.c
Signed-off-by: Hang Yu
---
v2-->v3:
No change.
hw/i2c/aspeed_i2c.c | 30 ++
1 file chan
Added support for the buffer organization option in pool buffer control
register.when set to 1,The buffer is split into two parts: Lower 16 bytes
for Tx and higher 16 bytes for Rx.
Signed-off-by: Hang Yu
---
v2-->v3:
1. Fixed typos
2. Simplified the judgment logic of buffer organization
According to the ast2600 datasheet,the actual Tx count is
Transmit Data Byte Count plus 1, and the max Rx size is
Receive Pool Buffer Size plus 1, both in Pool Buffer Control Register.
The version before forgot to plus 1, and mistake Rx count for Rx size.
Signed-off-by: Hang Yu
---
hw/i2c
transmitted,and M_TX_CMD should not be cleared
at this condition.The driver url is:
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v5.15/drivers/i2c/busses/i2c-ast2600.c
Signed-off-by: Hang Yu
---
hw/i2c/aspeed_i2c.c | 30 ++
1 file changed, 6 insertions(+), 24
Count and bit field
[29:24]:Actual Received Pool Buffer Size according to the datasheet.
Signed-off-by: Hang Yu
---
include/hw/i2c/aspeed_i2c.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h
index 51c944efea
Added support for the BUFFER ORGANIZATION option in reg I2CC_POOL_CTRL,
when set to 1,The buffer is split into two parts: Lower 16 bytes for Tx
and higher 16 bytes for Rx.
Signed-off-by: Hang Yu
---
hw/i2c/aspeed_i2c.c | 7 ++-
include/hw/i2c/aspeed_i2c.h | 1 +
2 files changed, 7
Hello
> Hello,
>
> On 8/4/23 10:11, Hang Yu via wrote:
> > 1. Fixed inconsistency between the bit field definition in
register
> > I2CD_POOL_CTRL and the ast2600 datasheet
> > 2. Fixed issue of confusing RXSIZE and RXCOUNT, as well as
forgetting
> > to add
4. Added support for the BUFFER ORGANIZATION option in reg I2CC_POOL_CTRL
After adding these changes, QEMU can support driver code:
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v5.15
/drivers/i2c/busses/i2c-ast2600.c
Signed-off-by: Hang Yu <1339236...@qq.com>
---
hw/i2c/aspeed
11 matches
Mail list logo
