Re: The latest Qemu release can't bootup VM with latest guest kernel.

2021-05-23 Thread Gal Hammer
Hi Yang, On Thu, 20 May 2021 at 11:27, Yang Zhong wrote: > Hello all, > > I found the latest Qemu release can't bootup the VM with latest guest > kernel(>5.13). > > The normal v6.0.0 release is good to bootup the latest guest kernel. > > There are two issues were found > 1. Guest kernel panic. >

[PATCH] target/i386: Add PDCM feature bit when when CPU's pmu property is enabled

2020-07-27 Thread Gal Hammer
The PDCM feature bit is not enabled when adding the pmu property to a CPU without this capability (e.g. -cpu qemu64,pmu). Signed-off-by: Gal Hammer --- target/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 588f32e136..6e1c8b6019

Re: [Qemu-devel] [PATCH V10 3/9] include/standard-headers: add pvrdma related headers

2018-02-14 Thread Gal Hammer
Hi, I'm not familiar with the pvrdma device itself, but I reviewed the changes to the update-linux-headers.sh script. Reviewed-by: Gal Hammer Gal. On Mon, Feb 12, 2018 at 8:08 PM, Marcel Apfelbaum wrote: > Also modify update-linux-headers.sh script to manage > the headers ne

Re: [Qemu-devel] [PATCH v3 0/2] virtio: improve virtio devices initialization time

2018-01-30 Thread Gal Hammer
Hi Greg, On Mon, Jan 29, 2018 at 7:47 PM, Greg Kurz wrote: > On Mon, 29 Jan 2018 16:20:55 +0200 > Gal Hammer wrote: > >> Using a cleanup callback function (Version 2 of this patches) in order to >> support transactions fails when the same event notifier fd was used by mo

[Qemu-devel] [PATCH v3 1/2] virtio: remove event notifier cleanup call on de-assign

2018-01-29 Thread Gal Hammer
to allow executing the virtio_bus_set_host_notifier function in a memory region transaction. Signed-off-by: Gal Hammer --- hw/block/dataplane/virtio-blk.c | 2 ++ hw/scsi/virtio-scsi-dataplane.c | 2 ++ hw/virtio/vhost.c | 2 ++ hw/virtio/virtio-bus.c | 14

[Qemu-devel] [PATCH v3 0/2] virtio: improve virtio devices initialization time

2018-01-29 Thread Gal Hammer
Using a cleanup callback function (Version 2 of this patches) in order to support transactions fails when the same event notifier fd was used by more than one Memory Region. This time I ask the caller to do the event notifier cleanup by himself. Gal Hammer (2): virtio: remove event notifier

[Qemu-devel] [PATCH v3 2/2] virtio: improve virtio devices initialization time

2018-01-29 Thread Gal Hammer
to the memory regions in a single memory transaction. Reported-by: Sitong Liu Reported-by: Xiaoling Gao Signed-off-by: Gal Hammer --- hw/virtio/virtio.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index

Re: [Qemu-devel] [PULL 1/1] kvm-all: Partially reverts 4fe6d78b2e to remove the cleanup call

2018-01-28 Thread Gal Hammer
On Mon, Jan 29, 2018 at 6:45 AM, Michael S. Tsirkin wrote: > On Sun, Jan 28, 2018 at 04:07:27PM +0200, Gal Hammer wrote: >> Hi, >> >> Sorry for a bad patch and the problems it may have caused. > > Not at all, these things happen. Do you have short term plans to

Re: [Qemu-devel] [PULL 1/1] kvm-all: Partially reverts 4fe6d78b2e to remove the cleanup call

2018-01-28 Thread Gal Hammer
abort(); >> > >>> } >> > >>> - >> > >>> -if (e->cleanup) { >> > >>> -e->cleanup(e); >> > >>> -} >> > >> >> > >> This looks wrong as the cleanup is e

Re: [Qemu-devel] [PATCH 0/3 v2] virtio: improve virtio devices initialization time

2018-01-17 Thread Gal Hammer
ations or by the QEMU's PCI emulation code. > Ray K Gal. > > On 14/01/2018 10:06, Gal Hammer wrote: >> >> A bug was reported about a very slow boot time and a 100% CPU usage of >> both Windows and Linux guests when running a VM with multiple >> virtio-se

[Qemu-devel] [PATCH 3/3] virtio: improve virtio devices initialization time

2018-01-14 Thread Gal Hammer
to the memory regions in a single memory transaction. Reported-by: Sitong Liu Reported-by: Xiaoling Gao Signed-off-by: Gal Hammer --- hw/virtio/virtio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index d6002ee..3ac3491 100644 --- a/hw/virtio

[Qemu-devel] [PATCH 2/3] virtio: postpone the execution of event_notifier_cleanup function

2018-01-14 Thread Gal Hammer
in a failure. Signed-off-by: Gal Hammer --- accel/kvm/kvm-all.c| 4 hw/virtio/virtio-bus.c | 19 +++ 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f290f48..071f4f5 100644 --- a/accel/kvm/kvm-all.c +++ b/

[Qemu-devel] [PATCH 1/3] qemu: add a cleanup callback function to EventNotifier

2018-01-14 Thread Gal Hammer
Adding a cleanup callback function to the EventNotifier struct which allows users to execute event_notifier_cleanup in a different context. Signed-off-by: Gal Hammer --- include/qemu/event_notifier.h | 1 + util/event_notifier-posix.c | 5 - util/event_notifier-win32.c | 2 ++ 3 files

[Qemu-devel] [PATCH 0/3 v2] virtio: improve virtio devices initialization time

2018-01-14 Thread Gal Hammer
EventNotifier struct, so it will be possible to use a transaction in the shutdown code path as well. Gal Hammer (3): qemu: add a cleanup callback function to EventNotifier virtio: postpone the execution of event_notifier_cleanup function virtio: improve virtio devices initialization time

Re: [Qemu-devel] [PATCH] virtio: improve virtio devices initialization time

2018-01-12 Thread Gal Hammer
On Thu, Jan 11, 2018 at 9:52 PM, Michael S. Tsirkin wrote: > On Thu, Jan 11, 2018 at 12:16:56PM +0200, Gal Hammer wrote: > > The loading time of a VM is quite significant when its virtio > > devices uses a large amount of virt-queues (e.g. a virtio-serial > > device with

[Qemu-devel] [PATCH] virtio: improve virtio devices initialization time

2018-01-11 Thread Gal Hammer
to the memory regions in a single memory transaction. Reported-by: Sitong Liu Reported-by: Xiaoling Gao Signed-off-by: Gal Hammer --- hw/virtio/virtio.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index ad564b0..8d8d93d 100644 --- a

[Qemu-devel] [PATCH] qga: implement the guest-set-vcpus for windows

2015-11-02 Thread Gal Hammer
Signed-off-by: Gal Hammer --- qga/commands-win32.c | 66 ++-- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d9de23b..a8eb4a0 100644 --- a/qga/commands-win32.c +++ b/qga/commands

[Qemu-devel] [PATCH] acpi: fix pvpanic device is not shown in ui

2015-07-26 Thread Gal Hammer
Commit 2332333c added a _STA method that hides the device. The fact that the device is not shown in the gui make it harder to install its Windows' device. https://bugzilla.redhat.com/show_bug.cgi?id=1238141 Signed-off-by: Gal Hammer --- hw/i386/acpi-build.c | 4 ++-- 1 file chang

[Qemu-devel] [PATCH V16 4/4] tests: add a unit test for the vmgenid device

2015-06-16 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 44 2 files changed, 46 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index c5e4744..3608068 100644 --- a/tests

[Qemu-devel] [PATCH V16 2/4] acpi: add a vm_generation_id_changed method

2015-06-16 Thread Gal Hammer
Add a new method to the AcpiDeviceIfClass interface. The new method sends an ACPI notfication when the VM generation id is changed. Signed-off-by: Gal Hammer --- hw/acpi/core.c | 8 hw/acpi/ich9.c | 8 hw/acpi/piix4.c

[Qemu-devel] [PATCH V16 3/4] i386: add a Virtual Machine Generation ID device

2015-06-16 Thread Gal Hammer
Based on Microsoft's specifications (paper can be downloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V16 0/4] Virtual Machine Generation ID

2015-06-16 Thread Gal Hammer
s description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (4): docs: vm generation id device's description acpi: add a vm_generation_id_changed method i386: add a Virtual Machine Generation ID device tests: add a unit test for the vmgenid de

[Qemu-devel] [PATCH V16 1/4] docs: vm generation id device's description

2015-06-16 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 33 + 1 file changed, 33 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..d06977a --- /dev/null +++ b

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 18:22, Michael S. Tsirkin wrote: On Mon, Jun 08, 2015 at 05:17:31PM +0200, Paolo Bonzini wrote: On 08/06/2015 17:01, Michael S. Tsirkin wrote: Are there applications that would actually use this? For microsoft this seems to be mostly driven by ActiveDirectory needs. It seems qu

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 16:58, Daniel P. Berrange wrote: On Mon, Jun 08, 2015 at 03:55:14PM +0200, Paolo Bonzini wrote: On 08/06/2015 15:52, Gal Hammer wrote: 2. Is it possible to create a sysbus device using the "-device" command line argument? I vaguely recall that it is not possible to

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 16:55, Paolo Bonzini wrote: On 08/06/2015 15:52, Gal Hammer wrote: 2. Is it possible to create a sysbus device using the "-device" command line argument? I vaguely recall that it is not possible to do it and that's the reason that I specifically add the device

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
On 08/06/2015 16:43, Paolo Bonzini wrote: On 08/06/2015 15:42, Gal Hammer wrote: On 03/06/2015 19:37, Paolo Bonzini wrote: Since Michael said he'd merge this version, there's just one thing I would change. You can access the region only one byte at a time, and let the memor

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-06-08 Thread Gal Hammer
it and that's the reason that I specifically add the device in the pc init. Thanks, Gal. On 27/04/2015 13:19, Gal Hammer wrote: +static uint64_t vmgenid_ram_read(void *opaque, hwaddr addr, + unsigned size) +{ +VmGenIdState *s = VMGENID(opaque); +

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-05-28 Thread Gal Hammer
On 28/05/2015 13:25, Paolo Bonzini wrote: On 27/04/2015 13:19, Gal Hammer wrote: +static void vmgenid_init(Object *obj) +{ +SysBusDevice *sbd = SYS_BUS_DEVICE(obj); +VmGenIdState *s = VMGENID(obj); + +memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vg

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-04-29 Thread Gal Hammer
On 27/04/2015 16:38, Michael S. Tsirkin wrote: On Mon, Apr 27, 2015 at 02:19:50PM +0300, Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implement

Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description

2015-04-28 Thread Gal Hammer
On 27/04/2015 17:56, Eric Blake wrote: On 04/27/2015 05:19 AM, Gal Hammer wrote: Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b

Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description

2015-04-28 Thread Gal Hammer
On 27/04/2015 16:55, Michael S. Tsirkin wrote: On Mon, Apr 27, 2015 at 02:19:47PM +0300, Gal Hammer wrote: Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git

[Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device

2015-04-27 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V15 2/5] acpi: add a vm_generation_id_changed method

2015-04-27 Thread Gal Hammer
Add a new method to the AcpiDeviceIfClass interface. The new method send an ACPI notfication when the VM generation id is changed. Signed-off-by: Gal Hammer --- hw/acpi/core.c | 8 hw/acpi/ich9.c | 8 hw/acpi/piix4.c

[Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device.

2015-04-27 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 44 2 files changed, 46 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index 55aa745..6e4905c 100644 --- a/tests

[Qemu-devel] [PATCH V15 0/5] Virtual Machine Generation ID

2015-04-27 Thread Gal Hammer
ption from DSDT back to SSDT table. V3 - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (5): docs: vm generation id device's description acpi: add a vm_generation_id_changed

[Qemu-devel] [PATCH V15 3/5] aml: implement a 32-bit fixed memory range descriptor

2015-04-27 Thread Gal Hammer
Signed-off-by: Gal Hammer --- hw/acpi/aml-build.c | 18 ++ include/hw/acpi/aml-build.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index d7945f6..038384f 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description

2015-04-27 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..86ce6ab --- /dev/null +++ b

[Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Gal Hammer
A predefined scope in the ACPI specs is precede with a backslash. Signed-off-by: Gal Hammer --- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 8d1a761

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-19 Thread Gal Hammer
On 19/03/2015 11:50, Michael S. Tsirkin wrote: On Wed, Mar 11, 2015 at 04:35:41PM +1100, David Gibson wrote: So it boils down to the fact that windows thinks it's RAM, It thinks it's PCI Standard RAM Controller not RAM itself. so it binds a generic driver to it, but then we get According to

[Qemu-devel] [PATCH V12 1/3] docs: vm generation id device's description

2015-02-10 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..656d598 --- /dev/null

[Qemu-devel] [PATCH V12 2/3] i386: Add a Virtual Machine Generation ID device

2015-02-10 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V12 0/3] Virtual Machine Generation ID

2015-02-10 Thread Gal Hammer
to SSDT table. V3 - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (3): docs: vm generation id device's description i386: Add a Virtual Machine Generation ID device

[Qemu-devel] [PATCH V12 3/3] tests: add a unit test for the vmgenid device.

2015-02-10 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 48 2 files changed, 50 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index d5df168..6b600c3 100644 --- a

Re: [Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine Generation ID device

2015-02-04 Thread Gal Hammer
Hi Igor, - Original Message - > From: "Igor Mammedov" > To: "Gal Hammer" > Cc: qemu-devel@nongnu.org, m...@redhat.com > Sent: Monday, February 2, 2015 3:55:02 PM > Subject: Re: [Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine > Generation

Re: [Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine Generation ID device

2015-02-02 Thread Gal Hammer
On 02/02/2015 14:46, Igor Mammedov wrote: On Sun, 01 Feb 2015 14:56:26 +0200 Gal Hammer wrote: On 22/01/2015 15:52, Igor Mammedov wrote: On Tue, 16 Dec 2014 17:50:43 +0200 Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/f

Re: [Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine Generation ID device

2015-02-01 Thread Gal Hammer
On 22/01/2015 15:52, Igor Mammedov wrote: On Tue, 16 Dec 2014 17:50:43 +0200 Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GU

[Qemu-devel] [PATCH V2] char: restore stdio echo on resume from suspend.

2015-01-07 Thread Gal Hammer
The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer --- V2 - restore old echo state rather than alway disable it. - don't check signal identifier in the handle

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Gal Hammer
- Original Message - > From: "Peter Maydell" > To: "Gal Hammer" > Cc: "Paolo Bonzini" , "QEMU Developers" > > Sent: Tuesday, January 6, 2015 4:36:19 PM > Subject: Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Gal Hammer
On 06/01/2015 15:49, Peter Maydell wrote: On 5 January 2015 at 09:21, Gal Hammer wrote: The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer --- qemu-char.c

[Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-05 Thread Gal Hammer
The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer --- qemu-char.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index ef

[Qemu-devel] [PATCH V11 1/3] docs: vm generation id device's description

2014-12-16 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..656d598 --- /dev/null

[Qemu-devel] [PATCH V11 3/3] tests: add a unit test for the vmgenid device.

2014-12-16 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 48 2 files changed, 50 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index 16f0e4c..612441a 100644 --- a

[Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine Generation ID device

2014-12-16 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V11 0/3] Virtual Machine Generation ID

2014-12-16 Thread Gal Hammer
ce's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (3): docs: vm generation id device's description i386: Add a Virtual Machine Generation ID device tests: add a unit test for the vmgenid device. default-configs/i386-softmmu.mak

[Qemu-devel] [PATCH V10 1/3] docs: vm generation id device's description

2014-12-14 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..656d598 --- /dev/null

[Qemu-devel] [PATCH V10 2/3] i386: Add a Virtual Machine Generation ID device

2014-12-14 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V10 0/3] Virtual Machine Generation ID

2014-12-14 Thread Gal Hammer
le (dynamic). V4 - Fix a typo in error message string. - Move device's description from DSDT back to SSDT table. V3 - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (3

[Qemu-devel] [PATCH V10 3/3] tests: add a unit test for the vmgenid device.

2014-12-14 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 48 2 files changed, 50 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index 16f0e4c..612441a 100644 --- a

Re: [Qemu-devel] [PATCH V9 1/3] docs: vm generation id device's description

2014-12-10 Thread Gal Hammer
- Original Message - > From: "Eric Blake" > To: "Gal Hammer" , qemu-devel@nongnu.org > Sent: Tuesday, December 9, 2014 7:50:07 PM > Subject: Re: [Qemu-devel] [PATCH V9 1/3] docs: vm generation id device's > description > > On 12/09/2

[Qemu-devel] [PATCH V9 1/3] docs: vm generation id device's description

2014-12-09 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..9a09d11 --- /dev/null +++ b/docs

[Qemu-devel] [PATCH V9 3/3] tests: add a unit test for the vmgenid device.

2014-12-09 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 48 2 files changed, 50 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index 16f0e4c..612441a 100644 --- a

[Qemu-devel] [PATCH V9 0/3] Virtual Machine Generation ID

2014-12-09 Thread Gal Hammer
age string. - Move device's description from DSDT back to SSDT table. V3 - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (3): docs: vm generation id device's descriptio

[Qemu-devel] [PATCH V9 2/3] i386: Add a Virtual Machine Generation ID device

2014-12-09 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

Re: [Qemu-devel] [PATCH V8 0/3] Virtual Machine Generation ID

2014-11-17 Thread Gal Hammer
- Original Message - > From: "Michael S. Tsirkin" > To: "Gal Hammer" > Cc: pbonz...@redhat.com, qemu-devel@nongnu.org > Sent: Sunday, November 16, 2014 9:49:37 PM > Subject: Re: [Qemu-devel] [PATCH V8 0/3] Virtual Machine Generation ID > > On S

[Qemu-devel] [PATCH 3/3] tests: update acpi tables after adding the vmgenid device

2014-11-16 Thread Gal Hammer
Signed-off-by: Gal Hammer --- tests/acpi-test-data/pc/DSDT | Bin 2807 -> 2820 bytes tests/acpi-test-data/pc/SSDT | Bin 3065 -> 3268 bytes tests/acpi-test-data/q35/DSDT | Bin 7397 -> 7410 bytes tests/acpi-test-data/q35/SSDT | Bin 1346 -> 1549 bytes 4 files changed, 0 inse

[Qemu-devel] [PATCH 2/3] i386: Add a Virtual Machine Generation ID device

2014-11-16 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V8 0/3] Virtual Machine Generation ID

2014-11-16 Thread Gal Hammer
typo in error message string. - Move device's description from DSDT back to SSDT table. V3 - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (3): docs: vm generati

[Qemu-devel] [PATCH 1/3] docs: vm generation id device's description

2014-11-16 Thread Gal Hammer
Signed-off-by: Gal Hammer --- docs/specs/vmgenid.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..9a09d11 --- /dev/null +++ b/docs

Re: [Qemu-devel] [PATCH 1/2] i386: Add a Virtual Machine Generation ID device

2014-10-19 Thread Gal Hammer
On 19/10/2014 18:14, Michael S. Tsirkin wrote: On Sun, Oct 19, 2014 at 04:43:07PM +0300, Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implement

[Qemu-devel] [PATCH 2/2] tests: update acpi tables after adding the vmgenid device

2014-10-19 Thread Gal Hammer
--- tests/acpi-test-data/pc/DSDT | Bin 2807 -> 2820 bytes tests/acpi-test-data/pc/SSDT | Bin 3065 -> 3239 bytes tests/acpi-test-data/q35/DSDT | Bin 7397 -> 7410 bytes tests/acpi-test-data/q35/SSDT | Bin 1346 -> 1520 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/a

[Qemu-devel] [PATCH 1/2] i386: Add a Virtual Machine Generation ID device

2014-10-19 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global "vmgenid.uuid" parameter. Signed-off-by: Gal Hammer --- defau

[Qemu-devel] [PATCH V6 0/2] Virtual Machine Generation ID

2014-10-19 Thread Gal Hammer
iles. V4 - Move device's description to SSDT table (dynamic). V3 - Fix a typo in error message string. - Move device's description from DSDT back to SSDT table. V2 - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-10-02 Thread Gal Hammer
On 02/10/2014 15:49, Michael S. Tsirkin wrote: On Wed, Sep 17, 2014 at 02:39:52PM +0300, Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set us

Re: [Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-10-02 Thread Gal Hammer
On 01/10/2014 11:58, Markus Armbruster wrote: Did this get stuck? I think so. Did I miss a comment which was not handled in the last version of the patch? Gal. Gal Hammer writes: Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device.

[Qemu-devel] [PATCH 0/2 V5] Virtual Machine Generation ID

2014-09-17 Thread Gal Hammer
T back to SSDT table. V2: - Remove "-uuid" command line parameter. - Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (2): i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive. i386: Add a Virtual Machine Generation

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-17 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer Reviewed-By: Igor Mammedov --- defau

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-17 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer Reviewed-by: Paolo Bonzini --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-17 Thread Gal Hammer
Hi Igor, - Original Message - > From: "Igor Mammedov" > To: "Gal Hammer" > Cc: pbonz...@redhat.com, qemu-devel@nongnu.org > Sent: Tuesday, September 16, 2014 5:54:28 PM > Subject: Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation &g

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-16 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer --- default-configs/i386-softmmu.mak

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-16 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468

[Qemu-devel] [PATCH 0/2 V4] Virtual Machine Generation ID

2014-09-16 Thread Gal Hammer
Move device's description from SSDT to DSDT table. - Add new "vmgenid" sysbus device. Gal Hammer (2): i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive. i386: Add a Virtual Machine Generation ID device. default-configs/i386-softmmu.mak | 1 + default-configs/x86

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-15 Thread Gal Hammer
Got it. I'll start to work on V4 then... Gal. - Original Message - From: "Igor Mammedov" To: "Gal Hammer" Cc: pbonz...@redhat.com, qemu-devel@nongnu.org Sent: Monday, September 15, 2014 11:46:41 AM Subject: Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virt

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-15 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the DSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer --- default-configs/i386-softmmu.mak

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-15 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468

[Qemu-devel] [PATCH 0/2 V3] Virtual Machine Generation ID

2014-09-15 Thread Gal Hammer
ual device. Your comment are welcomed. Thanks, Gal. V3: - Fix a typo in error message string. - Move device's description from DSDT back to SSDT table. V2: - Remove "-uuid" command line parameter. - Move device's description from SSDT to DDST table. - Add new

Re: [Qemu-devel] [PATCH RESEND 0/2 V2] Virtual Machine Generation ID

2014-09-14 Thread Gal Hammer
On 14/09/2014 11:48, Paolo Bonzini wrote: Il 14/09/2014 08:25, Gal Hammer ha scritto: Hi, A two parts patch to add a QEmu support for Microsoft's Virtual Machine Generation ID device. The first one add a new ACPI directive which allow to use a 16-bytes buffer in an ACPI table. This buff

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-13 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468

[Qemu-devel] [PATCH RESEND 0/2 V2] Virtual Machine Generation ID

2014-09-13 Thread Gal Hammer
ual device. Your comment are welcomed. Thanks, Gal. V2: - Remove "-uuid" command line parameter. - Move device's description from SSDT to DDST table. - Add new "vmgenid" sysbus device. Gal Hammer (2): i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive. i38

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-13 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the DSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer --- default-configs/i386-softmmu.mak

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-02 Thread Gal Hammer
On 01/09/2014 11:57, Paolo Bonzini wrote: Il 01/09/2014 09:20, Gal Hammer ha scritto: We are still in the process of defining which devices/methods go in the DSDT and which go in the SSDT. We had bad experiences with ACPI table migration in 2.1, and one plan to fix them is the following

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-02 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the DSDT ACPI table. The GUID is set using a new "vmgenid" device. Signed-off-by: Gal Hammer --- default-configs/i386-softmmu.mak

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-09-02 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468

[Qemu-devel] [PATCH 0/2 V2] Virtual Machine Generation ID

2014-09-02 Thread Gal Hammer
ual device. Your comment are welcomed. Thanks, Gal. V2: - Remove "-uuid" command line parameter. - Move device's description from SSDT to DDST table. - Add new "vmgenid" sysbus device. Gal Hammer (2): i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive. i38

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-01 Thread Gal Hammer
On 17/08/2014 12:49, Paolo Bonzini wrote: Il 12/08/2014 10:02, Gal Hammer ha scritto: Hi, On 10/08/2014 20:22, Paolo Bonzini wrote: Il 10/08/2014 13:32, Gal Hammer ha scritto: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=2

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-08-12 Thread Gal Hammer
Hi, On 10/08/2014 20:22, Paolo Bonzini wrote: Il 10/08/2014 13:32, Gal Hammer ha scritto: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a new &quo

[Qemu-devel] [PATCH 1/2] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-08-10 Thread Gal Hammer
Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/scripts/acpi_extract.py b/scripts/acpi_extract.py index 22ea468

[Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-08-10 Thread Gal Hammer
Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table. The GUID is set using a new "-vmgenid" command line parameter. Signed-off-by: Gal Hammer --- hw/i386/acp

[Qemu-devel] [PATCH 0/2] Virtual Machine Generation ID

2014-08-10 Thread Gal Hammer
e required command line parameter. Your comment are welcomed. Thanks, Gal. Gal Hammer (2): i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive. i386: Add a Virtual Machine Generation ID device. hw/i386/acpi-build.c| 23 +++ hw/i386/ssdt-misc.

[Qemu-devel] [PATCH V6] char: restore read callback on a reattached (hotplug) chardev

2014-02-25 Thread Gal Hammer
t.com/show_bug.cgi?id=1027181 Signed-off-by: Gal Hammer --- qemu-char.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) V6: - replace asserts with remove_fd_in_watch to allow changing the char device read hanlders. V5: - remove_fd_in_watch in fd_chr_update_read_ha

  1   2   >