Errata and left it at that.
Signed-off-by: Gabriel Laupre
v6: Move changelog to after signature
v5: Reduce the test to only control that the pba_offset doesn't extend beyond
the specified BAR. The rare cases of potential other wrong offset variables
extending beyond their specific BAR
#x27;s T5 VF devices identifier schema of 0x58xx
Signed-off-by: Gabriel Laupre
---
hw/vfio/pci.c| 27 +++
include/hw/pci/pci_ids.h | 2 ++
2 files changed, 29 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e0e339a..3257eed 100644
--- a/hw/vfio/pci.c
n hardware error. The table_offset has never
been seen as wrong. Therefore the msix_init() sanity check should take care of
a "rare" potential error as you mentioned.
This time I'll wait for ACKs from your side before submitting a new version :)
Gabriel
-Original Messag
Message-
From: Bandan Das [mailto:b...@redhat.com]
Sent: Tuesday, June 30, 2015 6:48 PM
To: Gabriel Laupre
Cc: jb-gnumli...@wisemo.com; Casey Leedom; m...@redhat.com;
qemu-devel@nongnu.org; Anish Bhatt; Michael Boksanyi;
alex.william...@redhat.com; b...@makefile.in
Subject: Re: [Qemu-devel] [
Right,
I may have send the patch a bit too soon, I need to take care of that.
-Original Message-
From: Bandan Das [mailto:b...@redhat.com]
Sent: Tuesday, June 30, 2015 6:48 PM
To: Gabriel Laupre
Cc: jb-gnumli...@wisemo.com; Casey Leedom; m...@redhat.com;
qemu-devel@nongnu.org; Anish
S_VF macro definition with
the Chelsio's T5 VF devices identifier schema of 0x58xx
Signed-off-by: Gabriel Laupre
---
hw/vfio/pci.c| 29 +
include/hw/pci/pci_ids.h | 2 ++
2 files changed, 31 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e
@ Bandan
...
> > +
> > +/* Chelsio T5 Virtual Function devices are encoded as 0x58xx for T5
> > + * adapters. The T5 hardware returns an incorrect value of 0x8000
> > for
> > + * the VF PBA offset. The correct value is 0x1000, so we hard code
> > that
> > + * here.
ices identifier schema of 0x58xx
Signed-off-by: Gabriel Laupre
---
hw/vfio/pci.c| 25 +
include/hw/pci/pci_ids.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e0e339a..797fedb 100644
--- a/hw/vfio/pci.c
+++
ges that you suggested and summit a v3 of this patch.
Gabriel
-Original Message-
From: Alex Williamson [mailto:alex.william...@redhat.com]
Sent: Friday, June 26, 2015 11:01 AM
To: Gabriel Laupre
Cc: qemu-devel@nongnu.org; m...@redhat.com; jb-gnumli...@wisemo.com;
b...@makefile.in; Ca
Errata and left it at that.
v2 : Replace and PCI_DEVICE_ID_CHELSIO_T5_SERIES_VF macro definition with
the Chelsio's T5 VF devices identifier schema of 0x58xx
Signed-off-by: Gabriel Laupre
---
hw/vfio/pci.c| 12
include/hw/pci/pci_ids.h | 2 ++
2 files changed
From: Alex Williamson [mailto:alex.william...@redhat.com]
Sent: Thursday, June 25, 2015 7:08 AM
To: Gabriel Laupre
Cc: qemu-devel@nongnu.org; m...@redhat.com; jb-gnumli...@wisemo.com;
b...@makefile.in; Casey Leedom; Michael Boksanyi; Anish Bhatt
Subject: Re: [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5
Fix pba_offset initialization value for Chelsio T5 devices. The
hardware doesn't return the correct pba_offset value, so add a
quirk to instead return a hardcoded value of 0x1000 when a Chelsio
T5 device is detected.
Signed-off-by: Gabriel Laupre
---
hw/vfio/pci.c
12 matches
Mail list logo
